24 Commits

Include renames

Author	SHA1	Message	Date
Nick Jamesandpc.yu	3841e6f299	fix(plugins): drain the dsh pending queue in-process so a transient write failure self-heals (#4779) ... * fix(plugins): drain the pending queue in-process so a transient write failure self-heals The dsh memory plugin latches capture and commit on the first retryable write failure (hasPendingWrites) and only reset the latch at session init, so the long-lived dsh process stayed stuck until restart. Add a per-process single-flight drainer (default 60s, env OPENVIKING_PENDING_DRAIN_INTERVAL_MS) that follows the session-start flow: probe health, replay the queue without consuming retry budgets, then re-derive every session's latch from the queue. replayPending gains an optional consumeRetries flag (default true, byte-compatible): drainers release a failed claim back to its original filename instead of incrementing the retry count, so the session-start path keeps owning all retry accounting and D4 deletions. Latch and health transitions are logged once per flip for observability. * test(plugins): cover the drainer and non-consuming replay mode Add pending-queue coverage for consumeRetries:false (retryable failures stay retryable and ordered, non-retryable and exhausted entries still delete, commitSession failures keep the run going, default mode unchanged) and runtime drainer coverage (recovery clears the latch, outages keep it and leave entries retryable, empty queue means zero HTTP, commit resumes after the drain, single-flight, per-session latch isolation, interval wiring with env fallback). --------- Co-authored-by: pc.yu <nick@fourieralpha.com>	2026-09-10 13:26:46 +08:00
t0saki	708dba60bd	feat(plugins): configurable regex input filters for recall queries and captured turns (#4858) ... * feat(plugins): ordered regex input filters for plugin input The memory plugins feed the raw user prompt into recall and the raw transcript into capture. Nothing between the harness and the server lets an operator shape that text: a thinking-keyword prefix (`ultrathink ...`) goes into the search query verbatim, a slash command becomes a memory, and a token pasted into a prompt is stored as it was typed. The only user-configurable pattern today is `bypassSessionPatterns`, which matches a session id or a cwd, never the text; every text rule -- `ACK_RE`, `SLASH_COMMAND_RE`, `sanitizeCapturedText` -- is hard-coded. `lib/input-filters.mjs` adds the missing layer: an ordered list of sed-style rules, `s` to substitute, `d` to drop the text on a match and `k` to keep it only on a match, each optionally scoped to one role. The rules are plain strings so they survive the existing string-list config coercion (env CSV, `ovcli.conf` array) without a new config type. Nothing in the module throws: an unparsable rule, an unknown flag or a pattern RegExp rejects becomes an entry in `errors` and is skipped, because a typo in a config file must not take a hook down. Compilation is memoised per rule list so a long-lived host compiles once, and rule count and pattern length are capped. The time budget is deliberately advisory -- `applyInputFilters` reports `slow`/`elapsedMs` and runs every rule anyway, since skipping the tail of the list would skip exactly the redaction rule an operator added. `capture-utils.mjs` grows the capture-side seam. `filterCaptureParts` prunes blank text parts as before, then takes one drop verdict per turn on the aggregate of its text parts and rewrites the individual parts with the substitutions only, so a rule can never both keep and drop the same turn; tool call/result payloads are carried through unmatched, though a turn dropped on its text takes them with it. `shouldCaptureText` gains the same step for the text path, behind a `filters` option that `extractCaptureTurns` turns off when parts are on the wire -- one application per stored string, and `turn.text` stays faithful for callers that scan it for trigger words. No loader supplies either knob yet, so this commit changes no behaviour: with `captureFilters` unset every path is the identity it was. * feat(claude-code): recallQueryFilters / captureFilters Wires the shared filter engine into the Claude Code plugin. Both knobs are string lists shaped exactly like `bypassSessionPatterns`: an env CSV replaces the configured array wholesale, entries are trimmed and non-strings dropped, and a rule that needs a literal comma has to come from the `ovcli.conf` array because the env value is split on one. Recall filters run in `auto-recall.mjs` immediately above the `minQueryLength` gate, so a prompt whose only content was a stripped prefix reports `short_query` rather than searching for the empty string, and a dropped prompt gets its own `last-recall.json` reason, `query_filtered` -- distinct from `filtered_out`, which is the score threshold. The statusline only tests for `ok`, so it needs no change. Capture filters run at the send site rather than in the extractor, because the cursor CC persists is an index into the extracted turn list: dropping a turn earlier would leave `capturedTurnCount` describing a list the next run does not reproduce. `sanitizePartsForSend` in `auto-capture.mjs` and the equivalent in `subagent-stop.mjs` are the two places every payload passes through, and both now delegate their blank- part pruning to `filterCaptureParts`, which keeps that behaviour when no rules are configured. `ov-memory-doctor` lists the active rules per knob and warns, with the exact parse or RegExp error, about the ones it could not compile -- config errors have to be visible somewhere other than a debug log, because a skipped rule is silent by design. The README gains an "Input filters" section with the grammar, six worked examples (every one of them asserted in the shared engine test), an ovcli.conf sample, and the caveats that actually bite: the env comma split, that drops win over substitutions, that filters run before the built-in ack/slash heuristics, that a mid-session drop rule shortens the turn list and reads as a transcript rewrite, and that nothing already stored is rewritten. * feat(codex): recallQueryFilters / captureFilters The same two knobs on the Codex side. The loader gains the string-list helper the harness did not have yet -- an env CSV replaces the configured array wholesale, both paths trim and drop non-strings -- and reads `cx.recallQueryFilters` / `cx.captureFilters`, so `ovcli.conf` `plugin.codex`, `plugin` and the legacy `ov.conf` `codex` block all work without further change. Recall filters go in `auto-recall.mjs` immediately above the `minQueryLength` gate: a dropped prompt emits the empty envelope before the health check, so a filtered turn costs no request at all. Capture needs no edit here. Codex's four write hooks funnel through `catchUpTurns` into the shared `extractCaptureTurns`, which is where the filters already run -- and it has to be there rather than at the send site, because this cursor advances by payloads durably sent: dropping a turn later would leave the cursor short and replay the surrounding turns on the next hook. The test covers exactly that, running the same transcript twice and asserting the second pass finds nothing new. `ov-memory-doctor` reports the active rules and the compile errors, and the README documents the grammar, both env examples, the ovcli.conf array for rules that need a literal comma, and the ordering and mid-session caveats. * docs(agent-integrations): input filter env vars The Claude Code integration guide's env table is where most people look first, so the two new knobs belong there next to the bypass patterns they resemble. The grammar and the worked examples stay in the plugin README, which the table already links to. * refactor(plugins): drop machinery the input filters do not need A review pass against the actual requirement — let an operator configure a regex over plugin input — found five constructions that solve problems this feature does not have. All of them go: - The compile memo cache, its FIFO eviction and the test-only reset. It was justified as "a long-lived host compiles once", but the only hosts that supply these knobs are the Claude Code and Codex hooks, which are short-lived subprocesses; the per-turn capture path is the one repeat caller, and compiling five rules measures 3 microseconds. The cache cost more code than it saved work. - `maxRules` / `maxPatternLength` as injectable options nothing passed, and the caps themselves. Rules come from the operator's own config, so a 33rd rule or a 600-character pattern is self-inflicted and harmless, and `bypassSessionPatterns` — the same shape of knob, also operator regexes — has never capped anything. - The advisory time budget: `slow` / `elapsedMs` and the injectable `now` whose only non-default caller was the test that made it look slow. The pattern that actually hurts is one that backtracks, and that hangs rather than reporting a number. - The try/catch around rule application. Every hook already ends in `main().catch(...)` that logs and approves, so an exception here was never going to take a session down. The try/catch around `new RegExp` stays: that one parses operator input, and the doctors render its message. - The warnings channel, which existed to carry one advisory string. Stripping `g` from a `d`/`k` rule is load-bearing — `.test()` on a global regex advances `lastIndex` and would alternate between calls — but it needs no announcement, since the rule then means exactly what it looked like it meant. `filterCaptureParts` also returned `ruleIndex` / `op` / `slow` that no caller read, and `extractCaptureTurns` tested `decision.reason === "filtered"` inside a condition where that disjunct could never be the deciding one: `filters` is passed as `shaped.parts.length === 0`, so the reason can only appear when the other half is already true. Docs lose the retired caps and a duplicated note; the Claude Code recall test loses the case Codex's suite already covers. Engine 303 -> 218 lines, behaviour identical for every rule an operator can write. * docs(agent-integrations): point the filter knobs at their grammar The env-var rows added to the Claude Code guide named the two knobs but said nothing about how to write a rule, and described only the comma-separated environment form — which reads as if that were the only way to configure them. Both rows now link to the plugin README's Input filters section, and a note under each table says the knobs also live in `ovcli.conf` under `plugin.<harness>.<key>` or the shared `plugin.<key>` as a JSON array, which is the better form: the env vars are split on commas, so a rule containing a literal comma can only be written in the array. The grammar itself stays in the plugin READMEs, where these guides already send readers for the full env-var list. The Codex guide had no mention of the feature at all; it gets the same two rows, the same note, and a link to its own README. The capability reference carried counts this feature invalidated: `memory-plugin-shared/lib/` is 24 modules rather than 23, the hook set `sync.mjs` gives every hook-driven plugin is 13 rather than 12, and every per-target total shifts with it (dsh 15, opencode 17, zcode 19, claude-code and codex 22 each). pi's entry was already wrong before this change — it takes `batch-send` as well as `setup-wizard`, so 15, not 13 — and is corrected in the same sentence. `input-filters.mjs` joins the module table, and the `capture-utils.mjs` row now says "built-in capture heuristics" so the two rows do not both read as "capture filtering". * docs(configuration): document the ovcli.conf plugin section `docs/*/configuration/02-client.md` is titled "ovcli Configuration" and covers connection, command behaviour, upload filters and the workspace layers — but never described the `plugin` section itself. It appeared only twice in passing: two rows of the workspace precedence table, and one sentence about `peerSource`. The nearest thing to a general explanation was buried in the agent-integrations overview, inside a discussion of recall latency. That gap is why the input filter note added in the previous commit had to explain the section's shape inline for two knobs, which reads as an oddity rather than a reference. The section is now documented once, where someone editing `ovcli.conf` would look: what `plugin` and `plugin.<harness>` mean, that keys are the camelCase counterparts of the `OPENVIKING_*` tuning variables and that the mapping does not go both ways, that list-valued knobs are JSON arrays here while their environment counterparts are comma-separated, the full resolution order, when an edit takes effect versus when the agent has to restart, that only Claude Code and Codex read it today, and that `ov-memory-doctor` flags unrecognised keys. The per-knob lists stay in the plugin READMEs, which the section links. The two integration guides now point at it in one line instead of restating it, the workspace precedence table links the section it already named, and the complete example grows a `plugin` block.	2026-09-09 17:12:16 +08:00
Xinmin Zeng	58bafa5ba1	fix(codex): reuse shared recall compressor (#4445) ... * fix(codex): reuse shared recall compressor * fix(plugins): harden recall compressor fallbacks	2026-09-08 15:45:13 +08:00
Nick Jamesandpc.yu	98f24e1690	fix(plugins): treat camelCase isError as an error tool result (#4724) ... * fix(plugins): treat camelCase isError as an error tool result DSH emits tool-result blocks with a camelCase isError field ({type:"tool-result", toolCallId, content, isError}), but the shared capture-utils toolStatus() only checks is_error / error / state.error. Failed results were therefore labeled tool_status=completed, while their error text still landed in tool_output. The mislabel does not mislead LLM memory extraction (verified end-to-end), but it does corrupt status-driven consumers: experience read lineage (experience_lineage.py), usage reporting, working-memory formatting, and rollout training artifacts. Recognize block.isError alongside is_error. Vendored copies are regenerated via examples/memory-plugin-shared/sync.mjs. Adds a capture-utils regression test plus a DSH capture test for the real tool-result wire shape. * fix(plugins): register capture-utils test in CI and cover state.isError Review follow-up: add examples/memory-plugin-shared/capture-utils.test.mjs to the pr.yml plugin-tests list (it was author-local only), and recognize block.state.isError alongside state.error in toolStatus with a matching test case. Vendored copies regenerated via sync.mjs. --------- Co-authored-by: pc.yu <nick@fourieralpha.com>	2026-09-07 17:22:02 +08:00
now-ingandmac	f7c6e84386	fix(memory-plugins): report client-side MCP proxy timeouts as -32004 instead of unreachable (#4741) ... A request aborted by the proxy's own timeout budget fell into mapError()'s catch-all and surfaced as -32001 'check the URL / server reachable' even while the server was healthy and still computing — rerank-inclusive find/search legitimately runs tens of seconds past the default 15s budget, so every such call was mislabeled as an outage (#4739). Branch on AbortError before the catch-all and return a dedicated -32004 naming the elapsed budget, the endpoint, and the OPENVIKING_TIMEOUT_MS knob; -32001 keeps its meaning of genuine connection failure. -32003 is already taken by the empty-response error, so timeouts use -32004. The change is applied to the shared lib and propagated to every generated copy via sync.mjs; the new mcp-proxy-core.test.mjs covers both the abort and the connection-failure contrast and is registered in the plugin-tests list in pr.yml. Signed-off-by: mac <bishopapril850965@yahoo.com> Co-authored-by: mac <bishopapril850965@yahoo.com>	2026-09-07 17:20:39 +08:00
t0saki	37ef554bb2	refactor(plugins): converge the harness forks back onto the shared library (#4594) ... * refactor(plugins): ship each harness only the shared modules it imports `sync.mjs` grouped its lists by how they had grown rather than by what each target imports, so three modules travelled to plugins that never load them: `setup-wizard.mjs` reached dsh and zcode, neither of which ships a setup entry point, and `async-writer.mjs` reached opencode, which its host imports in-process and so has no hook subprocess to detach a write from. Split the groups by capability — the hook set, the wizard, the stdio proxy pair, the batch sender, the async write path — and give pi its own list, so a target's entry says which capabilities it has. `sync.test.mjs` kept its own copy of those lists, and the copy had drifted: it was missing `plugin-config`, `retryable`, `recall-compress-core` and `mcp-proxy-config`, so a stale vendored copy of any of them would have passed CI. Import the lists from `sync.mjs` instead, guarding the sync behind an entrypoint check, and add the check the duplicate could never make: every module in `lib/` is claimed by some target, and no target holds a banner-carrying file the sync no longer ships. * refactor(zcode): capture and shape the proxy config through the shared modules zcode sent every turn it parsed straight to the server: no length cap, no acknowledgement filter, no slash-command or injected-status guard — the four things `shouldCaptureText` does for every other harness. It re-derived the proxy config object by hand too, which is how it came to watch a narrower set of credential files than `buildMcpProxyConfig` watches. Route both through the shared modules. The dedup key stays keyed on the raw turn, so raising the cap later never resends a turn the server already holds in truncated form. * refactor(pi): log through the shared JSON Lines logger pi carried two copies of a hand-written `debugLog` — one in `index.ts`, one in `sync.ts` — that appended `<ISO timestamp> <message>` lines, read `OV_DEBUG_LOG` directly, and could only be turned on through the environment. Both are the shared `debug-log.mjs` with the structure taken out: no stage field, no JSON payload, no config knob, and a spelling of the variable no other harness uses. Use `createLogger` in both places, add a `debugLogPath` config key so the log can be turned on the way every other pi setting is, and read `OPENVIKING_DEBUG_LOG` with `OV_DEBUG_LOG` kept as a deprecated alias so existing setups keep logging. * fix(dsh): honor syncTurns on every write path, not just capture `syncTurns: false` gated `capture()` alone, so a read-only session still committed on `turn/end`, still committed again on dispose, and still replayed whatever an earlier session had queued. The toggle promised no writes and made three. Gate the commit paths and the replay on it too, and document it — the README and the integration page never mentioned the key at all. A backlog queued while capture was on stays on the queue for a session that still writes. * chore(plugins): bump the zcode and dsh plugin versions Both changed behavior in this branch — zcode now filters and truncates what it captures and watches the full credential set, dsh now writes nothing when `syncTurns` is off — and installed copies are keyed by version. * fix(plugins): make the installer and the plugin test matrix work in a git worktree `resolve_self_checkout` looked for `.git` as a directory. A linked worktree keeps it as a file pointing at the real gitdir, so `CHECKOUT_DIR` stayed empty there: `--source dev` resolved the marketplace to `/examples` and failed outright, and every other path fell through to `remote`, which clones from GitHub. On this machine that turned six of the thirteen installer tests red and made `release-marketplace.test.mjs` hang for twenty minutes on the network — long enough that the CPU starvation failed an unrelated recall timing assertion too. Test for existence instead of for a directory. Three test files were never run by CI, so nothing noticed that one of them had gone stale: the pi wiring assertion still required `new RecallManager(...)` to end at the session-id getter, which stopped being true when the recall ledger was added a fourth argument. Assert only the getter, and register all three files in `pr.yml` — the matrix now covers every `*.test.mjs` under `examples/`.	2026-09-04 13:59:29 +08:00
t0saki	1d89f8d465	feat(plugins): derive the workspace peer from git, and let a repository carry its own config (#4595) ... * fix(plugins): stop dropping ovcli.conf's plugin section, and unrot the sync test `ov config add|edit`, the config wizard and `ov config switch` all rebuild ovcli.conf from the `Config` struct, which has no `plugin` field and no catch-all — so every write silently deleted the whole `plugin` section the memory plugins own. `write_config_file` now carries over the top-level keys `Config` does not model, `save_edited_config` reads them from the old name on a rename, and `activate_config` keeps the active file's. Modeled keys are deliberately not carried over: one that is `None` was cleared on purpose. `KNOWN_CONFIG_KEYS` decides what counts as modeled, guarded by a test that fails when a struct field is added without listing it. sync.test.mjs kept its own copies of the target lists and they had drifted — dsh, opencode and agent-plugins were each missing modules the sync ships, so a stale vendored file passed CI. It now imports the lists from sync.mjs (whose `main()` moved behind an entrypoint guard) and additionally fails on a module no target claims or a banner-carrying orphan no target lists. Also in this hygiene pass: - postRecall dropped `peer_scope` on any 400/422, silently widening recall from the caller's own peer to the whole user root. It now retries only on an unknown-field rejection, remembers the downgrade so every turn stops paying for a rejected request, and both doctors warn while that memo is live. - The session peer pins (Claude Code's `ws-peer-*.json`, Codex's `workspacePeerId`) carry a version, so a pin written under one derivation rule cannot outlive it. Derivation is unchanged, so today they re-derive to the same value. - recall-session-wiring.test.mjs was never registered in CI and had rotted against a fourth RecallManager argument; assertion fixed and registered. * feat(plugins): layered workspace configuration A workspace can now carry `<root>/.openviking/config.json`, which a team commits, and `config.local.json`, which stays private; a per-machine registry under `~/.openviking/workspaces/` sits above both so the user keeps the last word over any repository they clone. All three share one schema and one merge, and they slot in exactly where ovcli.conf's `plugin` section already does, so `OPENVIKING_*` still wins over everything. Three modules, synced to all seven plugin targets: - workspace-identity.mjs finds the workspace root and reads git's own idea of what the repository is called, using only filesystem reads. No `git` subprocess: hooks are fresh Node processes on prompt-level paths with budgets as tight as Codex's 3s SessionEnd, and this keeps working where git is absent from PATH or would refuse the repo over dubious ownership. Worktrees converge through `commondir`; submodules stay separate; `$HOME` and `/` are never workspace roots. - workspace-config.mjs discovers, parses, filters and merges the layers, and records per-key provenance — which layer won and what it covered up. - workspace-registry.mjs keeps one file per workspace rather than one listing them all, so concurrent hooks cannot lose each other's writes, and treats a path whose git identity has changed as a miss rather than inheriting the previous repository's peer. These files are trusted without a prompt, because a hook is non-interactive and any approval gate degrades into "run one command per workspace first". What is refused instead is structural and costs nobody anything: connection and credential keys are stripped loudly, `${VAR}` is never expanded, and `cli_config_profile` — which decides which credentials reach which server — is registry-only and name-only. What a committed file switches off is announced in doctor rather than blocked. An adversarial review pass over these three modules found 18 defects, all fixed here and each now covered by a test. The one that mattered: `JSON.parse` keeps `__proto__` as an own property, so a 128-byte committed file could write straight into `Object.prototype`, and since `process.env` reads through the prototype chain and the environment outranks ovcli.conf, that set `OPENVIKING_URL` and `OPENVIKING_API_KEY` for the whole process — silently shipping the user's real API key to an attacker's host. Prototype keys are now dropped with a warning in both the strip and the merge. The rest: unbounded recursion (a 4KB file could take out every sibling layer), the identity cache storing a remote's embedded token at 0644, worktrees under a directory named `modules` misread as submodules, the registry's negative-evidence check being inert in its only caller, `Number(null)` pinning cost knobs to a bound, and provenance lying when two layers disagree about a key's type. `.gitignore` no longer ignores all of `.openviking/`, which would have stopped a team's config.json from ever being committed; doctor warns when a workspace still does. The schema maps `capture.commit_token_threshold`, matching the knob the loaders actually read — the RFC's example named a turn-based one that does not exist. * feat(plugins): derive the workspace peer from git, configurably The peer a workspace writes its memories under was the working directory with every non-alphanumeric byte turned into a dash. That made the identity an accident of where the repository happened to sit: a clone on another machine, a rename, a worktree, or simply `cd examples/` each minted a separate, empty namespace, and there is no server-side rename or merge to recover from it. The default is now git's own idea of the repository. `peer.source` decides the rule and reads from every layer — `OPENVIKING_PEER_SOURCE`, ovcli.conf's `plugin.peerSource`, or `peer.source` in a workspace file: - `git` (new default) ≡ `["{git_remote}", "{git_root}", "{cwd}"]` — the normalized origin, else the repository root, else the working directory. No preset adds a prefix; a path-derived id already starts with `-` on POSIX, so it cannot collide with a remote-derived one. - `cwd` — the old rule, byte for byte. - `none` — send no peer. `OPENVIKING_WORKSPACE_PEER=0` still means this. - Any template, or a list tried in order, over `{git_remote}` `{git_root}` `{cwd}` `{dir}`. Substitution is all-or-nothing: an empty variable falls through to the next template rather than leaving a half-formed shared id. So `/Users/x/Dev/OpenViking/examples/codex-memory-plugin` with origin `git@github.com:volcengine/OpenViking.git` is `github.com-volcengine-openviking` from any subdirectory, worktree, machine or clone. Every clone of one repository shares one peer; a fork has a different origin and stays separate, and `gh pr checkout` of someone else's PR does not change origin, so reviewing does not move a session's memory. Nobody has to migrate. The pre-git id is always recomputable locally, so `resolveEffectivePeerId` returns it alongside the effective one and recall still reaches it: under the default `peer_scope: "all"` the server's cross-peer sweep already covers it for free, and under `"actor"` — where that sweep is off by definition — the plugin asks that peer separately, as itself, which is cheaper and reaches more than a bare cross-peer read would. There is no deadline on this. Wired through all five recall paths; doctor names the previous peer and says which of the two is carrying it. `source` keeps its three values because five call sites compare it against the literal `"workspace"` to decide whether a session pin may be reused; the new `origin` field names the template that actually produced the id, and doctor prints it. Both session pins bump their version, so a pin frozen under the old rule cannot outlive it. * docs: the workspace peer comes from git, and a workspace can carry config Every page that described the peer as the working directory with its non-alphanumerics dashed now describes `peer.source` and the git default, with the presets, the template variables, the clone-vs-fork identity semantics, and why no migration is required. The capability reference gains the three new shared modules; the client configuration page gains a Workspace Configuration section covering the two workspace files, the per-machine registry, the precedence table, the v1 schema and what a workspace file may not set; the Claude Code and Codex integration pages, which never mentioned peer derivation at all, each gain a short section. All zh mirrors follow. `examples/schemas/workspace-config-v1.json` is the schema the `$schema` key in a workspace file points at, and `examples/workspace-config.example.json` is a file to copy. `ovcli.conf.example` shows `plugin.peerSource`. Two facts worth stating plainly, both verified against the loaders rather than assumed: `OPENVIKING_PEER_SOURCE` and the workspace-file layer are read only by the Claude Code and Codex plugins today, so the other harnesses run on the default and their pages document the config key rather than an env var that would be inert; and pi and dsh compute their legacy id from the process cwd, so their pages promise dual-read only under the default `peer_scope: "all"`. * fix(mcp): stop the proxies from guessing a peer out of their launch directory Three MCP proxies keyed the actor peer off `process.cwd()`, which for a long-lived server started from a static MCP config is the directory the harness happened to launch from — often the plugin's own. The Codex proxy already refused this and had a test forbidding it; the rule now holds for all of them through the same `resolveMcpActorPeerId`. The plan called for the parent process to inject `OPENVIKING_PEER_ID` at launch instead, following dsh's `mcp.mjs:27`. That only works for dsh: Claude Code and agent-plugins are launched from a static `.mcp.json`/`mcp.json` with no environment block, and OpenCode's `createOpenVikingMcpConfig` builds a command and args with nowhere to put one. So the fix is to stop guessing rather than to guess better — a proxy sends no actor peer, which is broad recall, the default. `resolveMcpActorPeerId` now warns and widens where it used to throw. Refusing to start took away every memory tool because a scope preference could not be honoured, which costs the user far more than the wider search does; the warning says which two settings would scope it. * test(pi): follow the git-derived peer default rather than pinning the cwd id * fix(plugins): warn on the camelCase spelling of a connection key too The projection into harness knobs is an allowlist, so `apiKey` in a workspace file could never take effect — but it vanished without a word, which reads as acceptance. It is refused by name now, like its snake_case twin. * feat(cli): ov workspace show, and ov peer link|migrate|forget-previous `ov workspace show` answers "which layer actually set this" the way `git config --show-origin --show-scope` does: the workspace root and how it was found, the git remote, every template variable, the effective peer and the template that produced it, each config layer with whether it applied, and per key the effective value plus everything it shadowed. That question matters here because three languages read this configuration and each could drift. So the Rust reader is not a paraphrase of the JS one — the two were run side by side over the identity helpers, the merge with full provenance trees, the file-read rules and the registry's raw bytes, and made byte-identical. That comparison paid for itself: it caught `serde_json::Map::remove` being a swap remove under `preserve_order`, which reshuffled a registry file the JS half reads on every rewrite. It also caught the divergence that would have made the command a liar. ovcli.conf's `plugin` section speaks the flat knob names a harness loader reads (`peerSource`, `recallLimit`); a workspace file spells the same settings nested (`peer.source`, `recall.max_items`). Both are one chain in `loadPluginSettings`, and the port had merged the flat file into the nested tree, so `plugin.peerSource: "cwd"` in ovcli.conf left `ov workspace show` reporting the git-derived peer while every plugin sent the cwd-derived one. `ov peer link <id>` pins a peer for this workspace in the registry — the way out of a fork that should share the upstream's memory, or a legacy id worth keeping. `ov peer migrate` moves a peer's memories and resources with the fs mv API, reporting the plan by default and requiring `--apply`; the server has no merge semantics, so a collision is refused with the colliding path rather than overwritten, and a listing that fills its limit aborts rather than planning from a truncated view that could hide one. `ov peer forget-previous` clears the recorded ids. `workspace show`, `peer link` and `peer forget-previous` are local and do not require ovcli.conf; `peer migrate` talks to the server and does. Both config gates and the hand-rendered help are registered, with a test pinning the gates against each other. A test now reads FORBIDDEN_KEYS, REGISTRY_ONLY_KEYS and FREE_FORM_SECTIONS out of the JS module and compares them to the Rust constants, because those lists are what someone fixing a bug in one language edits — and they had already drifted once while this was being written. * build(cli): record the sha2 dependency edge in Cargo.lock Already vendored for other workspace members; ov_cli now uses it for the registry slot hash. * test(plugins): the fixtures the plan named that were still missing A moved or renamed repository keeping its identity is the change's whole point and had no test; a shallow clone was worth pinning because it is exactly what the rejected root-commit scheme could not answer; and the registry's read-modify-write window between two hooks of one session is now written down as a test rather than only as a comment. * fix: the defects a plan review turned up An independent review against the plan this branch was built from found ten real defects. Each was reproduced before being fixed and is now covered by a test. The four that broke a promise the feature makes: - The workspace config layer was resolved from the hook process's own working directory, not from the `cwd` on its stdin payload — which is the authoritative one. A hook started in one repository while the session sits in another applied the wrong `.openviking/config.json`: its peer, its bypass patterns, its `capture.enabled`. `loadConfig` now takes the directory, and every hook that receives one re-resolves with it. Late re-resolution is safe precisely because connection and credential keys are structurally forbidden in a workspace file, so `baseUrl` and `apiKey` cannot move under an already built client — the gates that a workspace can switch off moved below the parse so they are decided on the right config too. - Codex threw away a workspace file's `peer.id`: it returned the credential chain's peer verbatim, so `{"peer": {"id": "team-a"}}` did nothing. Claude Code had always honoured it. - Claude Code's session pin returned only the id and source, dropping `legacyPeerId` — so from the second hook of a session onward, dual-read stopped asking the peer that holds everything written before the derivation changed. Silently, and exactly where it mattered. - `ov peer migrate` read the source peer with the actor-peer header set, which the server refuses for another peer's path, and treated every `stat` error as "does not exist". The common case — an `actor_peer_id` in ovcli.conf — got a cheerful "Nothing to migrate" instead of a 403. It now uses a client with no actor peer and tells a real error apart from an empty source. The rest: - A directory outside any repository is a workspace again. It had no root at all, so a `.openviking/config.json` there was ignored entirely. `$HOME` and `/` are still never roots, now judged on the starting directory rather than on where the upward walk stops, and `git_root` stays empty outside a repository so the `git` preset still falls through to `{cwd}`. - The registry slot is keyed on identity, not path. Two linked worktrees of one repository are one workspace — one peer, so one set of settings and one `ov peer link` — and keying on the checkout path split them in two. This also makes crossing two repositories physically impossible rather than merely detected. (Their `config.json` files still follow each checkout; those are files on a branch.) - git folds section and key names to lower case, so `[Remote "origin"]` with `URL = …` is a remote `git config` reads and we did not. A quoted subsection stays case-sensitive. - `min_client_version` warns instead of being silently kept as data, and still never blocks. - `cli_config_profile` was validated and then never used. It now selects `~/.openviking/ovcli.conf.<name>` before credentials resolve — registry-only, name-only, and a hard error when the profile is missing, because quietly authenticating somewhere the user did not choose is the failure the key exists to prevent. - `ov workspace show` is exempt from the language gate. It is a diagnostic and has to work on a machine where no language was ever chosen; `peer link`, `migrate` and `forget-previous` mutate state and still gate. - `ov peer link` records the peer it replaced, so a later `migrate` with no `--from` finds it instead of falling back to a recomputed cwd id. Two more the plan asked for that were missing: doctor now checks the knobs *inside* ovcli.conf's `plugin` section — it was on the allowlist, so until now `peerSorce` sat there doing nothing with no complaint — and suggests the key you probably meant. A test derives the known-knob set from what the two loaders actually read, so the list cannot rot into one that rejects a real knob; it caught a missing entry the moment it was written. The RFC is archived at docs/design/, with the three claims implementation disproved corrected in place: the knob is `commit_token_threshold`, `__self` and `ext-` are not reserved server-side, and a worktree converges its identity rather than its config file. * revert(cli): withdraw ov workspace and ov peer from this branch The command surface these two files added was larger than the feature they served: 4792 lines of Rust for `ov workspace show` and `ov peer link|migrate|forget-previous`, against a change whose whole point is what the hooks send. None of it had reached a user-facing document — only the RFC named it — so it goes back out whole and the branch becomes a plugin change plus one CLI bug fix. Restored from the branch's merge-base rather than from origin/main, since main has moved on since the branch was cut and those commits are not this branch's to carry. `sha2` was pulled in only by `workspace.rs`, so its dependency edge leaves with it. What stays is `config.rs` and `config_wizard/store.rs`: `ov config add|edit` dropped the whole `plugin` section because the wizard round-tripped the file through a typed struct, and that fix has nothing to do with the withdrawn commands. The registry under `~/.openviking/workspaces/` stays too, as a layer the plugins read. Nothing writes it for now; `ov-memory-doctor` prints the path it expects, and the file is small enough to create by hand. A writer can come back on its own merits. * fix(plugins): derive a peer only inside a git repository Codex desktop opens a directory per task — `~/Documents/Codex/<date>/<slug>/` — and none of them is a repository. The `git` preset ended its fallback chain at `{cwd}`, so every one-off task minted its own empty peer, and each new one started with no memory. Nine such directories here, nine peers. There is nothing app-specific to read: the state file that lists those threads is Electron-private, a megabyte wide, desktop-only, and would have to be parsed inside SessionEnd's 3-second budget. The signal that generalizes is structural — the directory is not a repository, and nothing in it says it is a project. So the default chain is now `["{git_remote}", "{git_root}"]` and stops there. A directory that is neither a repository nor marked gets no peer at all, and what is remembered in it goes to the user-level space, which is where it went before peers existed. Deriving an identity from a bare path is what `peer.source: "cwd"` is for, and it is a word away. Naming such a directory is the other half. `findWorkspaceRoot` now also stops at a directory holding `.openviking/config.json` or `config.local.json`, so a marker file works from any depth below it, the way a repository does — and when that marker sits inside a repository the git variables still resolve to the enclosing repository, so marking a subdirectory of a monorepo does not split the default peer. `{git_root}` is the repository's root, `{dir}` the workspace root's name whichever made it one. Nothing moves. When no template resolves, the pre-git id is still computed and returned as `legacyPeerId`, so `peer_scope: "actor"` keeps asking for it and `"all"` keeps sweeping it. Two doctor bugs fell out of the same walk: `checkWorkspace` read `git.kind` unconditionally and threw wherever there was no repository, and the peer block warned "set peer.source to git" at a directory where `git` is exactly what is already set and correctly resolves to nothing. It now says why no peer is sent, and prints the file to create. * docs(plugins): say how to give a directory its own peer, to users and to agents The behavior change is only useful if the reader can act on it, and two kinds of reader have to: the person whose scratch folder stopped having a memory, and the coding agent they ask about it. `docs/{en,zh}/configuration/02-client.md` is the one place that spells the rule out, and everything else links to it. It gains "Give a Directory Its Own Peer", which opens with the file to create and then the ladder above and below it; "By Situation", eight rows from fork to throwaway folder; and "Recall Isolation", which separates where memories are written from what is read back, names the server's per-category penalties, and states the cost of sending no peer outside a repository — a user-level memory is read at full weight in every project afterwards. The eight integration pages, both capability references, six plugin READMEs, the changelog and the schema stop promising a fallback to the working directory. Checking those claims against the loaders turned up one that was never true: opencode, dsh and pi do not read workspace files at all, so a `peer.id` written for them does nothing. Said plainly rather than left to be discovered. For agents, `openviking-memory/SKILL.md` gains ten lines on where memories are filed — it is the skill that fires when someone asks why a folder has no project memory, and it had nothing to say — and both `ov-memory-doctor` references gain a table from what the user says to the exact key to write. `ov-memory-doctor` prints the same snippet, so an agent that runs it needs no further reading. One snippet has to be identical in twenty places for any of this to hold, so `WORKSPACE_PEER_HINT` is a constant the report builds its line from, and `peer-guidance.test.mjs` asserts it appears verbatim wherever it is promised, that no page still spells the retired chain or names a command this branch withdrew, and that every variable the canonical page documents is one the code substitutes. It asserts no prose: rewording a page must not turn it red. * fix(plugins): reject an unrecognized peer.source instead of using it as an id `peer.source` accepts a preset name, a template, or a list of templates, and anything that is not a preset was treated as a template. A template with no `{...}` in it renders to itself, so a typo became the peer: `"Git"` wrote every memory under a peer literally named `Git`, and `"gti"` under `gti`. Silently — the wrong namespace is indistinguishable from an empty one until someone notices their project has no memory. A bare string that is neither a preset nor contains `{` now warns and falls back to the `git` default. A list is still taken at face value: writing one is explicit enough that a typo inside it is a different kind of mistake. The warning travels through an optional `onWarn` callback falling back to stderr, matching `resolveMcpActorPeerId` in `mcp-proxy-config.mjs` — there is no warnings array in reach, because `resolveEffectivePeerId` is called from the hook runtime and from four harness config loaders, none of which thread one. * docs(plugins): say what each harness can actually do with a peer The peer documentation promised the same thing everywhere, but only the Claude Code and Codex plugins read workspace configuration files. `loadPluginSettings` is called from exactly two loaders; the other harnesses build their config from their own file plus the environment. So a reader following the docs under pi, dsh, opencode or cursor would create `.openviking/config.json` and watch it do nothing. The skill is the sharpest case: `openviking-memory/SKILL.md` is synced to cursor and dsh as well, and it told an agent to write that file. An agent would have done it, reported success, and changed nothing. It now names the two harnesses that read it and points everyone else at `OPENVIKING_PEER_ID`. The integration pages had started teaching the recipe and then retracting it in the same sentence, which is worse than not mentioning it; they now carry the one instruction that works there, and link to the canonical section for the rest. The capability reference gains the same qualification, next to the paragraph that already says only two harnesses read those layers. Two smaller corrections. The doctor references had the same question answered twice, once in the peer table and once in the troubleshooting table 140 lines below; the troubleshooting row survives, since it carries a diagnostic column. The RFC still archived implementation notes for the CLI this branch withdrew, which would read as a description of commands that exist. `peer-guidance.test.mjs` guards this alignment, and had two flaws of its own: it swept the changelogs, which are generated from GitHub Releases and would go red on a release note nobody wrote by hand, and it sliced a page between two headings with `indexOf` without checking either was found — renaming the closing heading would have silently scanned to end of file. Also here, because it is the same kind of mismatch: the zcode MCP proxy sent an actor peer under broad recall, where the other proxies leave the header unset. It now routes through `resolveMcpActorPeerId` like they do. The dsh proxy deliberately does not — its parent process resolves the peer per session and injects it into the child environment, so it is not guessing at a launch directory, and that reason is now recorded next to the line. * fix(plugins): ship and install only the shared modules a plugin imports Three new modules were fanned out to all seven plugin directories in one hunk, and only two plugins call them. That left dead weight in five directories, and it broke three installs. The install is the part that mattered. `install.sh` copies a hand-written list of shared files into `~/.openviking/agent-integrations/memory-plugin-shared/lib`, where cursor, TRAE and TRAE CLI import from. The list names `workspace-peer.mjs` but not `workspace-identity.mjs`, which `workspace-peer.mjs` imports — nor `workspace-config.mjs`, which identity had come to import for three filename constants. Copying exactly that list and importing the hook runtime fails with ERR_MODULE_NOT_FOUND, so every hook of those three harnesses would have died on startup. Nothing tested the list. `CONFIG_DIR_NAME`, `TEAM_FILE` and `LOCAL_FILE` now live in `workspace-identity.mjs`, which is where the walk that recognises a marked directory needs them; `workspace-config.mjs` imports and re-exports them, so no call site moves. Identity has no library-internal dependency left, which is what makes the installed set closed at fifteen files instead of pulling the whole configuration layer along behind it. `install-lib-closure.test.mjs` derives both sides — the list parsed out of the shell script, and the transitive imports of the three entrypoints — and fails in either direction, so neither a new dependency nor a stale entry can go unnoticed again. With identity standing alone, the fan-out can follow what is actually imported. `sync.mjs` moves from arrays chained by spread — where the harness that does not need a file is often the one the array is named after — to explicit per-target lists. `plugin-config.mjs`, `workspace-config.mjs` and `workspace-registry.mjs` leave dsh, pi, opencode and zcode, none of which import them; all four workspace modules leave agent-plugins, whose only importer was deleted a half hour after they arrived and whose peer is environment-only by design. That is about 4500 lines of vendored code that said something the code did not do. The registry loses its write path in the same spirit. `writeEntry`, `rememberPreviousPeer` and `listEntries` had no caller outside their own tests: the CLI that would have written them was withdrawn from this branch. `readEntry` and `entryPath` stay, because a hand-created entry is still read and the doctor still prints where to put one. `cli_config_profile` goes with them — the whole mechanism, down to the documentation that described it, since nothing ever resolved a profile through it. This is not a new policy. `HARNESS_KEYS` already carried the rule in a comment, added the day after the same speculative fan-out happened in August: add a key as its loader starts calling `loadPluginSettings`, not before, so the section never promises a knob that silently does nothing. * fix(dsh): thread peerSource into the per-session peer The integration page documents `peerSource` in dsh's Cordis patch, but `stateFor` never passed it to `resolveEffectivePeerId`, so the key resolved to nothing and every dsh session ran on the default derivation. Pass it, and keep the pre-git id alongside so dual-read reaches memories written before the default changed. * docs(plugins): correct the shared-layer counts after the distribution changed The capability reference still described the pre-branch distribution: 18 library modules against 23, per-target counts from before each target stopped receiving the workspace configuration layer, and `workspace-config` / `workspace-registry` listed as reaching every JS harness when only claude-code and codex load them. It also still said `cli_config_profile` was registry-only, and that the registry is written for you. * docs(rfc): lead with a TL;DR of the workspace config and peer source proposal * feat(plugins): let peer.source name the harness with {harness} The peer templates could describe where a checkout sits but never which agent was running in it, so one repository could not keep a separate memory per agent even when its user wanted that. The harness name was already in every config, only baked into the User-Agent string. No preset uses the new variable: sharing one project memory across agents is the more useful default, so splitting stays opt-in via a template such as "{git_remote}-{harness}". It is composed at render time rather than in the workspace identity, whose result is cached under a cwd-only key that two harnesses in one directory would share. * docs(rfc): record git_branch and peer.command as directions, not deliverables * chore(plugins): resync the openclaw vendored recall-core after the rebase * test(opencode): follow resolveEffectivePeerId's widened return shape Also mark the openclaw shared copies generated, the way every other sync target already is.	2026-09-04 12:50:43 +08:00
AlmazandSearXNG Agent	028c2cb503	fix(zcode): omit empty-string matchers from hooks template (#4391) ... ZCode parses config-file hooks with strict zod rules (matcher:string().min(1), groups .strict()). Empty-string matchers fail validation and safeParse drops the ENTIRE user hook source silently — hooks never fire while every component looks healthy. Omitted matcher matches all events, preserving semantics. Incident reproduction and bundle-extraction provenance documented in operator workspace: projects/zcode-ov-dsh-plugin/docs/post-install-verification.md Co-authored-by: SearXNG Agent <agent@searxng.local>	2026-08-28 12:41:00 +08:00
Axiomoth	cf5cc308ca	fix(codex): avoid stale actor peer in MCP proxy (#4400) ... Signed-off-by: Axiomoth <alearner@splrad.com>	2026-08-27 18:33:20 +08:00
t0saki	3b1db2082f	fix(memory-plugin): setup wizard first-run path, proxy hint, config source reporting (#4387)	2026-08-27 16:31:20 +08:00
now-ingandmac	90405e2619	fix(zcode): make async stop test robust on slow CI runners (#4363) ... The async-path test asserted the parent hook exits within a hard-coded 650ms wall-clock budget. On loaded CI runners the node cold start plus ESM module-graph load alone can exceed that budget (observed 4.8s on a contended runner), making the test flaky without any real regression. Drop the wall-clock latency budget and keep the two assertions that actually pin the async contract: - completedResponses === 0: every server response is delayed 700ms, so a parent that exits having completed none provably never awaited the network. A synchronous fallback completes both before exiting, so the degenerate path is still caught (verified by forcing maybeDetach to return false). - elapsed < OPENVIKING_TIMEOUT_MS: retained as a hang guard only. Also raise the detached-worker waitFor budget from 5s to 20s: on a slow runner the worker needs cold start + two 700ms-delayed responses + state writes, which can exceed the old 5s default. Co-authored-by: mac <bishopapril850965@yahoo.com>	2026-08-27 11:25:48 +08:00
Nguyen Thanh Dat	24185a0848	fix(memory-plugin): stop the uri-guard from reading file content as a path (#4188) (#4233) ... findVikingUri() checked the path-like keys and then swept every remaining argument value, so a local write or edit whose CONTENT merely mentioned a viking URI was denied and no file was created: write { file_path: "/home/me/notes.md", content: "docs say viking://user/default/ is virtual" } -> deny The sweep still runs — it is what catches an unusual or nested path key — but it now skips arguments that carry content rather than a location (content, new_string, old_string, file_text, ...). A URI in file_path, path, uri, an unknown nested path key, or a bash command still denies. Vendored copies regenerated with examples/memory-plugin-shared/sync.mjs.	2026-08-26 12:33:59 +08:00
Yu ZhangandClaude Sonnet 4.6	5356ced5ba	fix(plugin): honor explicit recall context timeout (#4256) ... * fix(plugin): honor explicit recall context timeout Let operator-configured recallContextTimeoutMs apply even when context recall skips rewrite and query expansion, so low-latency configs can still extend the request deadline explicitly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * fix(plugin): sync recall timeout override Keep the explicit recall context timeout behavior in the shared plugin source so generated plugin copies stay synchronized. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-08-26 12:01:07 +08:00
t0saki	a83b81715b	feat(uri)!: remove uid-less current-user shorthand in favor of viking://~ (#4196) ... * feat(uri)!: reject uid-less current-user shorthand in favor of viking://~ viking://user/<segment> (memories/resources/skills/peers/privacy/sessions without a user id) was ambiguous with a user literally named after the segment, and a user actually named e.g. "memories" was unreachable for USER/ADMIN callers. Now that the viking://~ home alias (#4167) covers the same need unambiguously, the shorthand fails closed at the request boundary instead of expanding: - resolve_current_user_uri raises NamespaceShapeError with a corrective hint naming both viking://~/<rest> and the explicit-uid form. Silently parsing the reserved segment as a peer user id would misdirect reads and writes, so rejection is the only safe removal. - Bare viking://user falls through to the canonical parser and keeps container semantics (a user key listing it sees only its own space). - The self-id escape stays: a caller whose user_id equals a reserved name keeps viking://user/<own-id> as their canonical root. ROOT-role literal parsing and the legacy viking://session alias are unchanged. - AddTargetsConfig normalizes stored legacy config spellings (viking://user/resources|skills) to the viking://~ form at validation so existing ov.conf/user_config deployments keep working; the accepted per-user spelling is now viking://~/resources and viking://~/skills. - usage_reporter keeps canonicalizing the historical shorthand found in old transcripts and additionally recognizes viking://~/memories/. BREAKING CHANGE: requests using the uid-less viking://user/<segment> spelling now fail with 400; use viking://~/<segment> or an explicit viking://user/{user_id}/<segment> URI. * refactor(clients): migrate first-party emitters to the viking://~ home alias Every in-repo client that emitted the removed uid-less current-user shorthand now sends viking://~/... instead: vikingbot fallbacks and default sentinels, the LangChain store/tools defaults, the shared recall-core.mjs (all synced plugin copies), the codex/claude-code/ openclaw/openwebui/dsh/zcode/pi plugin emitters, quick-app examples, Go SDK example, tau2 benchmark targets, and the eval golden dataset. Compat kept where legacy strings live in stored user configs: bot and ov_dream sentinels accept both spellings while emitting only ~, and recall-core still rewrites legacy viking://user/<reserved> config values client-side. langchain_openviking._uri now classifies viking://~ with the explicit-user shape so canonicalized server responses keep matching a ~ root. Plugin READMEs note the server requirement for the alias. * docs: replace current-user shorthand guidance with the viking://~ home alias Rewrite every EN/ZH doc and model-facing prompt that advertised the uid-less viking://user/<segment> spelling: URI concept catalogue, context-types/storage/extraction/retrieval/session/privacy concepts, configuration guide (with the legacy add_targets auto-normalization note), resources/skills/sessions/retrieval/admin API references, FAQ, capability reference, and the openviking-memory / ov-experience-memory / openclaw / ov-resources skills. The stale MCP viking://user/<path> dialect passage in the MCP guide is replaced by ~ guidance, and bare viking://user is documented as the container of user spaces. * test(api): migrate live API session-used tests off the removed shorthand tests/api_test/sessions sent uid-less viking://user/skills/... URIs to record_used, which the request boundary now rejects with 400 (caught by the API & CLI Integration Tests CI job; these tests need a live server and are not part of the local suites). The api_test client authenticates as an admin-role user key, so the viking://~ home alias expands for it. tests/api_test/common/test_edge_cases.py is left as is: it asserts a 400 for a non-resource add target, which still holds.	2026-08-21 19:00:19 +08:00
t0saki	c7044075ef	feat(dsh): serve tools over the shared stdio MCP proxy (#4157) ... * feat(dsh): serve tools over the shared stdio MCP proxy Replace the dsh bundle's seven hand-registered `viking_*` tools with the OpenViking MCP surface, reached through the same stdio proxy every other memory integration starts, and collapse the four duplicated proxy entrypoints onto a shared config builder. The bundle now mounts `@deepseek-ai/dsh-mcp-client` (which ships with dsh itself) on `servers/mcp-proxy.mjs`. Pointing an MCP SDK client straight at the server's `/mcp` endpoint does not work: with `stateless_http=True` the server still answers `GET /mcp` with an idle 200 SSE stream, and once the SDK client opens that standalone stream it stops resolving POST responses, so `tools/list` never returns. The stdio proxy owns the transport itself and is unaffected. `trimSlash`, `normalizePath`, `uniq`, the watched-credential-path list and the cfg -> proxyConfig mapping existed in four near-identical copies (claude-code, codex, opencode, agent-plugins; the last one carried a "keep in sync with claude-code" comment). They move to `memory-plugin-shared/lib/mcp-proxy-config.mjs` and all five entrypoints — including the new dsh one — now shape their config through `buildMcpProxyConfig`. Behavior is preserved per field, including codex's explicit `mcpUrl` override, claude-code's `ovcli.conf` credential-source probe, and opencode's extra watched config file. The bridge is mounted last in `apply()` so a proxy that fails to start cannot hold up profile injection, recall, capture, commit, or the URI guard registrations above it. * feat(dsh): add to the unified installer and ship the shared skill The bundle now registers its own isolated `ctx.skills` provider serving the shared `openviking-memory` skill, so DSH gets the same guidance the Claude Code, Codex, and Cursor integrations ship. `sync.mjs` distributes the skill to the bundle, and the provider uses `includeDefaultRoots: false` so it never shadows DSH's own project/user skill catalog. `install.sh` grows a `dsh` harness id, auto-detected like the others, plus a profile prompt that defaults to `web` (`--dsh-profile` / `OPENVIKING_DSH_PROFILE` answer it up front). The installer always installs the published package: `dsh plugin` forwards to pnpm, and a linked source tree cannot resolve the dsh peers the bundle imports because Node resolves them from the checkout's realpath rather than from the profile. Documentation is restructured around installing rather than internals. The integration page now leads with the one-line installer and keeps behavior at the level the other harness pages use, with configuration in a details block; design rationale moves to the bundle README, which itself leads with Install and groups the rationale under "Design notes". Capability-reference claims that dsh is outside the unified installer are corrected. * chore(dsh): release 0.2.0 The MCP tool surface, the stdio proxy transport, and the bundled skill all change what the bundle does for an existing user, so this is a minor bump rather than a patch. 0.1.0 remains the native-`viking_*` tool surface. * docs(dsh): note pnpm's 24h minimum release age pnpm 11 refuses releases younger than minimumReleaseAge (24 hours by default), and surfaces it as a registry 404, so installing a freshly published version reads as "the package does not exist". * fix(dsh): honour dev source mode in the installer install_dsh ignored SOURCE_MODE and always fetched the published package, so selecting "current checkout" installed npm's build instead of the working tree and validation still reported success. npm is the bundle's only distribution channel, so the github/tos choice does not apply to it: every mode except dev now installs the published package, and dev packs the checkout with npm pack first. It has to arrive as a real package rather than a link, because a linked source tree resolves its dsh peers from its own realpath and misses the profile's hoisted node_modules. The install line reports which source was used. * fix(dsh): make repeated installs actually overwrite Two ways a re-run silently kept stale code: pnpm treats an already-satisfied version as a no-op regardless of which tarball the file: dependency points at, so a dev re-install after editing the checkout left the previous build in place. Local installs now drop the package before adding it back; that is confined to local sources, since doing it for the registry path would leave nothing installed when add fails. A bare package name has the same effect in reverse: a profile holding a dev build satisfies it, so switching back to the published package was a no-op. The registry path now asks for @latest. The packed tarball is named after a fingerprint of the checkout's shipped files, so an unchanged checkout skips the pack and keeps a stable path in the profile lockfile.	2026-08-20 19:05:18 +08:00
t0saki	eb5aaf78e9	feat(mcp): consolidate recall into context search (#4075)	2026-08-18 12:45:45 +08:00
t0saki	33043cb1b8	feat(plugins): expose session commit trace IDs (#3977) ... Preserve result.trace_id across plugin HTTP wrappers, include it in commit success and failure logs, and surface it in user-visible commit confirmations where supported.	2026-08-13 23:29:41 +08:00
agent	00f3738edb	feat(usage): emit resource-scoped experience usage records (#3921) ... * feat(usage): expand experience tracking and log schema * fix(usage): preserve experience count event names * refactor(agent-evolution): use generic OpenViking tools * fix(usage): capture generic OpenViking tool events * feat(skills): guide cross-agent experience retrieval * fix(usage): address generic tool migration review	2026-08-11 22:20:18 +08:00
t0saki	7e26fab61c	fix(memory-plugins): report tool output verbatim, let the server externalize (#3933) ... Coding-agent plugins capped a tool part's `tool_output` at 2000 chars before POSTing it to `/api/v1/sessions/{id}/messages`. That cap sits below the server's own externalization threshold (`tool_output_externalization.threshold_chars`, default 20000), so output in the 2k-20k band was destroyed for no reason and anything larger never reached `ToolResultStore` - leaving `tool_output_ref` permanently empty and the `/tool-results` read-back path unusable. Raise the `captureToolMaxChars` default to 1000000 (a guard against pathological payloads, not a truncation policy) and lift the opencode/pi clamps that would otherwise pin it back to 20000. claude-code had no knob at all - two hardcoded `TOOL_OUTPUT_PART_MAX_CHARS = 2000` constants - so it gains the same config entry and both capture scripts now read it. Also stop pi from sending tool output twice: for a tool-only payload the rawText-derived text part re-rendered the same output the tool part carries.	2026-08-11 19:17:54 +08:00
t0sakiandTRAE CLI	0ab48f96fc	fix(session): recover partial capture sessions (#3820) ... Treat messages.jsonl as the materialization boundary for session-aware recall, repair partial session roots during the existing authoritative append path, and preserve Claude capture cursors when writes never reach the server. Also replay explicitly retryable storage conflicts across memory plugins. Co-authored-by: TRAE CLI <noreply@bytedance.com>	2026-08-06 14:48:42 +08:00
t0saki	674f5e6039	fix(retrieval): honor context tier ceilings and stop cooling unserved recalls (#3746) ... * fix(retrieval): honor tier ceilings and stop cooling unserved recalls Follow-up to #3534, from its post-merge review round. - The abstract-to-overview substitute now applies only to categories whose stored abstract is the whole file body. A resource or skill whose abstract is missing (`processing_mode=vectors_only`) or over the per-entry cap read its body and returned an overview instead, which for a short file is the body almost verbatim — crossing the opt-in deepening boundary those categories are documented to have, and doing it even under an explicit `detail="abstract"`. They now degrade to a bare URI and their body is never read. - A digest reporting `no_relevant` blanks `rendered`, so the client injects nothing, yet those URIs still entered the dedup ledger and were cooled for `dedup_turns` turns. That contradicted the ledger's own bare-URI grace rule and held memories back from the later turn they were relevant to. - Flat retrieval reaches built-in memory types outside the four named ones (`cases`, `patterns`, `tools`, `trajectories`, skill-usage memories) and reported them as an undeclared `memories` category that no tier or penalty table covered, so other-peer hits skipped the score penalty and callers could not pin their tier. The catch-all is now a declared category with both; it stays out of `quotas`, whose buckets it would overlap. Skill-usage memories also stop being misread as the `skills` category. - ZCode, OpenCode and pi own an OV session id but did not forward it, so their recalls silently ran without query expansion or cross-turn dedup. - The context-request deadline covered only the server's 30s rewrite fuse, but the pipeline is serial: expansion, retrieval and budgeting all precede it. 45s covers both fuses and the work between them. - `plugin` config scope and the `/recall` successor example now match what the code actually does. * fix(retrieval): make the context deadline and expansion opt-out reachable Forwarding a session id turns on server-side query expansion, an LLM call with its own 5s fuse, but neither the deadline that was supposed to cover it nor the switch that turns it off reached the two harnesses this PR newly enabled it for. - `contextRequestTimeoutMs()` now derives the deadline from the request body rather than from `cfg` plus a rewrite flag. The body is what states which server stages will run: a session takes the expansion fuse, `rewrite` takes the digest fuse, and a bare retrieval takes neither and keeps the caller's own budget. Reading `cfg` alone could not tell those apart. - OpenCode pinned `timeoutMs: 5000` after spreading the helper's options and pi ignored them entirely, so the helper's deadline was dead code in both. Their own budgets are now defaults rather than ceilings. OpenCode's 5s in particular was shorter than the expansion fuse it had just enabled, so a legal request would have been aborted client-side and dropped back to the path with neither dedup nor expansion. - OpenCode and pi read `OPENVIKING_RECALL_QUERY_EXPANSION` (and `recallQueryExpansion` in their own config files) and set the `configured` flag the shared body builder requires, so the documented opt-out exists where the cost was introduced. - The integration overview no longer implies every harness reads the same environment knobs, and describes the deadline as per-stage rather than rewrite-only.	2026-08-05 23:52:15 +08:00
3 people	2cc96e393e	feat(retrieval): assemble auto-recall context server-side via /search mode="context" (#3534) ... * feat(retrieval): assemble auto-recall context server-side via /search mode="context" Auto-recall assembly lived in every harness plugin: each one searched per memory type, read hits back one by one, and stitched a context block with its own budget and degradation rules. The implementations drifted, and the shared weaknesses showed up in production injections — roughly half of the entries degraded to a bare URI plus a score, character budgets distorted up to 6x on CJK text, and adjacent turns re-injected the same memories. This moves assembly into the server as one round trip. /find stays an unchanged stateless primitive. /search gains mode="context" (mode="list" is the default and byte-identical to before), and /recall becomes a thin preset over the same kernel with its v1 field names folded onto the new contract. New assembly kernel under openviking/retrieve/context_assembler/: - Token budgeting with a CJK-aware estimate replaces the character budget. - detail="auto" fills breadth-first then deepens: every candidate gets a readable floor, then overview, then full for high-scoring entries. An oversized tier falls back to the previous one instead of being truncated, bounded by max_tokens / candidates * 2 per entry. - Overview extraction dispatches by source: memory files use their leading Summary section, code files reuse code_outline signatures, long documents use a heading tree plus first paragraph. - Directory hits start at overview and read their .overview.md sidecar, since directories carry no stored abstract; their full tier stays capped at overview. v1 injected the sidecar as if it were a whole file. - Quotas generalize beyond memory types to resources and skills, with purpose presets supplying ratios when quotas are absent. - dedup_turns keeps a per-session ledger at {session_uri}/.recall_log.json so every harness inherits cross-turn dedup; exclude_uris remains as the stateless fallback. - Rendering flattens to one <memory uri=... type=... score=... detail=...> element per entry. Every tier carries its URI, so the model can always drill down through the MCP read tool. - Query expansion and digest rewriting are opt-in and fail closed: both have timeout fuses, and a failed rewrite still returns the unrewritten block. Retrieval failures are counted into stats rather than silently yielding an empty block. Plugins now send one context request, falling back to /recall and then to raw find on older deployments, and cache that outcome so only the first turn pays for the probe. The tri-state recallRewrite knob chooses between local host-CLI compression and the server digest, and client-side settings move to a plugin section in ovcli.conf. * refactor(retrieval): give context tiers a per-category default The tier ladder assumed `abstract` is a cheap summary. For memory files it is not: the memory writer stores the whole stripped body in that scalar because it doubles as the embedding text, so `abstract` costs the same as `full` and the ladder runs `uri < overview < abstract = full`. Two of the model's properties fell out of that: exempting `abstract` from the per-entry cap let a single entry eat several times the budget, and `detail` — which only ever set a ceiling — collapsed to two distinguishable behaviours across its four values, since `auto` already allowed `full` for memory. Tiers now come from a per-category constant table that treats the storage shape as a given: `events` starts at overview (the one memory type whose `# Summary` extraction is a real compression) and may deepen to full on leftover budget; every other category is served at `abstract`, which for memory already is the complete file at zero read cost and for resources and skills is the generated 256-char summary. The table carries the note to move `events` back to `abstract` once the writer stores a separate summary scalar. Falling out of that: prefetch now reads only the candidates whose planned tier needs a body rather than every candidate, `detail` becomes a real pin (start and ceiling) and additionally accepts a per-category map, and `full_score_threshold` is gone — leftover budget is spent in score order instead of behind an absolute threshold the observed score band cannot support. `auto` is still accepted on the wire as a synonym for "unset". Assembly fixes found alongside: - Removing the abstract cap exemption would turn an oversized abstract into a bare URI, so it now falls back to overview first — for memory that is a cheaper substitute, not a step up. - Rewrite timeouts were reported as failures on Python 3.10, where `asyncio.TimeoutError` is a separate class from the builtin. - `stats.rewrite_usage` read `token_tracker` off `VLMConfig`, which has no such attribute; usage was structurally always null. It now reads the model instance's tracker and reports only when the call count moved by exactly one, since that tracker is shared. - A single malformed ledger record made every deduped recall in that session fail, and the file was never rewritten, so it could not heal. Records are now coerced on read and dropped on the next write, along with records left ahead of the clock by an archive rotation. - Entries served as a bare URI no longer enter the dedup cooldown: they lost to budget pressure, not to the reader having already seen them. - The render envelope only neutralised a literal `</memory>`, so a body could forge a sibling entry with its own uri, type and score. - Flat-mode gathering re-derived the category from the URI, reading `viking://resources/backup/memories/events/log.md` as an event. - Cooled and excluded URIs are compensated with extra rows, so a fully cooled bucket falls through to the next-best hits instead of coming back empty. - `/recall` quotas overlay the v1 bucket defaults again; `{"events": 5}` had started dropping the other three buckets. - The MCP `recall` signature sent its own defaults as if the caller had, which resolved a different profile than `POST /recall`; an unknown `detail` value raised `KeyError` through the whole call instead of degrading. * feat(codex): inject profile context on session start Reuse the shared profile builder for startup, clear, and resume hooks while preserving archive injection and orphan-session status output. Co-authored-by: TRAE CLI <noreply@bytedance.com> * fix(retrieval): raise rewrite timeout default to 30s * docs(agents): document low-latency recall settings * fix(codex): prefer luna as recall compressor fallback * refactor(plugins): unify recall compression setting * feat(plugins): enable recall compression by default * docs(agents): use absolute links in image docs * fix(retrieval): address context assembly review feedback Co-authored-by: TRAE CLI <noreply@bytedance.com> * test: trim redundant context assembly coverage * fix(retrieval): address second-round context assembly review - Drop the backticked `/search` from the deprecated-recall row in both API overviews. The reference checker scans the whole row after the method cell for backticked paths, so it read the description as a route named `POST /search` and Build Docs failed on an unknown, undocumented route. - Accept ovcli.conf's full field set in both Python readers. The file's schema belongs to the Rust CLI, which writes `root_api_key`, `output`, `echo_command`, `show_progress` and `verbose` and ignores unknown keys; the two Python readers had drifted into stricter subsets, so the shipped example already failed to load in both. Adding the new `plugin` section to a working ovcli.conf would have broken `ov doctor` and every SDK client the same way. - Return 400 from `mode="context"` for a request `mode="list"` also rejects. Retrieval validates query and image_url before searching, and the gather fuse swallowed that rejection along with genuine scope failures, so a body of `{"mode":"context"}` came back 200 with an empty block instead of the documented parameter error. Runtime failures still degrade into `stats.retrieval_errors`. - Let a context request that asks for a server-side digest outlast the server's rewrite fuse. The plugin's ordinary 15s request timeout is shorter than the 30s fuse, so a rewrite that finished inside its own budget was aborted client-side, discarding the whole response — including the uncompressed block the server returns when a rewrite fails — and falling back to `/recall`. The deadline is only extended when the body actually requests a rewrite, and `OPENVIKING_RECALL_CONTEXT_TIMEOUT_MS` / `plugin.recallContextTimeoutMs` pins it. * chore(plugins): sync shared modules into the zcode snapshot * fix(retrieval): align context quotas and plugin defaults Restore cross-domain coding recall, reuse authoritative actor resource scopes, and make bucket quotas the sole width control in purpose mode. Keep plugin defaults server-owned while preserving explicit legacy limit settings through quota conversion. Co-authored-by: TRAE CLI <noreply@bytedance.com> * fix(retrieval): preserve recall compatibility Restore the deprecated recall threshold default, distinguish successful empty rewrites from compressor failures, and document legacy quota floors across coding-agent plugins. Co-authored-by: TRAE CLI <noreply@bytedance.com> --------- Co-authored-by: TRAE CLI <noreply@bytedance.com> Co-authored-by: qin-ctx <qinhaojie.exe@bytedance.com>	2026-08-05 12:31:21 +08:00
t0sakiandTRAE CLI	f08293411d	fix(zcode): make memory capture reliable (#3728) ... Use ZCode rollout logs as the authoritative incremental source, advance capture state only for the acknowledged prefix, and persist host turn identity with the OpenViking turn_id contract. Detach Stop writes, package ZCode in the TOS marketplace artifact, add end-to-end regressions, and move the integration docs under community plugins. Co-authored-by: TRAE CLI <noreply@bytedance.com>	2026-08-04 14:33:54 +08:00
阿舟的AI小站（超级个体）andwoshiguanxiaoliang	2c374e79d9	feat(integrations): add ZCode memory plugin (#3678) ... * feat(integrations): add ZCode memory plugin Add examples/zcode-memory-plugin — a thin ZCode lifecycle adapter that reuses the shared memory-plugin-shared runtime for recall, capture, commit, and MCP proxy. No memory logic is duplicated. Key design decisions (see docs/design/zcode-memory-plugin-design.md): - Vendor shared runtime into scripts/shared/ via sync.mjs (self-contained plugin) - 4 hook events only (SessionStart, UserPromptSubmit, PreToolUse, Stop) — ZCode does not support PreCompact/SessionEnd/SubagentStart/SubagentStop - Output schema: ZCode-canonical keys only (no Claude-Code 'decision: approve') - Config-driven install: hooks + MCP merged into ~/.zcode/cli/config.json - install.sh wiring: detection, TUI, validation, install, uninstall Verified locally: - 22/22 node:test cases pass (turns parser + hook output schema) - sync.test.mjs passes - install → uninstall cycle: hooks/MCP correctly written and cleaned - URI guard denies viking:// paths with MCP redirect - Capture writes to OV session with zc- prefix Closes #3127 Related: #3442, #3544 * chore: remove non-essential files from PR, add .scratch to .gitignore - Remove .scratch/ working notes (local ticket files, not codebase artifacts) - Remove package.json and .gitignore from plugin dir (TRAE/Cursor don't have them) - Add .scratch/ to root .gitignore * fix(zcode): use verified ZCode field names + rollout fallback for capture - Update zcode-turns.mjs to probe responseText/responsePreview (verified from ZCode reverse-engineering in #3127 by @quinn-zenith) instead of the TRAE-inferred last_assistant_message - Add rollout file fallback: when stdin payload lacks user content (the known ZCode limitation), read ~/.zcode/cli/rollout/model-io-sess-*.jsonl to extract the last user+assistant pair from request.messages+response - Fix concurrent session isolation: normalize sessionId→session_id in zcode-hook.mjs before resolveNativeSessionId to prevent cwd-fallback collision when two ZCode windows run in the same directory - Add 2 new test cases for rollout fallback (14 turns tests total, 24 total) - All 24 tests pass * fix(zcode): address maintainer review blockers (config safety, MCP ownership, turnId) Addresses 3 blockers from @huangruiteng's review (CHANGES_REQUESTED): 1. Config safety: distinguish ENOENT from parse errors — malformed config.json now aborts instead of overwriting. Use backup+tmp+rename for atomic writes. 2. MCP ownership: only replace/delete mcp.servers.openviking entries tagged as openviking-memory. User-managed entries with the same name are preserved on install and untouched on uninstall. 3. TurnId-based dedup: rollout entries carry monotonic turnId — now used as the primary dedup key (capturedTurnIds set) instead of stableHash. extractUnseenRolloutTurns scans ALL unseen entries since lastTurnId, not just the last row — recovers missed turns after hook failure. Fail-closed when no turns are found. Also updates DESIGN.md to reflect verified field names (responseText/ responsePreview) and the turnId contract. 27/27 tests pass (was 24). Added 3 new rollout tests: incremental capture with lastTurnId, multi-entry scan, turnId propagation. * docs(zcode): update stale field name references in design spec Update test case descriptions to match verified field names (responseText/responsePreview instead of last_assistant_message) and add rollout fallback + turnId test coverage descriptions. * fix(zcode): dedup key includes role + first-capture returns all turns Fix two bugs found in code review pass 2: 1. Assistant turns silently dropped: user and assistant from the same rollout entry shared a turnId, so dedup via capturedTurnIds dropped the assistant. Fix: dedup key is now ${turnId}:${role}, not turnId alone. Regression test added. 2. First-capture data loss: when no lastKnownTurnId was set, only the last rollout entry was returned, losing prior turns. Fix: first-time capture now returns ALL entries. Also: add backup step to config atomic write (copyFileSync before tmp+rename), fix line width in zcode-turns.mjs, add 2 lifecycle tests (missed Stop recovery, user+assistant same turnId). 29/29 tests pass (was 27). * test(zcode): add concurrent session isolation tests Two new test cases addressing maintainer criterion 4 (concurrent sessions): 1. Two sessions read their own rollout files — verifies session A cannot see session B's content and vice versa (sentinel-based assertion) 2. Independent lastTurnId state per session — verifies incremental capture progresses independently when one session has prior state and another is fresh 31/31 tests pass (was 29). * fix(zcode): correct rollout file path pattern (model-io-<sessionId>) The rollout path used model-io-sess-${sessionId} but ZCode filenames are model-io-<sessionId> where sessionId already includes the sess_ prefix. This caused the rollout fallback to always miss the file and return empty, defeating capture entirely in production. Verified on live two-session ZCode setup: - Session A (sess_8c6ce483): 2 messages, 2 commits - Session B (sess_74759710): 2 messages, 2 commits - No cross-contamination between sessions 31/31 tests pass. Updated all test rollout filename patterns. * docs(zcode): fix stale rollout path in comments and DESIGN.md Comments referenced model-io-sess-<sessionId> but actual pattern is model-io-<sessionId> (fixed in code already, comments were stale). --------- Co-authored-by: woshiguanxiaoliang <woshiguanxiaoliang@noreply.gitcode.com>	2026-08-04 11:58:18 +08:00