mirror of
https://github.com/volcengine/OpenViking.git
synced 2026-09-28 19:53:23 +08:00
Rami
d5bd4fd7a8
AsyncHTTPClient.create_session() takes (session_id, options); memory_policy
is a key of CreateSessionOptions, not a keyword argument. Three production
call sites still pass it as a keyword and raise
TypeError: AsyncHTTPClient.create_session() got an unexpected keyword
argument 'memory_policy'
on every session that does not already exist:
- openviking/ingest/replay.py, ConversationReplayClient.ensure_session:
`ingest backfill` fails on every new session. The orchestrator catches
per-session exceptions, so a first backfill prints one error per session
and finishes with 0 commits.
- bot/vikingbot/openviking_mount/ov_server.py, VikingClient.ensure_session.
- openviking/session/train/components/session_commit.py,
SessionCommitPolicyTrainer._commit_one, which swallows the TypeError and
returns a failed commit record with an empty task_id.
All three now pass options={"memory_policy": policy}, and options=None when
no policy is configured. benchmark/locomo/vikingbot/import_to_ov.py already
used that form.
The three test fakes accepted the obsolete keyword, so none of the paths had
regression coverage. They now mirror the real SDK signature: reverting any
one of the three fixes fails its tests.
Fixes #4493