mirror of
https://github.com/zhu1090093659/dsh-web.git
synced 2026-09-28 14:24:03 +08:00
zhu1090093659
75d0386e15
The old bare-import regex ran over raw source text, so English prose like "flips from 'missing' to an mtime" in a JSDoc comment was classified as an import statement and tripped the gate (blocked the whole tree). Replace the regex with a state-machine scan that skips comments, string and template literals and only accepts keyword-boundary from / import( forms; add regression cases for comment prose, literal prose, property lookups and real imports beside comments.
79 lines
3.2 KiB
JavaScript
79 lines
3.2 KiB
JavaScript
import test from 'node:test'
|
|
import assert from 'node:assert/strict'
|
|
import { checkRuntimeImports } from './runtime-deps-check.mjs'
|
|
|
|
test('flags a runtime import of a devDependencies-only package (issue #70)', () => {
|
|
const violations = checkRuntimeImports(
|
|
{ dependencies: {}, devDependencies: { schemastery: '^3.18.0' } },
|
|
{ 'packages/skins/skin-center/lib/index.js': "import z from 'schemastery'" },
|
|
)
|
|
assert.equal(violations.length, 1)
|
|
assert.equal(violations[0].specifier, 'schemastery')
|
|
})
|
|
|
|
test('accepts specifiers declared in dependencies', () => {
|
|
const violations = checkRuntimeImports(
|
|
{ dependencies: { schemastery: '^3.18.0' } },
|
|
{ 'lib/index.js': "import z from 'schemastery'" },
|
|
)
|
|
assert.equal(violations.length, 0)
|
|
})
|
|
|
|
test('accepts runtime-provided @deepseek-ai/* specifiers', () => {
|
|
const violations = checkRuntimeImports(
|
|
{ dependencies: {} },
|
|
{ 'lib/index.js': "import { Context } from '@deepseek-ai/cordis'" },
|
|
)
|
|
assert.equal(violations.length, 0)
|
|
})
|
|
|
|
test('accepts node: builtins and relative imports', () => {
|
|
const violations = checkRuntimeImports(
|
|
{ dependencies: {} },
|
|
{ 'lib/index.js': "import { join } from 'node:path'\nimport x from './local.js'" },
|
|
)
|
|
assert.equal(violations.length, 0)
|
|
})
|
|
|
|
test('accepts package subpath imports when the parent package is a dependency', () => {
|
|
const violations = checkRuntimeImports(
|
|
{ dependencies: { ssh2: '^1.17.0' } },
|
|
{ 'lib/index.js': "import { Client } from 'ssh2/lib/client'" },
|
|
)
|
|
assert.equal(violations.length, 0)
|
|
})
|
|
|
|
test('flags dynamic import() of a devDependencies-only package', () => {
|
|
const violations = checkRuntimeImports(
|
|
{ dependencies: {} },
|
|
{ 'lib/index.js': "await import('some-optional-runtime-dep')" },
|
|
)
|
|
assert.equal(violations.length, 1)
|
|
assert.equal(violations[0].specifier, 'some-optional-runtime-dep')
|
|
})
|
|
|
|
test('ignores prose that looks like an import inside comments', () => {
|
|
const source = '/**\n * mtime; a root that appears later flips from \'missing\' to an mtime);\n */\nexport const x = 1\n'
|
|
const violations = checkRuntimeImports({ dependencies: {} }, { 'lib/index.js': source })
|
|
assert.equal(violations.length, 0)
|
|
})
|
|
|
|
test('ignores prose that looks like an import inside string and template literals', () => {
|
|
const source = "export const a = \"flips from 'missing' to an mtime\"\nexport const b = `flips from 'missing' to an mtime`\nexport const c = 'flips from \"missing\" to an mtime'\n"
|
|
const violations = checkRuntimeImports({ dependencies: {} }, { 'lib/index.js': source })
|
|
assert.equal(violations.length, 0)
|
|
})
|
|
|
|
test('ignores property lookups named from or import', () => {
|
|
const source = "const a = x.from('pkg-from')\nconst b = y.import('pkg-import')\n"
|
|
const violations = checkRuntimeImports({ dependencies: {} }, { 'lib/index.js': source })
|
|
assert.equal(violations.length, 0)
|
|
})
|
|
|
|
test('keeps flagging real imports next to comment prose', () => {
|
|
const source = "// flips from 'missing' to an mtime\nimport { join } from 'node:path'\nimport x from 'missing-dep'\n"
|
|
const violations = checkRuntimeImports({ dependencies: {} }, { 'lib/index.js': source })
|
|
assert.equal(violations.length, 1)
|
|
assert.equal(violations[0].specifier, 'missing-dep')
|
|
})
|