mirror of
https://github.com/multica-ai/multica.git
synced 2026-09-29 16:59:28 +08:00
* feat(issue-status): per-workspace custom issue statuses over 7 canonical categories (MUL-6243) Co-authored-by: multica-agent <github@multica.ai> * fix(issue-status): address review — normalize all status consumers, close archive race, gate rollout, split PK index Review round 1 (MUL-6243 / PR #7065): 1. Behavior normalization was incomplete. Adds issue_effective_status() as a SQL mirror of issuestatus.Effective so the six SQL consumers the Go resolver cannot reach (duplicate guard, open-issue list, sub-issue progress, project stats, completed-inbox archive, open_only) resolve categories too. Wires the resolver into the task-failure sweeper and the stage-barrier helpers. 2. Archive TOCTOU. Archive now runs its in-use census and the archive itself in one transaction under an exclusive catalog lock; writes that target a custom status take the shared side. Built-in writes stay lock-free — a built-in can never be archived. 3. Rollout safety. Creating a custom status is gated behind the default-off CustomIssueStatuses flag, so a value old pods cannot interpret cannot exist until the fleet is updated. Readers ship ungated and are safe. 4. Primary key index. Follows the repo convention (327-329): table without a PK, unique index built CONCURRENTLY in its own migration, attached via PRIMARY KEY USING INDEX, and registered for invalid-index cleanup. 5. Status normalization vs stored value. Write paths now persist the canonical key from Resolve, so 'HUMAN_REVIEW' no longer validates and then fails the column format constraint as a 500. Also fixes the two CLI tests failing in CI: they asserted the pre-MUL-6243 contract that an unknown-but-well-formed status is rejected locally. Co-authored-by: multica-agent <github@multica.ai> * fix(issue-status): close the archive race in both orderings; resolve categories in batch barrier and CLI progress Review round 2 (MUL-6243 / PR #7065): 1. The archive race was only half closed. Handlers resolved the status BEFORE opening a transaction, so an archive could commit in that window and the write would still land on an archived key. assertIssueStatusStillActive now takes the shared catalog lock and RE-RESOLVES inside the caller's transaction, which is what actually makes the status provably active at write time. Applied to create, update, batch, and both description-merge branches, which previously bypassed the guard entirely. A losing writer gets 409 rather than a silent partial update. 2. The batch stage-barrier prefilter still compared literals, so a batch that moved the last child onto a custom done status left childDoneCompleted empty and skipped the parent notification. It now resolves categories first. 3. multica issue children --output json counted only literal done/cancelled. ListChildIssues now emits status_category and the CLI reads it, falling back to status for older backends. TestArchiveCommitsInsideTheWriteRaceWindow interleaves the two operations so the writer validates against an active status and the archive commits before the write. Verified it fails without the re-resolve (issue stranded on the archived status) and passes with it. Co-authored-by: multica-agent <github@multica.ai> * refactor(issue-status): address review nits — honest race-test naming, one catalog read per list Review round 3 nits (MUL-6243 / PR #7065): 1. TestArchiveRaceBothOrderings claimed more than it proved. Its 'archive wins' cases archived first and only then sent the request, which the pre-flight check alone rejects. Split into TestWritesRejectAnArchivedStatus (the sequential case, named for what it is) and TestArchiveRefusesAfterACommitted Write, and extended TestArchiveCommitsInsideTheWriteRaceWindow — the only test that truly interleaves archive between pre-flight and write — from create alone to all five write endpoints. Re-verified by deleting the in-transaction re-resolve: 4 of 5 fail with issues stranded on the archived status (create is guarded in the service layer and checked separately). 2. ListChildIssues / ListChildrenByParents issued one category lookup per custom-status child. issuestatus.Resolver now amortizes that to a single catalog read per request, lazily on the first custom key, so built-in statuses still cost zero queries however long the list is. Co-authored-by: multica-agent <github@multica.ai> --------- Co-authored-by: Bohan-J <bohan@devv.ai> Co-authored-by: multica-agent <github@multica.ai>
38 lines
1.6 KiB
PL/PgSQL
38 lines
1.6 KiB
PL/PgSQL
-- SQL mirror of issuestatus.Effective (MUL-6243).
|
|
--
|
|
-- Several queries have to ask "is this issue terminal / open?" in SQL, where
|
|
-- the Go resolver cannot reach. Without this, a custom status in the `done`
|
|
-- category would still count as open for the duplicate guard, and would be
|
|
-- missed by sub-issue and project completion counts.
|
|
--
|
|
-- The built-in fast path comes FIRST and short-circuits, so a workspace with no
|
|
-- custom statuses performs no catalog lookup at all — the same guarantee the Go
|
|
-- resolver gives. The lookup for a custom key is a single point read on
|
|
-- idx_issue_status_workspace_key.
|
|
--
|
|
-- Falls back to the raw status when the key is unknown or its category is
|
|
-- corrupt, matching the Go resolver's fail-safe direction: an unrecognized
|
|
-- status matches none of the canonical comparisons, so the issue is left alone
|
|
-- rather than being treated as terminal on a guess.
|
|
--
|
|
-- STABLE (not IMMUTABLE): the result depends on catalog rows, so it must not be
|
|
-- folded into an index or cached across statements.
|
|
CREATE FUNCTION issue_effective_status(p_workspace_id UUID, p_status TEXT)
|
|
RETURNS TEXT
|
|
LANGUAGE sql
|
|
STABLE
|
|
PARALLEL SAFE
|
|
AS $$
|
|
SELECT CASE
|
|
WHEN p_status IN ('backlog', 'todo', 'in_progress', 'in_review', 'done', 'blocked', 'cancelled')
|
|
THEN p_status
|
|
ELSE COALESCE(
|
|
(SELECT s.category
|
|
FROM issue_status s
|
|
WHERE s.workspace_id = p_workspace_id
|
|
AND s.key = p_status
|
|
AND s.category IN ('backlog', 'todo', 'in_progress', 'in_review', 'done', 'blocked', 'cancelled')),
|
|
p_status)
|
|
END
|
|
$$;
|