From 3ddfc15df500293861baf63d747c652965bad717 Mon Sep 17 00:00:00 2001 From: "opencode-agent[bot]" <219766164+opencode-agent[bot]@users.noreply.github.com> Date: Thu, 24 Sep 2026 16:09:44 +0800 Subject: [PATCH] feat(app): show bottom navigation setting on mobile production (#51067) --- packages/app/src/settings/general/general.tsx | 2 +- packages/app/src/settings/search-catalog.ts | 4 ++-- packages/app/src/settings/search-index.ts | 4 +--- packages/app/src/settings/search-results.test.ts | 9 ++++----- packages/app/src/settings/search.tsx | 1 - 5 files changed, 8 insertions(+), 12 deletions(-) diff --git a/packages/app/src/settings/general/general.tsx b/packages/app/src/settings/general/general.tsx index 42570f0dbab..9a63b508db4 100644 --- a/packages/app/src/settings/general/general.tsx +++ b/packages/app/src/settings/general/general.tsx @@ -394,7 +394,7 @@ export const SettingsGeneral: Component = () => { - + = { description?: Label section?: Label subtab?: "mcps" | "plugins" | "skills" | "lsps" - available?: "desktop" | "browser" | "dev" | "mobile-dev" + available?: "desktop" | "browser" | "mobile" } export const clientSettings: Entry[] = [ @@ -83,7 +83,7 @@ export const clientSettings: Entry[] = [ tab: "general", label: "settings.general.row.mobileTitlebarBottom.title", target: "settings-mobile-titlebar-bottom", - available: "mobile-dev", + available: "mobile", }, { tab: "general", diff --git a/packages/app/src/settings/search-index.ts b/packages/app/src/settings/search-index.ts index 04f1468b882..72d5bc728ea 100644 --- a/packages/app/src/settings/search-index.ts +++ b/packages/app/src/settings/search-index.ts @@ -17,7 +17,6 @@ export function settingsSearchIndex(input: { servers: readonly SettingsSearchServer[] desktop: boolean browser: boolean - dev: boolean mobile: boolean translate: ReturnType["t"] }) { @@ -57,8 +56,7 @@ export function settingsSearchIndex(input: { clientSettings.forEach((entry) => { if (entry.available === "desktop" && !input.desktop) return if (entry.available === "browser" && !input.browser) return - if ((entry.available === "dev" || entry.available === "mobile-dev") && !input.dev) return - if (entry.available === "mobile-dev" && !input.mobile) return + if (entry.available === "mobile" && !input.mobile) return add(entry, { type: "root", tab: entry.tab, target: entry.target }, "") }) input.servers.forEach((server) => { diff --git a/packages/app/src/settings/search-results.test.ts b/packages/app/src/settings/search-results.test.ts index 03bd4e85c54..3324728eeb3 100644 --- a/packages/app/src/settings/search-results.test.ts +++ b/packages/app/src/settings/search-results.test.ts @@ -18,7 +18,6 @@ function index(input: Partial[0]> = {}) { servers, desktop: false, browser: false, - dev: false, mobile: false, translate: (key) => strings[key], ...input, @@ -49,7 +48,7 @@ describe("settings search index", () => { expect(rankSettings("font", items, root)).toHaveLength(3) }) - test("only advertises settings supported by this platform and channel", () => { + test("only advertises settings supported by this platform", () => { const targets = (input: Parameters[0]) => index(input).map((item) => item.view.target) expect(targets({})).not.toContain("settings-pinch-zoom") expect(targets({})).not.toContain("settings-experimental-browser") @@ -57,9 +56,9 @@ describe("settings search index", () => { expect(targets({})).toContain("settings-tab-layout") expect(targets({ desktop: true })).toContain("settings-pinch-zoom") expect(targets({ browser: true })).not.toContain("settings-experimental-browser") - expect(targets({ dev: true })).not.toContain("settings-show-project-icon") - expect(targets({ dev: true })).not.toContain("settings-mobile-titlebar-bottom") - expect(targets({ dev: true, mobile: true })).toContain("settings-mobile-titlebar-bottom") + expect(targets({})).not.toContain("settings-show-project-icon") + expect(targets({})).not.toContain("settings-mobile-titlebar-bottom") + expect(targets({ mobile: true })).toContain("settings-mobile-titlebar-bottom") }) test("uses section labels and stable identities independent of translated text", () => { diff --git a/packages/app/src/settings/search.tsx b/packages/app/src/settings/search.tsx index 1e251025f2f..051b3c9bb3f 100644 --- a/packages/app/src/settings/search.tsx +++ b/packages/app/src/settings/search.tsx @@ -75,7 +75,6 @@ export function SettingsSearch() { servers: inventory(), desktop: platform.platform === "desktop", browser: !!platform.browserPane, - dev: import.meta.env.VITE_OPENCODE_CHANNEL !== "prod", mobile: mobile(), translate: language.t, }),