From 0567b73fec7cfc6485019a0ec79eeed39556cc4f Mon Sep 17 00:00:00 2001
From: Paul Irish <paulirish@chromium.org>
Date: Mon, 2 May 2022 11:31:12 -0700
Subject: [PATCH] Performance: Trace the default categories when Show All
 Events experiment is enabled.

Currently, this experiment reveals a few more events that
were not allowlisted. But this change will expand the tracing category
selection to all non-high-overhead categories.

Driveby: fix undefined property exception.

Change-Id: I236aad44e40724d82d8c37055686e03148059d2b
Bug: 1321307
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3616460
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
---
 front_end/models/timeline_model/TimelineModel.ts       | 2 +-
 front_end/panels/timeline/TimelineController.ts        | 2 +-
 test/unittests/front_end/helpers/EnvironmentHelpers.ts | 1 +
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/front_end/models/timeline_model/TimelineModel.ts b/front_end/models/timeline_model/TimelineModel.ts
index b77f94a23d..ef80eb1741 100644
--- a/front_end/models/timeline_model/TimelineModel.ts
+++ b/front_end/models/timeline_model/TimelineModel.ts
@@ -1211,7 +1211,7 @@ export class TimelineModelImpl {
 
   private processBrowserEvent(event: SDK.TracingModel.Event): void {
     if (event.name === RecordType.LatencyInfoFlow) {
-      if (event.args.chrome_latency_info.trace_id) {
+      if (event.args.chrome_latency_info?.trace_id) {
         this.knownInputEvents.add(event.args.chrome_latency_info.trace_id);
       }
       return;
diff --git a/front_end/panels/timeline/TimelineController.ts b/front_end/panels/timeline/TimelineController.ts
index bff15f5c6e..7a808a98ea 100644
--- a/front_end/panels/timeline/TimelineController.ts
+++ b/front_end/panels/timeline/TimelineController.ts
@@ -90,7 +90,7 @@ export class TimelineController implements SDK.TargetManager.SDKModelObserver<SD
     // 'disabled-by-default-v8.cpu_profiler'
     //   └ default: on, option: enableJSSampling
     const categoriesArray = [
-      '-*',
+      Root.Runtime.experiments.isEnabled('timelineShowAllEvents') ? '*' : '-*',
       TimelineModel.TimelineModel.TimelineModelImpl.Category.Console,
       TimelineModel.TimelineModel.TimelineModelImpl.Category.UserTiming,
       'devtools.timeline',
diff --git a/test/unittests/front_end/helpers/EnvironmentHelpers.ts b/test/unittests/front_end/helpers/EnvironmentHelpers.ts
index 6fc2821372..d816a3f8ad 100644
--- a/test/unittests/front_end/helpers/EnvironmentHelpers.ts
+++ b/test/unittests/front_end/helpers/EnvironmentHelpers.ts
@@ -48,6 +48,7 @@ const REGISTERED_EXPERIMENTS = [
   'protocolMonitor',
   'sourcesPrettyPrint',
   'wasmDWARFDebugging',
+  'timelineShowAllEvents',
   'timelineV8RuntimeCallStats',
   'timelineInvalidationTracking',
   'ignoreListJSFramesOnTimeline',