From 0e15e8064fd0806e403edba970ff57c489c672e1 Mon Sep 17 00:00:00 2001 From: Sigurd Schneider Date: Wed, 25 Mar 2020 17:14:52 +0100 Subject: [PATCH] [coverage] Disable save button if there is nothing to save MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Fixed: chromium:1064206 Change-Id: I4d0ffb00077fab94bf6485d4baba6a46b101f81a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2119689 Reviewed-by: Simon Zünd Commit-Queue: Sigurd Schneider --- front_end/coverage/CoverageView.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/front_end/coverage/CoverageView.js b/front_end/coverage/CoverageView.js index f418a5ef95..3594dd9213 100644 --- a/front_end/coverage/CoverageView.js +++ b/front_end/coverage/CoverageView.js @@ -73,11 +73,12 @@ export class CoverageView extends UI.Widget.VBox { toolbar.appendToolbarItem(this._clearButton); toolbar.appendSeparator(); - const saveButton = new UI.Toolbar.ToolbarButton(Common.UIString.UIString('Export...'), 'largeicon-download'); - saveButton.addEventListener(UI.Toolbar.ToolbarButton.Events.Click, event => { + this._saveButton = new UI.Toolbar.ToolbarButton(Common.UIString.UIString('Export...'), 'largeicon-download'); + this._saveButton.addEventListener(UI.Toolbar.ToolbarButton.Events.Click, event => { this._exportReport(); }); - toolbar.appendToolbarItem(saveButton); + toolbar.appendToolbarItem(this._saveButton); + this._saveButton.setEnabled(false); /** @type {?RegExp} */ this._textFilterRegExp = null; @@ -171,6 +172,7 @@ export class CoverageView extends UI.Widget.VBox { this._statusMessageElement.textContent = ''; this._filterInput.setEnabled(false); this._filterByTypeComboBox.setEnabled(false); + this._saveButton.setEnabled(false); } _toggleRecording() { @@ -328,6 +330,7 @@ export class CoverageView extends UI.Widget.VBox { _updateViews(updatedEntries) { this._updateStats(); this._listView.update(this._model.entries()); + this._saveButton.setEnabled(this._model.entries().length > 0); this._decorationManager.update(updatedEntries); }