From 19a45dfd55a4768f90c027afdfd7642fa7caa982 Mon Sep 17 00:00:00 2001 From: Tim van der Lippe Date: Fri, 28 Aug 2020 10:34:54 +0100 Subject: [PATCH] Remove is_legacy_javascript_entrypoint This removes the now-obsolete is_legacy_javascript_entrypoint build flag, which was used as part of the devtools_entrypoint migration. This uncovered that accessibility was still using devtools_pre_built and a file was missing from the GRD variable. R=aerotwist@chromium.org,jacktfranklin@chromium.org Fixed: 1101738 Change-Id: Ie1556ccc1d1563c855417de18e896308de0cfe19 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2356305 Reviewed-by: Paul Lewis Reviewed-by: Jack Franklin Commit-Queue: Tim van der Lippe --- all_devtools_modules.gni | 1 + devtools_grd_files.gni | 1 + front_end/accessibility/ARIAAttributesView.js | 3 + front_end/accessibility/ARIAMetadata.js | 3 + front_end/accessibility/AXBreadcrumbsPane.js | 3 + front_end/accessibility/AccessibilityModel.js | 3 + .../accessibility/AccessibilityNodeView.js | 3 + .../accessibility/AccessibilitySidebarView.js | 3 + .../accessibility/AccessibilitySubPane.js | 3 + front_end/accessibility/BUILD.gn | 19 +- front_end/animation/BUILD.gn | 1 - front_end/bindings/BUILD.gn | 1 - front_end/browser_sdk/BUILD.gn | 2 - front_end/changes/BUILD.gn | 1 - front_end/client_variations/BUILD.gn | 2 - front_end/cm/BUILD.gn | 2 - front_end/cm_headless/BUILD.gn | 2 - front_end/cm_modes/BUILD.gn | 2 - front_end/color_picker/BUILD.gn | 1 - front_end/common/BUILD.gn | 1 - front_end/components/BUILD.gn | 2 - front_end/console/BUILD.gn | 1 - front_end/console_counters/BUILD.gn | 2 - front_end/cookie_table/BUILD.gn | 1 - front_end/coverage/BUILD.gn | 1 - front_end/css_overview/BUILD.gn | 1 - front_end/data_grid/BUILD.gn | 1 - front_end/devices/BUILD.gn | 1 - front_end/diff/BUILD.gn | 1 - front_end/dom_extension/BUILD.gn | 1 - front_end/elements/BUILD.gn | 2 - front_end/emulation/BUILD.gn | 1 - front_end/event_listeners/BUILD.gn | 1 - front_end/extensions/BUILD.gn | 2 - front_end/formatter/BUILD.gn | 1 - front_end/har_importer/BUILD.gn | 1 - front_end/heap_snapshot_model/BUILD.gn | 1 - front_end/help/BUILD.gn | 1 - front_end/host/BUILD.gn | 2 - front_end/i18n/BUILD.gn | 1 - front_end/inline_editor/BUILD.gn | 1 - front_end/input/BUILD.gn | 1 - front_end/inspector_main/BUILD.gn | 1 - front_end/issues/BUILD.gn | 2 +- front_end/javascript_metadata/BUILD.gn | 1 - front_end/js_main/BUILD.gn | 1 - front_end/layer_viewer/BUILD.gn | 1 - front_end/layers/BUILD.gn | 1 - front_end/main/BUILD.gn | 1 - front_end/marked/BUILD.gn | 2 - front_end/mobile_throttling/BUILD.gn | 1 - front_end/network/BUILD.gn | 1 - front_end/node_main/BUILD.gn | 1 - front_end/object_ui/BUILD.gn | 1 - front_end/perf_ui/BUILD.gn | 1 - front_end/performance_monitor/BUILD.gn | 1 - front_end/persistence/BUILD.gn | 1 - front_end/platform/BUILD.gn | 2 - front_end/profiler/BUILD.gn | 1 - front_end/protocol_client/BUILD.gn | 2 - front_end/protocol_monitor/BUILD.gn | 1 - front_end/quick_open/BUILD.gn | 1 - front_end/resources/BUILD.gn | 1 - front_end/root/BUILD.gn | 2 - front_end/screencast/BUILD.gn | 1 - front_end/sdk/BUILD.gn | 2 - front_end/search/BUILD.gn | 2 - front_end/security/BUILD.gn | 1 - front_end/services/BUILD.gn | 1 - front_end/settings/BUILD.gn | 1 - front_end/snippets/BUILD.gn | 1 - front_end/source_frame/BUILD.gn | 1 - front_end/sources/BUILD.gn | 1 - front_end/text_editor/BUILD.gn | 1 - front_end/text_utils/BUILD.gn | 2 - front_end/theme_support/BUILD.gn | 2 - front_end/timeline/BUILD.gn | 1 - front_end/timeline_model/BUILD.gn | 2 +- front_end/toolbox_bootstrap/BUILD.gn | 1 - front_end/ui/BUILD.gn | 1 - front_end/ui/utils/BUILD.gn | 1 - front_end/web_audio/BUILD.gn | 1 - front_end/web_audio/graph_visualizer/BUILD.gn | 1 - front_end/worker_main/BUILD.gn | 1 - front_end/worker_service/BUILD.gn | 1 - front_end/workspace/BUILD.gn | 1 - front_end/workspace_diff/BUILD.gn | 1 - scripts/build/ninja/README.md | 36 --- scripts/build/ninja/devtools_entrypoint.gni | 261 +++++++----------- 89 files changed, 133 insertions(+), 303 deletions(-) diff --git a/all_devtools_modules.gni b/all_devtools_modules.gni index b40492bfed..b9534e6c6b 100644 --- a/all_devtools_modules.gni +++ b/all_devtools_modules.gni @@ -65,6 +65,7 @@ all_typescript_module_sources = [ "accessibility/AccessibilitySidebarView.js", "accessibility/AccessibilityStrings.js", "accessibility/AccessibilitySubPane.js", + "accessibility/SourceOrderView.js", "animation/AnimationGroupPreviewUI.js", "animation/AnimationModel.js", "animation/AnimationScreenshotPopover.js", diff --git a/devtools_grd_files.gni b/devtools_grd_files.gni index 913e809b93..8babef84ac 100644 --- a/devtools_grd_files.gni +++ b/devtools_grd_files.gni @@ -315,6 +315,7 @@ grd_files_debug_sources = [ "front_end/accessibility/AccessibilitySidebarView.js", "front_end/accessibility/AccessibilityStrings.js", "front_end/accessibility/AccessibilitySubPane.js", + "front_end/accessibility/SourceOrderView.js", "front_end/animation/AnimationGroupPreviewUI.js", "front_end/animation/AnimationModel.js", "front_end/animation/AnimationScreenshotPopover.js", diff --git a/front_end/accessibility/ARIAAttributesView.js b/front_end/accessibility/ARIAAttributesView.js index 320d0c25ab..68a862d077 100644 --- a/front_end/accessibility/ARIAAttributesView.js +++ b/front_end/accessibility/ARIAAttributesView.js @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @ts-nocheck +// TODO(crbug.com/1011811): Enable TypeScript compiler checks + import * as SDK from '../sdk/sdk.js'; // eslint-disable-line no-unused-vars import * as UI from '../ui/ui.js'; diff --git a/front_end/accessibility/ARIAMetadata.js b/front_end/accessibility/ARIAMetadata.js index e341f97422..0ab77c9dd6 100644 --- a/front_end/accessibility/ARIAMetadata.js +++ b/front_end/accessibility/ARIAMetadata.js @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @ts-nocheck +// TODO(crbug.com/1011811): Enable TypeScript compiler checks + import * as ARIAProperties from '../generated/ARIAProperties.js'; /** diff --git a/front_end/accessibility/AXBreadcrumbsPane.js b/front_end/accessibility/AXBreadcrumbsPane.js index a15c3e744c..48115ebeeb 100644 --- a/front_end/accessibility/AXBreadcrumbsPane.js +++ b/front_end/accessibility/AXBreadcrumbsPane.js @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @ts-nocheck +// TODO(crbug.com/1011811): Enable TypeScript compiler checks + import * as Common from '../common/common.js'; import * as SDK from '../sdk/sdk.js'; import * as UI from '../ui/ui.js'; diff --git a/front_end/accessibility/AccessibilityModel.js b/front_end/accessibility/AccessibilityModel.js index a9a0106488..f5ffb5e419 100644 --- a/front_end/accessibility/AccessibilityModel.js +++ b/front_end/accessibility/AccessibilityModel.js @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @ts-nocheck +// TODO(crbug.com/1011811): Enable TypeScript compiler checks + import * as SDK from '../sdk/sdk.js'; /** diff --git a/front_end/accessibility/AccessibilityNodeView.js b/front_end/accessibility/AccessibilityNodeView.js index 1b97ecfd67..bf5be9113a 100644 --- a/front_end/accessibility/AccessibilityNodeView.js +++ b/front_end/accessibility/AccessibilityNodeView.js @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @ts-nocheck +// TODO(crbug.com/1011811): Enable TypeScript compiler checks + import * as Common from '../common/common.js'; import * as SDK from '../sdk/sdk.js'; import * as UI from '../ui/ui.js'; diff --git a/front_end/accessibility/AccessibilitySidebarView.js b/front_end/accessibility/AccessibilitySidebarView.js index 62336e63a2..6e422eb5af 100644 --- a/front_end/accessibility/AccessibilitySidebarView.js +++ b/front_end/accessibility/AccessibilitySidebarView.js @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @ts-nocheck +// TODO(crbug.com/1011811): Enable TypeScript compiler checks + import * as Common from '../common/common.js'; // eslint-disable-line no-unused-vars import * as SDK from '../sdk/sdk.js'; import * as UI from '../ui/ui.js'; diff --git a/front_end/accessibility/AccessibilitySubPane.js b/front_end/accessibility/AccessibilitySubPane.js index 96a78eb52d..c8cd6edd82 100644 --- a/front_end/accessibility/AccessibilitySubPane.js +++ b/front_end/accessibility/AccessibilitySubPane.js @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @ts-nocheck +// TODO(crbug.com/1011811): Enable TypeScript compiler checks + import * as SDK from '../sdk/sdk.js'; // eslint-disable-line no-unused-vars import * as UI from '../ui/ui.js'; diff --git a/front_end/accessibility/BUILD.gn b/front_end/accessibility/BUILD.gn index d191a2b8cb..24e3472589 100644 --- a/front_end/accessibility/BUILD.gn +++ b/front_end/accessibility/BUILD.gn @@ -3,9 +3,9 @@ # found in the LICENSE file. import("../../scripts/build/ninja/devtools_entrypoint.gni") -import("../../scripts/build/ninja/devtools_pre_built.gni") +import("../../scripts/build/ninja/devtools_module.gni") -devtools_pre_built("accessibility") { +devtools_module("accessibility") { sources = [ "ARIAAttributesView.js", "ARIAMetadata.js", @@ -17,15 +17,18 @@ devtools_pre_built("accessibility") { "AccessibilitySubPane.js", "SourceOrderView.js", ] + + deps = [ + "../common:bundle", + "../generated", + "../host:bundle", + "../sdk:bundle", + "../ui:bundle", + ] } devtools_entrypoint("bundle") { entrypoint = "accessibility.js" - deps = [ - ":accessibility", - "../elements:bundle", - "../generated", - "../sdk:bundle", - ] + deps = [ ":accessibility" ] } diff --git a/front_end/animation/BUILD.gn b/front_end/animation/BUILD.gn index 7f17977af8..34008f0d1a 100644 --- a/front_end/animation/BUILD.gn +++ b/front_end/animation/BUILD.gn @@ -26,7 +26,6 @@ devtools_module("animation") { devtools_entrypoint("bundle") { entrypoint = "animation.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":animation" ] } diff --git a/front_end/bindings/BUILD.gn b/front_end/bindings/BUILD.gn index 1a832b13e6..683c88f0e6 100644 --- a/front_end/bindings/BUILD.gn +++ b/front_end/bindings/BUILD.gn @@ -38,7 +38,6 @@ devtools_module("bindings") { devtools_entrypoint("bundle") { entrypoint = "bindings.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":bindings" ] } diff --git a/front_end/browser_sdk/BUILD.gn b/front_end/browser_sdk/BUILD.gn index 220b0f56f8..b541fa53b1 100644 --- a/front_end/browser_sdk/BUILD.gn +++ b/front_end/browser_sdk/BUILD.gn @@ -21,7 +21,5 @@ devtools_module("browser_sdk") { devtools_entrypoint("bundle") { entrypoint = "browser_sdk.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":browser_sdk" ] } diff --git a/front_end/changes/BUILD.gn b/front_end/changes/BUILD.gn index ff7b410407..c3b0948541 100644 --- a/front_end/changes/BUILD.gn +++ b/front_end/changes/BUILD.gn @@ -26,7 +26,6 @@ devtools_module("changes") { devtools_entrypoint("bundle") { entrypoint = "changes.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":changes" ] } diff --git a/front_end/client_variations/BUILD.gn b/front_end/client_variations/BUILD.gn index f9174a966c..06db1813ac 100644 --- a/front_end/client_variations/BUILD.gn +++ b/front_end/client_variations/BUILD.gn @@ -7,7 +7,5 @@ import("../../scripts/build/ninja/devtools_entrypoint.gni") devtools_entrypoint("bundle") { entrypoint = "client_variations.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ "../third_party/chromium" ] } diff --git a/front_end/cm/BUILD.gn b/front_end/cm/BUILD.gn index 26b43a4a85..8dce194813 100644 --- a/front_end/cm/BUILD.gn +++ b/front_end/cm/BUILD.gn @@ -7,7 +7,5 @@ import("../../scripts/build/ninja/devtools_entrypoint.gni") devtools_entrypoint("cm") { entrypoint = "cm.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ "../third_party/codemirror" ] } diff --git a/front_end/cm_headless/BUILD.gn b/front_end/cm_headless/BUILD.gn index 055a6f0a93..f0b913e067 100644 --- a/front_end/cm_headless/BUILD.gn +++ b/front_end/cm_headless/BUILD.gn @@ -7,7 +7,5 @@ import("../../scripts/build/ninja/devtools_entrypoint.gni") devtools_entrypoint("cm_headless") { entrypoint = "cm_headless.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ "../third_party/codemirror" ] } diff --git a/front_end/cm_modes/BUILD.gn b/front_end/cm_modes/BUILD.gn index 6086c0b856..b11c63d43d 100644 --- a/front_end/cm_modes/BUILD.gn +++ b/front_end/cm_modes/BUILD.gn @@ -14,8 +14,6 @@ devtools_module("cm_modes") { devtools_entrypoint("bundle") { entrypoint = "cm_modes.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":cm_modes", "../third_party/codemirror", diff --git a/front_end/color_picker/BUILD.gn b/front_end/color_picker/BUILD.gn index 755310812d..f203f87857 100644 --- a/front_end/color_picker/BUILD.gn +++ b/front_end/color_picker/BUILD.gn @@ -24,7 +24,6 @@ devtools_module("color_picker") { devtools_entrypoint("bundle") { entrypoint = "color_picker.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":color_picker" ] } diff --git a/front_end/common/BUILD.gn b/front_end/common/BUILD.gn index f7c8436a7d..875f02fa01 100644 --- a/front_end/common/BUILD.gn +++ b/front_end/common/BUILD.gn @@ -42,7 +42,6 @@ devtools_module("common") { devtools_entrypoint("bundle") { entrypoint = "common.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":common" ] } diff --git a/front_end/components/BUILD.gn b/front_end/components/BUILD.gn index 35af6b9f1c..e553c1266b 100644 --- a/front_end/components/BUILD.gn +++ b/front_end/components/BUILD.gn @@ -29,7 +29,5 @@ devtools_module("components") { devtools_entrypoint("bundle") { entrypoint = "components.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":components" ] } diff --git a/front_end/console/BUILD.gn b/front_end/console/BUILD.gn index f5a7dc23af..d6491e070b 100644 --- a/front_end/console/BUILD.gn +++ b/front_end/console/BUILD.gn @@ -35,7 +35,6 @@ devtools_module("console") { devtools_entrypoint("bundle") { entrypoint = "console.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":console" ] } diff --git a/front_end/console_counters/BUILD.gn b/front_end/console_counters/BUILD.gn index 5c1c0121db..f046b72e04 100644 --- a/front_end/console_counters/BUILD.gn +++ b/front_end/console_counters/BUILD.gn @@ -20,7 +20,5 @@ devtools_module("console_counters") { devtools_entrypoint("bundle") { entrypoint = "console_counters.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":console_counters" ] } diff --git a/front_end/cookie_table/BUILD.gn b/front_end/cookie_table/BUILD.gn index e28a5b70c9..53a62cf72e 100644 --- a/front_end/cookie_table/BUILD.gn +++ b/front_end/cookie_table/BUILD.gn @@ -20,7 +20,6 @@ devtools_module("cookie_table") { devtools_entrypoint("bundle") { entrypoint = "cookie_table.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":cookie_table" ] } diff --git a/front_end/coverage/BUILD.gn b/front_end/coverage/BUILD.gn index f3378267b6..f77adf2fd9 100644 --- a/front_end/coverage/BUILD.gn +++ b/front_end/coverage/BUILD.gn @@ -30,7 +30,6 @@ devtools_module("coverage") { devtools_entrypoint("bundle") { entrypoint = "coverage.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":coverage" ] } diff --git a/front_end/css_overview/BUILD.gn b/front_end/css_overview/BUILD.gn index 794e42e078..3ec1555f84 100644 --- a/front_end/css_overview/BUILD.gn +++ b/front_end/css_overview/BUILD.gn @@ -30,7 +30,6 @@ devtools_module("css_overview") { devtools_entrypoint("bundle") { entrypoint = "css_overview.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":css_overview" ] } diff --git a/front_end/data_grid/BUILD.gn b/front_end/data_grid/BUILD.gn index c7a21acd2d..2d197c4ad6 100644 --- a/front_end/data_grid/BUILD.gn +++ b/front_end/data_grid/BUILD.gn @@ -22,7 +22,6 @@ devtools_module("data_grid") { devtools_entrypoint("bundle") { entrypoint = "data_grid.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":data_grid" ] } diff --git a/front_end/devices/BUILD.gn b/front_end/devices/BUILD.gn index 92332c767a..c0fecf29ba 100644 --- a/front_end/devices/BUILD.gn +++ b/front_end/devices/BUILD.gn @@ -16,7 +16,6 @@ devtools_module("devices") { devtools_entrypoint("bundle") { entrypoint = "devices.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":devices" ] } diff --git a/front_end/diff/BUILD.gn b/front_end/diff/BUILD.gn index d73c51b314..bc2b9fc4dc 100644 --- a/front_end/diff/BUILD.gn +++ b/front_end/diff/BUILD.gn @@ -16,7 +16,6 @@ devtools_module("diff") { devtools_entrypoint("bundle") { entrypoint = "diff.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":diff" ] } diff --git a/front_end/dom_extension/BUILD.gn b/front_end/dom_extension/BUILD.gn index 57977f29d5..3b43152d7d 100644 --- a/front_end/dom_extension/BUILD.gn +++ b/front_end/dom_extension/BUILD.gn @@ -11,7 +11,6 @@ devtools_module("dom_extension") { devtools_entrypoint("bundle") { entrypoint = "dom_extension.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":dom_extension" ] } diff --git a/front_end/elements/BUILD.gn b/front_end/elements/BUILD.gn index aca92d25d6..af81d5925e 100644 --- a/front_end/elements/BUILD.gn +++ b/front_end/elements/BUILD.gn @@ -84,7 +84,5 @@ devtools_module("elements") { devtools_entrypoint("bundle") { entrypoint = "elements.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":elements" ] } diff --git a/front_end/emulation/BUILD.gn b/front_end/emulation/BUILD.gn index def5756bc2..8e750cb867 100644 --- a/front_end/emulation/BUILD.gn +++ b/front_end/emulation/BUILD.gn @@ -36,7 +36,6 @@ devtools_module("emulation") { devtools_entrypoint("bundle") { entrypoint = "emulation.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":emulation" ] } diff --git a/front_end/event_listeners/BUILD.gn b/front_end/event_listeners/BUILD.gn index 6c4de4fdc8..755c499d21 100644 --- a/front_end/event_listeners/BUILD.gn +++ b/front_end/event_listeners/BUILD.gn @@ -22,7 +22,6 @@ devtools_module("event_listeners") { devtools_entrypoint("bundle") { entrypoint = "event_listeners.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":event_listeners" ] } diff --git a/front_end/extensions/BUILD.gn b/front_end/extensions/BUILD.gn index 772546bcee..ab6fe8c47c 100644 --- a/front_end/extensions/BUILD.gn +++ b/front_end/extensions/BUILD.gn @@ -34,7 +34,5 @@ devtools_module("extensions") { devtools_entrypoint("bundle") { entrypoint = "extensions.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":extensions" ] } diff --git a/front_end/formatter/BUILD.gn b/front_end/formatter/BUILD.gn index 82d19d90d7..ce5bff26c1 100644 --- a/front_end/formatter/BUILD.gn +++ b/front_end/formatter/BUILD.gn @@ -24,7 +24,6 @@ devtools_module("formatter") { devtools_entrypoint("bundle") { entrypoint = "formatter.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":formatter" ] } diff --git a/front_end/har_importer/BUILD.gn b/front_end/har_importer/BUILD.gn index 8a6d791ae9..0a21991326 100644 --- a/front_end/har_importer/BUILD.gn +++ b/front_end/har_importer/BUILD.gn @@ -19,7 +19,6 @@ devtools_module("har_importer") { devtools_entrypoint("bundle") { entrypoint = "har_importer.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":har_importer" ] } diff --git a/front_end/heap_snapshot_model/BUILD.gn b/front_end/heap_snapshot_model/BUILD.gn index 95fd746fa0..c9ea2928b0 100644 --- a/front_end/heap_snapshot_model/BUILD.gn +++ b/front_end/heap_snapshot_model/BUILD.gn @@ -13,7 +13,6 @@ devtools_module("heap_snapshot_model") { devtools_entrypoint("bundle") { entrypoint = "heap_snapshot_model.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":heap_snapshot_model" ] } diff --git a/front_end/help/BUILD.gn b/front_end/help/BUILD.gn index a417f6f178..b6cb6771cd 100644 --- a/front_end/help/BUILD.gn +++ b/front_end/help/BUILD.gn @@ -21,7 +21,6 @@ devtools_module("help") { devtools_entrypoint("bundle") { entrypoint = "help.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":help" ] } diff --git a/front_end/host/BUILD.gn b/front_end/host/BUILD.gn index 44aa95a382..c440210ce7 100644 --- a/front_end/host/BUILD.gn +++ b/front_end/host/BUILD.gn @@ -23,7 +23,5 @@ devtools_module("host") { devtools_entrypoint("bundle") { entrypoint = "host.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":host" ] } diff --git a/front_end/i18n/BUILD.gn b/front_end/i18n/BUILD.gn index 7568f86b01..1952e3f67e 100644 --- a/front_end/i18n/BUILD.gn +++ b/front_end/i18n/BUILD.gn @@ -18,7 +18,6 @@ devtools_module("i18n") { devtools_entrypoint("bundle") { entrypoint = "i18n.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":i18n", ":i18n_locales", diff --git a/front_end/inline_editor/BUILD.gn b/front_end/inline_editor/BUILD.gn index bf6d21af8d..54a8c3ccae 100644 --- a/front_end/inline_editor/BUILD.gn +++ b/front_end/inline_editor/BUILD.gn @@ -25,7 +25,6 @@ devtools_module("inline_editor") { devtools_entrypoint("bundle") { entrypoint = "inline_editor.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":inline_editor" ] } diff --git a/front_end/input/BUILD.gn b/front_end/input/BUILD.gn index fb92fa483e..b44dbf5f5a 100644 --- a/front_end/input/BUILD.gn +++ b/front_end/input/BUILD.gn @@ -23,7 +23,6 @@ devtools_module("input") { devtools_entrypoint("bundle") { entrypoint = "input.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":input" ] } diff --git a/front_end/inspector_main/BUILD.gn b/front_end/inspector_main/BUILD.gn index c3debfeabf..67f5e39f54 100644 --- a/front_end/inspector_main/BUILD.gn +++ b/front_end/inspector_main/BUILD.gn @@ -23,7 +23,6 @@ devtools_module("inspector_main") { devtools_entrypoint("bundle") { entrypoint = "inspector_main.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":inspector_main" ] } diff --git a/front_end/issues/BUILD.gn b/front_end/issues/BUILD.gn index cb8e2e32cf..b062950d68 100644 --- a/front_end/issues/BUILD.gn +++ b/front_end/issues/BUILD.gn @@ -32,6 +32,6 @@ devtools_module("issues") { devtools_entrypoint("bundle") { entrypoint = "issues.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] + deps = [ ":issues" ] } diff --git a/front_end/javascript_metadata/BUILD.gn b/front_end/javascript_metadata/BUILD.gn index f56d3ec5f0..5f670ce4c8 100644 --- a/front_end/javascript_metadata/BUILD.gn +++ b/front_end/javascript_metadata/BUILD.gn @@ -16,7 +16,6 @@ devtools_module("javascript_metadata") { devtools_entrypoint("bundle") { entrypoint = "javascript_metadata.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":javascript_metadata" ] } diff --git a/front_end/js_main/BUILD.gn b/front_end/js_main/BUILD.gn index a5797bdd0b..807e5bcb95 100644 --- a/front_end/js_main/BUILD.gn +++ b/front_end/js_main/BUILD.gn @@ -18,7 +18,6 @@ devtools_module("js_main") { devtools_entrypoint("bundle") { entrypoint = "js_main.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":js_main" ] } diff --git a/front_end/layer_viewer/BUILD.gn b/front_end/layer_viewer/BUILD.gn index 266366347f..46bb96429d 100644 --- a/front_end/layer_viewer/BUILD.gn +++ b/front_end/layer_viewer/BUILD.gn @@ -26,7 +26,6 @@ devtools_module("layer_viewer") { devtools_entrypoint("bundle") { entrypoint = "layer_viewer.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":layer_viewer" ] } diff --git a/front_end/layers/BUILD.gn b/front_end/layers/BUILD.gn index ed61557092..ece89116d6 100644 --- a/front_end/layers/BUILD.gn +++ b/front_end/layers/BUILD.gn @@ -22,7 +22,6 @@ devtools_module("layers") { devtools_entrypoint("bundle") { entrypoint = "layers.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":layers" ] } diff --git a/front_end/main/BUILD.gn b/front_end/main/BUILD.gn index cc2d5f2ee2..2e6dff6989 100644 --- a/front_end/main/BUILD.gn +++ b/front_end/main/BUILD.gn @@ -29,7 +29,6 @@ devtools_module("main") { devtools_entrypoint("bundle") { entrypoint = "main.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":main" ] } diff --git a/front_end/marked/BUILD.gn b/front_end/marked/BUILD.gn index 15b9defc5f..d66fbf3719 100644 --- a/front_end/marked/BUILD.gn +++ b/front_end/marked/BUILD.gn @@ -7,7 +7,5 @@ import("../../scripts/build/ninja/devtools_entrypoint.gni") devtools_entrypoint("bundle") { entrypoint = "marked.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ "../third_party/marked" ] } diff --git a/front_end/mobile_throttling/BUILD.gn b/front_end/mobile_throttling/BUILD.gn index dcc1c80b5d..c730f3524d 100644 --- a/front_end/mobile_throttling/BUILD.gn +++ b/front_end/mobile_throttling/BUILD.gn @@ -25,7 +25,6 @@ devtools_module("mobile_throttling") { devtools_entrypoint("bundle") { entrypoint = "mobile_throttling.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":mobile_throttling" ] } diff --git a/front_end/network/BUILD.gn b/front_end/network/BUILD.gn index 17fda4500d..8fbabecaf2 100644 --- a/front_end/network/BUILD.gn +++ b/front_end/network/BUILD.gn @@ -60,7 +60,6 @@ devtools_module("network") { devtools_entrypoint("bundle") { entrypoint = "network.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":network" ] } diff --git a/front_end/node_main/BUILD.gn b/front_end/node_main/BUILD.gn index 18b7fb7920..8cfc21e267 100644 --- a/front_end/node_main/BUILD.gn +++ b/front_end/node_main/BUILD.gn @@ -23,7 +23,6 @@ devtools_module("node_main") { devtools_entrypoint("bundle") { entrypoint = "node_main.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":node_main" ] } diff --git a/front_end/object_ui/BUILD.gn b/front_end/object_ui/BUILD.gn index a0ec25f19e..ad7e57a98e 100644 --- a/front_end/object_ui/BUILD.gn +++ b/front_end/object_ui/BUILD.gn @@ -29,7 +29,6 @@ devtools_module("object_ui") { devtools_entrypoint("bundle") { entrypoint = "object_ui.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":object_ui" ] } diff --git a/front_end/perf_ui/BUILD.gn b/front_end/perf_ui/BUILD.gn index 719da4e888..26ec554976 100644 --- a/front_end/perf_ui/BUILD.gn +++ b/front_end/perf_ui/BUILD.gn @@ -42,7 +42,6 @@ devtools_module("perf_ui") { devtools_entrypoint("bundle") { entrypoint = "perf_ui.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":perf_ui" ] } diff --git a/front_end/performance_monitor/BUILD.gn b/front_end/performance_monitor/BUILD.gn index badbe8b472..bdf8352458 100644 --- a/front_end/performance_monitor/BUILD.gn +++ b/front_end/performance_monitor/BUILD.gn @@ -19,7 +19,6 @@ devtools_module("performance_monitor") { devtools_entrypoint("bundle") { entrypoint = "performance_monitor.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":performance_monitor" ] } diff --git a/front_end/persistence/BUILD.gn b/front_end/persistence/BUILD.gn index e0c6e805fe..cc932f2c80 100644 --- a/front_end/persistence/BUILD.gn +++ b/front_end/persistence/BUILD.gn @@ -35,7 +35,6 @@ devtools_module("persistence") { devtools_entrypoint("bundle") { entrypoint = "persistence.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":persistence" ] } diff --git a/front_end/platform/BUILD.gn b/front_end/platform/BUILD.gn index 8e10e7c850..af73a115e7 100644 --- a/front_end/platform/BUILD.gn +++ b/front_end/platform/BUILD.gn @@ -22,7 +22,5 @@ devtools_module("platform") { devtools_entrypoint("bundle") { entrypoint = "platform.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":platform" ] } diff --git a/front_end/profiler/BUILD.gn b/front_end/profiler/BUILD.gn index 7b1ee8d715..f0119873b5 100644 --- a/front_end/profiler/BUILD.gn +++ b/front_end/profiler/BUILD.gn @@ -48,7 +48,6 @@ devtools_module("profiler") { devtools_entrypoint("bundle") { entrypoint = "profiler.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":profiler" ] } diff --git a/front_end/protocol_client/BUILD.gn b/front_end/protocol_client/BUILD.gn index 78382d7f26..a3b6831a0f 100644 --- a/front_end/protocol_client/BUILD.gn +++ b/front_end/protocol_client/BUILD.gn @@ -21,7 +21,5 @@ devtools_module("protocol_client") { devtools_entrypoint("bundle") { entrypoint = "protocol_client.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":protocol_client" ] } diff --git a/front_end/protocol_monitor/BUILD.gn b/front_end/protocol_monitor/BUILD.gn index ce577d40c5..9a4822a84c 100644 --- a/front_end/protocol_monitor/BUILD.gn +++ b/front_end/protocol_monitor/BUILD.gn @@ -21,7 +21,6 @@ devtools_module("protocol_monitor") { devtools_entrypoint("bundle") { entrypoint = "protocol_monitor.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":protocol_monitor" ] } diff --git a/front_end/quick_open/BUILD.gn b/front_end/quick_open/BUILD.gn index f05bd50061..3d5a3166df 100644 --- a/front_end/quick_open/BUILD.gn +++ b/front_end/quick_open/BUILD.gn @@ -27,7 +27,6 @@ devtools_module("quick_open") { devtools_entrypoint("bundle") { entrypoint = "quick_open.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":quick_open" ] } diff --git a/front_end/resources/BUILD.gn b/front_end/resources/BUILD.gn index 7f4177542c..02485c281a 100644 --- a/front_end/resources/BUILD.gn +++ b/front_end/resources/BUILD.gn @@ -54,7 +54,6 @@ devtools_module("resources") { devtools_entrypoint("bundle") { entrypoint = "resources.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":resources" ] } diff --git a/front_end/root/BUILD.gn b/front_end/root/BUILD.gn index 56295404bf..ef17dbc7f7 100644 --- a/front_end/root/BUILD.gn +++ b/front_end/root/BUILD.gn @@ -14,7 +14,5 @@ devtools_module("root") { devtools_entrypoint("bundle") { entrypoint = "root.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":root" ] } diff --git a/front_end/screencast/BUILD.gn b/front_end/screencast/BUILD.gn index a02adaed38..31fa7f20c4 100644 --- a/front_end/screencast/BUILD.gn +++ b/front_end/screencast/BUILD.gn @@ -22,7 +22,6 @@ devtools_module("screencast") { devtools_entrypoint("bundle") { entrypoint = "screencast.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":screencast" ] } diff --git a/front_end/sdk/BUILD.gn b/front_end/sdk/BUILD.gn index d7b89f0410..0da04c4124 100644 --- a/front_end/sdk/BUILD.gn +++ b/front_end/sdk/BUILD.gn @@ -85,7 +85,5 @@ devtools_module("sdk") { devtools_entrypoint("bundle") { entrypoint = "sdk.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":sdk" ] } diff --git a/front_end/search/BUILD.gn b/front_end/search/BUILD.gn index b8857c3240..0cb63b0478 100644 --- a/front_end/search/BUILD.gn +++ b/front_end/search/BUILD.gn @@ -24,7 +24,5 @@ devtools_module("search") { devtools_entrypoint("bundle") { entrypoint = "search.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":search" ] } diff --git a/front_end/security/BUILD.gn b/front_end/security/BUILD.gn index 416a1a28eb..812a5515f5 100644 --- a/front_end/security/BUILD.gn +++ b/front_end/security/BUILD.gn @@ -22,7 +22,6 @@ devtools_module("security") { devtools_entrypoint("bundle") { entrypoint = "security.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":security" ] } diff --git a/front_end/services/BUILD.gn b/front_end/services/BUILD.gn index 8503957d48..796cdd6ebe 100644 --- a/front_end/services/BUILD.gn +++ b/front_end/services/BUILD.gn @@ -13,7 +13,6 @@ devtools_module("services") { devtools_entrypoint("bundle") { entrypoint = "services.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":services" ] } diff --git a/front_end/settings/BUILD.gn b/front_end/settings/BUILD.gn index eb1359bbfe..2dd8978b75 100644 --- a/front_end/settings/BUILD.gn +++ b/front_end/settings/BUILD.gn @@ -22,7 +22,6 @@ devtools_module("settings") { devtools_entrypoint("bundle") { entrypoint = "settings.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":settings" ] } diff --git a/front_end/snippets/BUILD.gn b/front_end/snippets/BUILD.gn index 8ea6c5e172..9b0c08c421 100644 --- a/front_end/snippets/BUILD.gn +++ b/front_end/snippets/BUILD.gn @@ -23,7 +23,6 @@ devtools_module("snippets") { devtools_entrypoint("bundle") { entrypoint = "snippets.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":snippets" ] } diff --git a/front_end/source_frame/BUILD.gn b/front_end/source_frame/BUILD.gn index b0a6a445e5..a9eb6a2ba5 100644 --- a/front_end/source_frame/BUILD.gn +++ b/front_end/source_frame/BUILD.gn @@ -36,7 +36,6 @@ devtools_module("source_frame") { devtools_entrypoint("bundle") { entrypoint = "source_frame.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":source_frame" ] } diff --git a/front_end/sources/BUILD.gn b/front_end/sources/BUILD.gn index e74f23664c..36501247dc 100644 --- a/front_end/sources/BUILD.gn +++ b/front_end/sources/BUILD.gn @@ -72,7 +72,6 @@ devtools_module("sources") { devtools_entrypoint("bundle") { entrypoint = "sources.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":sources" ] } diff --git a/front_end/text_editor/BUILD.gn b/front_end/text_editor/BUILD.gn index caf882f59f..b5fc6a4677 100644 --- a/front_end/text_editor/BUILD.gn +++ b/front_end/text_editor/BUILD.gn @@ -24,7 +24,6 @@ devtools_module("text_editor") { devtools_entrypoint("bundle") { entrypoint = "text_editor.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":text_editor", diff --git a/front_end/text_utils/BUILD.gn b/front_end/text_utils/BUILD.gn index d57539c780..e4fbc6ad60 100644 --- a/front_end/text_utils/BUILD.gn +++ b/front_end/text_utils/BUILD.gn @@ -27,7 +27,5 @@ devtools_module("text_utils") { devtools_entrypoint("bundle") { entrypoint = "text_utils.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":text_utils" ] } diff --git a/front_end/theme_support/BUILD.gn b/front_end/theme_support/BUILD.gn index 8da4488c0b..42569357b8 100644 --- a/front_end/theme_support/BUILD.gn +++ b/front_end/theme_support/BUILD.gn @@ -18,7 +18,5 @@ devtools_module("theme_support") { devtools_entrypoint("bundle") { entrypoint = "theme_support.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] - deps = [ ":theme_support" ] } diff --git a/front_end/timeline/BUILD.gn b/front_end/timeline/BUILD.gn index a118c6dd75..b10accb9b1 100644 --- a/front_end/timeline/BUILD.gn +++ b/front_end/timeline/BUILD.gn @@ -45,7 +45,6 @@ devtools_module("timeline") { devtools_entrypoint("bundle") { entrypoint = "timeline.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":timeline" ] } diff --git a/front_end/timeline_model/BUILD.gn b/front_end/timeline_model/BUILD.gn index 164af0c4c8..aa7fac9375 100644 --- a/front_end/timeline_model/BUILD.gn +++ b/front_end/timeline_model/BUILD.gn @@ -24,6 +24,6 @@ devtools_module("timeline_model") { devtools_entrypoint("bundle") { entrypoint = "timeline_model.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] + deps = [ ":timeline_model" ] } diff --git a/front_end/toolbox_bootstrap/BUILD.gn b/front_end/toolbox_bootstrap/BUILD.gn index 68e6ee2af3..3de3f59438 100644 --- a/front_end/toolbox_bootstrap/BUILD.gn +++ b/front_end/toolbox_bootstrap/BUILD.gn @@ -6,7 +6,6 @@ import("../../scripts/build/ninja/devtools_entrypoint.gni") devtools_entrypoint("bundle") { entrypoint = "toolbox_bootstrap.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [] } diff --git a/front_end/ui/BUILD.gn b/front_end/ui/BUILD.gn index 8be0e78ec0..79d53fc5c5 100644 --- a/front_end/ui/BUILD.gn +++ b/front_end/ui/BUILD.gn @@ -80,7 +80,6 @@ devtools_module("ui") { devtools_entrypoint("bundle") { entrypoint = "ui.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":ui" ] } diff --git a/front_end/ui/utils/BUILD.gn b/front_end/ui/utils/BUILD.gn index b589a56d3c..978d2f88f4 100644 --- a/front_end/ui/utils/BUILD.gn +++ b/front_end/ui/utils/BUILD.gn @@ -18,7 +18,6 @@ devtools_module("ui_utils") { devtools_entrypoint("bundle") { entrypoint = "utils.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":ui_utils" ] } diff --git a/front_end/web_audio/BUILD.gn b/front_end/web_audio/BUILD.gn index 500fe2193a..6c05b36d01 100644 --- a/front_end/web_audio/BUILD.gn +++ b/front_end/web_audio/BUILD.gn @@ -23,7 +23,6 @@ devtools_module("web_audio") { devtools_entrypoint("bundle") { entrypoint = "web_audio.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":web_audio" ] } diff --git a/front_end/web_audio/graph_visualizer/BUILD.gn b/front_end/web_audio/graph_visualizer/BUILD.gn index 758c8e85ba..79eb93b363 100644 --- a/front_end/web_audio/graph_visualizer/BUILD.gn +++ b/front_end/web_audio/graph_visualizer/BUILD.gn @@ -23,7 +23,6 @@ devtools_module("web_audio_graph_visualizer") { devtools_entrypoint("bundle") { entrypoint = "graph_visualizer.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":web_audio_graph_visualizer" ] } diff --git a/front_end/worker_main/BUILD.gn b/front_end/worker_main/BUILD.gn index 85ec311ebb..bccd9d5704 100644 --- a/front_end/worker_main/BUILD.gn +++ b/front_end/worker_main/BUILD.gn @@ -18,7 +18,6 @@ devtools_module("worker_main") { devtools_entrypoint("bundle") { entrypoint = "worker_main.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":worker_main" ] } diff --git a/front_end/worker_service/BUILD.gn b/front_end/worker_service/BUILD.gn index a277ca6629..37ef7fb89a 100644 --- a/front_end/worker_service/BUILD.gn +++ b/front_end/worker_service/BUILD.gn @@ -13,7 +13,6 @@ devtools_module("worker_service") { devtools_entrypoint("bundle") { entrypoint = "worker_service.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":worker_service" ] } diff --git a/front_end/workspace/BUILD.gn b/front_end/workspace/BUILD.gn index 810d85047a..7ef59284df 100644 --- a/front_end/workspace/BUILD.gn +++ b/front_end/workspace/BUILD.gn @@ -22,7 +22,6 @@ devtools_module("workspace") { devtools_entrypoint("bundle") { entrypoint = "workspace.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":workspace" ] } diff --git a/front_end/workspace_diff/BUILD.gn b/front_end/workspace_diff/BUILD.gn index de8a562df1..e720c622ce 100644 --- a/front_end/workspace_diff/BUILD.gn +++ b/front_end/workspace_diff/BUILD.gn @@ -19,7 +19,6 @@ devtools_module("workspace_diff") { devtools_entrypoint("bundle") { entrypoint = "workspace_diff.js" - is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] deps = [ ":workspace_diff" ] } diff --git a/scripts/build/ninja/README.md b/scripts/build/ninja/README.md index 6746d884e0..ff34999fd3 100644 --- a/scripts/build/ninja/README.md +++ b/scripts/build/ninja/README.md @@ -88,8 +88,6 @@ devtools_module("my_module") { devtools_entrypoint("bundle") { entrypoint = "my_module.js" - is_legacy_javascript_entrypoint = [ "crbug.com/" ] - deps = [ ":my_module", ] @@ -98,40 +96,6 @@ devtools_entrypoint("bundle") { Here, both the entrypoint and the sources of the module are all JavaScript files. All of these files are typechecked by Closure Compiler and TypeScript. -Since this is inherited from the legacy implementations, the entrypoint is marked with `is_legacy_javascript_entrypoint`. -Every `is_legacy_javascript_entrypoint` must include a new CRBug for that specific module. -As soon as Closure Compiler is no longer typechecking this module, the entrypoint and source files can be converted to TypeScript-authored files and the `is_legacy_javascript_entrypoint` attribute can be removed. - -#### Closure Compiler only - -For any module that has not been typescriptified (e.g. the TypeScript compiler does not typecheck the module), we can not use `devtools_module`. -Instead, we assume that the files are considered "pre-built", as the files are checked by the out-of-process Closure Compiler typecheck pass. - -As such, the following layout is used for Closure Compiler only modules: - -```python -import("../../scripts/build/ninja/devtools_entrypoint.gni") -import("../../scripts/build/ninja/devtools_pre_built.gni") - -devtools_pre_built("my_module") { - sources = [ - "implementation_detail.js", - "some_other_file.js", - ] - - deps = [ - "../other_dependency:bundle", - ] -} - -devtools_entrypoint("bundle") { - entrypoint = "my_module.js" - - deps = [ - ":my_module", - ] -} -``` ## GRD file generation diff --git a/scripts/build/ninja/devtools_entrypoint.gni b/scripts/build/ninja/devtools_entrypoint.gni index 7395772669..192295bbcb 100644 --- a/scripts/build/ninja/devtools_entrypoint.gni +++ b/scripts/build/ninja/devtools_entrypoint.gni @@ -25,63 +25,32 @@ template("devtools_entrypoint") { _entrypoint_gen_file_location = "$target_gen_dir/$_entrypoint_output_file_name.js" - _is_typescript_file = get_path_info(invoker.entrypoint, "extension") == - "ts" || defined(invoker.is_legacy_javascript_entrypoint) - - if (defined(invoker.is_legacy_javascript_entrypoint)) { - not_needed(invoker.is_legacy_javascript_entrypoint) - } + _ts_library_target_name = _entrypoint_target_name + "-typescript" # In debug mode, the entrypoint is kept as-is. This means we only # need to compile with TypeScript, which means it will fetch all # of its files as separate network requests. if (is_debug) { - if (_is_typescript_file) { - _ts_library_target_name = _entrypoint_target_name + "-typescript" + _ts_library_target_name = _entrypoint_target_name + "-typescript" - ts_library(_ts_library_target_name) { - sources = [ invoker.entrypoint ] + ts_library(_ts_library_target_name) { + sources = [ invoker.entrypoint ] - deps = invoker.deps - } + deps = invoker.deps + } - # In debug mode we also want to copy the sourcemap of the entrypoint into - # resources/inspector so that when you DevTools-on-DevTools it can find - # the sourcemaps. devtools_module takes care of copying all of the TS - # files but we also need the entrypoint's .js.map file copied from gen - # into resources/inspector - _typescript_target_dep = ":$_ts_library_target_name" - _copy_gen_name = _ts_library_target_name + "copy-source-maps" - copy_gen_to_resources(_copy_gen_name) { - sources = filter_include(get_target_outputs(_typescript_target_dep), - [ "*.map" ]) + # In debug mode we also want to copy the sourcemap of the entrypoint into + # resources/inspector so that when you DevTools-on-DevTools it can find + # the sourcemaps. devtools_module takes care of copying all of the TS + # files but we also need the entrypoint's .js.map file copied from gen + # into resources/inspector + _typescript_target_dep = ":$_ts_library_target_name" + _copy_gen_name = _ts_library_target_name + "copy-source-maps" + copy_gen_to_resources(_copy_gen_name) { + sources = filter_include(get_target_outputs(_typescript_target_dep), + [ "*.map" ]) - public_deps = [ _typescript_target_dep ] - } - } else { - action(_entrypoint_target_name) { - script = "//third_party/node/node.py" - - inputs = [ - devtools_location_prepend + "scripts/build/ninja/copy-file.js", - invoker.entrypoint, - ] - - _copy_src = rebase_path(".", root_build_dir) + "/" + invoker.entrypoint - _copy_dest = rebase_path(_entrypoint_gen_file_location, root_build_dir) - - args = [ - rebase_path( - devtools_location_prepend + "scripts/build/ninja/copy-file.js", - root_build_dir), - _copy_src, - _copy_dest, - ] - - outputs = [ _entrypoint_gen_file_location ] - - public_deps = invoker.deps - } + public_deps = [ _typescript_target_dep ] } } else { # In release mode, we are running Rollup and thus bundle all @@ -119,73 +88,43 @@ template("devtools_entrypoint") { # _output_file_name = "$target_gen_dir/$_entrypoint_output_file_name.prebundle" - _copy_target_name = _entrypoint_target_name + "-copy" + _copy_output_file_name = "$_output_file_name.ts" _prebundle_output_file_name = "$_output_file_name.js" + + _copy_target_name = _entrypoint_target_name + "-copy" _rollup_target_name = _entrypoint_target_name + "-rollup" + _prebundle_target_name = _entrypoint_target_name + "-tsconfig" - if (_is_typescript_file) { - _copy_output_file_name = "$_output_file_name.ts" + action(_copy_target_name) { + script = "//third_party/node/node.py" - _prebundle_target_name = _entrypoint_target_name + "-tsconfig" + inputs = [ + devtools_location_prepend + "scripts/build/ninja/copy-file.js", + invoker.entrypoint, + ] - action(_copy_target_name) { - script = "//third_party/node/node.py" + outputs = [ _copy_output_file_name ] - inputs = [ - devtools_location_prepend + "scripts/build/ninja/copy-file.js", - invoker.entrypoint, - ] + _copy_src = rebase_path(".", root_build_dir) + "/" + invoker.entrypoint + _copy_dest = rebase_path(_copy_output_file_name, root_build_dir) - outputs = [ _copy_output_file_name ] + args = [ + rebase_path( + devtools_location_prepend + "scripts/build/ninja/copy-file.js", + root_build_dir), + _copy_src, + _copy_dest, + ] - _copy_src = rebase_path(".", root_build_dir) + "/" + invoker.entrypoint - _copy_dest = rebase_path(_copy_output_file_name, root_build_dir) + public_deps = invoker.deps + } - args = [ - rebase_path( - devtools_location_prepend + "scripts/build/ninja/copy-file.js", - root_build_dir), - _copy_src, - _copy_dest, - ] + ts_library(_prebundle_target_name) { + sources = [ _copy_output_file_name ] - public_deps = invoker.deps - } + rootdir = target_gen_dir - ts_library(_prebundle_target_name) { - sources = [ _copy_output_file_name ] - - rootdir = target_gen_dir - - public_deps = [ ":$_copy_target_name" ] - } - } else { - _prebundle_target_name = _copy_target_name - _entrypoint_target_name = _rollup_target_name - - action(_copy_target_name) { - script = "//third_party/node/node.py" - - inputs = [ - devtools_location_prepend + "scripts/build/ninja/copy-file.js", - invoker.entrypoint, - ] - - _copy_src = rebase_path(".", root_build_dir) + "/" + invoker.entrypoint - _copy_dest = rebase_path(_prebundle_output_file_name, root_build_dir) - - args = [ - rebase_path( - devtools_location_prepend + "scripts/build/ninja/copy-file.js", - root_build_dir), - _copy_src, - _copy_dest, - ] - - outputs = [ _prebundle_output_file_name ] - - public_deps = invoker.deps - } + public_deps = [ ":$_copy_target_name" ] } rollup(_rollup_target_name) { @@ -205,76 +144,70 @@ template("devtools_entrypoint") { public_deps = [ ":$_prebundle_target_name" ] + invoker.deps } - if (_is_typescript_file) { - # TypeScript requires a `module.d.ts` that describes - # the public API of the `module.js` entrypoint. To do so, we copy - # the generated `prebundle.d.ts` over, as the public API for a - # rolled up bundle remains the same. - _ts_library_target_name = _entrypoint_target_name + "-typescript" - - action(_ts_library_target_name) { - script = "//third_party/node/node.py" - - inputs = [ devtools_location_prepend + - "scripts/build/ninja/generate-declaration.js" ] - - args = [ - rebase_path(devtools_location_prepend + - "scripts/build/ninja/generate-declaration.js", - root_build_dir), - rebase_path(target_gen_dir, root_build_dir), - invoker.entrypoint, - ] - - public_deps = [ - ":$_prebundle_target_name", - ":$_rollup_target_name", - ] - - outputs = [ "$target_gen_dir/$_entrypoint_output_file_name.d.ts" ] - } - } - } - - if (_is_typescript_file) { - # Because we change the filename before rolling up the bundle, - # tsc can get upset when it uses the original `target_name` to - # reference a different `ts_library`. The `ts_library` action - # above generates a `tsconfig.json` which does not include the - # `target_name`, but instead uses `_ts_library_target_name`. - # - # For example, if the `target_name` is "module", the `ts_library` - # action above generates a - # `devtools_entrypoint-module-typescript-tsconfig.json`. However, - # if a different `ts_library` depends on this `devtools_entrypoint`, - # it depends on it as "../module:module". Therefore, the expected - # location of the `tsconfig.json` is instead `module-tsconfig.json`. - # - # Therefore, we need to generate a separate tsconfig.json which - # artificially mimics what `ts_library` would have generated. - _generated_tsconfig_location = - target_gen_dir + "/" + invoker.target_name + "-tsconfig.json" - - action(_entrypoint_target_name) { + # TypeScript requires a `module.d.ts` that describes + # the public API of the `module.js` entrypoint. To do so, we copy + # the generated `prebundle.d.ts` over, as the public API for a + # rolled up bundle remains the same. + action(_ts_library_target_name) { script = "//third_party/node/node.py" inputs = [ devtools_location_prepend + - "scripts/build/ninja/generate-tsconfig.js" ] + "scripts/build/ninja/generate-declaration.js" ] args = [ - rebase_path(devtools_location_prepend + - "scripts/build/ninja/generate-tsconfig.js", - root_build_dir), - rebase_path(_generated_tsconfig_location, root_build_dir), - rebase_path(invoker.entrypoint, root_build_dir), - ] + invoker.deps + rebase_path(devtools_location_prepend + + "scripts/build/ninja/generate-declaration.js", + root_build_dir), + rebase_path(target_gen_dir, root_build_dir), + invoker.entrypoint, + ] - public_deps = [ ":$_ts_library_target_name" ] + public_deps = [ + ":$_prebundle_target_name", + ":$_rollup_target_name", + ] - outputs = [ _generated_tsconfig_location ] + outputs = [ "$target_gen_dir/$_entrypoint_output_file_name.d.ts" ] } } + # Because we change the filename before rolling up the bundle, + # tsc can get upset when it uses the original `target_name` to + # reference a different `ts_library`. The `ts_library` action + # above generates a `tsconfig.json` which does not include the + # `target_name`, but instead uses `_ts_library_target_name`. + # + # For example, if the `target_name` is "module", the `ts_library` + # action above generates a + # `devtools_entrypoint-module-typescript-tsconfig.json`. However, + # if a different `ts_library` depends on this `devtools_entrypoint`, + # it depends on it as "../module:module". Therefore, the expected + # location of the `tsconfig.json` is instead `module-tsconfig.json`. + # + # Therefore, we need to generate a separate tsconfig.json which + # artificially mimics what `ts_library` would have generated. + _generated_tsconfig_location = + target_gen_dir + "/" + invoker.target_name + "-tsconfig.json" + + action(_entrypoint_target_name) { + script = "//third_party/node/node.py" + + inputs = [ devtools_location_prepend + + "scripts/build/ninja/generate-tsconfig.js" ] + + args = [ + rebase_path(devtools_location_prepend + + "scripts/build/ninja/generate-tsconfig.js", + root_build_dir), + rebase_path(_generated_tsconfig_location, root_build_dir), + rebase_path(invoker.entrypoint, root_build_dir), + ] + invoker.deps + + public_deps = [ ":$_ts_library_target_name" ] + + outputs = [ _generated_tsconfig_location ] + } + copy_gen_to_resources(target_name) { sources = [ _entrypoint_gen_file_location ]