From 2edbdcdba2d39a53f9daeacdb993631a005ca087 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Alfonso=20Casta=C3=B1o?= Date: Wed, 25 Nov 2020 09:56:20 +0000 Subject: [PATCH] Fix Icon not showing on Source Tab RowInfo MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Although the icon was implemented it was not showing due to the use of "label" instead of span. Screenshot: https://i.imgur.com/oyRkIkq.png Bug:1151316 Change-Id: I37fc04575e60ba465f692a344cc571019e3ef7da Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2554571 Commit-Queue: Alfonso Castaño Reviewed-by: Sigurd Schneider --- front_end/sources/UISourceCodeFrame.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/front_end/sources/UISourceCodeFrame.js b/front_end/sources/UISourceCodeFrame.js index ddbda231ea..1b3f29e67e 100644 --- a/front_end/sources/UISourceCodeFrame.js +++ b/front_end/sources/UISourceCodeFrame.js @@ -691,7 +691,7 @@ export class RowMessage { this.element = document.createElement('div'); this.element.classList.add('text-editor-row-message'); /** @type {!UI.UIUtils.DevToolsIconLabel} */ - this._icon = /** @type {?} */ (this.element.createChild('label', '', 'dt-icon-label')); + this._icon = /** @type {?} */ (this.element.createChild('span', '', 'dt-icon-label')); this._icon.type = /** @type {string} */ (iconClassPerLevel.get(message.level())); /** @type {!UI.UIUtils.DevToolsSmallBubble} */ this._repeatCountElement =