[RPP] Use main thread and treeView bottomUpRootNode for 3P insight

Browse Source

This also simplifies the insight shape closer to how we use it in RPP,
and how we will use it in LH. This also simplifies some tests.

This modifies how we generate eventIDs when grouping by 3P. This fixes a
bug where when grouping by 3P, generateEventID can incorrectly group
events of different entities.

This fixes:
- misalignment in main thread times insight<->3P table
(by using same data source, including instant events, filters)
- incorrect event grouping: breaking bottomUp button and causing further
incorrect selftime/transfersize (bottomUp tree node ID generation)

Bug: 394651390
Change-Id: I1660a5b5b9a90be89815aad858caea94f153eabb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6341914
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>

...

This commit is contained in:

Adriana Ixba

2025-03-19 13:07:38 -07:00

committed by Devtools-frontend LUCI CQ

parent a01747c4fc

commit 3067d40135

17 changed files with 455 additions and 456 deletions

Show all changes Ignore whitespace when comparing lines Ignore changes in amount of whitespace Ignore changes in whitespace at EOL

Download Patch File Download Diff File Expand all files Collapse all files

test/interactions/goldens/linux/performance/insights-lcp-request-discovery.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 117 KiB After Width:  |  Height:  |  Size: 117 KiB

test/interactions/goldens/linux/performance/main-thread-long-task-candy-stripe.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 82 KiB After Width:  |  Height:  |  Size: 82 KiB

test/interactions/goldens/linux/performance/timeline-long-task-candystripe.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 82 KiB After Width:  |  Height:  |  Size: 82 KiB

test/interactions/goldens/linux/performance/timeline-web-dev-screenshot-frames.png

BIN

Binary file not shown.

Side by Side Swipe Overlay Before Width:  |  Height:  |  Size: 119 KiB After Width:  |  Height:  |  Size: 119 KiB