From 3103138c4fb2ed0d322bfd53ca994572c925c6bf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20Z=C3=BCnd?= Date: Fri, 11 Sep 2020 08:03:29 +0200 Subject: [PATCH] [ts] Type-check sources/Plugin.js with TypeScript MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit R=tvanderlippe@chromium.org Bug: chromium:1011811 Change-Id: I4e9a40c31f66b09c0feabd6c326d1c5c46ce8139 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2404647 Reviewed-by: Tim van der Lippe Commit-Queue: Simon Zünd --- front_end/sources/Plugin.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/front_end/sources/Plugin.js b/front_end/sources/Plugin.js index dbed0f4251..72325fd4f6 100644 --- a/front_end/sources/Plugin.js +++ b/front_end/sources/Plugin.js @@ -2,9 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// @ts-nocheck -// TODO(crbug.com/1011811): Enable TypeScript compiler checks - import * as UI from '../ui/ui.js'; // eslint-disable-line no-unused-vars import * as Workspace from '../workspace/workspace.js'; // eslint-disable-line no-unused-vars @@ -43,7 +40,7 @@ export class Plugin { /** * @param {!UI.ContextMenu.ContextMenu} contextMenu * @param {number} lineNumber - * @return {!Promise} + * @return {!Promise} */ populateLineGutterContextMenu(contextMenu, lineNumber) { return Promise.resolve(); @@ -53,7 +50,7 @@ export class Plugin { * @param {!UI.ContextMenu.ContextMenu} contextMenu * @param {number} lineNumber * @param {number} columnNumber - * @return {!Promise} + * @return {!Promise} */ populateTextAreaContextMenu(contextMenu, lineNumber, columnNumber) { return Promise.resolve();