diff --git a/front_end/models/trace/insights/DuplicatedJavaScript.ts b/front_end/models/trace/insights/DuplicatedJavaScript.ts index 01fadc87e6..216b1a0d4f 100644 --- a/front_end/models/trace/insights/DuplicatedJavaScript.ts +++ b/front_end/models/trace/insights/DuplicatedJavaScript.ts @@ -35,7 +35,7 @@ export const UIStrings = { const str_ = i18n.i18n.registerUIStrings('models/trace/insights/DuplicatedJavaScript.ts', UIStrings); export const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_); -export type DuplicateJavaScriptInsightModel = InsightModel; -function finalize(partialModel: PartialInsightModel): DuplicateJavaScriptInsightModel { +function finalize(partialModel: PartialInsightModel): + DuplicatedJavaScriptInsightModel { const requests = partialModel.scriptsWithDuplication.map(script => script.request).filter(e => !!e); return { @@ -59,7 +60,7 @@ function finalize(partialModel: PartialInsightModel { if (!context.navigation) { return false; diff --git a/front_end/panels/timeline/components/SidebarSingleInsightSet.test.ts b/front_end/panels/timeline/components/SidebarSingleInsightSet.test.ts index d5b4b5b8a3..4cfd23b904 100644 --- a/front_end/panels/timeline/components/SidebarSingleInsightSet.test.ts +++ b/front_end/panels/timeline/components/SidebarSingleInsightSet.test.ts @@ -67,6 +67,7 @@ describeWithEnvironment('SidebarSingleInsightSet', () => { 'Font display', 'Optimize viewport for mobile', 'Optimize DOM size', + 'Duplicated JavaScript', 'CSS Selector costs', 'Forced reflow', 'Use efficient cache lifetimes', @@ -84,6 +85,7 @@ describeWithEnvironment('SidebarSingleInsightSet', () => { 'Font display', 'Optimize viewport for mobile', 'Optimize DOM size', + 'Duplicated JavaScript', 'CSS Selector costs', 'Forced reflow', 'Use efficient cache lifetimes', @@ -124,6 +126,7 @@ describeWithEnvironment('SidebarSingleInsightSet', () => { 'Document request latency', 'Optimize viewport for mobile', 'Optimize DOM size', + 'Duplicated JavaScript', 'CSS Selector costs', 'Forced reflow', 'Modern HTTP', @@ -140,6 +143,7 @@ describeWithEnvironment('SidebarSingleInsightSet', () => { 'Document request latency', 'Optimize viewport for mobile', 'Optimize DOM size', + 'Duplicated JavaScript', 'CSS Selector costs', 'Forced reflow', 'Modern HTTP', diff --git a/front_end/panels/timeline/components/SidebarSingleInsightSet.ts b/front_end/panels/timeline/components/SidebarSingleInsightSet.ts index acc3c31255..d94407f877 100644 --- a/front_end/panels/timeline/components/SidebarSingleInsightSet.ts +++ b/front_end/panels/timeline/components/SidebarSingleInsightSet.ts @@ -90,7 +90,6 @@ export interface SidebarSingleInsightSetData { * us to ship incrementally without turning insights on by default for all * users. */ const EXPERIMENTAL_INSIGHTS: ReadonlySet = new Set([ - 'DuplicatedJavaScript', ]); type InsightNameToComponentMapping = diff --git a/front_end/panels/timeline/components/insights/DuplicatedJavaScript.ts b/front_end/panels/timeline/components/insights/DuplicatedJavaScript.ts index aa553f0d55..06ca3a0878 100644 --- a/front_end/panels/timeline/components/insights/DuplicatedJavaScript.ts +++ b/front_end/panels/timeline/components/insights/DuplicatedJavaScript.ts @@ -5,7 +5,7 @@ import './Table.js'; import * as i18n from '../../../../core/i18n/i18n.js'; -import type {DuplicateJavaScriptInsightModel} from '../../../../models/trace/insights/DuplicatedJavaScript.js'; +import type {DuplicatedJavaScriptInsightModel} from '../../../../models/trace/insights/DuplicatedJavaScript.js'; import * as Trace from '../../../../models/trace/trace.js'; import * as Buttons from '../../../../ui/components/buttons/buttons.js'; import * as Lit from '../../../../ui/lit/lit.js'; @@ -21,7 +21,7 @@ const {UIStrings, i18nString} = Trace.Insights.Models.DuplicatedJavaScript; const {html} = Lit; -export class DuplicatedJavaScript extends BaseInsightComponent { +export class DuplicatedJavaScript extends BaseInsightComponent { static override readonly litTagName = Lit.StaticHtml.literal`devtools-performance-duplicated-javascript`; override internalName = 'duplicated-javascript'; #treemapData: Utils.Treemap.TreemapData|null = null; diff --git a/front_end/panels/timeline/utils/Treemap.ts b/front_end/panels/timeline/utils/Treemap.ts index 2a58daac4c..43e53958fa 100644 --- a/front_end/panels/timeline/utils/Treemap.ts +++ b/front_end/panels/timeline/utils/Treemap.ts @@ -71,6 +71,7 @@ export function openTreemap(treemapData: TreemapData, mainDocumentUrl: string, w locale: i18n.DevToolsLocale.DevToolsLocale.instance().locale, }, }, + initialView: 'duplicate-modules', }; const url = 'https://googlechrome.github.io/lighthouse/treemap/'; const windowName = `treemap-${windowNameSuffix}`;