zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-29 16:57:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Consistently use assert.deepEqual instead of assert.deepStrictEqual.

Browse Source 
Previously we have been a bit sloppy with sometimes using one or the
other. In Chai both methods perform exactly the same comparison, but
the name `deepStrictEqual` can be a bit confusing to developers not
familiar with the Chai implementation, and particularly might leave
you wondering what exactly is *strict* about this method.

Fixed: 386330115
Change-Id: Idda55ee784b01cce650996ab3d56f76e220e6b2c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6110227
Commit-Queue: Samiya Caur <samiyac@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Samiya Caur <samiyac@chromium.org>
This commit is contained in:
Benedikt Meurer
2024-12-27 04:38:55 -08:00
committed by Devtools-frontend LUCI CQ
parent 586a9a5908
commit 3dffd37833
139 changed files with 898 additions and 794 deletions
Download Patch File Download Diff File Expand all files Collapse all files
test/interactions/panels/recorder/injected/injected_test.ts
+2 -2
View File
@@ -170,7 +170,7 @@ describe('Injected', () => {
.length,
];
});
assert.deepStrictEqual(results, [1, 1, 1, 0, 0, 2]);
assert.deepEqual(results, [1, 1, 1, 0, 0, 2]);
});
it('should return not-optimized CSS selectors for duplicate elements', async () => {
@@ -223,7 +223,7 @@ describe('Injected', () => {
});
it('should not return a text selector for elements > maximum length', async () => {
const selectors = await getSelectorOfButtonWithLength(MAXIMUM_LENGTH + 1);
assert.deepStrictEqual(selectors, undefined);
assert.deepEqual(selectors, undefined);
});
it('should return a text selector correctly with same prefix elements', async () => {
let selectors = await getSelectorOfButtonWithLength(