From 3f65fba83befe3bb198988b2f97f6767f0bb9a7f Mon Sep 17 00:00:00 2001 From: Tim van der Lippe Date: Mon, 24 May 2021 17:22:11 +0100 Subject: [PATCH] Move more dependencies out of front_end/BUILD.gn MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit These dependencies can be moved to their respective usages, rather than being listed in the top-level folder. R=szuend@chromium.org Bug: none Change-Id: Iab8c4682ef66feaa5840cca9929d1d5500d8422a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2912721 Commit-Queue: Tim van der Lippe Reviewed-by: Simon Zünd --- front_end/BUILD.gn | 3 --- front_end/models/issues_manager/BUILD.gn | 2 ++ front_end/panels/emulation/BUILD.gn | 3 +++ 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/front_end/BUILD.gn b/front_end/BUILD.gn index db2392f861..a7c874f29d 100644 --- a/front_end/BUILD.gn +++ b/front_end/BUILD.gn @@ -16,8 +16,6 @@ group("front_end") { ":legacy_css", ":legacy_entrypoints", "Images", - "Images:generate_css_vars", - "emulated_devices/optimized:optimized_emulated_devices", "entrypoints/devtools_app", "entrypoints/formatter_worker:worker_entrypoint", "entrypoints/heap_snapshot_worker:worker_entrypoint", @@ -31,7 +29,6 @@ group("front_end") { "entrypoints/wasmparser_worker:worker_entrypoint", "entrypoints/worker_app", "legacy_test_runner", - "models/issues_manager:descriptions", ] } diff --git a/front_end/models/issues_manager/BUILD.gn b/front_end/models/issues_manager/BUILD.gn index 2bffa3e45c..cdbf5e5ef7 100644 --- a/front_end/models/issues_manager/BUILD.gn +++ b/front_end/models/issues_manager/BUILD.gn @@ -39,6 +39,8 @@ devtools_module("issues_manager") { "../../models/workspace:bundle", "../../third_party/marked:bundle", ] + + public_deps = [ ":descriptions" ] } devtools_issue_description_files = [ diff --git a/front_end/panels/emulation/BUILD.gn b/front_end/panels/emulation/BUILD.gn index 366b1e7ab4..4bd585a561 100644 --- a/front_end/panels/emulation/BUILD.gn +++ b/front_end/panels/emulation/BUILD.gn @@ -37,6 +37,9 @@ devtools_module("emulation") { "../../ui/legacy:bundle", "../../ui/legacy/components/utils:bundle", ] + + public_deps = + [ "../../emulated_devices/optimized:optimized_emulated_devices" ] } copy_to_gen("legacy_css") {