From 60679104f62f52f044fa030e0eee8575cbd605fc Mon Sep 17 00:00:00 2001 From: Tim van der Lippe Date: Tue, 2 Nov 2021 12:20:51 +0000 Subject: [PATCH] Reland "Update to Node 16" MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This reverts commit 86a7f83986f4d1ff72fea564af812949797f4ca2. Reason for revert: fixed sync on Mac Original change's description: > Revert "Update to Node 16" > > This reverts commit 69fd14af2a88ff0b11e329d531d59af52f872a8e. > > Reason for revert: Breaks gclient sync on mac: https://logs.chromium.org/logs/devtools-frontend/buildbucket/cr-buildbucket/8831691191675479761/+/u/gclient_runhooks/stdout > > Original change's description: > > Update to Node 16 > > > > Chromium updated to Node 16, so we can do so too. > > > > DISABLE_THIRD_PARTY_CHECK=Updating Node > > R=​szuend@chromium.org > > > > Bug: 1248945 > > Change-Id: Ibd983d3e94a849aa19ffd8b4cf36951c61748c93 > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3253581 > > Reviewed-by: Simon Zünd > > Commit-Queue: Simon Zünd > > Auto-Submit: Tim van der Lippe > > Bug: 1248945 > Change-Id: Ie30e45513212cd8e6a88532ee14431741c181057 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3257541 > Auto-Submit: Simon Zünd > Commit-Queue: Rubber Stamper > Bot-Commit: Rubber Stamper DISABLE_THIRD_PARTY_CHECK=Updating Node Bug: 1248945 Change-Id: I15473467092ddf463a941c2b5531ff53874981a5 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3257662 Commit-Queue: Tim van der Lippe Auto-Submit: Tim van der Lippe Reviewed-by: Simon Zünd --- DEPS | 6 +++--- third_party/node/linux/node-linux-x64.tar.gz.sha1 | 2 +- third_party/node/mac/node-darwin-x64.tar.gz.sha1 | 2 +- third_party/node/win/node.exe.sha1 | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/DEPS b/DEPS index 360e11ea88..e32e3b0ffa 100644 --- a/DEPS +++ b/DEPS @@ -112,7 +112,7 @@ hooks = [ '--no_resume', '--extract', '--no_auth', - '--bucket', 'chromium-nodejs/14.15.4', + '--bucket', 'chromium-nodejs/16.13.0', '-s', 'third_party/node/linux/node-linux-x64.tar.gz.sha1', ], }, @@ -125,7 +125,7 @@ hooks = [ '--no_resume', '--extract', '--no_auth', - '--bucket', 'chromium-nodejs/14.15.4', + '--bucket', 'chromium-nodejs/16.13.0', '-s', 'third_party/node/mac/node-darwin-x64.tar.gz.sha1', ], }, @@ -137,7 +137,7 @@ hooks = [ 'third_party/depot_tools/download_from_google_storage.py', '--no_resume', '--no_auth', - '--bucket', 'chromium-nodejs/14.15.4', + '--bucket', 'chromium-nodejs/16.13.0', '-s', 'third_party/node/win/node.exe.sha1', ], }, diff --git a/third_party/node/linux/node-linux-x64.tar.gz.sha1 b/third_party/node/linux/node-linux-x64.tar.gz.sha1 index e99bd505fd..ab2e90ccf7 100644 --- a/third_party/node/linux/node-linux-x64.tar.gz.sha1 +++ b/third_party/node/linux/node-linux-x64.tar.gz.sha1 @@ -1 +1 @@ -b2e40ddbac04d05baafbb007f203c6663c9d4ca9 +ab9544e24e752d3d17f335fb7b2055062e582d11 diff --git a/third_party/node/mac/node-darwin-x64.tar.gz.sha1 b/third_party/node/mac/node-darwin-x64.tar.gz.sha1 index aa467ef259..1dc1f6f098 100644 --- a/third_party/node/mac/node-darwin-x64.tar.gz.sha1 +++ b/third_party/node/mac/node-darwin-x64.tar.gz.sha1 @@ -1 +1 @@ -17ba7216e09de1bffb9dc80b7ec617a1cee40330 +16dfd094763b71988933a31735f9dea966f9abd6 diff --git a/third_party/node/win/node.exe.sha1 b/third_party/node/win/node.exe.sha1 index 90d390395b..5e0e1f54f4 100644 --- a/third_party/node/win/node.exe.sha1 +++ b/third_party/node/win/node.exe.sha1 @@ -1 +1 @@ -58bca4fea5196d856e41f928c02f6d6af2421865 +5ef847033c517c499f56f9d136d159b663bab717