From 61a8b2d0a0157bd5cac0a16db9c4c3462e157570 Mon Sep 17 00:00:00 2001 From: Benedikt Meurer Date: Thu, 31 Oct 2024 10:17:07 +0100 Subject: [PATCH] [cleanup] Consistently use 'Open in Foo panel'. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Instead of the longer 'Reveal in Foo panel', just use 'Open in Foo panel', which also aligns well with the wording that is otherwise used (e.g. 'Open in new tab'). Bug: 372873222 Change-Id: Icbd93f5c6bbe8ea011179cbcedb8c306536ed781 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5979752 Auto-Submit: Benedikt Meurer Reviewed-by: Peter Müller Commit-Queue: Benedikt Meurer --- .../e2e/standalone/MemoryInspector_test.ts | 2 +- .../application/OpenedWindowDetailsView.ts | 5 ++--- .../application/components/FrameDetailsView.ts | 16 ++++++++-------- .../preloading/components/RuleSetGrid.ts | 12 ++++++------ front_end/panels/elements/ElementsPanel.ts | 4 ++-- .../panels/elements/StylePropertyTreeElement.ts | 4 ++-- .../panels/event_listeners/EventListenersView.ts | 4 ++-- .../LinearMemoryInspectorController.ts | 4 ++-- .../object_ui/ObjectPropertiesSection.ts | 4 ++-- test/e2e/console/console-log_test.ts | 2 +- test/e2e/helpers/application-helpers.ts | 2 +- test/e2e/helpers/sources-helpers.ts | 4 +++- test/e2e/resources/sources/wasm/memory.html | 2 +- 13 files changed, 33 insertions(+), 32 deletions(-) diff --git a/extensions/cxx_debugging/e2e/standalone/MemoryInspector_test.ts b/extensions/cxx_debugging/e2e/standalone/MemoryInspector_test.ts index 60d01c624f..0b931d1f1d 100644 --- a/extensions/cxx_debugging/e2e/standalone/MemoryInspector_test.ts +++ b/extensions/cxx_debugging/e2e/standalone/MemoryInspector_test.ts @@ -45,7 +45,7 @@ describe('LinearMemoryInspector', () => { assert.equal(stoppedText, 'Paused on breakpoint'); const localVariable = await waitFor('[data-object-property-name-for-test="d"]'); - const memIcon = await waitFor('[title="Reveal in Memory inspector panel"]', localVariable); + const memIcon = await waitFor('[title="Open in Memory inspector panel"]', localVariable); await clickElement(memIcon); const byteHighlights = await waitForMany('.byte-cell.highlight-area', 8); diff --git a/front_end/panels/application/OpenedWindowDetailsView.ts b/front_end/panels/application/OpenedWindowDetailsView.ts index 32f2e05667..ee0c0398f4 100644 --- a/front_end/panels/application/OpenedWindowDetailsView.ts +++ b/front_end/panels/application/OpenedWindowDetailsView.ts @@ -23,7 +23,7 @@ const UIStrings = { /** *@description Title for a link to the Elements panel */ - clickToRevealInElementsPanel: 'Click to reveal in Elements panel', + clickToOpenInElementsPanel: 'Click to open in Elements panel', /** *@description Name of a network resource type */ @@ -120,8 +120,7 @@ async function maybeCreateLinkToElementsPanel(opener: Protocol.Page.FrameId|SDK. return null; } const linkElement = linkifyIcon( - 'code-circle', i18nString(UIStrings.clickToRevealInElementsPanel), - () => Common.Revealer.reveal(linkTargetDOMNode)); + 'code-circle', i18nString(UIStrings.clickToOpenInElementsPanel), () => Common.Revealer.reveal(linkTargetDOMNode)); const label = document.createElement('span'); label.textContent = `<${linkTargetDOMNode.nodeName().toLocaleLowerCase()}>`; linkElement.insertBefore(label, linkElement.firstChild); diff --git a/front_end/panels/application/components/FrameDetailsView.ts b/front_end/panels/application/components/FrameDetailsView.ts index a84a3c22dc..c3a4e61f9b 100644 --- a/front_end/panels/application/components/FrameDetailsView.ts +++ b/front_end/panels/application/components/FrameDetailsView.ts @@ -61,11 +61,11 @@ const UIStrings = { /** *@description Title for a link to the Sources panel */ - clickToRevealInSourcesPanel: 'Click to reveal in Sources panel', + clickToOpenInSourcesPanel: 'Click to open in Sources panel', /** *@description Title for a link to the Network panel */ - clickToRevealInNetworkPanel: 'Click to reveal in Network panel', + clickToOpenInNetworkPanel: 'Click to open in Network panel', /** *@description Title for unreachable URL field */ @@ -73,7 +73,7 @@ const UIStrings = { /** *@description Title for a link that applies a filter to the network panel */ - clickToRevealInNetworkPanelMight: 'Click to reveal in Network panel (might require page reload)', + clickToOpenInNetworkPanelMight: 'Click to open in Network panel (might require page reload)', /** *@description The origin of a URL (https://web.dev/same-site-same-origin/#origin) *(for a lot of languages this does not need to be translated, please translate only where necessary) @@ -87,7 +87,7 @@ const UIStrings = { /** *@description Title for a link to the Elements panel */ - clickToRevealInElementsPanel: 'Click to reveal in Elements panel', + clickToOpenInElementsPanel: 'Click to open in Elements panel', /** *@description Title for ad frame type field */ @@ -391,7 +391,7 @@ export class FrameDetailsReportView extends LegacyWrapper.LegacyWrapper.Wrappabl const sourceCode = this.#uiSourceCodeForFrame(this.#frame); return renderIconLink( 'breakpoint-circle', - i18nString(UIStrings.clickToRevealInSourcesPanel), + i18nString(UIStrings.clickToOpenInSourcesPanel), () => Common.Revealer.reveal(sourceCode), 'reveal-in-sources', ); @@ -402,7 +402,7 @@ export class FrameDetailsReportView extends LegacyWrapper.LegacyWrapper.Wrappabl const resource = this.#frame.resourceForURL(this.#frame.url); if (resource && resource.request) { const request = resource.request; - return renderIconLink('arrow-up-down-circle', i18nString(UIStrings.clickToRevealInNetworkPanel), () => { + return renderIconLink('arrow-up-down-circle', i18nString(UIStrings.clickToOpenInNetworkPanel), () => { const requestLocation = NetworkForward.UIRequestLocation.UIRequestLocation.tab( request, NetworkForward.UIRequestLocation.UIRequestTabs.HEADERS_COMPONENT); return Common.Revealer.reveal(requestLocation); @@ -446,7 +446,7 @@ export class FrameDetailsReportView extends LegacyWrapper.LegacyWrapper.Wrappabl if (unreachableUrl) { return renderIconLink( 'arrow-up-down-circle', - i18nString(UIStrings.clickToRevealInNetworkPanelMight), + i18nString(UIStrings.clickToOpenInNetworkPanelMight), (): void => { void Common.Revealer.reveal(NetworkForward.UIFilter.UIRequestFilter.filters([ @@ -489,7 +489,7 @@ export class FrameDetailsReportView extends LegacyWrapper.LegacyWrapper.Wrappabl ${i18nString(UIStrings.ownerElement)}
-
  • Breakpoint should hit the new breakpoint
  • Now look at the Scope in the DevTools and right click on the imports.memory
    • -
  • Select "Reveal in Memory inspector panel"
    • +
  • Select "Open in Memory inspector panel"
  • The Linear memory inspector should open
  • Inspect memory and navigate