From 633bba159ed9d4c8a8bbb5cdb7feeada512eeae7 Mon Sep 17 00:00:00 2001 From: Alex Rudenko Date: Wed, 9 Nov 2022 12:58:55 +0100 Subject: [PATCH] Use closeTo in overlay tests Depending on the platform/monitor/mode the css width/height might be off by 0.5px. Bug: none Change-Id: I2e9038ba22a0dd63cd674bfd68571194e47f1759 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4016406 Reviewed-by: Philip Pfaffe Commit-Queue: Alex Rudenko --- .../front_end/helpers/InspectorOverlayHelpers.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/unittests/front_end/helpers/InspectorOverlayHelpers.ts b/test/unittests/front_end/helpers/InspectorOverlayHelpers.ts index d14d25a92d..b23a293a5f 100644 --- a/test/unittests/front_end/helpers/InspectorOverlayHelpers.ts +++ b/test/unittests/front_end/helpers/InspectorOverlayHelpers.ts @@ -196,13 +196,13 @@ export function drawGridLineNamesAndAssertLabels( } if (expected.type === 'column' && typeof expected.x !== 'undefined') { - assert.strictEqual( - foundLabel.x, expected.x, + assert.closeTo( + foundLabel.x, expected.x, 0.5, `Expected column line name label ${expected.textContent} to be positioned at ${expected.x}px`); } if (expected.type === 'row' && typeof expected.y !== 'undefined') { - assert.strictEqual( - foundLabel.y, expected.y, + assert.closeTo( + foundLabel.y, expected.y, 0.5, `Expected row line name label ${expected.textContent} to be positioned at ${expected.y}px`); } }