From 6621f46716ad7594dc457b6d0232677cb343efbb Mon Sep 17 00:00:00 2001 From: Takuto Ikuta Date: Wed, 2 Feb 2022 21:41:44 +0900 Subject: [PATCH] devtools_plugin: mark non-relative import as external This is to prevent error like https://ci.chromium.org/ui/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel_fastbuild/95/overview Bug: 1278663 Cq-Include-Trybots: luci.devtools-frontend.try:devtools_frontend_linux_blink_light_rel_fastbuild,devtools_frontend_linux_dbg_fastbuild Change-Id: I51ee2b52b88b9b52edf47edfd94c4a771540fd89 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3430082 Commit-Queue: Takuto Ikuta Auto-Submit: Takuto Ikuta Reviewed-by: Tim Van der Lippe Commit-Queue: Tim Van der Lippe --- scripts/build/devtools_plugin.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/build/devtools_plugin.js b/scripts/build/devtools_plugin.js index ac4ba2fc23..4fbf74eb73 100644 --- a/scripts/build/devtools_plugin.js +++ b/scripts/build/devtools_plugin.js @@ -43,7 +43,7 @@ function devtoolsPlugin(source, importer) { return null; } - if (source === '../../lib/codemirror' || source === 'fs') { + if (source === '../../lib/codemirror' || !source.startsWith('.')) { // These are imported via require(...), but we don't use // @rollup/plugin-commonjs. So this check is not necessary for rollup. But // need to have this for esbuild as it doesn't ignore require(...).