From 709b09e63cb39b33d533285f7f232d349ca18ff9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20Z=C3=BCnd?= Date: Wed, 3 Nov 2021 13:30:20 +0100 Subject: [PATCH] [test_runner] Use dynamic import directly instead of using eval MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: 1011811 Change-Id: Ia1391e881ba36d6c8a2cb391946d3058e87e816b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259092 Reviewed-by: Tim van der Lippe Commit-Queue: Simon Zünd --- front_end/legacy_test_runner/test_runner/test_runner.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/front_end/legacy_test_runner/test_runner/test_runner.js b/front_end/legacy_test_runner/test_runner/test_runner.js index 79e9e3a7c7..38914873e1 100644 --- a/front_end/legacy_test_runner/test_runner/test_runner.js +++ b/front_end/legacy_test_runner/test_runner/test_runner.js @@ -59,15 +59,13 @@ export async function _executeTestScript() { // Auto-start unit tests self.test = async function() { - // TODO(crbug.com/1011811): Remove eval when we use TypeScript which does support dynamic imports - await eval(`import("${testScriptURL}")`); + await import(testScriptURL); }; return; } try { - // TODO(crbug.com/1011811): Remove eval when we use TypeScript which does support dynamic imports - await eval(`import("${testScriptURL}")`); + await import(testScriptURL); } catch (err) { TestRunner.addResult('TEST ENDED EARLY DUE TO UNCAUGHT ERROR:'); TestRunner.addResult(err && err.stack || err);