From 74cb8b70d83f368dbe0a6c766cc8fe949da228ff Mon Sep 17 00:00:00 2001 From: Paul Lewis Date: Tue, 11 Feb 2020 11:05:23 +0000 Subject: [PATCH] Fixes UIString closure annotation No-Tree-Checks: true TBR=jacktfranklin@chromium.org Change-Id: I141038fc8cffaaf7ab4252c928a790443a8b0a5a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050228 Commit-Queue: Paul Lewis Reviewed-by: Paul Lewis --- front_end/common/UIString.js | 2 +- test/shared/runner.ts | 7 +++++- test/unittests/front_end/common/Color.ts | 32 ++++++++++++------------ 3 files changed, 23 insertions(+), 18 deletions(-) diff --git a/front_end/common/UIString.js b/front_end/common/UIString.js index 90caed1868..df3db0a33e 100644 --- a/front_end/common/UIString.js +++ b/front_end/common/UIString.js @@ -50,7 +50,7 @@ export function serializeUIString(string, values = []) { } /** - * @param {string} serializedMessage + * @param {string=} serializedMessage * @return {*} */ export function deserializeUIString(serializedMessage) { diff --git a/test/shared/runner.ts b/test/shared/runner.ts index 7da3fccdfc..fdbe97e281 100644 --- a/test/shared/runner.ts +++ b/test/shared/runner.ts @@ -109,7 +109,12 @@ interface DevToolsTarget { const listing = await devtools.$('pre'); const json = await devtools.evaluate(listing => listing.textContent, listing); const targets: DevToolsTarget[] = JSON.parse(json); - const {id} = targets.find((target) => target.url === blankPage)!; + const target = targets.find((target) => target.url === blankPage); + if (!target) { + throw new Error(`Unable to find target page: ${blankPage}`); + } + + const {id} = target; await devtools.close(); // Connect to the DevTools frontend. diff --git a/test/unittests/front_end/common/Color.ts b/test/unittests/front_end/common/Color.ts index 48249c47c0..4d168e94b2 100644 --- a/test/unittests/front_end/common/Color.ts +++ b/test/unittests/front_end/common/Color.ts @@ -99,31 +99,31 @@ describe('Color', () => { }); it('parses rgb(a) values', () => { - const colorOne = Common.Color.Color.parse('rgb(255, 255, 0)'); - assert.deepEqual(colorOne!.rgba(), [1, 1, 0, 1]); + const colorOne = Common.Color.Color.parse('rgb(255, 255, 0)')!; + assert.deepEqual(colorOne.rgba(), [1, 1, 0, 1]); - const colorTwo = Common.Color.Color.parse('rgba(0, 255, 255, 0.5)'); - assert.deepEqual(colorTwo!.rgba(), [0, 1, 1, 0.5]); + const colorTwo = Common.Color.Color.parse('rgba(0, 255, 255, 0.5)')!; + assert.deepEqual(colorTwo.rgba(), [0, 1, 1, 0.5]); - const colorThree = Common.Color.Color.parse('rgb(255 255 255)'); - assert.deepEqual(colorThree!.rgba(), [1, 1, 1, 1]); + const colorThree = Common.Color.Color.parse('rgb(255 255 255)')!; + assert.deepEqual(colorThree.rgba(), [1, 1, 1, 1]); - const colorFour = Common.Color.Color.parse('rgb(10% 10% 10%)'); - assert.deepEqual(colorFour!.rgba(), [0.1, 0.1, 0.1, 1]); + const colorFour = Common.Color.Color.parse('rgb(10% 10% 10%)')!; + assert.deepEqual(colorFour.rgba(), [0.1, 0.1, 0.1, 1]); - const colorFive = Common.Color.Color.parse('rgb(10% 10% 10% / 0.4)'); - assert.deepEqual(colorFive!.rgba(), [0.1, 0.1, 0.1, 0.4]); + const colorFive = Common.Color.Color.parse('rgb(10% 10% 10% / 0.4)')!; + assert.deepEqual(colorFive.rgba(), [0.1, 0.1, 0.1, 0.4]); }); it('parses hsl(a) values', () => { - const colorOne = Common.Color.Color.parse('hsl(0, 100%, 50%)'); - assert.deepEqual(colorOne!.rgba(), [1, 0, 0, 1]); + const colorOne = Common.Color.Color.parse('hsl(0, 100%, 50%)')!; + assert.deepEqual(colorOne.rgba(), [1, 0, 0, 1]); - const colorTwo = Common.Color.Color.parse('hsla(0, 100%, 50%, 0.5)'); - assert.deepEqual(colorTwo!.rgba(), [1, 0, 0, 0.5]); + const colorTwo = Common.Color.Color.parse('hsla(0, 100%, 50%, 0.5)')!; + assert.deepEqual(colorTwo.rgba(), [1, 0, 0, 0.5]); - const colorThree = Common.Color.Color.parse('hsla(50deg 100% 100% / 50%)'); - assert.deepEqual(colorThree!.rgba(), [1, 1, 1, 0.5]); + const colorThree = Common.Color.Color.parse('hsla(50deg 100% 100% / 50%)')!; + assert.deepEqual(colorThree.rgba(), [1, 1, 1, 0.5]); }); it('handles invalid values', () => {