From 76111edfecfcd4b5000cd11e07dcb1fa73b15402 Mon Sep 17 00:00:00 2001 From: Jesus David Garcia Gomez Date: Tue, 16 Feb 2021 16:57:18 -0800 Subject: [PATCH] Remove option Don't show Chrome Data Saver warning from settings. This CL removes the option "Don't show Chrome Data Saver warning" from settings because Chrome Data Saver has been deprecated. Before: https://i.imgur.com/Ggf8hlz.jpg After: https://i.imgur.com/pSekZs5.jpg Bug: 1056922 Change-Id: I0ed955e085d96c6bc677b47720994b43040c26cb Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2698373 Reviewed-by: Alex Rudenko Reviewed-by: Robert Paveza Reviewed-by: Benedikt Meurer Commit-Queue: Jesus David Garcia Gomez --- front_end/devtools_compatibility.js | 1 - front_end/inspector_main/inspector_main-meta.ts | 8 -------- front_end/inspector_main/inspector_main_strings.grdp | 3 --- 3 files changed, 12 deletions(-) diff --git a/front_end/devtools_compatibility.js b/front_end/devtools_compatibility.js index 3b1750e6ec..85ab34d532 100644 --- a/front_end/devtools_compatibility.js +++ b/front_end/devtools_compatibility.js @@ -970,7 +970,6 @@ 'dataGrid-cookiesTable', 'dataGrid-DOMStorageItemsView', 'debuggerSidebarHidden', - 'disableDataSaverInfobar', 'disablePausedStateOverlay', 'domBreakpoints', 'domWordWrap', diff --git a/front_end/inspector_main/inspector_main-meta.ts b/front_end/inspector_main/inspector_main-meta.ts index 334395dfc0..467370b419 100644 --- a/front_end/inspector_main/inspector_main-meta.ts +++ b/front_end/inspector_main/inspector_main-meta.ts @@ -139,14 +139,6 @@ Common.Settings.registerSettingExtension({ ], }); -Common.Settings.registerSettingExtension({ - category: Common.Settings.SettingCategory.APPEARANCE, - title: (): Platform.UIString.LocalizedString => ls`Don't show Chrome Data Saver warning`, - settingName: 'disableDataSaverInfobar', - settingType: Common.Settings.SettingType.BOOLEAN, - defaultValue: false, -}); - Common.Settings.registerSettingExtension({ category: Common.Settings.SettingCategory.APPEARANCE, title: (): Platform.UIString.LocalizedString => ls`Disable paused state overlay`, diff --git a/front_end/inspector_main/inspector_main_strings.grdp b/front_end/inspector_main/inspector_main_strings.grdp index 464e52149c..b9a917b599 100644 --- a/front_end/inspector_main/inspector_main_strings.grdp +++ b/front_end/inspector_main/inspector_main_strings.grdp @@ -75,9 +75,6 @@ Hit-test borders - - Don't show Chrome Data Saver warning - Force ad blocking on this site