From 7bf74cb9fa684e6ad11cebcd9e4a5ccd278dcf02 Mon Sep 17 00:00:00 2001 From: Alex Rudenko Date: Fri, 16 Oct 2020 08:56:23 +0000 Subject: [PATCH] Enable TypeScript for TimelineModelFilter.js MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Bug: 1011811 Change-Id: Icca8989b707c076ccd9f08cd5b855a19232d6e43 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2479122 Auto-Submit: Alex Rudenko Reviewed-by: Simon Zünd Commit-Queue: Simon Zünd --- front_end/timeline_model/TimelineModelFilter.js | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/front_end/timeline_model/TimelineModelFilter.js b/front_end/timeline_model/TimelineModelFilter.js index fd2d0c6183..10d0c74323 100644 --- a/front_end/timeline_model/TimelineModelFilter.js +++ b/front_end/timeline_model/TimelineModelFilter.js @@ -2,9 +2,6 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -// @ts-nocheck -// TODO(crbug.com/1011811): Enable TypeScript compiler checks - import * as SDK from '../sdk/sdk.js'; // eslint-disable-line no-unused-vars import {RecordType, TimelineModelImpl} from './TimelineModel.js'; @@ -38,6 +35,7 @@ export class TimelineVisibleEventsFilter extends TimelineModelFilter { } /** + * @param {!SDK.TracingModel.Event} event * @return {!RecordType} */ static _eventType(event) { @@ -50,7 +48,7 @@ export class TimelineVisibleEventsFilter extends TimelineModelFilter { if (event.hasCategory(TimelineModelImpl.Category.LatencyInfo)) { return RecordType.LatencyInfo; } - return /** @type !RecordType */ (event.name); + return /** @type {!RecordType} */ (event.name); } }