zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-30 17:27:22 +08:00
Code Issues Packages Projects Releases Wiki Activity

[globals] self.runtime

Browse Source 
Migrate all usages of self.runtime to Root.Runtime.Runtime.instance().

This also requires various type updates, as now Closure/TypeScript
can better understand the code and discover issues.

R=jacktfranklin@chromium.org

Bug: 1011811
Change-Id: Ice07aa0ca959e61a6acdf4618b9a272d8c1096b8
Fixed: 1081614
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2434339
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
This commit is contained in:
Tim van der Lippe
2020-09-29 10:52:39 +00:00
committed by Commit Bot
parent 5c1904772b
commit 7f2002c598
44 changed files with 177 additions and 143 deletions
Download Patch File Download Diff File Expand all files Collapse all files
front_end/object_ui/JavaScriptAutocomplete.js
+3 -1
View File
@@ -8,6 +8,7 @@
import * as Common from '../common/common.js';
import * as Formatter from '../formatter/formatter.js';
import * as Platform from '../platform/platform.js';
import * as Root from '../root/root.js';
import * as SDK from '../sdk/sdk.js';
import * as TextUtils from '../text_utils/text_utils.js';
import * as UI from '../ui/ui.js';
@@ -132,7 +133,8 @@ export class JavaScriptAutocomplete {
return clippedArgs;
}
}
const javaScriptMetadata = await self.runtime.extension(Common.JavaScriptMetaData.JavaScriptMetaData).instance();
const javaScriptMetadata =
await Root.Runtime.Runtime.instance().extension(Common.JavaScriptMetaData.JavaScriptMetaData).instance();
const name = /^function ([^(]*)\(/.exec(description)[1] || parsedFunctionName;
if (!name) {