From 8c02e882a3f210f20582505e756756d400a99c5b Mon Sep 17 00:00:00 2001 From: Jan Scheffler Date: Wed, 29 Jul 2020 16:43:51 +0200 Subject: [PATCH] Migrate `front_end/help` to `devtools_entrypoint` R=aerotwist@chromium.org, jacktfranklin@chromium.org Bug: 1101738 Change-Id: I13cc2e6c8b71550d421b3f0e73559d9958db629a Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2323624 Commit-Queue: Jan Scheffler Reviewed-by: Jack Franklin Reviewed-by: Paul Lewis Auto-Submit: Jan Scheffler --- all_devtools_modules.gni | 6 +++--- devtools_module_entrypoints.gni | 2 +- front_end/BUILD.gn | 1 + front_end/help/BUILD.gn | 27 +++++++++++++++++++++++++++ front_end/help/HelpImpl.js | 3 +++ front_end/help/ReleaseNoteText.js | 3 +++ front_end/help/ReleaseNoteView.js | 3 +++ front_end/help/module.json | 5 +++-- 8 files changed, 44 insertions(+), 6 deletions(-) create mode 100644 front_end/help/BUILD.gn diff --git a/all_devtools_modules.gni b/all_devtools_modules.gni index 8705911f24..f4093112ef 100644 --- a/all_devtools_modules.gni +++ b/all_devtools_modules.gni @@ -53,9 +53,6 @@ all_devtools_module_sources = [ "heap_snapshot_worker/HeapSnapshotLoader.js", "heap_snapshot_worker/HeapSnapshotWorker.js", "heap_snapshot_worker/HeapSnapshotWorkerDispatcher.js", - "help/HelpImpl.js", - "help/ReleaseNoteText.js", - "help/ReleaseNoteView.js", "input/InputModel.js", "input/InputTimeline.js", "inspector_main/InspectorMain.js", @@ -406,6 +403,9 @@ all_typescript_module_sources = [ "har_importer/HARFormat.js", "har_importer/HARImporter.js", "heap_snapshot_model/HeapSnapshotModel.js", + "help/HelpImpl.js", + "help/ReleaseNoteText.js", + "help/ReleaseNoteView.js", "host/InspectorFrontendHost.js", "host/InspectorFrontendHostAPI.js", "host/Platform.js", diff --git a/devtools_module_entrypoints.gni b/devtools_module_entrypoints.gni index 6a3dff0d87..4b7726c75e 100644 --- a/devtools_module_entrypoints.gni +++ b/devtools_module_entrypoints.gni @@ -43,7 +43,6 @@ devtools_module_entrypoint_sources = [ "heap_snapshot_worker/heap_snapshot_worker-legacy.js", "heap_snapshot_worker/heap_snapshot_worker.js", "help/help-legacy.js", - "help/help.js", "host/host-legacy.js", "inline_editor/inline_editor-legacy.js", "input/input-legacy.js", @@ -145,6 +144,7 @@ generated_typescript_entrypoint_sources = [ "$resources_out_dir/formatter_worker/formatter_worker.js", "$resources_out_dir/har_importer/har_importer.js", "$resources_out_dir/heap_snapshot_model/heap_snapshot_model.js", + "$resources_out_dir/help/help.js", "$resources_out_dir/host/host.js", "$resources_out_dir/inline_editor/inline_editor.js", "$resources_out_dir/issues/issues.js", diff --git a/front_end/BUILD.gn b/front_end/BUILD.gn index ce27e77a1d..f4986f0eac 100644 --- a/front_end/BUILD.gn +++ b/front_end/BUILD.gn @@ -29,6 +29,7 @@ group("front_end") { "formatter_worker:bundle", "har_importer:bundle", "heap_snapshot_model:bundle", + "help:bundle", "i18n:bundle_i18n", "inline_editor:bundle", "issues:bundle", diff --git a/front_end/help/BUILD.gn b/front_end/help/BUILD.gn new file mode 100644 index 0000000000..a417f6f178 --- /dev/null +++ b/front_end/help/BUILD.gn @@ -0,0 +1,27 @@ +# Copyright 2020 The Chromium Authors. All rights reserved. +# Use of this source code is governed by a BSD-style license that can be +# found in the LICENSE file. + +import("../../scripts/build/ninja/devtools_entrypoint.gni") +import("../../scripts/build/ninja/devtools_module.gni") + +devtools_module("help") { + sources = [ + "HelpImpl.js", + "ReleaseNoteText.js", + "ReleaseNoteView.js", + ] + + deps = [ + "../common:bundle", + "../host:bundle", + "../ui:bundle", + ] +} + +devtools_entrypoint("bundle") { + entrypoint = "help.js" + is_legacy_javascript_entrypoint = [ "crbug.com/1011811" ] + + deps = [ ":help" ] +} diff --git a/front_end/help/HelpImpl.js b/front_end/help/HelpImpl.js index b353596d0b..8a57d27540 100644 --- a/front_end/help/HelpImpl.js +++ b/front_end/help/HelpImpl.js @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @ts-nocheck +// TODO(crbug.com/1011811): Enable TypeScript compiler checks + import * as Common from '../common/common.js'; // eslint-disable-line no-unused-vars import * as Host from '../host/host.js'; import * as UI from '../ui/ui.js'; // eslint-disable-line no-unused-vars diff --git a/front_end/help/ReleaseNoteText.js b/front_end/help/ReleaseNoteText.js index c21e7d8fca..4011043125 100644 --- a/front_end/help/ReleaseNoteText.js +++ b/front_end/help/ReleaseNoteText.js @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @ts-nocheck +// TODO(crbug.com/1011811): Enable TypeScript compiler checks + // NOTE: need to be careful about adding release notes early otherwise it'll // be shown in Canary (e.g. make sure the release notes are accurate). // https://github.com/ChromeDevTools/devtools-frontend/wiki/Release-Notes diff --git a/front_end/help/ReleaseNoteView.js b/front_end/help/ReleaseNoteView.js index cccb5f25e2..8c33aed414 100644 --- a/front_end/help/ReleaseNoteView.js +++ b/front_end/help/ReleaseNoteView.js @@ -2,6 +2,9 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. +// @ts-nocheck +// TODO(crbug.com/1011811): Enable TypeScript compiler checks + import * as Host from '../host/host.js'; import * as UI from '../ui/ui.js'; diff --git a/front_end/help/module.json b/front_end/help/module.json index 08d9d04a29..20feb04c3e 100644 --- a/front_end/help/module.json +++ b/front_end/help/module.json @@ -72,5 +72,6 @@ ], "resources": [ "releaseNote.css" - ] -} + ], + "skip_rollup": true +} \ No newline at end of file