From 9ceac1600f9c791788989d74731babb206c80d18 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20Z=C3=BCnd?= Date: Mon, 21 Jun 2021 13:11:01 +0200 Subject: [PATCH] [cleanup] Linkfier.linkify can be an async static function MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit R=wolfi@chromium.org Bug: None Change-Id: I038606017afc6c9000e785fdfcddf79018bec6f6 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2974929 Reviewed-by: Wolfgang Beyer Commit-Queue: Simon Zünd --- front_end/core/common/Linkifier.ts | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/front_end/core/common/Linkifier.ts b/front_end/core/common/Linkifier.ts index d1986839d9..5dc885a7e5 100644 --- a/front_end/core/common/Linkifier.ts +++ b/front_end/core/common/Linkifier.ts @@ -2,21 +2,19 @@ // Use of this source code is governed by a BSD-style license that can be // found in the LICENSE file. -/* eslint-disable rulesdir/no_underscored_properties */ - export abstract class Linkifier { abstract linkify(object: Object, options?: Options): Node; - static linkify(object: Object|null, options?: Options): Promise { + static async linkify(object: Object|null, options?: Options): Promise { if (!object) { - return Promise.reject(new Error('Can\'t linkify ' + object)); + throw new Error('Can\'t linkify ' + object); } const linkifierRegistration = getApplicableRegisteredlinkifiers(object)[0]; if (!linkifierRegistration) { - return Promise.reject(new Error('No linkifiers registered for object ' + object)); + throw new Error('No linkifiers registered for object ' + object); } - return linkifierRegistration.loadLinkifier().then( - linkifier => /** @type {!Linkifier} */ (linkifier).linkify(/** @type {!Object} */ (object), options)); + const linkifier = await linkifierRegistration.loadLinkifier(); + return linkifier.linkify(object, options); } } export interface Options {