From 9ec3f6e9cc736efceb079dc34821795b36058bc7 Mon Sep 17 00:00:00 2001
From: Changhao Han <changhaohan@chromium.org>
Date: Tue, 12 Nov 2019 19:43:25 +0100
Subject: [PATCH] Updates Network Panel's Text in Network Log View.

Bug: chromium:961389
Change-Id: Ib2ce117e8c3c40e58938bddb4c826a0fa3a5add0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1908569
Commit-Queue: Changhao Han <changhaohan@chromium.org>
Reviewed-by: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
---
 front_end/network/NetworkLogView.js    | 10 ++++++----
 front_end/network/network_strings.grdp | 24 ++++++++++++------------
 2 files changed, 18 insertions(+), 16 deletions(-)

diff --git a/front_end/network/NetworkLogView.js b/front_end/network/NetworkLogView.js
index c0ee14688b..f1e53b89ea 100644
--- a/front_end/network/NetworkLogView.js
+++ b/front_end/network/NetworkLogView.js
@@ -809,17 +809,19 @@ Network.NetworkLogView = class extends UI.VBox {
       this._summaryToolbar.appendSeparator();
       appendChunk(
           ls`${Number.bytesToString(selectedTransferSize)} / ${Number.bytesToString(transferSize)} transferred`,
-          ls`${selectedTransferSize} B / ${transferSize} B transferred`);
+          ls`${selectedTransferSize} B / ${transferSize} B transferred over network`);
       this._summaryToolbar.appendSeparator();
       appendChunk(
           ls`${Number.bytesToString(selectedResourceSize)} / ${Number.bytesToString(resourceSize)} resources`,
-          ls`${selectedResourceSize} B / ${resourceSize} B resources`);
+          ls`${selectedResourceSize} B / ${resourceSize} B resources loaded by the page`);
     } else {
       appendChunk(ls`${nodeCount} requests`);
       this._summaryToolbar.appendSeparator();
-      appendChunk(ls`${Number.bytesToString(transferSize)} transferred`, ls`${transferSize} B transferred`);
+      appendChunk(
+          ls`${Number.bytesToString(transferSize)} transferred`, ls`${transferSize} B transferred over network`);
       this._summaryToolbar.appendSeparator();
-      appendChunk(ls`${Number.bytesToString(resourceSize)} resources`, ls`${resourceSize} B resources`);
+      appendChunk(
+          ls`${Number.bytesToString(resourceSize)} resources`, ls`${resourceSize} B resources loaded by the page`);
     }
 
     if (baseTime !== -1 && maxTime !== -1) {
diff --git a/front_end/network/network_strings.grdp b/front_end/network/network_strings.grdp
index 1d84d8397c..eaf295e767 100644
--- a/front_end/network/network_strings.grdp
+++ b/front_end/network/network_strings.grdp
@@ -15,9 +15,6 @@
   <message name="IDS_DEVTOOLS_0382c94481db9197dd5a72ea4bdd2ff0" desc="A tag of Network Conditions tool that can be searched in the command menu">
     disk cache
   </message>
-  <message name="IDS_DEVTOOLS_059f48d76d79fe0727740d75dc81fa94" desc="Text in Network Log View of the Network panel">
-    <ph name="SELECTEDTRANSFERSIZE">$1s<ex>25</ex></ph> B / <ph name="TRANSFERSIZE">$2s<ex>25</ex></ph> B transferred
-  </message>
   <message name="IDS_DEVTOOLS_05ffb3b626077843c5f71d13185391d8" desc="An option in the user agent dropdown menu in the Network conditions tool">
     <ph name="LOCKED_1">Safari — iPad iOS 9</ph>
   </message>
@@ -60,6 +57,9 @@
   <message name="IDS_DEVTOOLS_12881f9e98bb240671bc3e1787d64a03" desc="Title of a setting under the Network category that can be invoked through the Command Menu">
     Color code by resource type
   </message>
+  <message name="IDS_DEVTOOLS_13d453df11cf2f0534129d30b6253ac0" desc="Text in Network Log View of the Network panel">
+    <ph name="TRANSFERSIZE">$1s<ex>4</ex></ph> B transferred over network
+  </message>
   <message name="IDS_DEVTOOLS_16c32be3b42643aee708e7ccdd52c9f4" desc="An option in the user agent dropdown menu in the Network conditions tool">
     <ph name="LOCKED_1">Microsoft Edge — Android Mobile</ph>
   </message>
@@ -90,9 +90,6 @@
   <message name="IDS_DEVTOOLS_1c047e32d57295a9f0319976c543162e" desc="Text in Network Data Grid Node of the Network panel">
     (blocked:<ph name="REASON">$1s<ex>mixed-content</ex></ph>)
   </message>
-  <message name="IDS_DEVTOOLS_1cb07ce276f37ba2acdfb8605aaefbb8" desc="Text in Network Log View of the Network panel">
-    <ph name="RESOURCESIZE">$1s<ex>10</ex></ph> B resources
-  </message>
   <message name="IDS_DEVTOOLS_1cf0226d974af378b6aa6070bb2a37c3" desc="A tag of Network Conditions tool that can be searched in the command menu">
     network throttling
   </message>
@@ -144,6 +141,9 @@
   <message name="IDS_DEVTOOLS_31977081ea2c828cc70e6151ab5d7da8" desc="Text in Request Headers View of the Network panel">
     view decoded
   </message>
+  <message name="IDS_DEVTOOLS_324c6483c84f17f8af6b9a0d20145dda" desc="Text in Network Log View of the Network panel">
+    <ph name="RESOURCESIZE">$1s<ex>10</ex></ph> B resources loaded by the page
+  </message>
   <message name="IDS_DEVTOOLS_336439019ce67912717a20d54298bf24" desc="Text in Request Timing View of the Network panel">
     Receiving Push
   </message>
@@ -234,15 +234,15 @@
   <message name="IDS_DEVTOOLS_46ff2c7bbdbb02687287512c874d391f" desc="Text in Network Data Grid Node of the Network panel">
     signed-exchange
   </message>
+  <message name="IDS_DEVTOOLS_47d546fc3634f59db7e350acbb01885c" desc="Text in Network Log View of the Network panel">
+    <ph name="SELECTEDTRANSFERSIZE">$1s<ex>10</ex></ph> B / <ph name="TRANSFERSIZE">$2s<ex>15</ex></ph> B transferred over network
+  </message>
   <message name="IDS_DEVTOOLS_490aa6e856ccf208a054389e47ce0d06" desc="Text in Event Source Messages View of the Network panel">
     Id
   </message>
   <message name="IDS_DEVTOOLS_4a5a4b959ef84dd7b7ee73e837b6a54e" desc="A context menu item in the Network Panel of the Network panel">
     Reveal in Network panel
   </message>
-  <message name="IDS_DEVTOOLS_4a7ba0d17eafde708ca8f5f34debcfef" desc="Text in Network Log View of the Network panel">
-    <ph name="TRANSFERSIZE">$1s<ex>4</ex></ph> B transferred
-  </message>
   <message name="IDS_DEVTOOLS_4dea2ac78e9450e62e96c166ef9f5d4c" desc="Text in Network Log View Columns of the Network panel">
     Manage Header Columns…
   </message>
@@ -354,6 +354,9 @@
   <message name="IDS_DEVTOOLS_722e6ea747a62b7f93bb017d3dd04cbd" desc="Op codes continuation frame of map in Resource Web Socket Frame View of the Network panel">
     Continuation Frame
   </message>
+  <message name="IDS_DEVTOOLS_c21b43091d5f2cb131e79122289ce033" desc="Text in Network Log View of the Network panel">
+    <ph name="SELECTEDRESOURCESIZE">$1s<ex>40</ex></ph> B / <ph name="RESOURCESIZE">$2s<ex>50</ex></ph> B resources loaded by the page
+  </message>
   <message name="IDS_DEVTOOLS_ca092ce554360617d7bb503ff16dcb7c" desc="Text for toggling the view of header data (e.g. query string parameters) from parsed to source in the headers tab">
     View source
   </message>
@@ -708,9 +711,6 @@
   <message name="IDS_DEVTOOLS_c54dcc2fd5e72371ef21f1553d79e740" desc="Text in Network Data Grid Node of the Network panel">
     (canceled)
   </message>
-  <message name="IDS_DEVTOOLS_c6f969f563d21beac9731f177053484c" desc="Text in Network Log View of the Network panel">
-    <ph name="SELECTEDRESOURCESIZE">$1s<ex>40</ex></ph> B / <ph name="RESOURCESIZE">$2s<ex>50</ex></ph> B resources
-  </message>
   <message name="IDS_DEVTOOLS_c81e295bfd7fbaec6257ea14992f4643" desc="Text in Network Item View of the Network panel">
     Request and response cookies
   </message>