From a27ec02e9e1e5c4354be3581a2bb3b7d75daa4da Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20Z=C3=BCnd?= Date: Fri, 27 Mar 2020 11:41:37 +0100 Subject: [PATCH] Move 'issues' module from 'shell' to 'devtools_app' and 'worker_app' MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The issues module depends on the network module. As we do not want to add the network module to shell, we lift the issues module "upwards" into the two application configurations that 1) extend from shell and 2) have network available. R=sigurds@chromium.org, tvanderlippe@chromium.org Change-Id: Ic975edf871d1e9cd60a65aa0dc800564aa1b7931 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2123478 Reviewed-by: Tim van der Lippe Reviewed-by: Sigurd Schneider Commit-Queue: Simon Zünd --- front_end/devtools_app.json | 1 + front_end/issues/module.json | 2 +- front_end/shell.json | 1 - front_end/worker_app.json | 1 + 4 files changed, 3 insertions(+), 2 deletions(-) diff --git a/front_end/devtools_app.json b/front_end/devtools_app.json index f53fe326e0..21c71ee5aa 100644 --- a/front_end/devtools_app.json +++ b/front_end/devtools_app.json @@ -14,6 +14,7 @@ { "name": "devices" }, { "name": "elements" }, { "name": "emulated_devices" , "type": "remote" }, + { "name": "issues" }, { "name": "har_importer" }, { "name": "help" }, { "name": "layers" }, diff --git a/front_end/issues/module.json b/front_end/issues/module.json index 7414987b5b..e7decc74ad 100644 --- a/front_end/issues/module.json +++ b/front_end/issues/module.json @@ -19,7 +19,7 @@ "className": "Issues.IssueRevealer" } ], - "dependencies": ["platform", "ui", "host", "components", "sdk"], + "dependencies": ["platform", "ui", "host", "components", "sdk", "network"], "scripts": [], "modules": [ "issues.js", diff --git a/front_end/shell.json b/front_end/shell.json index 1f258867da..156ec3a3e4 100644 --- a/front_end/shell.json +++ b/front_end/shell.json @@ -45,7 +45,6 @@ { "name": "text_editor" }, { "name": "workspace_diff" }, { "name": "protocol_monitor"}, - { "name": "issues"}, { "name": "input"} ] } diff --git a/front_end/worker_app.json b/front_end/worker_app.json index 6ecf3f39b2..2ccc7bdc45 100644 --- a/front_end/worker_app.json +++ b/front_end/worker_app.json @@ -8,6 +8,7 @@ { "name": "elements" }, { "name": "har_importer" }, { "name": "help" }, + { "name": "issues" }, { "name": "layer_viewer" }, { "name": "network" }, { "name": "resources" },