From a91afc977de0a30b83b09ff61ba28ae181f787f3 Mon Sep 17 00:00:00 2001 From: Riho Isawa Date: Wed, 17 Nov 2021 10:36:55 +0000 Subject: [PATCH] [devtools] Normalize Back/forward cache display names MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit "Back/forward cache" is the official name of BFCache. https://groups.google.com/a/google.com/g/chrome-bfcache/c/WmRKH29afrw/m/JiXi0p0sBAAJ?utm_medium=email&utm_source=footer This CL spells lowercase b when not starting a sentence. This CL normalizes all notations. Deactivate tests in Chromium: I356efe231e9f7547573eb94e2244b9e5e19266cf Activate tests in Chromium: Ia69f55a42a9ce977ef89e5ec1f3398e874a88765 Bug: 1271044 Change-Id: Iadd4e198143572188a5a66b28834cf7237738482 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3281075 Commit-Queue: Riho Isawa Reviewed-by: Simon Zünd Reviewed-by: Yuzu Saijo Reviewed-by: Darren W Reviewed-by: Wolfgang Beyer --- front_end/core/i18n/locales/en-US.json | 14 +++--- front_end/core/i18n/locales/en-XL.json | 14 +++--- front_end/entrypoints/main/MainImpl.ts | 4 +- .../ApplicationPanelCacheSection.ts | 2 +- .../application/BackForwardCacheView.ts | 48 +++++++++---------- 5 files changed, 41 insertions(+), 41 deletions(-) diff --git a/front_end/core/i18n/locales/en-US.json b/front_end/core/i18n/locales/en-US.json index 47b09e96ee..995d2087f3 100644 --- a/front_end/core/i18n/locales/en-US.json +++ b/front_end/core/i18n/locales/en-US.json @@ -2055,7 +2055,7 @@ "message": "Stop recording events" }, "panels/application/ApplicationPanelCacheSection.ts | backForwardCache": { - "message": "Back-Forward Cache" + "message": "Back/forward cache" }, "panels/application/ApplicationPanelCacheSection.ts | cacheStorage": { "message": "Cache Storage" @@ -2691,10 +2691,10 @@ "message": "Pages that use WebXR are not currently eligible for back/forward cache." }, "panels/application/BackForwardCacheView.ts | backForwardCacheTitle": { - "message": "Back-Forward Cache" + "message": "Back/forward cache" }, "panels/application/BackForwardCacheView.ts | bfcacheStatus": { - "message": "Back-Forward Cache Status" + "message": "Back/forward cache Status" }, "panels/application/BackForwardCacheView.ts | circumstantial": { "message": "Not Actionable" @@ -2706,16 +2706,16 @@ "message": "Main Frame" }, "panels/application/BackForwardCacheView.ts | normalNavigation": { - "message": "Normal navigation (Not restored from Back-Forward Cache)" + "message": "Normal navigation (Not restored from back/forward cache)" }, "panels/application/BackForwardCacheView.ts | pageSupportNeeded": { "message": "Actionable" }, "panels/application/BackForwardCacheView.ts | pageSupportNeededExplanation": { - "message": "These reasons are actionable i.e. they can be cleaned up to make the page eligible for Back-Forward Cache." + "message": "These reasons are actionable i.e. they can be cleaned up to make the page eligible for back/forward cache." }, "panels/application/BackForwardCacheView.ts | restoredFromBFCache": { - "message": "Restored from Back-Forward Cache" + "message": "Restored from back/forward cache" }, "panels/application/BackForwardCacheView.ts | runTest": { "message": "Run Test" @@ -2724,7 +2724,7 @@ "message": "Pending Support" }, "panels/application/BackForwardCacheView.ts | supportPendingExplanation": { - "message": "Chrome support for these reasons is pending i.e. they will not prevent the page from being eligible for Back-Forward Cache in a future version of Chrome." + "message": "Chrome support for these reasons is pending i.e. they will not prevent the page from being eligible for back/forward cache in a future version of Chrome." }, "panels/application/BackForwardCacheView.ts | unavailable": { "message": "unavailable" diff --git a/front_end/core/i18n/locales/en-XL.json b/front_end/core/i18n/locales/en-XL.json index daf4c2dea9..a384ca6593 100644 --- a/front_end/core/i18n/locales/en-XL.json +++ b/front_end/core/i18n/locales/en-XL.json @@ -2055,7 +2055,7 @@ "message": "Ŝt́ôṕ r̂éĉór̂d́îńĝ év̂én̂t́ŝ" }, "panels/application/ApplicationPanelCacheSection.ts | backForwardCache": { - "message": "B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé" + "message": "B̂áĉḱ/f̂ór̂ẃâŕd̂ ćâćĥé" }, "panels/application/ApplicationPanelCacheSection.ts | cacheStorage": { "message": "Ĉáĉh́ê Śt̂ór̂áĝé" @@ -2691,10 +2691,10 @@ "message": "P̂áĝéŝ t́ĥát̂ úŝé Ŵéb̂X́R̂ ár̂é n̂ót̂ ćûŕr̂én̂t́l̂ý êĺîǵîb́l̂é f̂ór̂ b́âćk̂/f́ôŕŵár̂d́ ĉáĉh́ê." }, "panels/application/BackForwardCacheView.ts | backForwardCacheTitle": { - "message": "B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé" + "message": "B̂áĉḱ/f̂ór̂ẃâŕd̂ ćâćĥé" }, "panels/application/BackForwardCacheView.ts | bfcacheStatus": { - "message": "B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé Ŝt́ât́ûś" + "message": "B̂áĉḱ/f̂ór̂ẃâŕd̂ ćâćĥé Ŝt́ât́ûś" }, "panels/application/BackForwardCacheView.ts | circumstantial": { "message": "N̂ót̂ Áĉt́îón̂áb̂ĺê" @@ -2706,16 +2706,16 @@ "message": "M̂áîń F̂ŕâḿê" }, "panels/application/BackForwardCacheView.ts | normalNavigation": { - "message": "N̂ór̂ḿâĺ n̂áv̂íĝát̂íôń (N̂ót̂ ŕêśt̂ór̂éd̂ f́r̂óm̂ B́âćk̂-F́ôŕŵár̂d́ Ĉáĉh́ê)" + "message": "N̂ór̂ḿâĺ n̂áv̂íĝát̂íôń (N̂ót̂ ŕêśt̂ór̂éd̂ f́r̂óm̂ b́âćk̂/f́ôŕŵár̂d́ ĉáĉh́ê)" }, "panels/application/BackForwardCacheView.ts | pageSupportNeeded": { "message": "Âćt̂íôńâb́l̂é" }, "panels/application/BackForwardCacheView.ts | pageSupportNeededExplanation": { - "message": "T̂h́êśê ŕêáŝón̂ś âŕê áĉt́îón̂áb̂ĺê í.ê. t́ĥéŷ ćâń b̂é ĉĺêán̂éd̂ úp̂ t́ô ḿâḱê t́ĥé p̂áĝé êĺîǵîb́l̂é f̂ór̂ B́âćk̂-F́ôŕŵár̂d́ Ĉáĉh́ê." + "message": "T̂h́êśê ŕêáŝón̂ś âŕê áĉt́îón̂áb̂ĺê í.ê. t́ĥéŷ ćâń b̂é ĉĺêán̂éd̂ úp̂ t́ô ḿâḱê t́ĥé p̂áĝé êĺîǵîb́l̂é f̂ór̂ b́âćk̂/f́ôŕŵár̂d́ ĉáĉh́ê." }, "panels/application/BackForwardCacheView.ts | restoredFromBFCache": { - "message": "R̂éŝt́ôŕêd́ f̂ŕôḿ B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé" + "message": "R̂éŝt́ôŕêd́ f̂ŕôḿ b̂áĉḱ/f̂ór̂ẃâŕd̂ ćâćĥé" }, "panels/application/BackForwardCacheView.ts | runTest": { "message": "R̂ún̂ T́êśt̂" @@ -2724,7 +2724,7 @@ "message": "P̂én̂d́îńĝ Śûṕp̂ór̂t́" }, "panels/application/BackForwardCacheView.ts | supportPendingExplanation": { - "message": "Ĉh́r̂óm̂é ŝúp̂ṕôŕt̂ f́ôŕ t̂h́êśê ŕêáŝón̂ś îś p̂én̂d́îńĝ í.ê. t́ĥéŷ ẃîĺl̂ ńôt́ p̂ŕêv́êńt̂ t́ĥé p̂áĝé f̂ŕôḿ b̂éîńĝ él̂íĝíb̂ĺê f́ôŕ B̂áĉḱ-F̂ór̂ẃâŕd̂ Ćâćĥé îń â f́ût́ûŕê v́êŕŝíôń ôf́ Ĉh́r̂óm̂é." + "message": "Ĉh́r̂óm̂é ŝúp̂ṕôŕt̂ f́ôŕ t̂h́êśê ŕêáŝón̂ś îś p̂én̂d́îńĝ í.ê. t́ĥéŷ ẃîĺl̂ ńôt́ p̂ŕêv́êńt̂ t́ĥé p̂áĝé f̂ŕôḿ b̂éîńĝ él̂íĝíb̂ĺê f́ôŕ b̂áĉḱ/f̂ór̂ẃâŕd̂ ćâćĥé îń â f́ût́ûŕê v́êŕŝíôń ôf́ Ĉh́r̂óm̂é." }, "panels/application/BackForwardCacheView.ts | unavailable": { "message": "ûńâv́âíl̂áb̂ĺê" diff --git a/front_end/entrypoints/main/MainImpl.ts b/front_end/entrypoints/main/MainImpl.ts index 99bad118b7..1879f833fa 100644 --- a/front_end/entrypoints/main/MainImpl.ts +++ b/front_end/entrypoints/main/MainImpl.ts @@ -299,8 +299,8 @@ export class MainImpl { 'keyboardShortcutEditor', 'Enable keyboard shortcut editor', true, 'https://developer.chrome.com/blog/new-in-devtools-88/#keyboard-shortcuts'); - // Back-Forward Cache - Root.Runtime.experiments.register('bfcacheDebugging', 'Enable Back-Forward Cache debugging support'); + // Back/forward cache + Root.Runtime.experiments.register('bfcacheDebugging', 'Enable back/forward cache debugging support'); // Timeline Root.Runtime.experiments.register('timelineEventInitiators', 'Timeline: event initiators'); diff --git a/front_end/panels/application/ApplicationPanelCacheSection.ts b/front_end/panels/application/ApplicationPanelCacheSection.ts index e4558d1393..690ae410c9 100644 --- a/front_end/panels/application/ApplicationPanelCacheSection.ts +++ b/front_end/panels/application/ApplicationPanelCacheSection.ts @@ -20,7 +20,7 @@ const UIStrings = { /** *@description Text in Application Panel Sidebar of the Application panel */ - backForwardCache: 'Back-Forward Cache', + backForwardCache: 'Back/forward cache', /** *@description A context menu item in the Application Panel Sidebar of the Application panel */ diff --git a/front_end/panels/application/BackForwardCacheView.ts b/front_end/panels/application/BackForwardCacheView.ts index 7e2979706a..e099140a54 100644 --- a/front_end/panels/application/BackForwardCacheView.ts +++ b/front_end/panels/application/BackForwardCacheView.ts @@ -17,67 +17,67 @@ import backForwardCacheViewStyles from './backForwardCacheView.css.js'; const UIStrings = { /** - * @description Title text in Back-Forward Cache view of the Application panel + * @description Title text in back/forward cache view of the Application panel */ mainFrame: 'Main Frame', /** - * @description Title text in Back-Forward Cache view of the Application panel + * @description Title text in back/forward cache view of the Application panel */ - backForwardCacheTitle: 'Back-Forward Cache', + backForwardCacheTitle: 'Back/forward cache', /** * @description Status text for the status of the main frame */ unavailable: 'unavailable', /** - * @description Entry name text in the Back-Forward Cache view of the Application panel + * @description Entry name text in the back/forward cache view of the Application panel */ url: 'URL', /** - * @description Entry name text in the Back-Forward Cache view of the Application panel + * @description Entry name text in the back/forward cache view of the Application panel */ - bfcacheStatus: 'Back-Forward Cache Status', + bfcacheStatus: 'Back/forward cache Status', /** - * @description Status text for the status of the Back-Forward Cache status + * @description Status text for the status of the back/forward cache status */ unknown: 'unknown', /** - * @description Status text for the status of the Back-Forward Cache status indicating that - * the Back-Forward Cache was not used and a normal navigation occured instead. + * @description Status text for the status of the back/forward cache status indicating that + * the back/forward cache was not used and a normal navigation occured instead. */ - normalNavigation: 'Normal navigation (Not restored from Back-Forward Cache)', + normalNavigation: 'Normal navigation (Not restored from back/forward cache)', /** - * @description Status text for the status of the Back-Forward Cache status indicating that - * the Back-Forward Cache was used to restore the page instead of reloading it. + * @description Status text for the status of the back/forward cache status indicating that + * the back/forward cache was used to restore the page instead of reloading it. */ - restoredFromBFCache: 'Restored from Back-Forward Cache', + restoredFromBFCache: 'Restored from back/forward cache', /** * @description Label for a list of reasons which prevent the page from being eligible for - * Back-Forward Cache. These reasons are actionable i.e. they can be cleaned up to make the - * page eligible for Back-Forward Cache. + * back/forward cache. These reasons are actionable i.e. they can be cleaned up to make the + * page eligible for back/forward cache. */ pageSupportNeeded: 'Actionable', /** * @description Explanation for actionable items which prevent the page from being eligible - * for Back-Forward Cache. + * for back/forward cache. */ pageSupportNeededExplanation: - 'These reasons are actionable i.e. they can be cleaned up to make the page eligible for Back-Forward Cache.', + 'These reasons are actionable i.e. they can be cleaned up to make the page eligible for back/forward cache.', /** * @description Label for a list of reasons which prevent the page from being eligible for - * Back-Forward Cache. These reasons are circumstantial / not actionable i.e. they cannot be - * cleaned up by developers to make the page eligible for Back-Forward Cache. + * back/forward cache. These reasons are circumstantial / not actionable i.e. they cannot be + * cleaned up by developers to make the page eligible for back/forward cache. */ circumstantial: 'Not Actionable', /** * @description Explanation for circumstantial/non-actionable items which prevent the page from being eligible - * for Back-Forward Cache. + * for back/forward cache. */ circumstantialExplanation: 'These reasons are not actionable i.e. caching was prevented by something outside of the direct control of the page.', /** * @description Label for a list of reasons which prevent the page from being eligible for - * Back-Forward Cache. These reasons are pending support by chrome i.e. in a future version - * of chrome they will not prevent Back-Forward Cache usage anymore. + * back/forward cache. These reasons are pending support by chrome i.e. in a future version + * of chrome they will not prevent back/forward cache usage anymore. */ supportPending: 'Pending Support', /** @@ -86,10 +86,10 @@ const UIStrings = { runTest: 'Run Test', /** * @description Explanation for 'pending support' items which prevent the page from being eligible - * for Back-Forward Cache. + * for back/forward cache. */ supportPendingExplanation: - 'Chrome support for these reasons is pending i.e. they will not prevent the page from being eligible for Back-Forward Cache in a future version of Chrome.', + 'Chrome support for these reasons is pending i.e. they will not prevent the page from being eligible for back/forward cache in a future version of Chrome.', }; const str_ = i18n.i18n.registerUIStrings('panels/application/BackForwardCacheView.ts', UIStrings); const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_);