From bf712d5e92d7431d43930e8269dccef3a0de602c Mon Sep 17 00:00:00 2001 From: Sigurd Schneider Date: Mon, 22 Mar 2021 10:13:50 +0100 Subject: [PATCH] Disable more tests from test/e2e/inline_editor/color-swatch_test.ts Failure examples: https://ci.chromium.org/p/devtools-frontend/builders/ci/Stand-alone%20Mac/3700 https://ci.chromium.org/p/devtools-frontend/builders/ci/Stand-alone%20Mac/3703 https://ci.chromium.org/p/devtools-frontend/builders/ci/Stand-alone%20Mac/3705 Bug: chromium:1184160 Change-Id: I87b1a42da997438b8ce33db7cd3a899723a5bd4d Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2776016 Reviewed-by: Alex Rudenko Reviewed-by: Sigurd Schneider Commit-Queue: Sigurd Schneider --- test/e2e/inline_editor/color-swatch_test.ts | 17 ++++++++++------- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/test/e2e/inline_editor/color-swatch_test.ts b/test/e2e/inline_editor/color-swatch_test.ts index 234e8a6b7b..a867aea1c6 100644 --- a/test/e2e/inline_editor/color-swatch_test.ts +++ b/test/e2e/inline_editor/color-swatch_test.ts @@ -39,7 +39,8 @@ async function assertNoColorSwatch(container: puppeteer.ElementHandle|undefined) } describe('The color swatch', async () => { - it('is displayed for color properties in the Styles pane', async () => { + // Test flaky on Mac + it.skipOnPlatforms(['mac'], '[crbug.com/1184160]: is displayed for color properties in the Styles pane', async () => { await goToTestPageAndSelectTestElement(); await waitForCSSPropertyValue('#inspected', 'color', 'red'); @@ -59,14 +60,16 @@ describe('The color swatch', async () => { await assertColorSwatch(property, 'rgb(255, 0, 0)'); }); - it('is not displayed for non-color properties in the Styles pane', async () => { - await goToTestPageAndSelectTestElement(); + // Test flaky on Mac + it.skipOnPlatforms( + ['mac'], '[crbug.com/1184160]: is not displayed for non-color properties in the Styles pane', async () => { + await goToTestPageAndSelectTestElement(); - await waitForCSSPropertyValue('#inspected', 'margin', '10px'); - const property = await getCSSPropertyInRule('#inspected', 'margin'); + await waitForCSSPropertyValue('#inspected', 'margin', '10px'); + const property = await getCSSPropertyInRule('#inspected', 'margin'); - await assertNoColorSwatch(property); - }); + await assertNoColorSwatch(property); + }); // Test flaky on Mac it.skipOnPlatforms(