From d0dee8efbd7aefec40650e405984ee9913d552ee Mon Sep 17 00:00:00 2001 From: Danil Somsikov Date: Tue, 2 Aug 2022 16:19:29 +0200 Subject: [PATCH] Re-enable network request blocking panel e2e tests, and temporary replace beforeEach with an explicit function call to aid debugging. I cannot reproduce the flakiness using the trybot, let's see if it still fails. Bug: 1259120 Change-Id: Ie20e1702408e5000e50af2746eb34c058749ca8f Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3804761 Auto-Submit: Danil Somsikov Reviewed-by: Kateryna Prokopenko Commit-Queue: Danil Somsikov --- test/e2e/network/network-request-blocking-panel_test.ts | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/e2e/network/network-request-blocking-panel_test.ts b/test/e2e/network/network-request-blocking-panel_test.ts index 3af5a817df..32338e10e5 100644 --- a/test/e2e/network/network-request-blocking-panel_test.ts +++ b/test/e2e/network/network-request-blocking-panel_test.ts @@ -40,9 +40,8 @@ async function disableNetworkRequestBlocking() { expect(await checkboxIsChecked(networkRequestBlockingCheckbox)).to.equal(false); } -// Flakey in the beforeEach step on Mac bot. -describe.skip('[crbug.com/1259120] Network request blocking panel', async () => { - beforeEach(async () => { +describe('Network request blocking panel', async () => { + async function setup() { await navigateToNetworkRequestBlockingTab(); for (let i = 0; i < 20; i++) { const plusButton = await waitForAria('Add pattern'); @@ -52,9 +51,10 @@ describe.skip('[crbug.com/1259120] Network request blocking panel', async () => const addButton = await waitForAria('Add'); await addButton.click(); } - }); + } it('pattern list inactive when blocking disabled', async () => { + await setup(); await disableNetworkRequestBlocking(); await waitForAriaNone('Edit'); @@ -68,6 +68,7 @@ describe.skip('[crbug.com/1259120] Network request blocking panel', async () => }); it('pattern scrollable when blocking disabled', async () => { + await setup(); await disableNetworkRequestBlocking(); const list = await waitFor('.list');