From d2a117c50fbbd6e3aa574ea18381358d2d46e694 Mon Sep 17 00:00:00 2001 From: Jack Franklin Date: Thu, 5 Aug 2021 16:16:53 +0100 Subject: [PATCH] Remove lint-components-css script Now we ban CSS in web components, this script is irrelevant as it'll never find any issues - and we lint to ensure no style tags creep into our Lit templates. Bug: 1106746 Change-Id: I507193c63a1ab26901d9d3aaec2b01620717b477 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3075380 Commit-Queue: Jack Franklin Commit-Queue: Tim van der Lippe Auto-Submit: Jack Franklin Reviewed-by: Tim van der Lippe --- package.json | 3 +-- scripts/test/run_lint_check_css.js | 4 ---- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/package.json b/package.json index 7c49c935f0..832300a463 100644 --- a/package.json +++ b/package.json @@ -31,8 +31,7 @@ "check-gn": "third_party/node/node.py --output scripts/check_gn.js", "check-json": "third_party/node/node.py --output scripts/json_validator/validate_module_json.js", "check-lint": "third_party/node/node.py --output scripts/test/run_lint_check_js.js && third_party/node/node.py --output scripts/test/run_lint_check_css.js && npm run check-lint-components-css", - "check-lint-components-css": "third_party/node/node.py --output scripts/test/run_lint_check_css.js --glob 'front_end/**/*.ts' --syntax html", - "check-lint-css": "third_party/node/node.py --output scripts/test/run_lint_check_css.js && npm run check-lint-components-css", + "check-lint-css": "third_party/node/node.py --output scripts/test/run_lint_check_css.js", "collect-strings": "third_party/node/node.py --output third_party/i18n/collect-strings.js front_end", "components-server": "third_party/node/node.py --output scripts/component_server/server.js", "debug-e2etest": "DEBUG_TEST=1 npm run e2etest", diff --git a/scripts/test/run_lint_check_css.js b/scripts/test/run_lint_check_css.js index 82d3952666..c34a78f60b 100644 --- a/scripts/test/run_lint_check_css.js +++ b/scripts/test/run_lint_check_css.js @@ -44,10 +44,6 @@ function run() { // eslint-disable-next-line no-unused-vars const {glob, files, cwd, _, $0, ...flagsForStylelint} = yargsObject; - /* - * This reduce is a flatten, because our Node version - * doesn't have flatMap :( - */ const extraFlagsForStylelint = Object.keys(flagsForStylelint).flatMap(key => [`--${key}`, flagsForStylelint[key]]); const args = [