From d48805e43af857255bdfc19d8df25da6464e8b37 Mon Sep 17 00:00:00 2001 From: John Emau Date: Thu, 5 Jan 2023 00:50:22 +0000 Subject: [PATCH] [e2e] Fix: Remove aync describe in can-create-panels_tests.ts Passing an aync callback to describe can cause unintended behavior in mocha helpers. Remove the `async` keyword to the describe callback. It is not needed. If in the future async work is needed before a test is run passing an async callback to `before` is the recommended approach. See https://mochajs.org/#using-async-await Bug: None Change-Id: I6ad2cef69ece58a91d333932d35e8ed5c6c1436b Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4136865 Auto-Submit: John Emau Commit-Queue: Yang Guo Reviewed-by: Yang Guo --- test/e2e/extensions/can-create-panels_test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/e2e/extensions/can-create-panels_test.ts b/test/e2e/extensions/can-create-panels_test.ts index 051fd80951..f171706687 100644 --- a/test/e2e/extensions/can-create-panels_test.ts +++ b/test/e2e/extensions/can-create-panels_test.ts @@ -15,7 +15,7 @@ import { import {describe, it} from '../../shared/mocha-extensions.js'; import {loadExtension} from '../helpers/extension-helpers.js'; -describe('The Extension API', async () => { +describe('The Extension API', () => { it('can create panels with callbacks', async () => { const extension = await loadExtension('TestExtension');