From d79e3c545b430a063a76cdff57237d86a67f26f4 Mon Sep 17 00:00:00 2001 From: Tim van der Lippe Date: Wed, 1 Sep 2021 14:31:24 +0100 Subject: [PATCH] Strongly type key in pressKey R=jacktfranklin@chromium.org Bug: none Change-Id: Ib9eb75bdb76124e1d4f6d54e5b5edcfdea6a4504 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3135426 Commit-Queue: Tim van der Lippe Commit-Queue: Jack Franklin Auto-Submit: Tim van der Lippe Reviewed-by: Jack Franklin --- test/shared/helper.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/test/shared/helper.ts b/test/shared/helper.ts index 335fbfe20f..82e50f68b4 100644 --- a/test/shared/helper.ts +++ b/test/shared/helper.ts @@ -128,7 +128,8 @@ export const typeText = async (text: string) => { await frontend.keyboard.type(text); }; -export const pressKey = async (key: string, modifiers?: {control?: boolean, alt?: boolean, shift?: boolean}) => { +export const pressKey = + async (key: puppeteer.KeyInput, modifiers?: {control?: boolean, alt?: boolean, shift?: boolean}) => { const {frontend} = getBrowserAndPages(); if (modifiers) { if (modifiers.control) { @@ -146,7 +147,7 @@ export const pressKey = async (key: string, modifiers?: {control?: boolean, alt? await frontend.keyboard.down('Shift'); } } - await frontend.keyboard.press(key as puppeteer.KeyInput); + await frontend.keyboard.press(key); if (modifiers) { if (modifiers.shift) { await frontend.keyboard.up('Shift');