From dbb8de4898935b04ced7cbfaab16cb9aba614574 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Simon=20Z=C3=BCnd?= Date: Wed, 22 Sep 2021 09:56:48 +0200 Subject: [PATCH] Use explicit SDKModel for models without events MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Using 'void' causes TypeScript compilation errors when someone tries to add listeners or dispatch events on a SDKModel. R=bmeurer@chromium.org Bug: 1228674 Change-Id: I4de24710d92d7fa4d916ec1b0a723ba6e3351ab6 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3175285 Commit-Queue: Simon Zünd Commit-Queue: Benedikt Meurer Auto-Submit: Simon Zünd Reviewed-by: Benedikt Meurer --- front_end/core/sdk/TracingManager.ts | 2 +- front_end/entrypoints/node_main/NodeMain.ts | 2 +- front_end/panels/css_overview/CSSOverviewModel.ts | 2 +- front_end/panels/input/InputModel.ts | 2 +- front_end/panels/screencast/InputModel.ts | 2 +- front_end/ui/legacy/components/utils/TargetDetachedDialog.ts | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/front_end/core/sdk/TracingManager.ts b/front_end/core/sdk/TracingManager.ts index dad0884a4a..386a8cd167 100644 --- a/front_end/core/sdk/TracingManager.ts +++ b/front_end/core/sdk/TracingManager.ts @@ -10,7 +10,7 @@ import {Capability} from './Target.js'; import {SDKModel} from './SDKModel.js'; import type {ObjectSnapshot} from './TracingModel.js'; -export class TracingManager extends SDKModel { +export class TracingManager extends SDKModel { private readonly tracingAgent: ProtocolProxyApi.TracingApi; private activeClient: TracingManagerClient|null; private eventBufferSize: number|null; diff --git a/front_end/entrypoints/node_main/NodeMain.ts b/front_end/entrypoints/node_main/NodeMain.ts index 1e795f3387..8e47771e5e 100644 --- a/front_end/entrypoints/node_main/NodeMain.ts +++ b/front_end/entrypoints/node_main/NodeMain.ts @@ -47,7 +47,7 @@ export class NodeMainImpl implements Common.Runnable.Runnable { Common.Runnable.registerEarlyInitializationRunnable(NodeMainImpl.instance); -export class NodeChildTargetManager extends SDK.SDKModel.SDKModel implements ProtocolProxyApi.TargetDispatcher { +export class NodeChildTargetManager extends SDK.SDKModel.SDKModel implements ProtocolProxyApi.TargetDispatcher { private readonly targetManager: SDK.TargetManager.TargetManager; private readonly parentTarget: SDK.Target.Target; private readonly targetAgent: ProtocolProxyApi.TargetApi; diff --git a/front_end/panels/css_overview/CSSOverviewModel.ts b/front_end/panels/css_overview/CSSOverviewModel.ts index ad8db3ace1..4529de7079 100644 --- a/front_end/panels/css_overview/CSSOverviewModel.ts +++ b/front_end/panels/css_overview/CSSOverviewModel.ts @@ -41,7 +41,7 @@ export interface GlobalStyleStats { }; } -export class CSSOverviewModel extends SDK.SDKModel.SDKModel { +export class CSSOverviewModel extends SDK.SDKModel.SDKModel { private readonly runtimeAgent: ProtocolProxyApi.RuntimeApi; private readonly cssAgent: ProtocolProxyApi.CSSApi; private readonly domAgent: ProtocolProxyApi.DOMApi; diff --git a/front_end/panels/input/InputModel.ts b/front_end/panels/input/InputModel.ts index d252342808..df19e6c2f4 100644 --- a/front_end/panels/input/InputModel.ts +++ b/front_end/panels/input/InputModel.ts @@ -6,7 +6,7 @@ import * as SDK from '../../core/sdk/sdk.js'; import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js'; import * as Protocol from '../../generated/protocol.js'; -export class InputModel extends SDK.SDKModel.SDKModel { +export class InputModel extends SDK.SDKModel.SDKModel { private readonly inputAgent: ProtocolProxyApi.InputApi; private eventDispatchTimer: number; private dispatchEventDataList: EventData[]; diff --git a/front_end/panels/screencast/InputModel.ts b/front_end/panels/screencast/InputModel.ts index cbad5a55be..f5c373cb83 100644 --- a/front_end/panels/screencast/InputModel.ts +++ b/front_end/panels/screencast/InputModel.ts @@ -6,7 +6,7 @@ import * as SDK from '../../core/sdk/sdk.js'; import type * as ProtocolProxyApi from '../../generated/protocol-proxy-api.js'; import * as Protocol from '../../generated/protocol.js'; -export class InputModel extends SDK.SDKModel.SDKModel { +export class InputModel extends SDK.SDKModel.SDKModel { private readonly inputAgent: ProtocolProxyApi.InputApi; private activeTouchOffsetTop: number|null; private activeTouchParams: Protocol.Input.EmulateTouchFromMouseEventRequest|null; diff --git a/front_end/ui/legacy/components/utils/TargetDetachedDialog.ts b/front_end/ui/legacy/components/utils/TargetDetachedDialog.ts index 4a9e4a854c..5e77ec1aec 100644 --- a/front_end/ui/legacy/components/utils/TargetDetachedDialog.ts +++ b/front_end/ui/legacy/components/utils/TargetDetachedDialog.ts @@ -16,7 +16,7 @@ const UIStrings = { }; const str_ = i18n.i18n.registerUIStrings('ui/legacy/components/utils/TargetDetachedDialog.ts', UIStrings); const i18nString = i18n.i18n.getLocalizedString.bind(undefined, str_); -export class TargetDetachedDialog extends SDK.SDKModel.SDKModel implements ProtocolProxyApi.InspectorDispatcher { +export class TargetDetachedDialog extends SDK.SDKModel.SDKModel implements ProtocolProxyApi.InspectorDispatcher { private static hideCrashedDialog: (() => void)|null; constructor(target: SDK.Target.Target) { super(target);