zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-29 16:57:00 +08:00
Code Issues Packages Projects Releases Wiki Activity

Fix interactions tests

Browse Source 
These tests were still importing the css files from their original
location. The files were moved in https://crrev.com/c/2810839, but
because of stale `autoninja` compilation outputs, that CL got
submitted just fine. When new bots were provisioned, the files
were missing and the tests started failing post-submit.

Confirmed locally that removing the old compilation output fails
the tests and this output makes them pass again.

R=jacktfranklin@chromium.org

Bug: 1187573
Change-Id: Ia564c76f53ff31d0669c88967ba916bf910e3538
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2813958
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
This commit is contained in:
Tim van der Lippe
2021-04-08 10:17:42 +00:00
committed by Commit Bot
parent b2108e6332
commit e6583133ad
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
scripts/component_server/server.js
+2 -2
View File
@@ -243,9 +243,9 @@ async function requestHandler(request, response) {
componentDocsBaseArg && componentDocsBaseArg.endsWith(sharedResourcesBase) ? '/' : `/${sharedResourcesBase}`;
const fileContents = await fs.promises.readFile(path.join(componentDocsBaseFolder, filePath), {encoding: 'utf8'});
const themeColoursLink = `<link rel="stylesheet" href="${
path.join(baseUrlForSharedResource, 'front_end', 'ui', 'themeColors.css')}" type="text/css" />`;
path.join(baseUrlForSharedResource, 'front_end', 'ui', 'legacy', 'themeColors.css')}" type="text/css" />`;
const inspectorCommonLink = `<link rel="stylesheet" href="${
path.join(baseUrlForSharedResource, 'front_end', 'ui', 'inspectorCommon.css')}" type="text/css" />`;
path.join(baseUrlForSharedResource, 'front_end', 'ui', 'legacy', 'inspectorCommon.css')}" type="text/css" />`;
const toggleDarkModeScript = `<script type="module" src="${
path.join(baseUrlForSharedResource, 'front_end', 'component_docs', 'component_docs.js')}"></script>`;
const newFileContents = fileContents.replace('<style>', `${themeColoursLink}\n${inspectorCommonLink}\n<style>`)