From fb2fd3ecd628fac235c3efce836aa9ea63bd5c15 Mon Sep 17 00:00:00 2001 From: Tim van der Lippe Date: Mon, 15 Nov 2021 15:06:39 +0000 Subject: [PATCH] Remove panels/network/module.json R=jacktfranklin@chromium.org Bug: 1127902 Change-Id: I92a8fe99172623f9739f6f175be6935d86401fa8 Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3282033 Commit-Queue: Tim van der Lippe Reviewed-by: Jack Franklin --- BUILD.gn | 1 - config/gni/all_devtools_files.gni | 1 - config/gni/devtools_grd_files.gni | 1 - front_end/entrypoints/devtools_app/devtools_app.json | 1 - front_end/entrypoints/worker_app/worker_app.json | 1 - front_end/panels/application/module.json | 3 +-- front_end/panels/issues/module.json | 1 - front_end/panels/network/module.json | 5 ----- front_end/panels/network/network-meta.ts | 3 --- front_end/panels/security/module.json | 1 - 10 files changed, 1 insertion(+), 17 deletions(-) delete mode 100644 front_end/panels/network/module.json diff --git a/BUILD.gn b/BUILD.gn index 9796cbbb81..fdc3b16265 100644 --- a/BUILD.gn +++ b/BUILD.gn @@ -86,7 +86,6 @@ non_autostart_non_remote_modules = [ "panels/layer_viewer/layer_viewer_module.js", "panels/layers/layers_module.js", "panels/lighthouse/lighthouse_module.js", - "panels/network/network_module.js", "panels/profiler/profiler_module.js", "panels/issues/issues_module.js", "panels/application/application_module.js", diff --git a/config/gni/all_devtools_files.gni b/config/gni/all_devtools_files.gni index 9630612394..4c614fdcd2 100644 --- a/config/gni/all_devtools_files.gni +++ b/config/gni/all_devtools_files.gni @@ -60,7 +60,6 @@ all_devtools_files = [ "front_end/panels/layers/module.json", "front_end/entrypoints/ndb_app/ndb_app.json", "front_end/legacy_test_runner/network_test_runner/network_test_runner.js", - "front_end/panels/network/module.json", "front_end/entrypoints/node_main/nodeConnectionsPanel.css", "front_end/legacy_test_runner/performance_test_runner/performance_test_runner.js", "front_end/legacy_test_runner/performance_test_runner/TimelineDataTestRunner.js", diff --git a/config/gni/devtools_grd_files.gni b/config/gni/devtools_grd_files.gni index bcbd8f65fe..caa0c3d91c 100644 --- a/config/gni/devtools_grd_files.gni +++ b/config/gni/devtools_grd_files.gni @@ -396,7 +396,6 @@ grd_files_release_sources = [ "front_end/panels/network/network-legacy.js", "front_end/panels/network/network-meta.js", "front_end/panels/network/network.js", - "front_end/panels/network/network_module.js", "front_end/panels/performance_monitor/performance_monitor-meta.js", "front_end/panels/performance_monitor/performance_monitor.js", "front_end/panels/profiler/profiler-legacy.js", diff --git a/front_end/entrypoints/devtools_app/devtools_app.json b/front_end/entrypoints/devtools_app/devtools_app.json index 91fb78d451..2b58ae651f 100644 --- a/front_end/entrypoints/devtools_app/devtools_app.json +++ b/front_end/entrypoints/devtools_app/devtools_app.json @@ -7,7 +7,6 @@ { "name": "panels/issues" }, { "name": "panels/layers" }, { "name": "panels/layer_viewer" }, - { "name": "panels/network" }, { "name": "panels/application" }, { "name": "panels/security" }, { "name": "panels/timeline" } diff --git a/front_end/entrypoints/worker_app/worker_app.json b/front_end/entrypoints/worker_app/worker_app.json index 1a8b29e759..172bfbd042 100644 --- a/front_end/entrypoints/worker_app/worker_app.json +++ b/front_end/entrypoints/worker_app/worker_app.json @@ -2,7 +2,6 @@ "modules" : [ { "name": "panels/issues" }, { "name": "panels/layer_viewer" }, - { "name": "panels/network" }, { "name": "panels/application" }, { "name": "panels/timeline" } ], diff --git a/front_end/panels/application/module.json b/front_end/panels/application/module.json index 7c40634514..cf13a6aadd 100644 --- a/front_end/panels/application/module.json +++ b/front_end/panels/application/module.json @@ -1,6 +1,5 @@ { "dependencies": [ - "ui/legacy", - "panels/network" + "ui/legacy" ] } diff --git a/front_end/panels/issues/module.json b/front_end/panels/issues/module.json index 4dfb9ba560..cf13a6aadd 100644 --- a/front_end/panels/issues/module.json +++ b/front_end/panels/issues/module.json @@ -1,6 +1,5 @@ { "dependencies": [ - "panels/network", "ui/legacy" ] } diff --git a/front_end/panels/network/module.json b/front_end/panels/network/module.json deleted file mode 100644 index cf13a6aadd..0000000000 --- a/front_end/panels/network/module.json +++ /dev/null @@ -1,5 +0,0 @@ -{ - "dependencies": [ - "ui/legacy" - ] -} diff --git a/front_end/panels/network/network-meta.ts b/front_end/panels/network/network-meta.ts index 58723ac421..780abb6143 100644 --- a/front_end/panels/network/network-meta.ts +++ b/front_end/panels/network/network-meta.ts @@ -3,7 +3,6 @@ // found in the LICENSE file. import * as Common from '../../core/common/common.js'; -import * as Root from '../../core/root/root.js'; import * as SDK from '../../core/sdk/sdk.js'; import * as Workspace from '../../models/workspace/workspace.js'; import * as NetworkForward from '../../panels/network/forward/forward.js'; @@ -117,8 +116,6 @@ let loadedNetworkModule: (typeof Network|undefined); async function loadNetworkModule(): Promise { if (!loadedNetworkModule) { - // Side-effect import resources in module.json - await Root.Runtime.Runtime.instance().loadModulePromise('panels/network'); loadedNetworkModule = await import('./network.js'); } return loadedNetworkModule; diff --git a/front_end/panels/security/module.json b/front_end/panels/security/module.json index 508f284b02..9fde837ad7 100644 --- a/front_end/panels/security/module.json +++ b/front_end/panels/security/module.json @@ -1,5 +1,4 @@ { "dependencies": [ - "panels/network" ] } \ No newline at end of file