This adds an option `--enable-unstable-features`, which now also turns
on multimodal support for Freestyler.
It also adds `--enable-features` and `--disable-features`, to allow more
fine-grained control over the exact feature set when necessary.
Fixed: 406941932
Change-Id: I7fcecbba833a2e0a66166890aa5af218ae2a8f7e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404318
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
This adds a new script for `npm run build`, which supports a `--watch`
argument, to automatically re-build whenever source files change. It
also hooks this up to `npm start`, which to automatically rebuild in
the background while Chrome is running.
Bug: 404192426
Change-Id: I90ee3ea81312bcfff9470ab8c62d38608e4e9a71
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367220
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
This adds an initial version of the `npm start` script, which builds the
DevTools front-end and launches either CfT or Chrome Canary binary with
the custom DevTools front-end, passing appropriate flags to enable or
disable certain experimental features.
Bug: 404192426
Change-Id: Ia7bcbf8cb5f93bcf455e59964a488480e8ec1fff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367034
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Ideally the host configuration would live in `core/host`, but due to the
current setup, this isn't possible. However it also doesn't make sense
to bolt it into `Settings`, since this has nothing to do with settings.
Rather, it makes sense to keep it together with the type definitions as
part of `core/root`. This also simplifies the test handling and makes it
more robust.
Fixed: 396033932
Change-Id: I8f00fc84f62b180ede4407741d261544a13218da
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6257569
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
The solidus `/>` does not have any special meaning in HTML, and does
not replace an end tag.
This patch fixes the examples by adding explicit end tags where
intended, ensuring that e.g. <devtools-tab-pane> does not get nested
under <devtools-widget> in the first example.
The distinction is critical as it results in a different DOM structure.
Bug: chromium:394001149
Change-Id: I5331103b758693021798adde3e4dbd8c34eb1ff4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6252743
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
This merges the definitions that were in design_tokens into
theme_colors.css and application_color_tokens.css.
In a follow up, we'll rename these two (theme_colors and
application_color_tokens). Keeping the same name here in order to
keep the diff easier to read for review purposes.
Bug: 390330089
Change-Id: Ia8510ca0818d31409250c1d5e6ef67897e6fc193
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6203922
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
This is the first part of our goal to merge the token css files
(token.css, theme_colors.css, design_tokens.css and
application_color_tokens.css). In the end, we want to end up
with two css files only.
This CL makes the following changes:
1. Move the content from `tokens.css` into `theme_colors.css`
2. Remove `tokens.css`
Note that this CL is simply moving the content for simplicity of
reviewing.
More clean ups will follow.
Bug: 390330089
Change-Id: Id06de578b1f5bf5f6dda7674e356a2c9f0463e94
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6189457
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
With this CL, we remove the `.chrome-select` CSS class and the two
different ways of styling a `<select>` element (excluding the completely
custom thing in the Recorder panel), and only have one set of styles
that we use consistently for all `<select>` elements (modulo the one in
the Recorder panel b/c LitElement), independent of whether the
`<select>` is used in a toolbar or elsewhere.
That means we can now simply put a `<select>` directly into a
`<devtools-toolbar>` and it will work as expected.
Drive-by-fix: Skip the test from crbug.com/383478771 completely now,
since even though the `<select>` in the Recorder panel is unaffected
by these changes, some surrounding (likely) timing changes now make that
test fail consistently, not only on Mac.
Bug: 383478771, 388445687
Change-Id: I01d7835d5858cac8863a7337a8e43a49b55820f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6163607
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
As part of the Vision for the Chrome DevTools UI Engineering[^1],
we need to migrate off of built-in custom elements. Which also has
the additional benefit that our UI will work in Safari (part of
this was already fixed with https://crrev.com/c/6028362 earlier).
This CL replaces the previous built-in custom elements with proper
autonomous custom elements: `BezierSwatch`,`DevToolsIconLabel`,
`DevToolsSmallBubble`, and `DevToolsCloseButton`.
The `HistoryInput` component only added special handling for keydown
and input events, and otherwise was just a simple `HTMLInputElement`.
This migrates the class to a simple helper function that does the
same (without requiring a built-in custom element, which we're
trying to migrate off of).
The `DevToolsSlider` and `DevToolsRadioButton` built-in custom
elements are removed in favor of simple helpers that just create
the appropriate `HTMLInputElement`s. The styles for these are
moved to the `inspectorCommon.css`. The custom elements were
really overkill for something trivial as these and only added
confusion. The component server and documentation now also describe
sliders and radio buttons.
This change is functionally neutral and only replaces implementation
details.
Drive-by-fix: Fix a bunch of outdated / incorrect CSS along the way.
[^1]: http://go/chrome-devtools:ui-engineering-proposal
Bug: 386453980
Change-Id: I7ba9f9c156e5f0f9396c0c6eb3d2febc8d371b33
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6114579
Reviewed-by: Changhao Han <changhaohan@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
- Chrome for Testing releases are built with `is_official_build` + `is_chrome_for_testing_branded`.
- Regular Chrome releases are built with `is_official_build` + `is_chrome_branded`.
- Chromium builds usually have none of these GN args set.
Any features conditional on `is_chrome_branded` are thus not supported in Chromium nor in CfT.
Bug: none
Change-Id: Ia8ecac55d93e2cca9abcb4fa3220293858cd7e17
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6021663
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Benedikt Meurer