Jack Franklin
5c9a3b6b59
Karma: apply patch to prevent timeouts after test complete
...
In github.com/karma-runner/karma/pull/3852 it is suggested that the 30s
timeout issue with Karma can be seen when:
1. All the tests complete, which sets the state of Karma to
"disconnected"
2. But there is some async activity which logs, or something. This
causes Karma to restart its 30s timeout, but no more messages will be
received.
This is a bit experimental, but trying this patch to see if it has a
positive impact on CQ.
Bug: 406729910
Change-Id: Iaaa9247c801e193e5782a0da4857d804bcc45a92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6407593
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
2025-03-28 04:41:42 -07:00
Jack Franklin
8f8ec22bb3
Update karma to 6.4.0
...
No changes in the changelog
(https://github.com/karma-runner/karma/blob/master/CHANGELOG.md ) to
concern ourselves about, but one useful change is they upgraded the
log4js dependency which was spitting out console messages on each test
run. This is fixed with this version of Karma.
Bug: none
Change-Id: Ic49618cbda7a079cacb9813f5129692a83508a92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3745621
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org >
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org >
2022-07-05 10:46:37 +00:00
Tim van der Lippe
b693eb34d5
Update remaining NPM dependencies
...
DISABLE_THIRD_PARTY_CHECK=NPM fix
R=jacktfranklin@chromium.org
Bug: none
Change-Id: I41baa3294f88b7e4463fdc580c050932c5abe40e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372932
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org >
2022-01-07 14:42:53 +00:00
Tim van der Lippe
d3425b95d0
Update unit test NPM dependencies
...
Updates Karma, Mocha and Sinon.
R=jacktfranklin@chromium.org
Bug: none
Change-Id: Ia93cdafc646e4d3277e7ce869a7a8b5e66a13f0d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372928
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org >
2022-01-07 14:26:50 +00:00
Tim van der Lippe
61fe685814
Update various test packages
...
- Update Sinon (breaking change does not affect us)
- Update Mocha
- Update Karma
R=jacktfranklin@chromium.org
Bug: none
Change-Id: Ieb50ba55ce7a9e01e32ee553a6741e6323fcaaab
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3158223
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2021-09-13 12:55:26 +00:00
Tim van der Lippe
0a9b84dbd8
Update NPM dependencies
...
Major updates to Puppeteer (Chromium roll and updates to types:
https://github.com/puppeteer/puppeteer/blob/0b5969dea9048dc34a4d2e109e96c42e8928182c/CHANGELOG.md#800-2021-02-26 ) and Sinon (unaffected by browser support changes).
DISABLE_THIRD_PARTY_CHECK=NPM updates
R=jacktfranklin@chromium.org
Fixed: 1176642
Change-Id: I419300fc573e8086b4a7b3b6281c81602890f8d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2782553
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2021-03-24 13:47:34 +00:00
Tim van der Lippe
459f40214e
Run npm run install-deps on NPM 7.4.5
...
This CL contains the output of running `npm run install-deps` on
NPM 7.4.5. This includes a version bump of the package-lock.json,
which means all DevTools engineers who run `npm run install-deps`
should use NPM 7+. Additionally, this allows `npm run dedupe` to
produce a better output and remove more duplicate packages.
For more information, see https://github.com/eslint/eslint/issues/14098
DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org
Bug: none
Change-Id: Id1ca2f33f3bb7d555dca1c0737d38bc1c7f5221c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2705386
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2021-02-19 13:25:21 +00:00
Tim van der Lippe
6d109a9d45
Update Mocha to 8.3.0
...
This also adds Python-2.0 to the list of accepted licenses.
Lastly, it fixes a bug where the package.json files were incorrectly
reordered. For the `exports` of a particular package, the order that
the entrypoints are defined in is crucial. Therefore, we should not
alter the order of entrypoints and instead maintain the originally
defined ordering. We can use an `OrderedDict` to ensure that Python
always loads the JSON files in the same order.
DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org
Bug: none
Change-Id: I5a309782de6015edea6ba3b502aa0db1f008d973
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692909
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
2021-02-17 12:08:49 +00:00
Tim van der Lippe
c7b05fe360
Update testing packages
...
This updates Chai, Karma and Sinon. The breaking changes in Karma
6.0.0 don't affect us.
DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org
Bug: none
Change-Id: I77c2d4b1aeb1f0544d56c1f8a37e409a19352bfe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2692906
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2021-02-15 13:17:30 +00:00
Tim van der Lippe
bfcaca046e
Update remaining outdated packages
...
- Update yargs to 16.1.1
- Update @rollup/plugin-commonjs to 17.0.0
- Update @types/codemirror to 0.0.100
- Update Puppeteer to 5.5.0
- Update Rollup to 2.34.0
DISABLE_THIRD_PARTY_CHECK=NPM update
R=jacktfranklin@chromium.org
Change-Id: Ie3ed95b7c83ec615122643769ff5c53ac4111c09
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2567910
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2020-12-02 13:07:39 +00:00
Tim van der Lippe
5226a88fe0
Update karma-related packages
...
This updates karma to 5.2.3, karma-coverage to the officially
published version 2.0.3 (we were previously relying on a git
commit) and karma-sourcemap-loader to 0.3.8.
DISABLE_THIRD_PARTY_CHECK=Update Karma
R=aerotwist@chromium.org
Change-Id: Iaa365379d7c2c6eb9145b1507be1a0a3ae812359
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2527043
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Paul Lewis <aerotwist@chromium.org >
2020-11-09 17:42:16 +00:00
Tim van der Lippe
2a1ede5c26
Fix newline additions in package.json files in node_modules/
...
`manage_node_deps.py` was changed in
https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2259834
to add line endings at the end of the package.json file
However, `npm run install-deps` was not rerun to add the line endings.
To prevent future CLs that add deps to include the line ending changes,
fix them in this CL.
R=mathias@chromium.org
Change-Id: Id4ee0003520c4aa0cb55494cdf64df57e31a86d7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2263952
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-06-24 12:59:49 +00:00
Tim van der Lippe
ef991621e0
Update Karma to 5.0.1
...
The breaking changes listed in
https://github.com/karma-runner/karma/releases/tag/v5.0.0 do not
apply to us.
This should also include support for Edgium per
https://github.com/karma-runner/karma/pull/3440
R=jacktfranklin@chromium.org
DISABLE_THIRD_PARTY_CHECK=Update karma
Bug: 1068145
Change-Id: I7567b2db14dbf59aaf9c091220157bf55d155810
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2144050
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
2020-04-15 08:03:17 +00:00
Paul Lewis
ea0d7566dc
[tests] Adds resemblejs and rimraf to node_modules
...
This CL adds deps that are necessary for comparing images in node, which
will be part of screenshot testing.
DISABLE_THIRD_PARTY_CHECK=Changes to deps require updating package-lock.json
Change-Id: I3b6266e7a8a6042cb14f1f6bfa40ca5a921592f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2050781
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
2020-02-12 13:59:13 +00:00
Tim van der Lippe
e4974ddc4c
Remove whitespace at the end of the package.json lines
...
json.dump appears to add extraneous spaces before newline characters. By
specifying the separators option, we can remove these whitespaces,
reducing the diff noise. Solution taken from
https://stackoverflow.com/questions/16311562/python-json-without-whitespaces
DISABLE_THIRD_PARTY_CHECK=Fix whitespace in node_modules
Change-Id: I26556e5053f19a9021ad41779319bdfe3f8c2b6c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2013154
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org >
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2020-01-22 15:17:25 +00:00
Paul Lewis
911c1b8a93
Updates node_modules
...
DISABLE_THIRD_PARTY_CHECK=Package needs updating with node_modules
Change-Id: I889f1b86c586e37307a3e13ad762aa56d1ece150
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1946468
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
2019-12-02 14:54:54 +00:00
Paul Lewis
75090cfd93
Reland "Updates node_modules and update script"
...
This is a reland of 4df552c652
Original change's description:
> Updates node_modules and update script
>
> Change-Id: I3fcf49bc416301a030d298cfc48c448bfeba4335
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1878808
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
> Reviewed-by: Yang Guo <yangguo@chromium.org >
> Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Change-Id: I97d1442c21420488fadde3f17f67cd4e3b959be6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880030
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
2019-10-25 13:19:06 +00:00
Lorne Mitchell
db3885dd80
Revert "Updates node_modules and update script"
...
This reverts commit 4df552c652 .
Reason for revert: Breaks esprima.
Original change's description:
> Updates node_modules and update script
>
> Change-Id: I3fcf49bc416301a030d298cfc48c448bfeba4335
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1878808
> Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
> Reviewed-by: Yang Guo <yangguo@chromium.org >
> Commit-Queue: Paul Lewis <aerotwist@chromium.org >
TBR=yangguo@chromium.org ,aerotwist@chromium.org ,tvanderlippe@chromium.org
Change-Id: Iad2bcdf98a486476715d1e829cdce450c5f218af
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1880098
Reviewed-by: Lorne Mitchell <lomitch@microsoft.com >
Commit-Queue: Lorne Mitchell <lomitch@microsoft.com >
2019-10-24 21:53:24 +00:00
Paul Lewis
4df552c652
Updates node_modules and update script
...
Change-Id: I3fcf49bc416301a030d298cfc48c448bfeba4335
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1878808
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org >
Reviewed-by: Yang Guo <yangguo@chromium.org >
Commit-Queue: Paul Lewis <aerotwist@chromium.org >
2019-10-24 14:48:04 +00:00
Yang Guo
4fd355cc40
Switch to new repository
2019-10-21 08:08:56 +02:00