1727 Commits
Author SHA1 Message Date
Nicola Corti 950f4a8e3f Bump vulnerable dev dependencies (#259) 2026-06-04 14:46:30 +01:00
Alex Hunt 8edd9be3b8 Clean up legacy rn_inspector entry point (#236) 2026-02-23 17:34:33 +00:00
Alex Hunt c85f7e933a Add FB only network event coverage notice (#228) 2025-12-16 11:36:22 +00:00
Alex Hunt d37d4264b8 Add experimental Perf Issues sub-panel (#217) 2025-11-06 18:01:59 +00:00
Ruslan Lesiutin 68cfd0ae84 feat: restore Performance landing page (#179) 2025-06-11 19:20:10 +01:00
Ruslan Lesiutin b73d2d5cbf Merge remote-tracking branch 'chromedevtools/chromium/7103' into repo-sync 2025-06-10 18:46:44 +01:00
Danil Somsikov 305ec9b563 [eslint] Fix strict tsc issues in the no-imperative-dom-api
Bug: 407085691
Change-Id: If07beab48274b5491e78576556434db3b3670495
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6414778
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
2025-03-31 08:59:28 -07:00
Danil Somsikov 2a7a29655f Add support for the rest of DOM API that has some usage in the codebase
Bug: 400353541
Change-Id: Ib9dd04e483a56d6f592ab1ec55bc391cfe164f56
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6411011
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2025-03-31 08:21:31 -07:00
Nikolay Vitkov 02606bd150 [eslint] Fix type assertions in custom Rules
Last batch, all other issue are on the `no-imperative-dom-api`

Bug: 407085691
Change-Id: I25c70e66d3749978faed3e602f3524e656171f16
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6416090
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
2025-03-31 07:09:10 -07:00
Nikolay Vitkov b00393cd97 [eslint] Fix type checking in custom EsLint rules
Either fix or suppress the errors for now

Bug: 407085691
Change-Id: I45c5bd4c3644571ddaebcba45914c209ebfa46f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415909
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2025-03-31 04:42:11 -07:00
Philip Pfaffe 3b548905b3 Partially revert crrev.com/c/6403238
Undo the test script changes, which broke the integrated checkout
workflow.

Bug: none
Change-Id: I1a29f605949265510c15725b1fd370b9ddd369ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415791
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
2025-03-31 03:09:07 -07:00
Danil Somsikov bbd3ef7096 Do not replace function parameters
Bug: 400353541
Change-Id: Ia77304e4cde91b216b9e4f90bfc2fba645c576ad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6409254
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2025-03-31 02:28:04 -07:00
Nikolay Vitkov 4eac8f8231 [eslint] Run type checking on custom rules
Currently behind a flag, as there are a lot of error.
This CL fixes some of them.

Bug: 407085691
Change-Id: I736472ff5a9d8c46e45a1ce89a42199774d9075f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6410471
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
2025-03-28 16:08:54 -07:00
Eric Leese 3dffede8b4 Change error path rewriting to work in full chromium checkout
Instead of calculating the path relative to the root of the
DevTools source tree, we now just remove "../../" to get the
relative path. This makes terminal links in vscode work in
full Chromium checkouts as well as devtools only checkouts.

Bug: None
Change-Id: I7bf410c353c5929bc9a0ef064449fa88f3bc1264
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405079
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
2025-03-28 07:14:10 -07:00
Benedikt Meurer 1022e32645 [npm] Allow to select (unstable) features with npm start.
This adds an option `--enable-unstable-features`, which now also turns
on multimodal support for Freestyler.

It also adds `--enable-features` and `--disable-features`, to allow more
fine-grained control over the exact feature set when necessary.

Fixed: 406941932
Change-Id: I7fcecbba833a2e0a66166890aa5af218ae2a8f7e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404318
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
2025-03-28 06:40:16 -07:00
Danil Somsikov d3465fc604 Replace top-level variables with a lit template
Bug: 400353541
Change-Id: Iab1b2a5b596ca7efe4922124253947419d41a2d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6407493
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2025-03-28 04:29:23 -07:00
Danil Somsikov f83ed266a9 Support external expressions as children of DOM fragments
Bug: 400353541
Change-Id: Id29c4fa82500507fcde454afe21de6e0cac9d1e8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405673
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2025-03-28 04:19:35 -07:00
Danil Somsikov 282ff278ad Only remove processed references to DOM fragments
Bug: 400353541
Change-Id: I9b93a605c7ae90705539a9293c4c9b1a9c998582
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405493
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2025-03-28 04:15:41 -07:00
Nikolay Vitkov 0fa4f1a476 Support all Chrome channels
Also add support for binary to point to executable of your
choice.

Bug: none
Change-Id: I122ad4fd117241c0c0106e2896e4fca602791958
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397059
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
2025-03-28 04:02:57 -07:00
Eric Leese 5f7e033b32 Fix npm run start and build scripts to work in full Chromium checkout
Also simplified code for test script to use devtools_paths.js

Bug: none
Change-Id: I699808267782f55150eabaacf9f86298ab3741d1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403238
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
2025-03-28 03:39:01 -07:00
Danil Somsikov 1675d4de76 An abstraction to track class members and distinguish the class they belong to
Bug: 400353541
Change-Id: I5f8c6577407299d2c91980b40e1cc93ca74ef043
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6403237
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2025-03-28 03:36:29 -07:00
Nikolay Vitkov 77ba8df5a3 [stylelint] Run test on Presubmit
We missed running this test and thus didn't catch some changes.

Bug: none
Change-Id: I4781780c6df539671bf3191b888fb8ca8ae436b2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6401394
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
2025-03-27 08:40:23 -07:00
Danil Somsikov c14787393e Reduce the number of casts to Node in preferTemplateLiterals
The problem is that ESLint defines a `parent` property on the estree Node. However specific estree Node subtypes, such as MemberExpression, have properties with estree Node subtypes, such as Identifier. The value in practice does have a `parent` property but this is not reflected in types.

This CL makes subrules unaware of the difference by exposing only the estree type to them and makes "core" libraries do the casting where necessary.

Bug: 400353541
Change-Id: I84db45bb35bbfb09f0d6bbde8f730d0f61f09c71
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6400633
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
2025-03-27 08:29:54 -07:00
Danil Somsikov 555cc4ba2b Extract "subrules" out of preferTemplateLiterals
Bug: 400353541
Change-Id: I068797f4ed37071a655b767f2d22e65b3dd8e72b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394682
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2025-03-27 08:25:05 -07:00
Nikolay Vitkov a175b3fd0d Use correct package for JavaScript natives
We never install the packages mentioned in that package json
but rely on the node_modules one, so removed.
Also update the packages and types

Bug: none
Change-Id: I0676c36621f39bff7408c5b910f5e4461f3f0158
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394480
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
2025-03-27 00:19:13 -07:00
Danil Somsikov 8c395f4474 Extract DOM fragment and AST libraries from preferTemplateLiterals rule
Bug: 400353541
Change-Id: Id52ceaa205579096a7b9d845bc3d521a3e7bb303
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396062
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2025-03-26 08:09:24 -07:00
Benedikt Meurer 9cfc7f9b9c [npm] Fix flag name for patching.
Bug: 393063467
Change-Id: Ib439eeb44079655ff4eadc7cb8102b4f89796a70
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396858
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
2025-03-26 05:15:51 -07:00
Nikolay Vitkov b9f5c81d58 Fix delete after copy
Bug: none
Change-Id: I278b7409a86756a16e93d0ac1751ff288a74bd77
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396857
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
2025-03-26 05:13:44 -07:00
Nikolay Vitkov c5db4754c2 Fix passing command to sub-script
https://github.com/yargs/yargs-parser?tab=readme-ov-file#strip-aliased

Bug: none
Change-Id: Ifb1a77de162ea6367ed76d7e2f6f4301d4c9890d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6396776
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Liviu Rau <liviurau@chromium.org>
2025-03-26 02:49:15 -07:00
Benedikt Meurer 173c953b91 [npm] Enable Auto-annotation labeling with npm start.
Bug: 393063467
Change-Id: I93ce321a5d62308ca48d040697501416b0d51790
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387111
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
2025-03-26 01:22:26 -07:00
Danil Somsikov dd60dc9c8a Support class properties as DOM fragments in the preferTemplateLiterals
Bug: 400353541
Change-Id: I0d0724f752d75a262da31deaf0662221cc8442d4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387921
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2025-03-25 14:06:41 -07:00
Danil Somsikov e4192641bb Support toolbar buttons in the preferTemplateLiterals
Tighten up types along the way.

Bug: 400353541
Change-Id: I23b644e7ebc2c19194486817ac98c39498ae1679
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387112
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2025-03-25 13:40:50 -07:00
Jack Franklin db52fce504 Define window.scheduler as non-optional
We used the wicg-task-scheduling types for `window.scheduler` but it
types it as optional - this is true for the general case but because we
are in Chrome we know it exists.

Unfortunately you cannot override the member from optional or not on
`Window`, so this CL removes the use of the
`@types/wicg-task-scheduling` package and reuses the code inline with
the extension to the `Window` interface making it always present.

Bug: none
Change-Id: I8399d3477f89f88e758ed31399c6256fcbd31de9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6393155
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
2025-03-25 12:28:00 -07:00
Nikolay Vitkov 953dde3e99 Fix script to pass only non included options
This should be more correct than deleting the object above as
under some cases yargs will include the aliases
https://github.com/yargs/yargs-parser?tab=readme-ov-file#strip-aliased

Bug: none
Change-Id: I8daa2a77e4b103c516a06aaf47cdded1bf3ca605
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387922
Reviewed-by: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
2025-03-25 10:55:41 -07:00
Paul Irish 2467bf84e8 Add more experiment flags to start script
Bug:none
Change-Id: Iec3215c9dd003b2eaa71b9062db045c473c1c9cd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6391995
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Irish <paulirish@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
2025-03-25 10:20:57 -07:00
Nikolay Vitkov 7099949310 [cleanup] Fix yargs type
Uses ParseSync else the result is Promise<T> | T.
This give IDE better types to work with.

Bug: none
Change-Id: I4d6014aeccd7428ec03bfde90c5d728c6182c1f7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387381
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
2025-03-25 06:21:49 -07:00
Benedikt Meurer 6b1b791739 [npm] Port npm start to JavaScript.
There's no point in writing this one script in Python. It's much better
to have it in JavaScript, just like `npm run build`.

Bug: 404192426
Change-Id: Ic19eaeb5b1d97ca750ae4253963b8434072d00fd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387801
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
2025-03-25 05:33:21 -07:00
Danil Somsikov 0832829c9c Support ToolbarInput and Adorner in the preferTemplateLiterals
Bug: 400353541
Change-Id: Ibb13f752eb215b3a01b8d0ad16ced080b98a68ac
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387797
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
2025-03-25 03:23:06 -07:00
Danil Somsikov 715d95eb9d Remove all the references to the processed DOM fragments
Bug: 400353541
Change-Id: Ie86c6e6e8810f34ed51fd22dd43f3e62fe540534
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6381538
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2025-03-24 03:47:24 -07:00
Benedikt Meurer ce8feaf8c6 [npm] Tweaks for the npm run build script.
This addresses late feedback in https://crrev.com/c/6367220.

Bug: 404192426
Change-Id: Ib514a6793c5a015021f2e6584cbe6ecbb71f5681
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6372905
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
2025-03-20 02:38:07 -07:00
Benedikt Meurer eabb1f3605 [npm] Add watch mode to npm run build and npm start.
This adds a new script for `npm run build`, which supports a `--watch`
argument, to automatically re-build whenever source files change. It
also hooks this up to `npm start`, which to automatically rebuild in
the background while Chrome is running.

Bug: 404192426
Change-Id: I90ee3ea81312bcfff9470ab8c62d38608e4e9a71
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367220
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2025-03-19 11:01:21 -07:00
Nikolay Vitkov efd6594929 [eslint] Support no used for NotTranslated
Bug: none
Change-Id: Ia1dec1d28bbbd63e2e192ff2d8f7556fc743ffd7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367218
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
2025-03-19 02:47:55 -07:00
Benedikt Meurer f395cc3765 [npm] Fix enabled/disabled features.
Pass only a single `--disable-features=` / `--enable-features` CLI
flag to Chrome binary.

Bug: 404192426
Change-Id: I858f87b41e9328cb0e3b9a5c7e16a0f57a73be53
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367217
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
2025-03-18 07:28:52 -07:00
Benedikt Meurer 06791eb495 [npm] Pass --use-mock-keychain on macOS in general.
Bug: 404192426
Change-Id: Ic04335232e4535e0d3c3419141db1d497d168580
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6366898
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
2025-03-18 07:28:52 -07:00
Benedikt Meurer 9ce8154fca [npm] Also enable DevToolsCssValueTracing by default.
Make `npm start` also enable the CSS Value Debugger by default.

Bug: 404192426, 396080529
Change-Id: I4eaea73ad0f25b498458eb4b000c1ab542457ca8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6366896
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
2025-03-18 05:42:29 -07:00
Benedikt Meurer 6b5dba97f0 [npm] Add initial npm start script.
This adds an initial version of the `npm start` script, which builds the
DevTools front-end and launches either CfT or Chrome Canary binary with
the custom DevTools front-end, passing appropriate flags to enable or
disable certain experimental features.

Bug: 404192426
Change-Id: Ia7bcbf8cb5f93bcf455e59964a488480e8ec1fff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367034
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
2025-03-18 03:34:36 -07:00
Benedikt Meurer 5307d4dd45 [unified-css] Rename cssContent to cssText.
The name `cssText` is more aligned with the Web Platform APIs (both
`CSSRule` and `CSSStyleDeclaration` have a `cssText` property).
Otherwise this change is neutral.

Bug: 391381439
Change-Id: Iae65bd4cc0fe96078cdd8c2847573551fd3f80f9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6357196
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
2025-03-17 05:45:06 -07:00
Nikolay Vitkov afc8a8cec8 [eslint] Include ExtensionAPI
This makes all current files under DevTools lintable with EsLint
by default.
Also remove the rule for default export for configs.

Bug: 397260638
Change-Id: I3b380ad4351eb53c65207b242d7f8221e7788e48
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6357121
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
2025-03-17 03:48:33 -07:00
Alex Rudenko feb21f6438 Add assertScreenshot to unit tests
This CL adds a custom browser wrapper that starts the browser using
Puppeteer instead of letting Karma to directly start the browser. The
wrapper also exposes a binding that allows the test code to capture a
screenshot of the test DOM. The helper reuses existing screenshot
assertions and reports the result back to the test code.

This CL also adds args to improve stability of screenshots and
fixes the font to be a Roboto font loaded from Google Fonts.

To test: `npm run test --
front_end/panels/ai_assistance/components/UserActionRow.test.ts`

Bug: 401489541
Change-Id: I04889d0f0caa5c468fd35f98c66b0e6ac393de18
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6330749
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
2025-03-14 11:32:55 -07:00
Danil Somsikov 469b8180fc Support createChild and toolbar items in the preferTemplateLiterals rule
Bug: 400353541
Change-Id: I27a18bb4829336dfaba4dcdd697c84d6591fb60e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6357270
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
2025-03-14 06:01:58 -07:00