zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-28 21:24:26 +08:00
Code Issues Packages Projects Releases Wiki Activity
25,771 Commits 43 Branches 79 Tags
main
Commit Graph
12 Commits
Author SHA1 Message Date
Benedikt Meurer 6e53408a5e [cleanup] Shorten LitHtml to Lit (lit-html to lit). 
There's no benefit in the long version and the underlying package is
also just called `lit` these days, and `LitHtml` is really annoying
on the eyes.

Bug: 301364727
Change-Id: I38d90b8332af2c792063e318d3e0b11121501df1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6211898
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2025-01-29 03:09:15 -08:00
Philip Pfaffe 9f9b531a71 Revert "Update esbuild" 
This reverts commit 556d230a0e.

Reason for revert: Breaks the build on windows.

Original change's description:
> Update esbuild
>
> DISABLE_THIRD_PARTY_CHECK=DEPS needs to be updated together
>
> Bug: none
> Change-Id: I6af5660c313d5d998b320f688a36a1f3de5beb03
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5025093
> Commit-Queue: Randolf Jung <jrandolf@chromium.org>
> Reviewed-by: Danil Somsikov <dsv@chromium.org>

Bug: none
Change-Id: I331613611d0b8bd56a96a5eff50e452213f6f14b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5033272
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
 2023-11-16 07:34:14 +00:00
Randolf Jung 556d230a0e Update esbuild 
DISABLE_THIRD_PARTY_CHECK=DEPS needs to be updated together

Bug: none
Change-Id: I6af5660c313d5d998b320f688a36a1f3de5beb03
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5025093
Commit-Queue: Randolf Jung <jrandolf@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2023-11-15 15:27:58 +00:00
Alex Rudenko 67e3886186 Roll puppeteer-core 
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

In case of failures or errors, reach out to someone from config/owner/RECORDER_OWNERS.

Roll created at https://cr-buildbucket.appspot.com/build/8766374352283153121

R=devtools-waterfall-sheriff-onduty@grotations.appspotmail.com

Bug: none
Change-Id: Ib753eb31a685c2588a7b539dacf69fdc894311ce
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4968502
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2023-10-24 08:46:40 +00:00
Alex Rudenko 6e435700ad Fix rollup plugin for DevTools 
devtools-plugin for rollup should not treat code inside
Puppeteer folders as DevTools entrypoints. Only the `frontend/third_party/puppeteer/puppeteer.js` and `frontend/third_party/puppeteer-replay/puppeteer-replay.js` should be treated as entry points.

Fixed: 1470202
Change-Id: Ic9c6344f163bc23f5b1d04c936c0446bb07c4d0e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4765265
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2023-08-09 10:26:55 +00:00
Alex Rudenko 6a4b64d675 Remove special treatment for puppeteer by rollup 
And by accident the special treatment for puppeteer-replay.

Fixed: 1455094
Change-Id: Ia80fbd62e5389133e7c38717365d772a94fb5585
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4637784
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2023-06-23 04:32:02 +00:00
Jack Franklin df0e9312aa Add ESLint rule for commented out import statements 
This is something I've been caught out with a few times when moving code
round, and thought it would be a good ESLint rule. I've enabled the rule
as part of this CL as we currently have few issues that need fixes.

Bug: none
Change-Id: I72c6aad3e4258fbda280e062f98823a068c6bfc8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4076326
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-12-05 11:24:51 +00:00
Takuto Ikuta d0e51ea796 add test for esbuild plugin 
Fixed: 1293772
Change-Id: I0c12c27c66fcab491fac6869f282b3059e16ee9b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3439239
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-02-08 13:52:42 +00:00
Takuto Ikuta 6621f46716 devtools_plugin: mark non-relative import as external 
This is to prevent error like
https://ci.chromium.org/ui/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel_fastbuild/95/overview

Bug: 1278663
Cq-Include-Trybots: luci.devtools-frontend.try:devtools_frontend_linux_blink_light_rel_fastbuild,devtools_frontend_linux_dbg_fastbuild
Change-Id: I51ee2b52b88b9b52edf47edfd94c4a771540fd89
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3430082
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-02-02 13:21:01 +00:00
Takuto Ikuta 7f5fd554eb fix build errors 
This fixes build error when we disable typescript and when we build
puppeteer.

Bug: 1293019
Change-Id: Ia927344166f543846e6fc3351f1621cd03593a49
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3430599
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-02-02 10:45:11 +00:00
Takuto Ikuta 2548a6cd6c introduce devtools_fast_bundle build config 
Proposal: http://go/devtools-fast-bundle

This CL introduces build flag switching bundler from rollup.js to
esbuild by
* adding esbuild to npm without downloading binary packages
* making devtools_plugin for rollup.js re-usable to esbuild

On 24C/48T Z840 Linux machine, this shows following performance
difference by using
```
devtools_skip_typecheck = true
is_debug = false
```
as base build config.

esbuild (devtools_fast_bundle = true)
$ time ninja -C out/Default/
...
real    0m21.174s
user    2m47.513s
sys     0m38.549s

rollup.js (devtools_fast_bundle = false)
$ time ninja -C out/Default/
...
real    1m28.286s
user    30m19.220s
sys     5m36.392s


So esbuild is 3.2x faster and use only 9.6% of machine resouce
(user + sys) compared to rollup.js.

refs:
* https://esbuild.github.io/plugins/#on-resolve
* https://rollupjs.org/guide/en/#resolveid

Bug: 1278663
Cq-Include-Trybots: luci.devtools-frontend.try:devtools_frontend_linux_blink_light_rel_fastbuild,devtools_frontend_linux_dbg_fastbuild
Change-Id: If6b2e774f48091b0fe9c959e7ed1ed9bc2b0847c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3401984
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2022-02-01 12:49:12 +00:00
Takuto Ikuta 9b3b13af90 extract devtools_plugin from rollup.config.js 
This is extracted from https://crrev.com/c/3401984/30

I'll use this from esbuild too.

Bug: 1278663
DISABLE_THIRD_PARTY_CHECK=parent CL has change for npm
Change-Id: Ia5f3410a2cb59e349e7a76250fbe35b354462a4c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3419384
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2022-01-27 10:44:05 +00:00