zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-28 13:13:37 +08:00
Code Issues Packages Projects Releases Wiki Activity
25,771 Commits 43 Branches 79 Tags
main
Commit Graph
14 Commits
Author SHA1 Message Date
Nikolay Vitkov 9554d8f023 Unify code in check_experiment 
Use the same setting we use in EsLint for consistency.

Bug: none
Change-Id: Ic56b3bb5bc85fbf37925423130e8dbb3d1ce11df
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6148455
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-08 01:43:11 -08:00
Nikolay Vitkov b4e8dc7ac2 Update EsLint v9 
Bug: none
Change-Id: Iebcc53c0f70a51242f22e4df167cd588b08cefcd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6140633
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-07 05:41:31 -08:00
Nikolay Vitkov 8962d5956d Fix check_experiments.js import 
After the @typescript/eslint update their resolution does not include
CJS so the import fails. The files are still have CJS support
so import the file directly.

Bug: none
Change-Id: I84ad3164fc1046b616d99fe0c196f93f2523fcfd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6059977
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2024-11-29 15:53:12 +00:00
Benedikt Meurer b7d85047a3 [eslint] Migrate front_end/core/ to CONSTANT_CASE enum values. 
Note that this only migrates the code, but doesn't yet change the
ESLint configuration, since other folders are still pending.

Bug: 361720369
Change-Id: Ia248c58a67680ff2ed8f81af0e0c04d6b6de1c7c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5807576
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2024-08-23 14:18:27 +00:00
Jack Franklin 2bbb561a5b Update metrics enum PRESUBMIT check with right path 
The enums file has been moved in Chromium.

Bug: none
Change-Id: I63bd0699076defabdbf13c2dbb58f47d496b7414
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5554256
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-05-22 11:32:21 +00:00
Wolfgang Beyer b2da5bb358 Allow removal of entries from UMA enums 
`recordEnumeratedHistogram()` needs both the actual bucket and the total
number of buckets. The total number of buckets was previously determined
by `Object.keys(someMap).length`. This prevented us from ever removing
keys from `someMap` since its length would change.
By explicitly adding a `LastValidEnumPosition` we can now safely remove
keys.

Bug: 1278403
Change-Id: Ib256fc2cf54123f596aa9c5525cce2aabe28bec0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3329541
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-12-21 08:42:54 +00:00
Jan Scheffler d5bf879558 [Underscore Migration] Migrate entrypoints 
This patch is part of the underscore migration that adds the private
keyword to all properties that start with an underscore and removes the
underscore.

Bug:chromium:1207342
Change-Id: Iec114859ae3f46457bafa2d823e11add202c6eb2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3077887
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Auto-Submit: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-07 15:52:16 +00:00
Kriti Sapra 56daf78ddb Updated no-multiple-empty-lines to only have 1 as max 
DISABLE_THIRD_PARTY_CHECK=updated linting formatting
Bug: 1106746
Change-Id: I371bca95b7cf1e8b7eaa4f9e7c3860af4eedee3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3057042
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-28 14:10:15 +00:00
Sigurd Schneider 6fdf2da9db Teach check_experiments.js to recognize Root.Runtime.ExperimentName 
This modifies check_experiments.js such that it recognizes the use
of Root.Runtime.ExperimentName enum members, e.g. it allows to
write

Root.Runtime.experiments.register(
  Root.Runtime.ExperimentName.LOCALIZED_DEVTOOLS,
  'Enable localized DevTools');

Bug: chromium:1226082
Change-Id: Iac0bd394a739562df7e7ce0b06f0a8ede3fdfbd7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3003255
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2021-07-05 14:31:23 +00:00
Christy Chen ab9a44d9de Fix devtools experiment UserMetrics and presubmit check 
There are missing entries for DevTools experiment in the UserMetrics emun, and the presubmit check has been broken so the issue didnt get caught.
This CL fix the DevTools experiment userMetrics and presubmit check

Bug: 1226082
Change-Id: I881a846b3d988746fb96ffd91eb16789198c2e3a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3002943
Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
 2021-07-05 13:19:15 +00:00
Jan Scheffler b4eb22da3a [JSDOC2TS]: Migrate main 
Bug: chromium:1158760
Change-Id: Ibe9b0fe480794bb788253a3b9902d4cc42a5ca2e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2789347
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-04-05 21:15:07 +00:00
Tim van der Lippe e0247311ec Move host to core/host 
R=aerotwist@chromium.org

No-Presubmit: true
Bug: 1187573
Change-Id: I836c98bbd5b05f4595e28cedfaf957a6f47c7807
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2799755
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-01 15:00:23 +00:00
Jan Scheffler 9aca8c7402 [JSDOC2TS]: Migrate host 
Bug: chromium:1158760
Change-Id: I86a4477d44617adac598f107755fbd3db49d7bf2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2718291
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-02-26 17:18:55 +00:00
Brandon Goddard 331043706c Add Presubmit for Devtools Experiment Telemetry 
This CL adds a new Presubmit check that ensures that all devtools
experiemnts that are registered in MainImpl.js are also placed
in the UserMetrics.js file so that they have telemetry registered.

Explainer:
https://docs.google.com/document/d/1pcvN11C4onSXqOE0dTjUUHodMj55bRVl_5_e3kMg_rs/edit?ts=5f2329dc#heading=h.ezo3vjjctj8w

Bug: 1107636
Change-Id: If7ca22ef641b037717b808b7c57cc57c6f502536
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2341797
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Reviewed-by: Kalon Hinds <kahinds@microsoft.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Patrick Brosset <patrick.brosset@microsoft.com>
 2020-08-13 16:10:50 +00:00