Liviu Rau
bec18e2c02
Replace deprecated gsutil cli with gcloud storage
...
Bug: 380123202
Change-Id: I4d957387c063b57b635f1e6f9ad36dd2304cca5f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6038616
Reviewed-by: Mathias Bynens <mathias@chromium.org >
Commit-Queue: Liviu Rau <liviurau@chromium.org >
2024-11-21 12:28:54 +00:00
Liviu Rau
1c8dc082a7
Update builder name prefix for screenshot collectors
...
Bug: 376446538
Change-Id: I64d31b001f74e74950bdd0bfc5e4be72e7d5a83d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5986493
Auto-Submit: Liviu Rau <liviurau@google.com >
Commit-Queue: Mathias Bynens <mathias@chromium.org >
Reviewed-by: Alexander Schulze <alexschulze@chromium.org >
Reviewed-by: Mathias Bynens <mathias@chromium.org >
2024-11-04 11:24:16 +00:00
Connor Clark
2b55515d9d
Add some additional help to snapshot documentation
...
Bug: None
Change-Id: I65d0b95e7de7c70b17523830a7eff8c1245d583d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5846631
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2024-09-10 09:11:47 +00:00
Liviu Rau
f23899815e
Add group membership hint on update failure
...
Bug: none
Change-Id: I19d08f69d9b9f84d25b91e5dc1ba3d27104a505f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4720846
Reviewed-by: Michael Achenbach <machenbach@chromium.org >
Reviewed-by: Paul Irish <paulirish@chromium.org >
Commit-Queue: Liviu Rau <liviurau@google.com >
2023-07-26 16:36:04 +00:00
Liviu Rau
08ca9d229e
Give feedback when try-results cannot be loaded
...
Bug: none
Change-Id: Ia4c627d9f572d3df239821b2e28518150026eead
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4714555
Reviewed-by: Michael Achenbach <machenbach@chromium.org >
Commit-Queue: Liviu Rau <liviurau@google.com >
Commit-Queue: Liviu Rau <liviurau@chromium.org >
2023-07-26 13:24:37 +00:00
Liviu Rau
d1a36c004c
Start old CLI tool deprecation
...
We start deprecating the old 2 steps process (trigger & update) for screenshot testing golden updates. The old CLI tool is still a dependency for other projects.
Bug: chromium:1413723
Change-Id: Idcd0e415c6b41ab6591d49bd5e26123c5ca22ce3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4314919
Reviewed-by: Michael Achenbach <machenbach@chromium.org >
Reviewed-by: Andres Olivares <andoli@chromium.org >
Commit-Queue: Liviu Rau <liviurau@google.com >
2023-03-09 19:12:52 +00:00
Liviu Rau
3925b7d736
Collect screenshots from mac
...
Bug: chromium:1413723
Change-Id: Ib3e68936bc41023f0169e5c315b66a4c54325683
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4315942
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Liviu Rau <liviurau@google.com >
Reviewed-by: Andres Olivares <andoli@chromium.org >
2023-03-08 11:39:22 +00:00
Liviu Rau
005e716799
Update screenshots directly from failing CQ builders
...
This improves the process of updating screenshots in Interaction tests by collecting the screenshots already generated when devtools_frontend* builders fail.
Deprecates scripts/tools/update_goldens.py (v1) which need to be kept here until we update other impacted projects.
Bug: chromium:1413723
Change-Id: I37ba934d37d2287f105c76fe5bca5018078a9031
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4286875
Commit-Queue: Liviu Rau <liviurau@google.com >
Reviewed-by: Andres Olivares <andoli@chromium.org >
2023-03-06 16:48:38 +00:00
Liviu Rau
5d2ee7226b
Support custom platform names
...
The platform name `win64` is tight to infra/config branch and hard to modify to `win`, as it is by default in the other projects. As a followup cleanup I will reverse the default to `win64` and update the other projects.
Bug: chromium:1413723
Change-Id: I5359b74c224d00e1bf05d7f694af4669bdd63984
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4282201
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Commit-Queue: Liviu Rau <liviurau@chromium.org >
2023-02-23 09:29:58 +00:00
Liviu Rau
a9e61a6ed5
Add support for project configurations
...
Bug: chromium:1413723
Change-Id: Ie18a59e9794a7d13a024ec9076d51f5432b2ef39
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4236123
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
Reviewed-by: Simon Zünd <szuend@chromium.org >
Commit-Queue: Liviu Rau <liviurau@google.com >
2023-02-09 12:07:33 +00:00
Liviu Rau
3fd21361b6
Add script to update screenshots
...
This prepares the necessary tools for updating screenshots on multiple platforms at once. The actual screenshot builders will be added later on infra.
Bug: chromium:1413723
Change-Id: Iad17ff1a3e26064dc8831343c9a71acac21742c3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4228073
Commit-Queue: Liviu Rau <liviurau@google.com >
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org >
2023-02-08 09:28:26 +00:00