zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-29 16:57:00 +08:00
Code Issues Packages Projects Releases Wiki Activity
25,771 Commits 43 Branches 79 Tags
main
Commit Graph
25771 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
Connor Clark 95644fe8c2 [RPP] Fix some bugs related to using the wrong time units 
- The insights sorting criteria incorrectly used wrong time units for
  field data
- #getFilmStripFrame incorrectly compared times in different units

These bugs were discovered by a custom eslint rule that has not yet
landed[1].

[1] https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395588

Bug: 406518012
Change-Id: I7a19181bf1362f200bb9038dca6fff06b16555a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6417905
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
 2025-03-31 13:32:19 -07:00
Connor Clark cf5c715e76 [RPP] Add Legacy JavaScript insight component 
- Shown by default (not in experimental)
- Adds `scriptRef` helper for rendering a script
- Sorts results by estimated savings in the model
- Filter out results less than 5kb in the model

Fixed: 394373852
Change-Id: I7558f9dba01238b1af80a6d8d500b900bd03b964
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6410451
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
 2025-03-31 12:00:41 -07:00
Danil Somsikov 305ec9b563 [eslint] Fix strict tsc issues in the no-imperative-dom-api 
Bug: 407085691
Change-Id: If07beab48274b5491e78576556434db3b3670495
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6414778
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-31 08:59:28 -07:00
Sofia Emelianova 9491d58622 What's new in DevTools, Chrome 136 
Bug:407504567
Change-Id: I620923eed0b9df358e7c70a4fa27d6b0527e9008
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415614
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Sofia Emelianova <semel@chromium.org>
 2025-03-31 08:55:00 -07:00
Alina Varkki 0e2f9673ab [RPP][AI] Add a condition to the Auto Labelling Agent prompt 
It  sometimes returns multi-line responses, let's try to prevent it.

Bug:None
Change-Id: I2d1044c3f230cb31377441b9bb9a063aa179e5ca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6414390
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Alina Varkki <alinavarkki@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-31 08:53:57 -07:00
Wolfgang Beyer c77a395915 [Patch agent] Success states for "patch export" and "apply to workspace" 
Fixed: 406700639
Change-Id: I0a3c5e58dc9ce081e6ffcd59ecc71ac801aaec2a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415615
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2025-03-31 08:31:40 -07:00
Danil Somsikov 2a7a29655f Add support for the rest of DOM API that has some usage in the codebase 
Bug: 400353541
Change-Id: Ib9dd04e483a56d6f592ab1ec55bc391cfe164f56
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6411011
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2025-03-31 08:21:31 -07:00
Nikolay Vitkov d0b39ca8fe [AI Assistance] Don't hide changes 
When the Patch Widget rerenders the changes may be empty.
We should respect the current status.

Bug: none
Change-Id: I229d9c54f21415511b336a03d88d68efb9a35706
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6416093
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-31 07:18:54 -07:00
Jack Franklin 6258ac7044 RPP: simplify / reduce frontend validity checks in ignore list 
The validation checks in this component were a bit eager and showed a
lot when the user interacted. Or it was easy to put some invalid input
in, but then click away and it was unclear if the message should stay or
go (it stayed).

In the attached bug Paul made this suggestion:

> get rid of the user-facing validity (and ensure we dont mess up ignorelist settings by committing an empty rule)

I like this, and therefore this CL does that. It still checks the regex
is valid before storing it, because else the ignore list errors, but now
we don't show anything to the user.

I think this is OK because it's fairly obvious an empty regex is not
valid. The only edge case is if you've typed a complex regex in and not
closed everything properly, so we might want to consider that, but I
don't think many users use it in this way so for now let's make our
validation less noisy.

Bug: 394325644
Change-Id: Ib16a62cbb17a4bb3852f6f7f2516ad7e85f7a1bc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415795
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2025-03-31 07:12:27 -07:00
Alina Varkki 4d6568db9a [RPP][AI] Aria label to button trigerring tooltip instead of the tooltip container 
Bug: 406543373
Change-Id: I0a17442063f61d9a62b5b652bba747389d472e5f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6416092
Auto-Submit: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-31 07:11:23 -07:00
Jack Franklin feae0f9f1f RPP: announce to screen readers that the label is generating 
This CL ensures that the loading status is announced to screen readers.

It also fixed a bug where we were announcing selected events too eagerly
even when the selection hadn't changed, and the same with empty labels.
I turned on voice over and got very overwhelmed!

Fixed: 407047308
Change-Id: I63abd5a16ab8147bb185ad2d853595b267a09ff5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415788
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-31 07:10:13 -07:00
Nikolay Vitkov 02606bd150 [eslint] Fix type assertions in custom Rules 
Last batch, all other issue are on the `no-imperative-dom-api`

Bug: 407085691
Change-Id: I25c70e66d3749978faed3e602f3524e656171f16
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6416090
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-31 07:09:10 -07:00
Kim-Anh Tran c698f451d9 Reduce paddings for style and box editors 
Screenshots: https://imgur.com/a/0BPDtY9
Bug: none
Change-Id: I558c579060d84a17b2ff39c7a7a66aef4bd91f13
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415800
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2025-03-31 07:08:06 -07:00
devtools-ci-autoroll-builder 8f5d339bb7 Roll browser-protocol 
This roll requires a manual review. See http://go/reviewed-rolls for guidance.

In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.

Roll created at https://cr-buildbucket.appspot.com/build/8718882819977049313

R=devtools-waterfall-sheriff-onduty@rotations.google.com

Bug: none
Change-Id: Idd3d0b1de31dc784a35eac2b497aa3c74af8a563
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6414692
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2025-03-31 06:29:56 -07:00
Philip Pfaffe 53fc6d324c [elements] align slot adorner 
Fixed: 402089780
Change-Id: Ic6378a332a9aca6f00ad78faf0d0c0767b1dd767
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6407775
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
 2025-03-31 06:07:28 -07:00
Jack Franklin 61e38de4a0 Increase 10s timeout on tracing tests to 15s 
We have seen more timeouts recently, which is probably in part because
the functionality of the engine has been extended. Let's see if a higher
limit increases stability on the bots.

Bug: none
Change-Id: I8eade981a07865bd4d2f0d3a18c7cd88218c20c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415797
Reviewed-by: Eric Leese <leese@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-31 06:01:23 -07:00
Jack Franklin 664654157c RPP: ensure labels being edited get drawn above others 
Which makes it easier to edit them in the event that other labels are
overlapping.

Fixed: 406938980
Change-Id: I30f7d7232ac2ecc3e9f5a213f007bd53cf0bef3f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415908
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
 2025-03-31 05:39:34 -07:00
devtools-ci-autoroll-builder f53ea2f095 Update Chrome (for Testing) PIN 
Chromium pin updated to 136.0.7101.0

Roll created at https://cr-buildbucket.appspot.com/build/8718882819977049313

Bug: none
Change-Id: If6b62baf238367a967eb1a5e4ac4089c90e2a0cd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415510
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-03-31 05:38:30 -07:00
Nikolay Vitkov 3c6f9de893 [AI Assistance] Don't hide PatchWidget while applying changes 
We try to see if any changes need to be applied but
we already stashed them thus on update the PatchWidget
disappears.

Fixed: 406217587
Change-Id: I87528f082e713b43076363cdd71d430dd6ea8631
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415793
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Ergün Erdoğmuş <ergunsh@chromium.org>
 2025-03-31 04:48:20 -07:00
Nikolay Vitkov b00393cd97 [eslint] Fix type checking in custom EsLint rules 
Either fix or suppress the errors for now

Bug: 407085691
Change-Id: I45c5bd4c3644571ddaebcba45914c209ebfa46f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415909
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2025-03-31 04:42:11 -07:00
Nikolay Vitkov 935df521b1 [AI Assistance] Ignore changes that don't have a diff 
Updates the lineDiff to return empty array of changes
when both the original and the changed text are
equal.
Then check in the CombinedDiffView whether there were
actual diff before rendering.

Bug: 406699819
Change-Id: I3f637f22b42a0eb4853b9897c2ea08fc632f79ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404313
Reviewed-by: Ergün Erdoğmuş <ergunsh@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-31 04:00:29 -07:00
Kim-Anh Tran 6c5d77f8f4 [GM3Restyling] Update filter bar in experiments settings 
This updates the filter bar to the updated filter in the experiments
settings.

Before: https://i.imgur.com/oniQF3F.png
After: https://i.imgur.com/V6L8Rtp.png
Fixed: 407480170
Change-Id: Ieae203a2f3576bfa3696d1e08f7b99b60c459735
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415792
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
 2025-03-31 03:54:59 -07:00
Kim-Anh Tran 36943d1130 [GM3Restyling] Hide layers information if nothing can be shown 
This changes the layers panel to only show the empty state if nothing
can be shown yet.

Before: https://i.imgur.com/jC0gqBa.png
After: https://i.imgur.com/VvoIxie.png
Fixed: 400383914
Change-Id: I0ea7d8438d86dc8a000b09582739368a4ac9b171
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415488
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Kim-Anh Tran <kimanh@chromium.org>
 2025-03-31 03:28:07 -07:00
Philip Pfaffe 3b548905b3 Partially revert crrev.com/c/6403238 
Undo the test script changes, which broke the integrated checkout
workflow.

Bug: none
Change-Id: I1a29f605949265510c15725b1fd370b9ddd369ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415791
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-31 03:09:07 -07:00
Nikolay Vitkov f591172202 [eslint] Fix extension-api 
We need to proved the tsconfig so EsLint can lint correctly

Bug: none
Change-Id: If2ee68deef76e51e4a9096e417e9c6bb01ba7e67
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6407772
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-31 02:36:29 -07:00
Danil Somsikov bbd3ef7096 Do not replace function parameters 
Bug: 400353541
Change-Id: Ia77304e4cde91b216b9e4f90bfc2fba645c576ad
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6409254
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
 2025-03-31 02:28:04 -07:00
Jack Franklin b2557558ff RPP: fix mistaken instruction in Perf prompt 
Bug: none
Change-Id: I8100315ff8b5eeb9b150ab32d3f963371688a864
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415790
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2025-03-31 02:20:58 -07:00
Philip Pfaffe 79c3b12631 [css value tracing] cap the maximum width of the tooltip 
See bug for screenshot.

Fixed: 404535761
Change-Id: I9d94779eb01374d377a2f6d78ed68afc711cbbc9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6415768
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2025-03-31 01:47:01 -07:00
Jack Franklin 78d3973605 Reland "RPP: create new annotations AI agent" 
This is a reland of commit 9995b96203

Original change's description:
> RPP: create new annotations AI agent
>
> Required mostly for metrics so we can track its usage accurately rather
> than bundled in with the existing "Ask AI" integration.
>
> (Googlers: see the attached bug for a link to the backend CL, this needs
> to land first before this can land).
>
> Bug: 406795908
> Change-Id: Ibf0fff042f72a6e622e9d9d9e87769a71feb23af
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6407494
> Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
> Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>

Bug: 406795908
Change-Id: I0c3bc41014a1f1f120fbb4f68f701eafcb4216a0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405318
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-31 01:29:30 -07:00
Philip Pfaffe cdcca1ad4e Check file access on the host side of the extension api 
Fixed: 406034851
Change-Id: I125bfa572ba9e987569e8524da99de84db83d389
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6401296
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2025-03-31 00:40:50 -07:00
devtools-ci-autoroll-builder 4091180134 Update Chrome (for Testing) PIN 
Chromium pin updated to 136.0.7100.0

Roll created at https://cr-buildbucket.appspot.com/build/8718916799054713345

Bug: none
Change-Id: Ib19d46b065d15337c133c9cb494c214e7cc2f92b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6414968
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-03-31 00:24:22 -07:00
devtools-ci-autoroll-builder bad7f7c656 Update DevTools DEPS (trusted) 
Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/ac0421e..6f35929

Roll created at https://cr-buildbucket.appspot.com/build/8718916799054713345

Bug: none
Change-Id: I082bdf9a7486eb31196b3bc0ea9942be83be8f0b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6414948
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-03-31 00:23:18 -07:00
devtools-ci-autoroll-builder e9da51da2e Update Chrome (for Testing) PIN 
Chromium pin updated to 136.0.7096.0

Roll created at https://cr-buildbucket.appspot.com/build/8719097992811764721

Bug: none
Change-Id: If18ae8511e3f7cc7a7dffb07580b16c9ef6db748
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6410853
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-03-28 20:46:08 -07:00
devtools-ci-autoroll-builder 70dd637939 Update DevTools DEPS (trusted) 
Rolling buildtools: https://chromium.googlesource.com/chromium/src/buildtools/+log/244e7cf..ac0421e

Roll created at https://cr-buildbucket.appspot.com/build/8719097992811764721

Bug: none
Change-Id: Ie648e640d53007439852e425c770d7b798f07325
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6411136
Commit-Queue: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Bot-Commit: Devtools Autoroller <devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
 2025-03-28 20:40:09 -07:00
Adam Raine f2ba87197e Revert "[NetworkRequestDetails] Fix initiator row styling" 
This reverts commit 6333612700.

Reason for revert: Obsolete with https://crrev.com/6404821

Original change's description:
> [NetworkRequestDetails] Fix initiator row styling
>
> The initiator row was separated because the link can be very long. This
> CL groups the initiator with everything else but applies `ellipis` to
> contain the size.
>
> Bug: 406864076
> Change-Id: I7088b64f7b3154e457a46f515b35908102c7cd5e
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404927
> Auto-Submit: Adam Raine <asraine@chromium.org>
> Commit-Queue: Adam Raine <asraine@chromium.org>
> Reviewed-by: Paul Irish <paulirish@chromium.org>

Bug: 406864076
Change-Id: I9fa423e170455f4235bb5feb7c77a35691f6b3a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6410873
Commit-Queue: Adam Raine <asraine@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2025-03-28 18:13:45 -07:00
Nikolay Vitkov 4eac8f8231 [eslint] Run type checking on custom rules 
Currently behind a flag, as there are a lot of error.
This CL fixes some of them.

Bug: 407085691
Change-Id: I736472ff5a9d8c46e45a1ce89a42199774d9075f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6410471
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-28 16:08:54 -07:00
Connor Clark 1bbd38cc8d [RPP] Remove table-layout: fixed from Table component 
Bug: none
Change-Id: I29719ca6bbf4924c1a3066c34e76405f0e5d8abc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6410711
Reviewed-by: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Paul Irish <paulirish@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
 2025-03-28 15:25:11 -07:00
Connor Clark 39b158a8da [RPP] Remove Duplicated JavaScript insight from experimental 
Also configures the "initialView" when opening the treemap from this
insight card.

Fixed: 394373632
Change-Id: Ic0ed412193a337d7d68e031d14a664516bb8d6ee
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6408022
Commit-Queue: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2025-03-28 14:00:27 -07:00
Adam Raine 42fe2c4d98 [LiveMetrics] Render field data phase column on the right 
Fixed: 406826928
Change-Id: I7bd68732e5db30c7e55f2c2b4eb446d0c677c93c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404928
Commit-Queue: Paul Irish <paulirish@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
Auto-Submit: Adam Raine <asraine@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2025-03-28 13:15:54 -07:00
Adam Raine 6333612700 [NetworkRequestDetails] Fix initiator row styling 
The initiator row was separated because the link can be very long. This
CL groups the initiator with everything else but applies `ellipis` to
contain the size.

Bug: 406864076
Change-Id: I7088b64f7b3154e457a46f515b35908102c7cd5e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404927
Auto-Submit: Adam Raine <asraine@chromium.org>
Commit-Queue: Adam Raine <asraine@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2025-03-28 12:50:32 -07:00
Andrés Olivares 89847dd997 [RPP] Sort sample events after running SamplesIntegrator 
With https://crrev.com/c/6394268 events created for samples with a trace
id were added after the ones created for all the obtained samples. As a
consequence, the containing array ended up unsorted. This can cause
an error  where an unordered event is unexpectedly found when
building the tree hierarchy in the trace engine.

To fix this, the containing array is ordered at the end of the
buildProfileCalls, which contains the main implementation of the
SamplesIntegrator.

Bug: none
Change-Id: I9e26e7890b91f5be1510e4fbc7c29e577aed4ed0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6408651
Commit-Queue: Paul Irish <paulirish@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2025-03-28 11:57:01 -07:00
Connor Clark 61c9086ba8 [RPP] Fix type failure in insights AI getSuggestions 
Back-to-back CLs with indirect impact on each other caused this.

Bug: 405925760
Change-Id: I44a00e678ec71a87717b57c70416d8f53f13909b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6409451
Commit-Queue: Paul Irish <paulirish@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
 2025-03-28 11:55:58 -07:00
Jack Franklin ed77ee4244 RPP: add default suggestions for each Insight 
Bug: 405925760
Change-Id: I12b70506b58bf684fc55162d6be99df4012b6a41
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6397060
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
 2025-03-28 10:31:21 -07:00
Connor Clark c029e350fc [RPP] Add Legacy JavaScript insight model 
Bug: 394373852
Change-Id: I97b0ee1af0b025dddfc691a11137c84f6c28c135
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6405705
Commit-Queue: Paul Irish <paulirish@chromium.org>
Auto-Submit: Connor Clark <cjamcl@chromium.org>
Reviewed-by: Paul Irish <paulirish@chromium.org>
 2025-03-28 10:09:03 -07:00
Jack Franklin b12601e996 RPP: skip layout shift cluster unit test 
Bug: 406981939
Change-Id: I0033bff92181ed9541b0dc05e1bedad07c5e2bd2
No-Tree-Checks: True
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6408652
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
 2025-03-28 09:48:18 -07:00
Jack Franklin d8698b71e3 Annotations: new prompt to reduce "responsiveness" 
The mention of responsiveness in the prompt really made the AI use
it...a lot! This version seems better. By asking the AI to not focus so
much on "user visible impact" we reduce how much it talks about "user
interaction responsiveness" which really isn't helpful.

Bug: 400357484
Change-Id: Id9f594b3af34bd733e6a3fe61c21aeef0cb1a1ed
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6408872
Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
Reviewed-by: Alina Varkki <alinavarkki@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-28 09:44:33 -07:00
Andrés Olivares cee49a9b62 [RPP] Fix network request details layout 
Margins and spacing between items was off.
Before: https://screenshot.googleplex.com/3Rz759PHWKxbFqp
After: https://screenshot.googleplex.com/3xTGaLkE2E5dqco

Fixed: 406990013
Change-Id: I5f7ec7f1bb2ad5b5a2fab0acf5fc6eae3edfedb8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6404821
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2025-03-28 09:27:48 -07:00
Philip Pfaffe cb1e1ed98e Automatically reopen tooltips on rerender 
When a tooltip gets detached without being closed and then gets replaced by a tooltip with the same id, the new tooltip is automatically reopend once connected. This addresses an issue in the styles tab where property values are rerendered entirely on changes.

Fixed: 404720158
Change-Id: I9e0f40f42898343faf112dc92127463fc7cab7f8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387117
Auto-Submit: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2025-03-28 08:28:05 -07:00
Mike West 0a15a0f000 Refactor SRIMessageSignatureIssue. 
This CL doesn't introduce any behavioral change, but simply reworks the
implementation of `SRIMessageSignatureIssue` for clarity and concision.

Bug: 381044049
Change-Id: I726aa4e5f9249f1d2f1992f64c1b9821cf3ac8c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6395499
Commit-Queue: Mike West <mkwst@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2025-03-28 08:13:19 -07:00
Kim-Anh Tran 7de602ae97 [GM3Restyling] Update swatch popover helper and CSSPlugin 
Both open the color picker in different environments (GlassPane, and Codemirror Tooltips).

Screenshots: https://imgur.com/a/js6wjcU
Bug: 406706611
Change-Id: I14e78949c6246dada6897604e9d1f5c6169d398e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6400616
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2025-03-28 07:56:51 -07:00