zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-28 21:24:26 +08:00
Code Issues Packages Projects Releases Wiki Activity
25,758 Commits 43 Branches 79 Tags
screencasting
Commit Graph
97 Commits
Author SHA1 Message Date
Nikolay Vitkov a175b3fd0d Use correct package for JavaScript natives 
We never install the packages mentioned in that package json
but rely on the node_modules one, so removed.
Also update the packages and types

Bug: none
Change-Id: I0676c36621f39bff7408c5b910f5e4461f3f0158
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394480
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-27 00:19:13 -07:00
Jack Franklin db52fce504 Define window.scheduler as non-optional 
We used the wicg-task-scheduling types for `window.scheduler` but it
types it as optional - this is true for the general case but because we
are in Chrome we know it exists.

Unfortunately you cannot override the member from optional or not on
`Window`, so this CL removes the use of the
`@types/wicg-task-scheduling` package and reuses the code inline with
the extension to the `Window` interface making it always present.

Bug: none
Change-Id: I8399d3477f89f88e758ed31399c6256fcbd31de9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6393155
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
 2025-03-25 12:28:00 -07:00
Simon Zündand 877957906c [deps] Update esbuild to 0.25.1 
Drive-by: Update "@types/estree" to a newer version.

Co-Authored-By: liviurau@chromium.org
Fixed: 404582010
Change-Id: I17d7657f485860dc84c8ea256aadccf61daae83c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382042
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2025-03-24 04:11:41 -07:00
Nikolay Vitkov 17794eed93 Update TypeScript to v5.7.3 
https://devblogs.microsoft.com/typescript/announcing-typescript-5-7/
Some changes to the ArrayBuffer types was needed. And TypeScript started
"panicking" if we included a bundle multiple times, so updated the
BUILD.gn files.

Bug: none
Change-Id: I3277c191c83ea773ef88765ff89a4f4103b5757c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6210862
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-30 03:58:33 -08:00
Nikolay Vitkov efcab21c86 [deps] Removed unused deps 
I can't seem to find a place where these packages are used.
If they needed to be overridden due to bug of other issue
the `overrides` should be used in the feature.

Bug: none
Change-Id: I3af062cae4856ee9cef3b4ee3211df3c48ccf5cf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6198370
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-27 23:04:17 -08:00
Jack Franklin dadb165d35 Add @types/yargs 
Useful for scripts that we write.

Bug: none
Change-Id: I2732c6af54cf0575aec338e4c5512231a1bc1df1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6172330
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2025-01-13 21:07:49 -08:00
Nikolay Vitkov b4e8dc7ac2 Update EsLint v9 
Bug: none
Change-Id: Iebcc53c0f70a51242f22e4df167cd588b08cefcd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6140633
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-07 05:41:31 -08:00
Nikolay Vitkov 937f463144 Revert "[eslint] Prefer TypeScript interface over type aliases." 
This reverts commit af6c6337aa.

Reason for revert: The latest version of EsLint v9 does not work with the plugin added here, also the rule does more that just change shape objects from type to interface.

Original change's description:
> [eslint] Prefer TypeScript `interface` over type aliases.
>
> We have a mix of `type` and `interface` usage throughout our codebase,
> that is sometimes difficult to follow and reason about. We should follow
> the suggestion from the TypeScript PM and use `interface` consistently
> where possible. This leads to better type display in errors and makes
> our codebase easier to read (b/c consistency).
>
> This CL adds the `etc/prefer-interface` ESLint rule to accomplish this.
>
> Fixed: 387237537
> Change-Id: Idd6775094ba94b8397f626191788437f6b156dc6
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6135001
> Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
> Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>

Bug: 387237537
Change-Id: I6ecf18bfdaa4ad9efb17f0801def528035f9e703
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6140555
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-03 09:42:50 -08:00
Nikolay Vitkov 2a1b3b34b1 Update StyleLint to v16 
Stylelint v16 deprecated CJS so I moved our lint script to ESM,
and fixed all the deprecation warning.
The only place I needed to silence them were tests,
as we import CJS there.

Bug: none
Change-Id: Iae4d2df76c855a9738b774a2d035f22509770215
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6138610
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-03 02:57:06 -08:00
Nikolay Vitkov 924fc2c153 [deps] Update StyleLint to v15.11 
Info at https://stylelint.io/migration-guide/to-15
Our custom rule needed to be updated to reflect a small change.
All changes are separated into patches for ease of review.
More work is need for a v16 migration so separating it to reduce
risks of breaking.

Bug: none
Change-Id: I616829fba25b06bf8febe8390074046ad582f531
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6126881
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-03 01:57:35 -08:00
Benedikt Meurer af6c6337aa [eslint] Prefer TypeScript interface over type aliases. 
We have a mix of `type` and `interface` usage throughout our codebase,
that is sometimes difficult to follow and reason about. We should follow
the suggestion from the TypeScript PM and use `interface` consistently
where possible. This leads to better type display in errors and makes
our codebase easier to read (b/c consistency).

This CL adds the `etc/prefer-interface` ESLint rule to accomplish this.

Fixed: 387237537
Change-Id: Idd6775094ba94b8397f626191788437f6b156dc6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6135001
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-02 03:42:22 -08:00
Jayson Chen 2e999d1495 Add wicg scheduling API definition 
window.scheduler.postTask and .yield are originally not available in the devtools-frontend codebase. This CL added the type definition so Typescript recognizes the API

Bug: 383240467
Change-Id: I4a395aca4e3956ceaa08053dcded5017f0ed10b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6081857
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Jayson Chen <jaysonchen@microsoft.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-12-10 20:09:10 +00:00
Nikolay Vitkov d562298ebb [deps] Update types to match the installed Node.JS 
The node version in third_party is v22.11.0.

Bug: none
Change-Id: Ib6d22b314f88c6ae997af3a4e20ae72f1862e7c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6063481
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-12-03 05:09:47 +00:00
Nikolay Vitkov 65f45cc921 [deps] Update TypeScript EsLint parser 
Update the @typescript-eslint - eslint-plugin and parser to v7.18.0
cia incremental patches.
This is the last version before breaking changes need to start be applied to the infrastructure.
Needed to update EsLint to v8.56.0 as required by the above major v7.
Only one new error was uncovered in test file and fixed.

No-Presubmit: true
Bug: none
Change-Id: I4e4fe265b82deeb49786c5bf3e154dac8fcfecbd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6054130
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2024-11-29 13:15:35 +00:00
Simon Zünd abf0cd1847 [deps] Update rollup to 4.24.3 (and update plugins) 
Since we have the major version jump, we needed to update quite
a few things to make this work:

  1. rollup4 ships with native binaries. We can't check them into
     our node_modules for all platforms. Luckily they also ship a
     a wasm version. This requires us to adjust the 'binary' path
     to `node_modules/@rollup/wasm-node/dist/bin/rollup` instead.

  2. rollup4 is more strict when it comes to ES modules vs
     CommonJS. We adjust this by renaming the rollup config files.

  3. Some plugins got deprecated so we had to replace them with
     the newer versions (source maps and terser).

Bug: None
Change-Id: If13d590c8185db6ad85b3992d0a869111909dc8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5999255
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-11-07 05:25:54 +00:00
Simon Zünd 479b92bc6b [deps] Update @types/node to 20.11.0 to match our node version 
This fixes the TS compilation errors when generating the protocol
definition files.

R=pfaffe@chromium.org

Bug: None
Change-Id: Ibcb4554ea34f69f8f30072540928444e7690e4f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5920710
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2024-10-10 10:44:55 +00:00
Alex Rudenko cb4b9688d4 Remove coverage 
Infra change: https://chromium-review.googlesource.com/c/chromium/tools/build/+/5833493

Bug: 364237269
Change-Id: Iebc847a3a3644b5538771b94128943da588910a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5830445
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-05 11:38:42 +00:00
Simon Zünd b69e8ddcaa [deps] Upgrade TypeScript to 5.5.4 
TypeScript 5.5.4 fixes the crashing tsserver when using vscode with
the devtools-frontend repo.

We have to pin the "ws" package to 8.18.0 manually. Normally
'npm dedupe' would handle this, but 'dedupe' wants to pull in the
'debug' package thats only 4 days old.

We can remove the 'override' once 'npm dedupe' runs successfully
again.

R=alexrudenko@chromium.org

Bug: None
Change-Id: I3e8ad9b5b5f999f9f60758313167230724e8dddc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5752041
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
 2024-07-31 07:55:16 +00:00
Alex Rudenko 537c631ab8 Bump vulnerable deps 
Drive-by: fixing the presubmit

Fixed: 343248814
Change-Id: I3ec86edbe2ce3d6e7b6a310827b5b5fb0b09c626
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5720898
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-07-19 07:12:02 +00:00
Simon Zünd 2e2368a63f [deps] Update TypeScript to 5.5.3 
The CL also updates @types/karma-chai-sinon to 0.1.20. This is
required to fix the global `sinon` namespace object that our test
code assumes to be there.

We also need to allow access of UMD globals without import in test
code, otherwise we'd have to add an import of sinon to each
individual test file.

DISABLE_THIRD_PARTY_CHECK=Requires a ts_library change for test modules
R=alexrudenko@chromium.org

Bug: None
Change-Id: I449be485a9e3fe03ccc68fad44ee3573a98b3413
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5702080
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-07-12 11:07:54 +00:00
Simon Zünd a578545017 [deps] Update 'sinon' and '@types/sinon' 
R=alexrudenko@chromium.org

Bug: None
Change-Id: I1f8dcaa62c6d5e90f37c34db1fd8fb2ed1a7369c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5666839
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
 2024-07-02 06:22:54 +00:00
Simon Zünd aebbf4f106 [deps] Update 'eslint-plugin-jsdoc' to 46.10.1 
This silences a warning because our Node engine is newer then the
package expects.

There are newer versions of the plugin by now, but the transitive
dependencies are younger than 1 week so the audit mirror blocks them.
46.10.1 seems like it was stable for a couple months so we use that.

R=alexrudenko@chromium.org

Bug: None
Change-Id: Icf1c1276852e55dcad97d2ea2eeb6a8d7a9d82ae
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5660063
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-06-27 09:26:18 +00:00
Benedikt Meurer 6472fee2f1 [chai] Update @types/chai to v4.3.15 
The changes to use `asserts` in chai type definitions were just accepted
upstream and published with @types/chai 4.3.15, so remove our custom
patching and update to the latest upstream version of the type
definitions.

Fixed: 333520272, 334719469
Change-Id: If8ccb6112cd58567975dfc23a25ecfdfa7d51752
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5509475
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-05-02 14:23:21 +00:00
Benedikt Meurer 11565081e8 [chai] Improve types for assert functions. 
This CL adds `asserts` to various `assert` functions provided by Chai,
and massages some parts of the code base to still typecheck correctly.
This is in preparation for removing a bunch of homegrown helpers, but
also as proof-of-concept for upstreaming these to DefinitelyTyped
once battle-tested in DevTools.

The following functions now have `asserts`:

- `assert()`
- `assert.isOk()` and `assert.ok()`
- `assert.isTrue()` and `assert.isNotTrue()`
- `assert.isFalse()` and `assert.isNotFalse()`
- `assert.isNull()` and `assert.isNotNull()`
- `assert.exists()` and `assert.notExists()`
- `assert.isDefined()` and `assert.isUndefined()`
- `assert.instanceOf()`

Bug: 333520272
Change-Id: I852edd4fc579b0d9f9b6a347502d64ea3d12dc46
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5444833
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-04-12 07:32:43 +00:00
Alex Rudenko f7ea7ab986 Update pptr to 21.4.1 
DISABLE_THIRD_PARTY_CHECK=roll of Puppeteer and removal of the Puppeteer flag.

Fixed: 1484476
Change-Id: I98425afe43878948983dba94bda362aa6681d603
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4968458
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2023-10-24 10:11:59 +00:00
Vidal Guillermo Diazleal Ortega 5151f41f3f npm package security updates (babel/traverse) 
I ran the following script to update @babel/traverse from 7.15.4 to 7.23.2 packages
to address the security issue tracked in crbug.com/1493744:

`npm run install-deps audit fix --audit-level=critical`

Bug: 1493744
Change-Id: Ie3fa0dc0527b6fa9e4b7906ee2034b95900c6033
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4953413
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Vidal Diazleal <vidorteg@microsoft.com>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2023-10-20 17:29:27 +00:00
Simon Zünd 3502cdcf8c [build] Remove 'minify-html-template-literals' plugin from node_modules 
DISABLE_THIRD_PARTY_CHECK=Removing a npm package.

R=alexrudenko@chromium.org

Bug: 1213034
Change-Id: I1546dfe1a1c74d44d02cae35e0334c8463790233
Fixed: 1471374
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4762688
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2023-08-09 08:54:29 +00:00
Philip Pfaffe ead3f105e7 node_modules: Add emscripten types and rollup node plugin 
Includes a rerun of install-deps which updates some unrelated packages.

Bug: 1454724
Change-Id: I29651314ac40c985f42a3fb2bce73ece20b7236a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4632539
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Kshitij Pancholi <panchok@google.com>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2023-07-28 09:28:45 +00:00
Simon Zünd cba2ac9e1c [deps] Update 'terser' to 5.19.1 
The update contains a bug fix that improves the quality for DevTools
release source maps.

The update also seems to stop minifiying certain names in the overlay
bundle so we had to slightly bump the limit.

  * Old size: 69660
  * New size: 71295

DISABLE_THIRD_PARTY_CHECK=Bump overlay size limit
R=alexrudenko@chromium.org

Bug: 1459146
Change-Id: I3036787bbb3ba8d28669b9aaab9c29c5f5581e55
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4693881
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2023-07-18 09:44:36 +00:00
Guangyue Xu 2314ddcbfe npm pakage security updates 
Ran the following script to update engine.io and socket.io-parser
package from 4.2.1 to 4.2.4 to address the security issue tracked
in crbug.com/1464405:

`npm run install-deps audit fix --audit-level=critical`

Bug:1464405
Change-Id: I40f54d721642ad124b81a2df1307ab1d2dfecbdc
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4682214
Commit-Queue: Guangyue Xu <guangyue.xu@microsoft.com>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2023-07-13 17:37:54 +00:00
Jack Franklin b6e869c1ff Update @typescript-eslint/* deps 
Following the update to TS 5.1.3, updating the ESLint plugins too.
Includes a couple of small fixes where more floating promises are now
detected.

DISABLE_THIRD_PARTY_CHECK=source file changes to fix issues

Bug: none
Change-Id: Ia4b346ded7a63abed3dfc08db5f7b15baf6a40c8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4584591
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
 2023-06-02 14:33:49 +00:00
Jack Franklin 98d9d46d28 Upgrade TypeScript to 5.1.3 
DISABLE_THIRD_PARTY_CHECK=TS upgrade and source code changes.

Bug: none
Change-Id: I21244e75a24e8e323ef40c696254e552f3956e6d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4583215
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2023-06-02 13:05:48 +00:00
Guangyue Xu bffee6084d npm pakage security updates 
Ran the following script to update engine.io and socket.io packages
to address the security issue tracked in crbug.com/1447254:

`npm run install-deps audit fix --audit-level=critical`

Bug: 1447254
Change-Id: Ia617b76882259bdab5259855029353701ff0bc1e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4551951
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Brandon Walderman <brwalder@microsoft.com>
Commit-Queue: Guangyue Xu <guangyue.xu@microsoft.com>
 2023-05-23 16:50:12 +00:00
Simon Zünd 0cc29a70d1 [deps] Update @types/codemirror for tsc 5.0 compatibility 
DISABLE_THIRD_PARTY_CHECK=We need to remove a @ts-expect-error in the
formatter

Bug: 1412307
Change-Id: Ic130c0db4f879ec4e53b5ea31ba034aa880779a2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4358158
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
 2023-03-22 06:31:16 +00:00
Brandon Walderman f64f77e749 Update node_modules to address security vulnerabilities 
This change addresses 2 issues in uglify-js and socket.io-parser. See
reports below for details:
- https://www.mend.io/vulnerability-database/CVE-2022-37598
- https://nvd.nist.gov/vuln/detail/CVE-2022-2421

The socket.io-parser issue was addressed by running npm audit via the
following command:

`npm run install-deps audit fix --audit-level=critical`

Since audit didn't recognize the uglify-js issue, I updated uglify-js
to version 3.13.10 "manually" by adding an entry in
manage_node_deps.py. running install-deps to update package-lock.json
and then removing the entry from manage_node_deps.py.

Bug: None
Change-Id: I29238b14773a1b94b973886b0bb700f50e45cfa9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4061168
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Brandon Walderman <brwalder@microsoft.com>
 2022-11-30 15:19:46 +00:00
Jack Franklin 2703ce56ba Upgrade @typescript-eslint packages 
After upgrading TS to 4.9, we need to upgrade these packages so they can
parse the new TS features (such as the `satisfies` keyword).

Bug: 1392651
Change-Id: I85466727628e37b5b63c0f1e45484324fd05b8fb
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4046522
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2022-11-28 11:31:39 +00:00
Nancy Li 6403713b4d Update types 
- Update `@types/node` packages to the latest version

Bug: none
Change-Id: I0caaa8c1a889e0ce593da6458563e305101e44af
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4048320
Auto-Submit: Nancy Li <nancyly@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
 2022-11-22 16:47:17 +00:00
Jack Franklin 3710bbf933 Upgrade eslint to 8.13.0 
Bug: none
Change-Id: I438ea7b8e1c69e85939b1ed60578aa10fe87b821
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3598874
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-04-21 10:20:38 +00:00
Brandon Walderman 110d5929d1 Upgrade minimist to 1.2.6 
This CL updates minimist to 1.2.6 to fix a critical security
vulnerability: https://nvd.nist.gov/vuln/detail/CVE-2021-44906

The fix was made by running:
`npm run install-deps audit fix --audit-level=critical`

Bug: none
Change-Id: I51103b525d9969e03000d55af86cebdabc7e0366
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3591079
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Brandon Walderman <brwalder@microsoft.com>
 2022-04-20 06:33:45 +00:00
Simon Zünd 7a5852438e Update @typescript-eslint/plugin to 5.20.0 
Our current @typescript-eslint version does not support TypeScript 4.6.
The update fixes that.

.eslintrc.js changes taken from https://crrev.com/c/3583292.

DISABLE_THIRD_PARTY_CHECK="Update contains a breaking change. Requires
updated config"

Bug: None
Change-Id: Id1d9f4f073f068ec95af6632a6d061adbee63cca
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3592593
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2022-04-19 07:12:14 +00:00
Johan Bay 986acd0681 Add dependencies for js signature generation to top-level node_modules 
This change makes it easier to run the script from directly
`roll_py.deps` without having to fetch the dependencies first. This also
makes it easier to track which dependencies our tooling have.

Change-Id: I1ce55074ee6a1fffa6f2a2f05a56d0d74b4aca90
Bug: 1255619
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3431346
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
 2022-02-02 17:33:42 +00:00
Takuto Ikuta 2e08a7d1fc npm: add esbuild 
This is extracted from https://crrev.com/c/3401984/30

Bug: 1278663
Change-Id: Icddd2af2ce157cc3877bcdc84653fb639f44c083
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3419383
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-27 10:33:05 +00:00
Tim van der Lippe 0150c2a641 Update build packages 
Updates TypeScript and @types packages, as well as Rollup + terser.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Id8c4d360be486a703d51a937302c894de3a44fe9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372930
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 14:33:50 +00:00
Tim van der Lippe d3425b95d0 Update unit test NPM dependencies 
Updates Karma, Mocha and Sinon.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Ia93cdafc646e4d3277e7ce869a7a8b5e66a13f0d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372928
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 14:26:50 +00:00
Tim van der Lippe c581bb8fad Update marked to 4.0.4 
DISABLE_THIRD_PARTY_CHECK=Have to update both @types/marked and marked
R=szuend@chromium.org

Bug: none
Change-Id: I1030c1d11f329bbb4b28566921efff0fd439b6de
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3297844
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2021-11-24 06:28:40 +00:00
Tim van der Lippe 16b822804c Reland "Reland "Update stylelint to 14.0.1"" 
This reverts commit 2b4a9df2d9.

Reason for revert: subsequent presubmit uploads should be fixed now.

Original change's description:
> Revert "Reland "Update stylelint to 14.0.1""
>
> This reverts commit f2ea2c940d.
>
> Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview
>
> Original change's description:
> > Reland "Update stylelint to 14.0.1"
> >
> > This reverts commit 6c0f161c95.
> >
> > Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed
> >
> > Original change's description:
> > > Revert "Update stylelint to 14.0.1"
> > >
> > > This reverts commit 1e08ee816b.
> > >
> > > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview
> > >
> > > Original change's description:
> > > > Update stylelint to 14.0.1
> > > >
> > > > This also upgrades PostCSS to 8.3.11.
> > > >
> > > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> > > > R=​szuend@chromium.org
> > > >
> > > > Bug: none
> > > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> > > > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > >
> > > Bug: none
> > > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
> > > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > > Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
> > > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
> >
> > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> >
> > Bug: none
> > Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
>
> Bug: none
> Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222
> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration

Bug: none
Change-Id: I609941d48b46bfcf454b03dcc75a76d460fbe674
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264223
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-08 14:47:39 +00:00
Tim van der Lippe 2b4a9df2d9 Revert "Reland "Update stylelint to 14.0.1"" 
This reverts commit f2ea2c940d.

Reason for revert: https://ci.chromium.org/ui/p/devtools-frontend/builders/try/dtf_presubmit_linux/b8831129368825517985/overview

Original change's description:
> Reland "Update stylelint to 14.0.1"
>
> This reverts commit 6c0f161c95.
>
> Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed
>
> Original change's description:
> > Revert "Update stylelint to 14.0.1"
> >
> > This reverts commit 1e08ee816b.
> >
> > Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview
> >
> > Original change's description:
> > > Update stylelint to 14.0.1
> > >
> > > This also upgrades PostCSS to 8.3.11.
> > >
> > > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> > > R=​szuend@chromium.org
> > >
> > > Bug: none
> > > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> > > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> > > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> >
> > Bug: none
> > Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
> > No-Presubmit: true
> > No-Tree-Checks: true
> > No-Try: true
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
> > Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> > Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
> > Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
>
> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
>
> Bug: none
> Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>

Bug: none
Change-Id: Idc6c9f5cc1e225c752799461eb0344e94b4ad1e5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264222
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2021-11-08 12:59:31 +00:00
Tim van der Lippe f2ea2c940d Reland "Update stylelint to 14.0.1" 
This reverts commit 6c0f161c95.

Reason for revert: the prerequisite CL (https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259703) has landed

Original change's description:
> Revert "Update stylelint to 14.0.1"
>
> This reverts commit 1e08ee816b.
>
> Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview
>
> Original change's description:
> > Update stylelint to 14.0.1
> >
> > This also upgrades PostCSS to 8.3.11.
> >
> > DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> > R=​szuend@chromium.org
> >
> > Bug: none
> > Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> > Reviewed-by: Simon Zünd <szuend@chromium.org>
> > Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
>
> Bug: none
> Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>

DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration

Bug: none
Change-Id: If132a67ee4253d27114caedd66c5ee61c774a6c7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3264206
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-08 11:24:28 +00:00
Alex Rudenko 6c0f161c95 Revert "Update stylelint to 14.0.1" 
This reverts commit 1e08ee816b.

Reason for revert: tree is closed due to errors https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Linux/8169/overview

Original change's description:
> Update stylelint to 14.0.1
>
> This also upgrades PostCSS to 8.3.11.
>
> DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
> R=​szuend@chromium.org
>
> Bug: none
> Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
> Reviewed-by: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>

Bug: none
Change-Id: Icb1c02b41dbccc3b4fc5760f5dd0b78eca078b61
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3263399
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Owners-Override: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2021-11-05 06:32:31 +00:00
Tim van der Lippe 1e08ee816b Update stylelint to 14.0.1 
This also upgrades PostCSS to 8.3.11.

DISABLE_THIRD_PARTY_CHECK=Updating Stylelint configuration
R=szuend@chromium.org

Bug: none
Change-Id: I606540b03509d7c6e73f3d490327cd4174e03d31
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3259541
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-11-04 20:20:31 +00:00