zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-28 21:24:26 +08:00
Code Issues Packages Projects Releases Wiki Activity
25,758 Commits 43 Branches 79 Tags
screencasting
Commit Graph
199 Commits
Author SHA1 Message Date
Nikolay Vitkov a175b3fd0d Use correct package for JavaScript natives 
We never install the packages mentioned in that package json
but rely on the node_modules one, so removed.
Also update the packages and types

Bug: none
Change-Id: I0676c36621f39bff7408c5b910f5e4461f3f0158
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6394480
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-27 00:19:13 -07:00
Jack Franklin db52fce504 Define window.scheduler as non-optional 
We used the wicg-task-scheduling types for `window.scheduler` but it
types it as optional - this is true for the general case but because we
are in Chrome we know it exists.

Unfortunately you cannot override the member from optional or not on
`Window`, so this CL removes the use of the
`@types/wicg-task-scheduling` package and reuses the code inline with
the extension to the `Window` interface making it always present.

Bug: none
Change-Id: I8399d3477f89f88e758ed31399c6256fcbd31de9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6393155
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Connor Clark <cjamcl@chromium.org>
Commit-Queue: Connor Clark <cjamcl@chromium.org>
 2025-03-25 12:28:00 -07:00
Benedikt Meurer 6b1b791739 [npm] Port npm start to JavaScript. 
There's no point in writing this one script in Python. It's much better
to have it in JavaScript, just like `npm run build`.

Bug: 404192426
Change-Id: Ic19eaeb5b1d97ca750ae4253963b8434072d00fd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6387801
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-25 05:33:21 -07:00
Simon Zündand 877957906c [deps] Update esbuild to 0.25.1 
Drive-by: Update "@types/estree" to a newer version.

Co-Authored-By: liviurau@chromium.org
Fixed: 404582010
Change-Id: I17d7657f485860dc84c8ea256aadccf61daae83c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6382042
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2025-03-24 04:11:41 -07:00
Benedikt Meurer eabb1f3605 [npm] Add watch mode to npm run build and npm start. 
This adds a new script for `npm run build`, which supports a `--watch`
argument, to automatically re-build whenever source files change. It
also hooks this up to `npm start`, which to automatically rebuild in
the background while Chrome is running.

Bug: 404192426
Change-Id: I90ee3ea81312bcfff9470ab8c62d38608e4e9a71
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367220
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
 2025-03-19 11:01:21 -07:00
Benedikt Meurer a0b49423bf [cleanup] Remove npm scripts that no longer exist. 
Bug: 404192426
Change-Id: I85d52a876651600b8043392b822076a0251a4ef8
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367275
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2025-03-18 05:39:18 -07:00
Benedikt Meurer 6b5dba97f0 [npm] Add initial npm start script. 
This adds an initial version of the `npm start` script, which builds the
DevTools front-end and launches either CfT or Chrome Canary binary with
the custom DevTools front-end, passing appropriate flags to enable or
disable certain experimental features.

Bug: 404192426
Change-Id: Ia7bcbf8cb5f93bcf455e59964a488480e8ec1fff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6367034
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2025-03-18 03:34:36 -07:00
Nikolay Vitkov bb976f7b9e Update node_module dependecies 
Add one more deps "@typescript-eslint/utils" to top level to be used in our own custom rules (also needed override if I didn't).

Bug: none
Change-Id: I130415d1ec5f096ca51200df3eb688dadd963d0f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6343232
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-03-12 06:49:46 -07:00
Benedikt Meurer 96faaf281e [project_settings] Generate devtools.json for DevTools-on-DevTools. 
This generates project settings for DevTools-on-DevTools, using a v5
UUID with a pre-defined namespace, to ensure that builds remain
deterministic.

Fixed: 399502654
Bug: 395562934, 395037775
Change-Id: Ifa7c217eb9e5d0558b99c0e46085330bad9f8888
Doc: https://goo.gle/devtools-json-design
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6304926
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2025-02-27 01:57:31 -08:00
Alex Rudenko 5ce89562d1 Update sinon to 19.0.2 
Bug: none
Change-Id: I480dc4cbcdcbda70c74c597dd406e2f86285b840
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6268784
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-02-14 05:25:17 -08:00
Nikolay Vitkov f1e3bd8d99 [eslint] Introduce eslint-plugin-eslint-plugin 
Bug: none
Change-Id: I733528d699da8aa749d19d249e7752895c5a8195
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6259394
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-02-13 04:23:19 -08:00
Nikolay Vitkov 103719879d [deps] Update CSS related deps 
Bug: none
Change-Id: I9389834400d90beed8df9f28356720031abe9ef1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6225902
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-02-04 02:17:29 -08:00
Adam Raine ac00a7dd4d Upgrade puppeteer-core to 24.1.1 
Bug: None
Change-Id: Idae5199b6b729f58885632ef980850da0da5144e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6217301
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2025-01-30 22:07:46 -08:00
Nikolay Vitkov 17794eed93 Update TypeScript to v5.7.3 
https://devblogs.microsoft.com/typescript/announcing-typescript-5-7/
Some changes to the ArrayBuffer types was needed. And TypeScript started
"panicking" if we included a bundle multiple times, so updated the
BUILD.gn files.

Bug: none
Change-Id: I3277c191c83ea773ef88765ff89a4f4103b5757c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6210862
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-30 03:58:33 -08:00
Nikolay Vitkov efcab21c86 [deps] Removed unused deps 
I can't seem to find a place where these packages are used.
If they needed to be overridden due to bug of other issue
the `overrides` should be used in the feature.

Bug: none
Change-Id: I3af062cae4856ee9cef3b4ee3211df3c48ccf5cf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6198370
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-27 23:04:17 -08:00
Nikolay Vitkov 99a9104ae9 [test] Add scripts folder to runner 
Prototype for run.ts to include all scripts files as well.
This will make it easier to just run a single command.

Bug: none
Change-Id: I0e7e623a777330d320a003a0099518aeeed88821
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6187112
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-23 07:10:53 -08:00
Alex Rudenko fd8226a0f0 Upgrade puppeteer to v24 
Bug: none
Change-Id: I37f9e905ec2c9f1c6f988f18dc27995e2e56eaf1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6179962
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2025-01-17 02:05:32 -08:00
Jack Franklin dadb165d35 Add @types/yargs 
Useful for scripts that we write.

Bug: none
Change-Id: I2732c6af54cf0575aec338e4c5512231a1bc1df1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6172330
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2025-01-13 21:07:49 -08:00
Nikolay Vitkov b4e8dc7ac2 Update EsLint v9 
Bug: none
Change-Id: Iebcc53c0f70a51242f22e4df167cd588b08cefcd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6140633
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-07 05:41:31 -08:00
Nikolay Vitkov 937f463144 Revert "[eslint] Prefer TypeScript interface over type aliases." 
This reverts commit af6c6337aa.

Reason for revert: The latest version of EsLint v9 does not work with the plugin added here, also the rule does more that just change shape objects from type to interface.

Original change's description:
> [eslint] Prefer TypeScript `interface` over type aliases.
>
> We have a mix of `type` and `interface` usage throughout our codebase,
> that is sometimes difficult to follow and reason about. We should follow
> the suggestion from the TypeScript PM and use `interface` consistently
> where possible. This leads to better type display in errors and makes
> our codebase easier to read (b/c consistency).
>
> This CL adds the `etc/prefer-interface` ESLint rule to accomplish this.
>
> Fixed: 387237537
> Change-Id: Idd6775094ba94b8397f626191788437f6b156dc6
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6135001
> Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
> Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>

Bug: 387237537
Change-Id: I6ecf18bfdaa4ad9efb17f0801def528035f9e703
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6140555
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-03 09:42:50 -08:00
Nikolay Vitkov da53bfa011 [deps] Remove overrides 
We no longer need them as we can install the latest versions safely

Fixed: 381848229
Change-Id: I5cac9d3423e45c6dc8d1440b1c6001f1d06edbde
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6133025
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-03 04:57:30 -08:00
Nikolay Vitkov 2a1b3b34b1 Update StyleLint to v16 
Stylelint v16 deprecated CJS so I moved our lint script to ESM,
and fixed all the deprecation warning.
The only place I needed to silence them were tests,
as we import CJS there.

Bug: none
Change-Id: Iae4d2df76c855a9738b774a2d035f22509770215
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6138610
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-03 02:57:06 -08:00
Nikolay Vitkov 924fc2c153 [deps] Update StyleLint to v15.11 
Info at https://stylelint.io/migration-guide/to-15
Our custom rule needed to be updated to reflect a small change.
All changes are separated into patches for ease of review.
More work is need for a v16 migration so separating it to reduce
risks of breaking.

Bug: none
Change-Id: I616829fba25b06bf8febe8390074046ad582f531
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6126881
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-03 01:57:35 -08:00
Nikolay Vitkov 55adf677d3 [eslint] Migrate to Flat config 
A necessary step to adopt EsLint v9.
More can be read at - https://eslint.org/blog/2022/08/new-config-system-part-2/
In short - only a single configuration is used a cross the whole repo.

Bug: none
Change-Id: I74cd613fba25b94cee92e4b7c1b525471bcbe44b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6059264
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-02 04:58:36 -08:00
Benedikt Meurer af6c6337aa [eslint] Prefer TypeScript interface over type aliases. 
We have a mix of `type` and `interface` usage throughout our codebase,
that is sometimes difficult to follow and reason about. We should follow
the suggestion from the TypeScript PM and use `interface` consistently
where possible. This leads to better type display in errors and makes
our codebase easier to read (b/c consistency).

This CL adds the `etc/prefer-interface` ESLint rule to accomplish this.

Fixed: 387237537
Change-Id: Idd6775094ba94b8397f626191788437f6b156dc6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6135001
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-02 03:42:22 -08:00
Benedikt Meurer 586a9a5908 [eslint] Adopt ESLint Rule Naming Conventions. 
Update our custom ESLint rules to follow the official naming
conventions[^1], in particular the rule names need to

1. consistently use dashes to separate words (rather a mix of
   underscores and dashes), and
1. consistently use `no-` prefix for rules that disallow something.

Drive-by-fix: Also remove the `fixable` setting from rules that don't
provide a fix.

This is a functionally neutral change.

[^1]: https://eslint.org/docs/latest/contribute/core-rules#rule-naming-conventions

Fixed: 386319581
Change-Id: Ifcb6c0e4ca8334a263be6534596c30b3bcca243b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6110726
Reviewed-by: Samiya Caur <samiyac@chromium.org>
Commit-Queue: Samiya Caur <samiyac@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2024-12-27 02:54:56 -08:00
Jayson Chen 2e999d1495 Add wicg scheduling API definition 
window.scheduler.postTask and .yield are originally not available in the devtools-frontend codebase. This CL added the type definition so Typescript recognizes the API

Bug: 383240467
Change-Id: I4a395aca4e3956ceaa08053dcded5017f0ed10b1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6081857
Reviewed-by: Robert Paveza <Rob.Paveza@microsoft.com>
Commit-Queue: Jayson Chen <jaysonchen@microsoft.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2024-12-10 20:09:10 +00:00
Nikolay Vitkov d562298ebb [deps] Update types to match the installed Node.JS 
The node version in third_party is v22.11.0.

Bug: none
Change-Id: Ib6d22b314f88c6ae997af3a4e20ae72f1862e7c0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6063481
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-12-03 05:09:47 +00:00
Nikolay Vitkov d76576c6fe [deps] Update EsLint v8.57.1 and plugins 
This is need to be able to move to flat config which I am handling
in a separate CL.
The overrides are there as these packages got update today,
so we need to way, but they were last touched 3 years ago,
so reviewing their changes upstream as well.

Bug: none
Change-Id: I61534f881fd4e747c716b42b773f8f7f3e9bc761
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6063618
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2024-12-02 14:40:07 +00:00
Nikolay Vitkov 9974fbb24d Update link for bugs 
The npm bugs command opens a new issue to be reported to DevTools.
Use the link from the read-me

Bug: none
Change-Id: I72095baaf374fc21904299b17a85470de92b24f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6063660
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2024-12-02 14:03:01 +00:00
Nikolay Vitkov 65f45cc921 [deps] Update TypeScript EsLint parser 
Update the @typescript-eslint - eslint-plugin and parser to v7.18.0
cia incremental patches.
This is the last version before breaking changes need to start be applied to the infrastructure.
Needed to update EsLint to v8.56.0 as required by the above major v7.
Only one new error was uncovered in test file and fixed.

No-Presubmit: true
Bug: none
Change-Id: I4e4fe265b82deeb49786c5bf3e154dac8fcfecbd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6054130
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
 2024-11-29 13:15:35 +00:00
Alex Rudenko 09712c6777 Roll puppeteer-core to 23.8.0 
No-Presubmit: true
Bug: none
Change-Id: Ie0ddc7007c14ecc54c2aca66f22d204c93911d0f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6038617
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-11-21 09:48:27 +00:00
Alex Rudenko 5e9055f867 Remove setup-dtrun 
It does not appear to be doing anything anymore.
Removed in https://crrev.com/c/3344910.

Bug: none
Change-Id: Id650c3a726eb1504bf20ee814bde543cb7dd3de2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6023015
Reviewed-by: Simon Zünd <szuend@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-11-14 09:44:06 +00:00
Simon Zünd abf0cd1847 [deps] Update rollup to 4.24.3 (and update plugins) 
Since we have the major version jump, we needed to update quite
a few things to make this work:

  1. rollup4 ships with native binaries. We can't check them into
     our node_modules for all platforms. Luckily they also ship a
     a wasm version. This requires us to adjust the 'binary' path
     to `node_modules/@rollup/wasm-node/dist/bin/rollup` instead.

  2. rollup4 is more strict when it comes to ES modules vs
     CommonJS. We adjust this by renaming the rollup config files.

  3. Some plugins got deprecated so we had to replace them with
     the newer versions (source maps and terser).

Bug: None
Change-Id: If13d590c8185db6ad85b3992d0a869111909dc8c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5999255
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2024-11-07 05:25:54 +00:00
Benedikt Meurer 3735fffcf2 Fix npm bugs post Buganizer migration. 
Bug: none
Change-Id: Ibf6b2aa8b9ce3dcd4d0260ba92ac1d26e17e2e78
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5979938
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2024-10-31 09:02:42 +00:00
Simon Zünd 67f366bf77 Reland "[deps] Update esbuild to 0.24.0" 
This is a reland of commit fcb4df4e8b

ESBuild stumbled over the import(`../../${modulePath}`); in
Runtime.js. It considers this a "glob" import and attempts to bundle
ALL DevTools file (since the import could load anything).

There is no config option to disable this so the solution is to break
the esbuild heuristic that detects this.

See https://esbuild.github.io/api/#glob for more info.

Original change's description:
> [deps] Update esbuild to 0.24.0
>
> R=jacktfranklin@chromium.org
>
> Bug: None
> Change-Id: I587b974f2ff787fa2c0560863d702140f2eff9e2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5953149
> Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

Bug: None
Change-Id: If10a918a0f5075916493c3fa5797212ffb1ee9ba
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5952982
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
 2024-10-24 06:30:57 +00:00
Benedikt Meurer 6d7cbe0f72 Add ts-lit-plugin. 
This provides type checking and code completion for lit-html
within tsserver.

Fixed: 375149136
Change-Id: I9c7a97d14b901ea4cb0c98751d852f0b884230c6
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5953718
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2024-10-23 14:10:30 +00:00
Simon Zünd d5b287edd3 Revert "[deps] Update esbuild to 0.24.0" 
This reverts commit fcb4df4e8b.

Reason for revert: Breaks chromium build: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/DevTools%20Linux%20Fastbuild/7686/overview

Original change's description:
> [deps] Update esbuild to 0.24.0
>
> R=jacktfranklin@chromium.org
>
> Bug: None
> Change-Id: I587b974f2ff787fa2c0560863d702140f2eff9e2
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5953149
> Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
> Commit-Queue: Simon Zünd <szuend@chromium.org>

Bug: None
Change-Id: Iba32a446e1c86dbb168edb474c9f9dc600a5f931
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5952981
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2024-10-23 10:56:09 +00:00
Simon Zünd fcb4df4e8b [deps] Update esbuild to 0.24.0 
R=jacktfranklin@chromium.org

Bug: None
Change-Id: I587b974f2ff787fa2c0560863d702140f2eff9e2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5953149
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-10-23 09:51:10 +00:00
Alex Rudenko bfb1124d4a Bump vulnerable deps 
Fixed: 365626812
Change-Id: I1e4711a43fa31bff35b45ac6e6dd518391db562e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5939693
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-10-17 13:37:45 +00:00
Simon Zünd 479b92bc6b [deps] Update @types/node to 20.11.0 to match our node version 
This fixes the TS compilation errors when generating the protocol
definition files.

R=pfaffe@chromium.org

Bug: None
Change-Id: Ibcb4554ea34f69f8f30072540928444e7690e4f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5920710
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
 2024-10-10 10:44:55 +00:00
Simon Zünd f0d3b5c7fc [deps] Upgrade TypeScript to 5.6.2 
This upgrade requries some changes to the code base. TS 5.6 made the
types for the iterator protocol more strict. We have some places in the
code base where we retrieve the first item of `Set` via the `values()`
iterator. This CL adds 'as' casts or uses 'done' as appropriate. For
test code we use '!'.

R=alexrudenko@chromium.org

Bug: None
Change-Id: I09f1dccb31485a7e3036870f7688aa57f1202018
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5920100
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-10-10 07:23:16 +00:00
Danil Somsikov 058b9d879d Add lit-analyzer and run it as a part of lint check 
Bug: 370734442
No-Presubmit: true
Change-Id: I7021b801e5bacd4ed33643651a53b8db20ccf8b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5898986
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-10-07 12:41:05 +00:00
Danil Somsikov 2a0e55eb29 Add web-component-analyzer explicitly first, to workaround win presubmit issue. 
http://crrev.com/c/5898986 is currently failing presubmit on win bot
because command line command for clang format gets too long.

It looks like `git cl format` is running for all changes files ignoring
the .clang-format Disable-Format directive in node_modules/

Bug: 370734442
Change-Id: Ia790c5998a4d25b42f2f14efc56df26cefa540f5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5907633
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-10-07 10:48:55 +00:00
Alex Rudenko cb4b9688d4 Remove coverage 
Infra change: https://chromium-review.googlesource.com/c/chromium/tools/build/+/5833493

Bug: 364237269
Change-Id: Iebc847a3a3644b5538771b94128943da588910a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5830445
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-05 11:38:42 +00:00
Benedikt Meurer 67b69bf002 [cleanup] Remove "Highlight important DOM properties in the Object Properties viewer" experiment. 
This feature never made it past the experiment stage and while we believe
that it's beneficial to highlight important DOM properties, we aren't
convinced that this approach is the right one. Since we have no capacity
or intention to work on this experiment, we are removing the code now.

Doc: http://go/pinned-properties
Bug: 40267030, 40840064
Change-Id: Ib2d0f287834ca9ee87d957bd64f77a450c322f46
Fixed: 315126594
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5836838
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Victor Porof <victorporof@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2024-09-04 14:40:11 +00:00
Alex Rudenko cf8f902449 Roll puppeteer to 23.0.2 
Bug: none
Change-Id: I176811a16871431d82160d4bcc91cbcd54ac244c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5797137
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-08-20 15:27:20 +00:00
Benedikt Meurer b14d69ab75 Remove npm run check-lint* scripts. 
Bug: 360832181
Change-Id: Ica37d64d1254a6fc79413b444942695d977d5870
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5797136
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-08-20 10:44:49 +00:00
Benedikt Meurer e6a39dc688 [scripts] Provide a single npm run lint command. 
This unifies the current set of two dedicated scripts for running ESLint
and stylelint into a single script, with a single npm run-script
command. We need to migrate the Infra and devtools-internal before we
can fully remove the old scripts.

Bug: 360832181
Change-Id: Ifb98d882d951fb3e1c9d7ff8aae22c8d844ced55
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5796886
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-08-19 16:04:20 +00:00
Alex Rudenko 55d5f67ec6 Bump puppeteer to 22.14.0 
Bug: none
Change-Id: I6a02ebbb4fcc5cdab6dec0bcfd7bc6030fe78435
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5756526
Auto-Submit: Alex Rudenko <alexrudenko@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-08-02 17:03:43 +00:00