zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-09-28 21:24:26 +08:00
Code Issues Packages Projects Releases Wiki Activity
25,729 Commits 43 Branches 79 Tags
test
Commit Graph
73 Commits
Author SHA1 Message Date
Kim-Anh Tran 91816c4c33 [cleanup] Rename theme_colors.css and application_color_tokens.css 
This renames these two files to better reflect the current content:

theme_colors -> design_system_tokens
application_color_tokens -> application_tokens

Bug: 390330089
Change-Id: Iceac9fc91fb774912236715643f831caad035ed2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6205768
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
 2025-01-28 05:08:12 -08:00
Kim-Anh Tran d452a53cc3 [cleanup] Merge design_tokens.css into other token css files 
This merges the definitions that were in design_tokens into
theme_colors.css and application_color_tokens.css.

In a follow up, we'll rename these two (theme_colors and
application_color_tokens). Keeping the same name here in order to
keep the diff easier to read for review purposes.

Bug: 390330089
Change-Id: Ia8510ca0818d31409250c1d5e6ef67897e6fc193
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6203922
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2025-01-28 02:45:40 -08:00
Kim-Anh Tran 73597f0d70 [cleanup] Merging token.css file into themeColors.css 
This is the first part of our goal to merge the token css files
(token.css, theme_colors.css, design_tokens.css and
application_color_tokens.css). In the end, we want to end up
with two css files only.

This CL makes the following changes:
1. Move the content from `tokens.css` into `theme_colors.css`
2. Remove `tokens.css`

Note that this CL is simply moving the content for simplicity of
reviewing.
More clean ups will follow.

Bug: 390330089
Change-Id: Id06de578b1f5bf5f6dda7674e356a2c9f0463e94
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6189457
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-23 01:15:37 -08:00
Benedikt Meurer da8d124d10 Merge inspectorSyntaxHighlight.css and inspectorCommon.css. 
Eventually we will need to split up the `inspectorCommon.css` styles
into separate style sheets and be more explicit about their usage,
but that's a bigger undertaking, and not something to start today.

Bug: 391381439
Change-Id: Ib075553b808257d1ef72d1abdb981221b8f19b93
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6189458
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
 2025-01-22 06:53:00 -08:00
Benedikt Meurer bf0e2b48f4 Move text-button styles to the button component. 
This is the next step in unifying the way we inject CSS. While we should
probably have a proper `<devtools-text-button>` component instead of the
`.text-button` styles, I'm leaving that as a refactoring for later, and
for now, move the styles out of the legacy UI bundle and into the button
component.

Bug: 391381439
Change-Id: Id4708319dbfe2d609da0947ef9e3f7692723393b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6189456
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2025-01-22 06:28:56 -08:00
Benedikt Meurer 5a8025d801 Inject :root styles (for CSS tokens) only once. 
Instead of injecting our CSS tokens into every document and every shadow
root, which is unnecessary and only makes it more challenging to reason
about the cascade in DevTools, inject these `.css` files exactly once
via the entrypoints.

Bug: 391381439, 390330089
Change-Id: Id3eba5303f636bd47cf893934c8ec625339cd289
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6187530
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-22 02:25:54 -08:00
Nikolay Vitkov b4e8dc7ac2 Update EsLint v9 
Bug: none
Change-Id: Iebcc53c0f70a51242f22e4df167cd588b08cefcd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6140633
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
 2025-01-07 05:41:31 -08:00
Nikolay Vitkov 04cca9f499 [cleanup] Remove dead code 
Reland of https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6070376

Now that devtools-frontend is merged directly into chromium,
we can safely remove this.

Bug: none
Change-Id: I882e3f58a71eab50485eb0ef23b398154d784531
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6110744
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2025-01-02 04:29:39 -08:00
Alex Rudenko 789751e321 Revert "[cleanup] Remove dead code" 
This reverts commit 26bc275ce1.

Reason for revert: used in devtools-internal so breaks the roll

Original change's description:
> [cleanup] Remove dead code
>
> The infra now all uses `npm run lint` for linting.
> Moves a common function to the only place it's used.
>
> Bug: none
> Change-Id: Ibcf86daa95e33d8b313efe76a6173436769786d5
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6070376
> Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
> Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
> Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>

Bug: none
Change-Id: I090c1750ec1ada53df22c443253922162f41e271
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6072803
Reviewed-by: Simon Zünd <szuend@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-12-05 07:06:18 +00:00
Nikolay Vitkov 26bc275ce1 [cleanup] Remove dead code 
The infra now all uses `npm run lint` for linting.
Moves a common function to the only place it's used.

Bug: none
Change-Id: Ibcf86daa95e33d8b313efe76a6173436769786d5
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6070376
Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2024-12-04 15:44:37 +00:00
Alex Rudenko cb4b9688d4 Remove coverage 
Infra change: https://chromium-review.googlesource.com/c/chromium/tools/build/+/5833493

Bug: 364237269
Change-Id: Iebc847a3a3644b5538771b94128943da588910a7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5830445
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2024-09-05 11:38:42 +00:00
Simon Zünd e20bdacd07 [deps] Move ts_library out of third_party 
ts_library.py and typescript.gni do not contain any third party code.
They had the Chromium license headers from the beginning. The only
"third-party"ness they have, is that they use the "typescript"
npm package.

R=alexrudenko@chromium.org

Fixed: 362397305
Change-Id: I33a2ee2817c940e365f810e897de5907bf586093
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5816329
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-08-27 10:47:27 +00:00
Danil Somsikov 65e958b5fc [console] Use Acorn instead of function constructor in JavaScriptREPL 
With strict CSP (no usafe-eval) the function constructor will always throw

Bug: 360830630
Change-Id: I5e99d660d8d9e50520f95a46355ca4b9b1350693
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5796885
Commit-Queue: Simon Zünd <szuend@chromium.org>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Auto-Submit: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-08-20 08:33:10 +00:00
Eric Leese 460be15667 Add support for running tests in a full checkout. 
Allows the npm run test script to work when running from the
third_party/devtools-frontend/src folder of a full chromium
checkout. In this case it will trigger a chrome build and use
that binary instead of a downloaded release.

Bug: None
Change-Id: Ib53ee477954f298f443b0f528c68b25293701338
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5683365
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
Commit-Queue: Eric Leese <leese@google.com>
Reviewed-by: Simon Zünd <szuend@chromium.org>
 2024-07-10 12:52:54 +00:00
Liviu Rau 715da070da [testing] fix interaction tests coverage 
Bug: 333423685
Change-Id: Idfc1d058e4041afe4e53fc2aa63f877b9bbe27ec
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5688550
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Liviu Rau <liviurau@google.com>
Reviewed-by: Philip Pfaffe <pfaffe@chromium.org>
 2024-07-09 14:01:56 +00:00
Liviu Rau cc4ed1e43f Reland "Resolve compilation target in server.js from the current path" 
This is a reland of commit cbda0e2158

Proof of fix @ https://chromium-swarm.appspot.com/task?d=true&id=696bff6c916ca010 where we trigger the same swarming task with a different CAS hash (one generated by the windows bot on self cq).

Original change's description:
> Resolve compilation target in server.js from the current path
>
> Bug: 333423685
> Change-Id: I3c00d9139794c4b7aa51b7ab5fdfef91f3ecd409
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5518529
> Reviewed-by: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Danil Somsikov <dsv@chromium.org>
> Commit-Queue: Liviu Rau <liviurau@google.com>

Bug: 333423685
Change-Id: I7ae05df1492a392e85e13627edf70422fc9abdd0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5521433
Commit-Queue: Liviu Rau <liviurau@google.com>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
 2024-05-07 14:16:44 +00:00
Kim-Anh Tran 22d4b16e61 Revert "Resolve compilation target in server.js from the current path" 
This reverts commit cbda0e2158.

Reason for revert: Causing problems on the windows bot leading to an unmatched backspace, see example: https://ci.chromium.org/ui/p/devtools-frontend/builders/ci/Stand-alone%20Win/12263/overview


Original change's description:
> Resolve compilation target in server.js from the current path
>
> Bug: 333423685
> Change-Id: I3c00d9139794c4b7aa51b7ab5fdfef91f3ecd409
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5518529
> Reviewed-by: Andres Olivares <andoli@chromium.org>
> Reviewed-by: Danil Somsikov <dsv@chromium.org>
> Commit-Queue: Liviu Rau <liviurau@google.com>

Bug: 333423685
Change-Id: Ib66128b8d0380ead11ec6220947d56b28154d69a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5518716
Commit-Queue: Kim-Anh Tran <kimanh@chromium.org>
Owners-Override: Kim-Anh Tran <kimanh@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2024-05-07 07:32:55 +00:00
Liviu Rau cbda0e2158 Resolve compilation target in server.js from the current path 
Bug: 333423685
Change-Id: I3c00d9139794c4b7aa51b7ab5fdfef91f3ecd409
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5518529
Reviewed-by: Andres Olivares <andoli@chromium.org>
Reviewed-by: Danil Somsikov <dsv@chromium.org>
Commit-Queue: Liviu Rau <liviurau@google.com>
 2024-05-06 13:00:39 +00:00
Kateryna Prokopenko b63b015fbd Add part of Material design tokens 
Bug:none
Change-Id: Iebf1a6a5190df67bea3c3dbda25c28718a111510
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5366404
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Auto-Submit: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2024-03-18 14:44:21 +00:00
Danil Somsikov 45f6ad10a0 [ve] Use button element instead of span to handle keyboard automatically 
Bug: chromium:1467464
Change-Id: Icd8657299d87c0f4cc6c0f08123a4103975399b0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5339956
Commit-Queue: Danil Somsikov <dsv@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
 2024-03-06 07:08:18 +00:00
Andrés Olivares 294a584948 Move test/unittests/fixtures/ content to front_end/timeline/fixtures 
This folder only contains traces atm and since the unittests/ folder is
going away we can move its content to the only panel that uses it.

Bug: 323795674
Change-Id: I245e1bf2964ff2283c47adf3866b98d2e8e21e37
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5330907
Reviewed-by: Nancy Li <nancyly@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
 2024-02-29 08:15:25 +00:00
Simon Zünd 803ee56682 [component-docs] Catch all requestHandler errors and bind to localhost 
R=alexrudenko@chromium.org

Bug: None
Change-Id: Ie249667e7a8430e9185b3b7687694f7d51d2e9d2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5272593
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-02-07 07:56:16 +00:00
Simon Zünd 11a99d0867 [component-docs] Fix requests for non-existent .html component files 
Such requests shouldn't crash the component docs server but rather
result in a 404.

R=alexrudenko@chromium.org

Bug: None
Change-Id: I345126da8f2208d2eff248d157cfb3cfd72a0279
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5272592
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
 2024-02-07 07:06:51 +00:00
Simon Zünd b7b0e5349a [component-docs] Check if directory exists before attempting to read it 
Otherwise we crash the server with a ENOENT error. This is
particularly annoying if a security scanner probes the component
server during a test run on the bots and causes the suite to fail.

R=andoli@chromium.org

Bug: None
Change-Id: Id6abdb6c5f310f909ffe1af45a1445dfa3f7430d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/5266338
Commit-Queue: Andres Olivares <andoli@chromium.org>
Commit-Queue: Simon Zünd <szuend@chromium.org>
Auto-Submit: Simon Zünd <szuend@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2024-02-05 10:26:31 +00:00
Jack Franklin e4379b40b3 Include inspectorSyntaxHighlight in component server 
It is included globally in DevTools, so to ensure the server matches we
need to include it globally here too.

Bug: none
Change-Id: I14645f4ec1fcb8e5bd3c120a52f2877c256061db
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4983612
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Nancy Li <nancyly@chromium.org>
Commit-Queue: Nancy Li <nancyly@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2023-10-27 15:09:26 +00:00
Jack Franklin 2d63337ed6 Fix errors when running component server index 
Passing an array to `path.join` is not supported, it takes unlimited
arguments rather than an array of one.

This was introduced in crrev.com/c/4678757, but I think the bots were
happy because they do not use the index page and instead navigate
directly to examples. This error only triggered on the index page.

As a drive-by, I also bumped the font size as otherwise they use the
default, rather small, DevTools font size.

Bug: none
Change-Id: I580c454d62e3ce66065bdb21c2fc7b0349825637
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4685569
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2023-07-17 11:51:36 +00:00
Andrés Olivares f1d811c86e Add ui/legacy/tokens.css to component server 
This way we ensure colors loaded from this file are available in the
component examples and screenshot tests, since it seems that after
https://crrev.com/c/4650363 , some colors for icons were no longer
available in the component server (see screenshots updates).

This CL adds the missing stylesheet to the server and adds it to a
reusable array so that stylesheet paths don't have to be hardcoded
multiple times.

Note: I forced a screenshot update so many goldens that are unrelated
to this issue are also re-baselined.

Bug: none
Change-Id: I8adcfbdd4966706a9b6f15d0947b4ef0ac0e96f4
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4678757
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2023-07-13 11:07:48 +00:00
Jack Franklin 2f2b9fcb55 Fix overriding component server port with PORT variable 
The logic for the PORT was slightly off, we need to make sure the PORT
variable is used before the logic for choosing a port based on tracing
mode.

Bug: none
Change-Id: Id512eb26f357096639a7b631521aae6c233ee81f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4566606
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
 2023-05-25 15:17:59 +00:00
Andrés Olivares 6c66158a5a Initialize the tracesMode flag in component server as false 
This prevents a bug I noticed where a request for the index file
wouldn't be properly handled because it relies on the tracesMode being
`false`. In cases where the flag isn't set, this flag would be
`undefined`, which would cause an error (see line 249 in server.js).

Bug: none
Change-Id: I3c3fa538f61e46c1ac1fddb0f6f920264a562f04
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4547509
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Andres Olivares <andoli@chromium.org>
 2023-05-22 10:57:29 +00:00
Paul Irish 7de493712a Introduce trace serving mode to component server 
Provides an index of fixture traces, CORS serving, and the magic
loadTimelineFromURL url to develop against.

To run: node scripts/component_server/server.js --traces

Screenshot: https://imgur.com/Sh85xBx

Bug: 1430630
Change-Id: I9912dc6db21e43a5287fdda331d0d66aff1b01df
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4545102
Commit-Queue: Paul Irish <paulirish@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2023-05-19 07:20:12 +00:00
Wolfgang Beyer 742df2baba [DevToolsIcon] Make icon colors available in component docs 
Update error icon in icon component component doc.

Screenshots: https://imgur.com/a/uglXcol

Bug: 1427397
Change-Id: I750b3906214a685881ee92f961ac9afa7f2d8f26
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4397716
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
Auto-Submit: Wolfgang Beyer <wolfi@chromium.org>
 2023-04-04 15:31:34 +00:00
Andrés Olivares 10417e7ccb Export merged results of unit and interaction test coverage as text file 
For convenience, since the bots will still use the JSON file.

Also, an option to define the folders on which coverage will be
calculated is added to the interaction tests. The flag works
identically to the COVERAGE_FOLDERS of unit tests, i.e. a pattern is
provided to define the included folders. For example: the flag can be
set like COVERAGE_FOLDERS=
front_end/{models/trace,models/timeline_model,panels/timeline}

These two changes should help to calculate the total OPP coverage in
go/opp-test-coverage

Bug: 1424729
Change-Id: Ie982f62dfac0014c05075e53173a8e7710d3b9e0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4345493
Commit-Queue: Andres Olivares <andoli@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2023-03-20 09:39:59 +00:00
Jack Franklin c8d5dd2e7c Apply JSDoc alignment rule to scripts/ directory 
I mistakenly applied this rule only to `*.ts` files, but we should apply
it to JavaScript files also.

Bug: none
Change-Id: I6c7af0e897e06a7a04ec3dea83fcbd9719744705
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/4111459
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2022-12-21 16:26:37 +00:00
Jack Franklin 0a188d5d28 Fix paths not using sharedResourcesBase in component-server 
This was missed when these sheets were added.

Bug: none
Change-Id: Ic4411e6f62c98db73d727611ba87b55eb8a31ad7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3367665
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-05 13:07:57 +00:00
Jack Franklin 64f1c6fa2e Add some styling to the component docs index page 
Just to make it look a little nicer!

https://imgur.com/a/uelnn6K

Bug: none
Change-Id: Ie65dc11d7a4047e2c2c6816baa66d47d32259c11
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3347792
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2021-12-20 16:39:53 +00:00
Tim van der Lippe cd385c2f28 Remove resources from ui/legacy/module.json 
This moves all ui/legacy stylesheets to the .css.legacy.js format. By
doing so, we can remove the module.json in a follow-up CL.

R=jacktfranklin@chromium.org

Bug: 1190991
Change-Id: I23b590845ae27880058b2ab02da8edf378ae8232
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3284811
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-11-16 16:47:21 +00:00
Jack Franklin 2b6063995b Fix path to locales file in component-server 
Bug: none
Change-Id: I7e47b1d8dc3ccafad980bcbae09d3083472a50a3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3110432
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-08-20 15:04:51 +00:00
Jack Franklin 2ef4d05706 [ComponentServer] load locale from sharedResourcesBase 
The locale is considered a shared resource, so when we load it we should
use the sharedResourcesBase argument that can be supplied when
instantiating the server.

Bug: none
Change-Id: Ic89b27bcd12b514e3efbef20a550062fcd871680
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3109847
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-08-20 13:21:17 +00:00
Kriti Sapra 56daf78ddb Updated no-multiple-empty-lines to only have 1 as max 
DISABLE_THIRD_PARTY_CHECK=updated linting formatting
Bug: 1106746
Change-Id: I371bca95b7cf1e8b7eaa4f9e7c3860af4eedee3e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3057042
Commit-Queue: Kriti Sapra <kritisapra@google.com>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-07-28 14:10:15 +00:00
Tim van der Lippe 23283e110a Instrument code with Istanbul for interactions tests 
All interaction tests are now lazily instrumented with Istanbul
to obtain code coverage. The interactions tests can be started
with `COVERAGE=1` to obtain coverage. For that, the Mocha hooks
perform the eventual reporting and gathering of data. The instrumentation
is performed in the components server itself.

To make sure that we perform the minimal amount of work required
(since code coverage instrumentation is computationally expensive),
we preload pages to populate the instrumentation cache. Every
interactions tests should preload an example (most likely basic.html)
to populate the cache. Every subsequent test will then use the
already-instrumented code, rather than computing the code over
and over again.

The eventual code coverage is written to /interactions-coverage.
The results will eventually be merged with /karma-coverage
to obtain the union of both unit and interaction tests coverage.

R=aerotwist@chromium.org,jacktfranklin@chromium.org

Bug: 1206705
Change-Id: I5e19b1ecef23d21107210699cb29800556e0415e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2879986
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-05-10 14:44:42 +00:00
Tim van der Lippe e622f55864 Move component_docs to ui/components/docs 
R=jacktfranklin@chromium.org

Bug: 1187573
Change-Id: I2f8225ba1b9fc9848cf497ec0235756ace0f4831
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2826290
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-14 15:08:31 +00:00
Tim van der Lippe 67d60bf707 Move ExpandableList from ui/components to ui/components/expandable_list 
R=jacktfranklin@chromium.org

Bug: 1187573
Change-Id: Id1bdf233133cff65f00cd311cedeb69d6413e53f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2825794
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-14 12:50:41 +00:00
Jack Franklin 0f019a03ee Fix ComponentServer relying on <style> tag to inject deps 
The component server needs to inject CSS and JS scripts into each
example. It was doing this by relying on a <style> and <script> tag as
the hook to inject more code. But if you have an example without a
<style> or <script> tag, it won't work. Instead we now inject based on
the </head> and </body> tags, which will always exist (or, if they
don't, we have bigger problems!)

Bug: None
Change-Id: Id2f586c917ee7ab0821d5ab8e50e5cd3d3647a92
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2815131
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-04-09 10:03:23 +00:00
Tim van der Lippe e6583133ad Fix interactions tests 
These tests were still importing the css files from their original
location. The files were moved in https://crrev.com/c/2810839, but
because of stale `autoninja` compilation outputs, that CL got
submitted just fine. When new bots were provisioned, the files
were missing and the tests started failing post-submit.

Confirmed locally that removing the old compilation output fails
the tests and this output makes them pass again.

R=jacktfranklin@chromium.org

Bug: 1187573
Change-Id: Ia564c76f53ff31d0669c88967ba916bf910e3538
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2813958
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-04-08 10:17:42 +00:00
Tim van der Lippe bb352e6a14 Move i18n to core/i18n 
R=aerotwist@chromium.org
DISABLE_THIRD_PARTY_CHECK=i18n move

No-Presubmit: true
Bug: 1187573
Change-Id: I3dd02956bcf078e0e3b059240ea583b3a83c09b2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2799756
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-04-01 18:31:44 +00:00
Paul Lewis d689287a1b [Components Server] Add support for gzip files 
R=jacktfranklin@chromium.org

Bug: None
Change-Id: I312dc4740fab41e207d2326113db247a19da3e5b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2799757
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Paul Lewis <aerotwist@chromium.org>
 2021-04-01 15:32:04 +00:00
Jack Franklin 49e33f9fa2 Remove component docs server image path hack 
This hack was needed back when we didn't unify how we loaded images in
CSS; we now do via the `var(--image-file-X)` approach that generates
correct relative images. Therefore we can lose this hack in the
component docs :)

Bug: none
Change-Id: I98ec7d21437aa280d7a33ecd4fae64f59bfba83b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2794950
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
 2021-03-31 11:03:13 +00:00
Jack Franklin a3dd06a3de Add test-suite-source-dir flag to new test runner 
The current tests try to figure out the root directory and then glob
for _test.ts files within there, but this breaks easily if the folder
structure isn't exactly as expected. Instead we can set this via a
flag in the test runner.

This CL only updates the interaction tests, which use the new runner.
e2e tests will be supported in time.

Bug: chromium:1186163
Change-Id: I198b67bf0081ce7334c40d7d661fb8642c2d56d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2772045
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
 2021-03-18 11:19:17 +00:00
Jack Franklin fe65bc6387 [TestRunner] add base-path and shared-resources flags 
This CL adds two flags to the new test runner for configuring the
components server and then updates the server to detect those values.

Note that whilst this CL adds yet-another-way to configure the
components server, this is only being done for backwards compat whilst
we roll out this change to all the various places. We will remove old
options towards the end of this work.

Bug: chromium:1186163
Change-Id: I4c9b85a5745b9fe36894e3c492952938a5b8f648
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2763875
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-03-16 13:59:59 +00:00
Tim van der Lippe 88ba72dc73 Use CSS variables for image references 
This CL is the result of applying the following regex:

```
url\(Images/(.+)\.\w+\)
```

and replacing it with

```
var(--image-file-$1)
```

R=jacktfranklin@chromium.org

Bug: 1183361
Change-Id: I3255dd23c817b050deaa55835eb8c715d00387aa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2732375
Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-03-04 15:31:13 +00:00