zzos/react-native-devtools-frontend
1
0
Fork 0
mirror of https://github.com/react/react-native-devtools-frontend.git synced 2026-10-29 17:35:02 +08:00
Code Issues Packages Projects Releases Wiki Activity
11,979 Commits 43 Branches 79 Tags
02ed46d348ce8a6cd6342e1829e830f3d55bfc89
Commit Graph
1203 Commits
Author SHA1 Message Date
Takuto Ikuta cfcea4217a rename rollup to bundle 
rollup target will support esbuild, so I rename that to bundle.

Bug: 1278663
DISABLE_THIRD_PARTY_CHECK=parent CL has change for npm
Change-Id: I823f425e9ac5d599a3ddc3fd1fcd7e47cd18e3bf
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3419385
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2022-01-27 10:46:25 +00:00
Takuto Ikuta 9b3b13af90 extract devtools_plugin from rollup.config.js 
This is extracted from https://crrev.com/c/3401984/30

I'll use this from esbuild too.

Bug: 1278663
DISABLE_THIRD_PARTY_CHECK=parent CL has change for npm
Change-Id: Ia5f3410a2cb59e349e7a76250fbe35b354462a4c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3419384
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2022-01-27 10:44:05 +00:00
Takuto Ikuta 2e08a7d1fc npm: add esbuild 
This is extracted from https://crrev.com/c/3401984/30

Bug: 1278663
Change-Id: Icddd2af2ce157cc3877bcdc84653fb639f44c083
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3419383
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-27 10:33:05 +00:00
Johan Bay 49f681ae20 Update javascript_natives/index.js script 
This change also includes a manual run of the script to update
NativeFunctions.js.

Change-Id: I9ce1c4979674d9513cb7259e3e311e30b13de9ed
Bug: 1255619
Doc: https://goo.gle/devtools-js-argument-hints
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3399837
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Johan Bay <jobay@chromium.org>
 2022-01-27 10:06:25 +00:00
Liviu Rau 547e711f3a Whitespace to trigger builders 
R=rubber-stamper@appspot.gserviceaccount.com

Bug: 1256412
No-Tree-Checks: true
Change-Id: I8394d6d313be32bdfbbc90c9f39a139b745ee76e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3416225
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Liviu Rau <liviurau@chromium.org>
Auto-Submit: Liviu Rau <liviurau@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2022-01-26 14:24:02 +00:00
Takuto Ikuta afe8b8e716 fix isInChromiumDirectory 
Checkout of chromium directory may not have 'chromium'.
e.g.
https://ci.chromium.org/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel
has chromium checkout under 'builder' dir.

Bug: 1278663
Change-Id: Icaef7e58ba93e30528ae23d352842abd3d0f3055
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3414935
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-26 10:44:45 +00:00
Takuto Ikuta 95a359d10c typescript: introduce devtools_skip_typecheck build flag 
This is experimental flag introducing esbuild for typescript transpiler.

I needed to modify some test code to pass tests with esbuild.

Bug: chromium:1278663
DISABLE_THIRD_PARTY_CHECK=need to add esbuild DEPS too
Change-Id: I661951fc4fd8f5e6a2a599e531638ab294f887f2
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3330076
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2022-01-24 02:19:51 +00:00
Takuto Ikuta f342a5145f replace protocol.d.ts with protocol.ts 
This is to make const enum in protocol.d.ts works with esbuild in
unittest.

Without this, const enum usage from protocol.d.ts is not replaced with
esbuild. So I need to make protocol.d.ts actual TypeScript file and make
it has corresponding JavaScript file with defined enums.

I also need to tweak how protocol.js is imported to make build/test pass
in both tsc and esbuild with child CL.

Bug: 1278663
DISABLE_THIRD_PARTY_CHECK=change generated/ and importing files
Change-Id: Ic5f27633c85bbfe8647636beef9b8625f33eabdd
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3367593
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
 2022-01-24 01:35:02 +00:00
Tim van der Lippe f2adc90457 Add Puppeteer to chrome://credits 
R=alexrudenko@chromium.org

Bug: 1282407
Change-Id: I489c47413bc22b4b44cf88a8225c9d908bf7e563
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3404101
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2022-01-20 14:16:01 +00:00
Eric Leese 30df387ba8 Better VSCode debugging support 
- Default build task is set up
 - Can launch unit tests and e2e tests under the debugger
 - When using JavaScript Debug Terminal, skip attaching to tsc as
   this slows down builds

Bug: None
Change-Id: I4cd627b186b799e148393008fef50fac647aa5a9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3366667
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Eric Leese <leese@chromium.org>
 2022-01-19 12:53:26 +00:00
Alex Rudenko b6331edcbd Update Puppeteer to v13.1.1 
This CL contains the result of running `scripts/deps/manage_node_deps.py`
after changing the version of Puppeteer to v13.1.1.

Bug: none
Change-Id: I13154143f1247dc836079f25676775227385c0fe
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3397928
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>
 2022-01-18 13:32:16 +00:00
Tim van der Lippe dcc95c9681 Fix licenses for about:credits 
This adds an additional_readme_paths.json file that specifies all
directories of third_party packages that we include in the DevTools
bundle. The file is used as part of Chromiums about:credits machinery to
list all licenses of all third_party software (accessible via
chrome://credits).

It also updates the names of the packages to use the full name, which is
used as header of the license.

To ensure that this file remains up-to-date, we also include a GN action
that verifies all third_party directories listed in our GRD are included
in the .json file.

Lastly, add the missing license for Puppeteer.

R=yangguo@chromium.org

Bug: 1282407
Change-Id: Ia3142ab5bbc79804c56bc754934b9aaf1d186d7f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3386943
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
 2022-01-17 12:49:00 +00:00
Tim van der Lippe 28af9fbe78 Reland "Do not overwrite generated files when contents remains the same" 
This reverts commit aaae6b021a.

Reason for revert: always check if tsconfig.json needs to be updated

Original change's description:
> Revert "Do not overwrite generated files when contents remains the same"
>
> This reverts commit c1e414725a.
>
> Reason for revert: Seems to be the cause for CQ compilation errors:
> https://ci.chromium.org/ui/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel/19852/overview
>
> Original change's description:
> > Do not overwrite generated files when contents remains the same
> >
> > To ensure that build timestamps don't unnecessarily cause full rebuilds,
> > make sure that we only write the generated contents to a file (if it
> > exists already) if it would be the same. This ensures that the file
> > timestamps remain the same, which will lead GN to conclude that the
> > build action is a noop (which it is).
> >
> > On a new year, the file contents would actually be different, so it
> > would cause a proper rebuild. However, in all months between when the
> > timestamp changes, it won't cause is unnecessarily to rebuild all these
> > files, even though the year hasn't changed (but the timestamp it was
> > based on did).
> >
> > R=​jacktfranklin@chromium.org
> >
> > Bug: 1283883
> > Change-Id: I2bdc3a79de710236c1501b21fa505692336cfa82
> > Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3377942
> > Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
> > Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> > Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
>
> Bug: 1283883
> Change-Id: I938cfe20a7ecf6df6c7becc9fa73a3dcfebe457c
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3380583
> Auto-Submit: Simon Zünd <szuend@chromium.org>
> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>

Bug: 1283883
Change-Id: Iae23d721bdeb4c8af227903a38255ee9fc1bc49d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3386675
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-13 15:20:09 +00:00
Simon Zünd aaae6b021a Revert "Do not overwrite generated files when contents remains the same" 
This reverts commit c1e414725a.

Reason for revert: Seems to be the cause for CQ compilation errors:
https://ci.chromium.org/ui/p/devtools-frontend/builders/try/devtools_frontend_linux_blink_light_rel/19852/overview

Original change's description:
> Do not overwrite generated files when contents remains the same
>
> To ensure that build timestamps don't unnecessarily cause full rebuilds,
> make sure that we only write the generated contents to a file (if it
> exists already) if it would be the same. This ensures that the file
> timestamps remain the same, which will lead GN to conclude that the
> build action is a noop (which it is).
>
> On a new year, the file contents would actually be different, so it
> would cause a proper rebuild. However, in all months between when the
> timestamp changes, it won't cause is unnecessarily to rebuild all these
> files, even though the year hasn't changed (but the timestamp it was
> based on did).
>
> R=​jacktfranklin@chromium.org
>
> Bug: 1283883
> Change-Id: I2bdc3a79de710236c1501b21fa505692336cfa82
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3377942
> Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
> Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
> Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>

Bug: 1283883
Change-Id: I938cfe20a7ecf6df6c7becc9fa73a3dcfebe457c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3380583
Auto-Submit: Simon Zünd <szuend@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
 2022-01-11 09:29:14 +00:00
Tim van der Lippe c1e414725a Do not overwrite generated files when contents remains the same 
To ensure that build timestamps don't unnecessarily cause full rebuilds,
make sure that we only write the generated contents to a file (if it
exists already) if it would be the same. This ensures that the file
timestamps remain the same, which will lead GN to conclude that the
build action is a noop (which it is).

On a new year, the file contents would actually be different, so it
would cause a proper rebuild. However, in all months between when the
timestamp changes, it won't cause is unnecessarily to rebuild all these
files, even though the year hasn't changed (but the timestamp it was
based on did).

R=jacktfranklin@chromium.org

Bug: 1283883
Change-Id: I2bdc3a79de710236c1501b21fa505692336cfa82
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3377942
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-10 15:54:45 +00:00
Tim van der Lippe b693eb34d5 Update remaining NPM dependencies 
DISABLE_THIRD_PARTY_CHECK=NPM fix
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I41baa3294f88b7e4463fdc580c050932c5abe40e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372932
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 14:42:53 +00:00
Tim van der Lippe 4cb097430f Update Stylelint and Postcss 
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I961be18530d3ccbc4efed0c2cda9bd603b14e27b
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372931
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 14:36:30 +00:00
Tim van der Lippe 0150c2a641 Update build packages 
Updates TypeScript and @types packages, as well as Rollup + terser.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Id8c4d360be486a703d51a937302c894de3a44fe9
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372930
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 14:33:50 +00:00
Tim van der Lippe 953e537f89 Update typescript-eslint 
DISABLE_THIRD_PARTY_CHECK=ESLint fix
R=jacktfranklin@chromium.org

Bug: none
Change-Id: I3c9830be1bf007e8443d1664d3979625d175248d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372929
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 14:30:30 +00:00
Tim van der Lippe d3425b95d0 Update unit test NPM dependencies 
Updates Karma, Mocha and Sinon.

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Ia93cdafc646e4d3277e7ce869a7a8b5e66a13f0d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372928
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-07 14:26:50 +00:00
Tim van der Lippe 08285ab74f Use GN build timestamps for copyright year 
To avoid non-determinism on January 1st of a new year, we have
to use the build timestamp from GN to compute the current year.
The build timestamp will be the same for all bots, which ensures
that all files are built with the same year in the copyright header.

R=jacktfranklin@chromium.org

Fixed: 1283883
Change-Id: Ifbe581ddb65095ca6ef555625be11a370cb8f238
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3372924
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-07 12:09:00 +00:00
Tim van der Lippe 0ceb465d1c Update ESLint and plugin packages 
R=jacktfranklin@chromium.org

Bug: none
Change-Id: If1b2420ba6e1c100c3d6b2013815ff1a555ea987
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3369367
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-06 15:06:40 +00:00
Jack Franklin a584190fb0 Lint against manually binding event handlers in components 
Bug: 1270726
Change-Id: I103e91d43fa55abd06d068065175c815f9a59e5d
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3369363
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-06 14:35:29 +00:00
Jack Franklin 0a188d5d28 Fix paths not using sharedResourcesBase in component-server 
This was missed when these sheets were added.

Bug: none
Change-Id: Ic4411e6f62c98db73d727611ba87b55eb8a31ad7
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3367665
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-05 13:07:57 +00:00
Takuto Ikuta 378ed186f5 use urllib.request.urlcleanup() in download_chromium.py 
Fixed: 1280064
Change-Id: Ie33b6d46ffd0b30ddba73efceec0bbe812df07ae
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3365894
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2022-01-05 11:02:37 +00:00
John Emau 94a007152f [ESLint] Update check_license_header_tests with new year 
Tests were hardcoded to expect the year 2021 in the license comment.
Implementation was fixed in 5bb7528e.

Happy New Year!

R=jacktfranklin@chromium.org

Bug: none
Change-Id: Id99e2c67ae2d2f66df0508b5754abbd53a14c3f1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3364293
Auto-Submit: John Emau <John.Emau@microsoft.com>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2022-01-04 09:10:29 +00:00
Jack Franklin 85c29e982d Extract isLitHtmlRenderCall into ESLint utils 
Bug: 1276968
Change-Id: I9fd6341f71374922e78eb36380411f721c357bf3
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3352211
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2021-12-22 13:51:45 +00:00
Wolfgang Beyer b2da5bb358 Allow removal of entries from UMA enums 
`recordEnumeratedHistogram()` needs both the actual bucket and the total
number of buckets. The total number of buckets was previously determined
by `Object.keys(someMap).length`. This prevented us from ever removing
keys from `someMap` since its length would change.
By explicitly adding a `LastValidEnumPosition` we can now safely remove
keys.

Bug: 1278403
Change-Id: Ib256fc2cf54123f596aa9c5525cce2aabe28bec0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3329541
Reviewed-by: Simon Zünd <szuend@chromium.org>
Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>
 2021-12-21 08:42:54 +00:00
Jack Franklin 64f1c6fa2e Add some styling to the component docs index page 
Just to make it look a little nicer!

https://imgur.com/a/uelnn6K

Bug: none
Change-Id: Ie65dc11d7a4047e2c2c6816baa66d47d32259c11
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3347792
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Andres Olivares <andoli@chromium.org>
Commit-Queue: Andres Olivares <andoli@chromium.org>
 2021-12-20 16:39:53 +00:00
Tim van der Lippe 74e7b89b20 Remove unused scripts 
None of these are used anymore or are obsolete (for example, because
we removed the module.json files).

R=jacktfranklin@chromium.org

Bug: none
Change-Id: I5f538d38ed6e1156e9ef6cf023daebe90999fb4f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3344910
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-16 12:13:20 +00:00
Tim van der Lippe db15a5f621 Enforce usage of private class members in components 
This adds a rule that we enable for all components sub-folders
of panels, as well as ui/components. The rule bans the private
TypeScript keyword and requires engineers to use private class
member notation instead.

R=jacktfranklin@chromium.org

Bug: 1222126
Change-Id: I99114e12d2dd2c1bdd14a2986fab839d5c4d6c4f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3341608
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-15 15:07:09 +00:00
Tim van der Lippe c2675ef35a Update migration script for private class methods 
R=jacktfranklin@chromium.org

Bug: 1222126
Change-Id: I27247553cfcb85e9980b217d7d55fb8c9bcf1238
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3341595
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-15 12:16:27 +00:00
Takuto Ikuta b7bebb0c26 use urllib.request.urlcleanup() in download_emscripten.py 
ref: https://docs.python.org/3/library/urllib.request.html#urllib.request.urlcleanup

Fixed: 1280064
Change-Id: Id39085d6d0ba871dd840e1bc8d74b4e7a3495565
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3341215
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Kim-Anh Tran <kimanh@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
 2021-12-15 12:06:48 +00:00
Nico Weber 5027efee97 Make devtools-frontend gn files not write absoute paths to generated ninja files 
Reduces `diff out/gn{1,2}/toolchain.ninja | wc -l` from 464 to 8
on my linux box.

No intended behavior change.

Bug: chromium:1278777
Change-Id: Ib9e711f67646e848fdfb95393ad75519f789ccf1
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3330417
Commit-Queue: Nico Weber <thakis@chromium.org>
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
 2021-12-10 15:32:59 +00:00
Jack Franklin 7a9e4e9b2c Support --mocha-reporter-options in run_test_suite 
I landed support for Mocha's `--reporter` flag but you also need
`--reporter-options` to be able to configure them fully.

Bug: 1278289
Change-Id: I8c46bc1e9dfd87ed22edd04d60e906b622364232
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3327249
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2021-12-10 10:53:01 +00:00
Jack Franklin 3d57faf4fe Support --mocha-reporter in run_test_suite.js 
So that we can generate JSON reports from test runs.

Bug: 1278289
Change-Id: I8450280297102154a36fd9698f6cb05a76899103
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3327242
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Paul Lewis <aerotwist@chromium.org>
Commit-Queue: Paul Lewis <aerotwist@chromium.org>
 2021-12-09 14:50:06 +00:00
Johan Bay 72ea2d5c4b Revert "Update NPM dependencies" 
This reverts commit 192c3d4ee1.

Reason for revert: Puppeteer's types.d.ts is broken.
See crrev.com/c/3320453.

Original change's description:
> Update NPM dependencies
>
> Update puppeteer to version 12.0.1
>
> Change-Id: I8f2b0378458ba9867bf58c4c49c7202b8fc2a302
> Bug: none
> Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317578
> Commit-Queue: Johan Bay <jobay@chromium.org>
> Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>

Bug: none
Change-Id: Ia73b4360e062e5cfb932ae4af96d28af32c79973
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3320462
Auto-Submit: Johan Bay <jobay@chromium.org>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-08 11:13:19 +00:00
Tim van der Lippe 4775ec11d6 Remove rjsmin again 
Chrome OS now uses the appropriate third_party version:
https://crrev.com/c/3311066

R=jacktfranklin@chromium.org

Bug: none
Change-Id: I43470c3d1b761e9ef17aadd90491ddeffdc119aa
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3318036
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-07 10:57:32 +00:00
Johan Bay 192c3d4ee1 Update NPM dependencies 
Update puppeteer to version 12.0.1

Change-Id: I8f2b0378458ba9867bf58c4c49c7202b8fc2a302
Bug: none
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317578
Commit-Queue: Johan Bay <jobay@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-07 09:32:13 +00:00
Jack Franklin b633909bdc Use ESLint isLitHtmlDotHtmlCall util in rules 
Bug: 1276968
Change-Id: I88bb566d92d6c11d42a39d384b83b75efa8ac6ea
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317580
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-06 16:19:20 +00:00
Jack Franklin 54e36ade34 Lint against {describe,it}.only in ESLint tests 
Bug: none
Change-Id: Ia9dd8e924f14020d02cce25d301d086c382ebb7e
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317576
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-06 15:22:30 +00:00
Jack Franklin c1991d2a40 Extract isLitHtmlTemplateCall to ESLint utils 
Will update usages to use this util in a follow-up CL, and see if there
are more duplicated utils that deserve to be extracted.

Bug: 1276968
Change-Id: I2470da9c1f1c6fd0bf1d02a3958eabadec91d3e0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3317352
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-06 14:37:51 +00:00
Jack Franklin f13bdf17c2 Add ESLint rule for unnecessary quotes around attributes 
Bug: none
Change-Id: Ic7336d3f28def1ac6bc03d60d70662bddaab03d0
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313072
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-03 12:36:10 +00:00
Jack Franklin cdbd19c6bd Enable no only: true rule in ESLint directory 
Bug: none
Change-Id: Ib3c2e8ccbe30209f3fec04c739612eb970071021
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3314757
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-03 12:32:19 +00:00
Jack Franklin 2a84998f49 Lint for only: true in ESLint tests 
These are just like `it.only()` and we want to ensure they don't make it
to CQ and cause us to not run all the ESLint tests.

Bug: none
Change-Id: I96c1ba2838c16c9e15ae204a39bef68095e6848a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3314756
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Tim Van der Lippe <tvanderlippe@chromium.org>
 2021-12-03 11:43:59 +00:00
Tim van der Lippe d36fbdeda7 Temporarily add back rjsmin.py for Chrome OS 
Chrome OS is accidentally relying on DevTools build scripts:
https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/resources/chromeos/accessibility/common/run_jsbundler.gni;l=16;drc=e86ab6e79b3cef0b3a37f691d8ec38d25fa0ca9e
We should clean that up, but for now let's add back the rjsmin.py script
back to unblock the DevTools autoroller.

R=kprokopenko@chromium.org

Bug: none
Change-Id: Icf51ffb5b468809bd623b3252d2f5c994409ff2f
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3313066
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Kateryna Prokopenko <kprokopenko@chromium.org>
Reviewed-by: Kateryna Prokopenko <kprokopenko@chromium.org>
 2021-12-02 15:08:18 +00:00
Tim van der Lippe 2ec9790ec5 Remove build_release_applications and friends 
This script is now unused and fully replaced by GN. As such, this
concludes the full `module.json` migration and related scripts, which
means we can consider crbug.com/1127902 fixed.

R=jacktfranklin@chromium.org

Fixed: 1127902
Change-Id: I0fde9c4fede0cdc8649e5e455e025a70ed4d2a09
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310869
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 12:08:02 +00:00
Tim van der Lippe fd742ce33a Remove entrypoints/js_app/js_app.json 
Since this was the last entrypoint that was still processed with
`build_release_applications`, GN now starts to error and claims the
action is unused (which it is). Therefore, we need to clean up this
action as well as all the GN variables it had been using. I will clean
up the actual Python implementation in a follow-up CL, to keep this one
as small as it can be.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Ie4296885e6825d72a0b6c356971290337b680a71
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310868
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 11:32:52 +00:00
Tim van der Lippe 8aeee41bc7 Remove module.json schema checks 
We have now removed all module.json files, so these checks are obsolete.

R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: Iefe8538474b77f78eed010b0fad9461873bad03c
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310603
Commit-Queue: Tim Van der Lippe <tvanderlippe@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 11:28:37 +00:00
Tim van der Lippe 73b8c4f35c Remove entrypoints/devtools_app/devtools_app.json 
R=jacktfranklin@chromium.org

Bug: 1127902
Change-Id: I0d143909fa7bc40368e223b17b3825b97b6ab772
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/3310865
Auto-Submit: Tim Van der Lippe <tvanderlippe@chromium.org>
Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
 2021-12-02 11:26:33 +00:00