“Unconfirmed” is a lower state than “Untriaged”. Untriaged issues
that also have the `TE-NeedsTriageHelp` label should be considered
when triaging.
Here are the relevant states with their descriptions as displayed
in Monorail:
1. Unconfirmed = New, has not been verified or reproduced
2. Untriaged = Confirmed, not reviewed for priority and assignment
3. Available = Triaged, but no owner assigned
4. Assigned = In someone's queue, but not started
5. Started = Work in progress
At the time of writing, 233 DevTools issues are in the Unconfirmed
state. 57 of those also have the `TE-NeedsTriageHelp` label.
Bug: chromium:1022301
Change-Id: Ia05a46e87139a4168c48e746e2cad855c4e1bbff
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2232948
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
We prefer single quotes by default, but still want to allow double
quotes in cases where that helps avoid quote-escaping, and also want
to allow template literals in cases where string interpolation is
used. For example:
const a = 'xxx'; // ok
const b = "xxx"; // not ok, should use single quotes
const c = "xxx'xxx"; // ok, double quotes avoid an escape sequence
const d = `xxx`; // not ok, frivolous use of template literal
const e = `xxx ${42}`; // ok
Per https://github.com/eslint/eslint/issues/12976, setting
the `allowTemplateLiterals` option for the `quotes` lint rule to
`false` gives us the desired behavior.
Note that the above lint rules are auto-fixed when running the linter;
there should be no need to manually make any changes to appease the
linter.
Per review feedback, this patch also removes the following escape
sequences for printable non-ASCII symbols:
- U+00D7 → ×
- U+2026 → …
- U+2019 → ’
Chromium CL temporarily updating test expectations:
https://chromium-review.googlesource.com/c/chromium/src/+/2083147
Cq-Depend: chromium:2083147
Bug: chromium:1057042
Change-Id: Id6bec3f96ca694d2fbc07dd8629fce305a58df8a
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2082372
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Tim van der Lippe <tvanderlippe@chromium.org>
Auto-Submit: Mathias Bynens <mathias@chromium.org>
Yang Guo