Running Lighthouse on DevTools lead to these changes:
* Label our <select> toolbar items
* Don't use tabIndex=1 for our canvas elements
* Don't use li items in the network panel
* add lang=en to our html tags
Change-Id: I9fef3d731dbbcbb56c3f73d81fd5669d65fa9827
Reviewed-on: https://chromium-review.googlesource.com/1093399
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566195}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 237b755cd007b58b585ad34137353e11e2bc3ccd
When there is a violation group with thousands of messages, Console marks all
of them all as 'seen', but fails to mark the group as 'seen'. This leads to a
O(n^2) runtime when filtering. This CL marks groups as 'seen' in this case,
reducing a 3+ second filter on 5000 violations to <500ms.
Screenshot: https://imgur.com/a/ikWo1My
Bug: 851126
Change-Id: I69f5c87ca72c06efd4e305a19eb88d90316161b7
Reviewed-on: https://chromium-review.googlesource.com/1094254
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#566169}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: a7449532f628ffe5b05140d6c91f771f31af9606
Console assumes that every 'mousedown' event is followed by either a
'mouseup' or 'mouseleave' event. This key assumption allows muting
viewport updates for scrollbar dragging, wheel-up-from-bottom, and
pageUp events.
This assumption is false for right clicks that: occur too rapidly or
mouseup outside the window. This CL prevents viewport muting on
right clicks.
Screenshot of bug: https://imgur.com/a/iC2lkgU
Bug: 807682
Change-Id: I2bb4f103eadc28950968c451b80e3186733e32ce
Reviewed-on: https://chromium-review.googlesource.com/917982
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#565812}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2e4850aa00809107324b200f13da152eedda50ea
This CL addresses vertical alignment, horizontal overflow, and the
creation of newlines in Console logs that use the style formatter.
Very long fragments still break into their own block, due to the
`contain: paint` rule.
Screenshot: https://imgur.com/a/QiNbvIT
Bug: 810581
Change-Id: Iefb5533d5696a7b91e3ff9863af67740a8e07225
Reviewed-on: https://chromium-review.googlesource.com/1058394
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#559700}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: cf20524aad95b76a21447a354926a313f6e618f4
Turns the console below-prompt UI experiment from hidden to
visible.
Clicking on the preview element will now focus the prompt
editor, unless it has a selection.
Bug: 810176
Change-Id: I28cb5fa9c375ab4ae5cbfdf5043d03c7d8c71057
Reviewed-on: https://chromium-review.googlesource.com/1043464
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#556316}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 65f577c90e5521bc91afd2aa25c2fa84d630a49b
* Enter accepts the current suggestion in the console.
* History suggestions are not auto-selected. The user must use the
arrow keys or manually click to select them now.
Previously we worried about that the user would accidentally select a
suggestion in the console when they actually wanted to run the command
as is. Due to recent improvements in autocomplete, this is less of a
problem. Autocomplete showing up on an already complete expression
should be extremely rare. The only exception is history completions,
which are no longer autoselected.
Change-Id: Id9d567ae69f4c29c63e875a1f3285448adbd7ce3
Reviewed-on: https://chromium-review.googlesource.com/1026838
Reviewed-by: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555609}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: ca3ac226e566791986bb6451bdfcb02d661c6eb8
When a RuntimeModel with multiple execution contexts was removed,
some of the execution contexts could be unintentionally left in the
ConsoleContextSelector.
Change-Id: I8fea191af5a2f02c1de350866d29ddffe24338f6
Reviewed-on: https://chromium-review.googlesource.com/1038794
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555296}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: deec77c695767d1f469c4a59153f920e5dac3033
This reverts commit fcaafdd756b1aef4f8244474e37be9ee12c75284.
Reason for revert: we'd like to be more strict about side effects
Original change's description:
> DevTools: use autocomplete's possibleSideEffect to bypass throwOnSideEffect
>
> Allow Console to evaluate without throwOnSideEffect when the entire
> expression meets the same strict conditions used by JSAutocomplete.
>
> Bug: 810176
> Change-Id: If5c80250cd75d81eec1e495d0414903213fac930
> Reviewed-on: https://chromium-review.googlesource.com/1028934
> Commit-Queue: Erik Luo <luoe@chromium.org>
> Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
> Reviewed-by: Joel Einbinder <einbinder@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#555142}
TBR=dgozman@chromium.org,einbinder@chromium.org,luoe@chromium.org
Change-Id: Iec31996445e98945a0a9a9b67e572d17bafdcbeb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 810176
Reviewed-on: https://chromium-review.googlesource.com/1039063
Reviewed-by: Erik Luo <luoe@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#555269}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 67c4b089fbb62cc5986b98129dadfab5f69fcc97
- Adds an empty 15px space directly below the Console
prompt's editor.
- Updates "isScrolledToBottom" logic in Console to account
for the new space. Without this update, typing on the
prompt's last line will not "jump + stick to bottom"
as expected.
With this CL, overlay scrollbars (e.g. on Mac), should
never cover the prompt's editor.
Bug: 725249
Change-Id: Ib0167f6919d5b9942e7f2dc4d8cf0c15fc9368df
Reviewed-on: https://chromium-review.googlesource.com/965020
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#551222}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 06e046ba940fb6dffe3bbed45b85fb840b4a9194
Joel Einbinder
