In StylesSidebarPane, the 3-dot 'More tools' icon reveals a toolbar on hover.
On 'mouseenter', we set 'display: none' on it, so the following 'mousemove'
determines its bounding rect as {x: 0, y: 0, w: 0, h: 0}, and shows a tooltip
in the top-left of DevTools.
This CL removes the unnecessary tooltip and checks that an element is visible
before showing the tooltip.
Bug: 829342
Change-Id: Ib0268f70dccbb1190916796e1ca6aadaec763e5f
Reviewed-on: https://chromium-review.googlesource.com/1067784
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Erik Luo <luoe@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#560738}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 67c89d4caa1ffd0b7d30d490e68ae9bd2dc1c544
Expanding an ElementsTreeElement used to immediately set a
populated flag to true before requesting getChildNodes().
If a ChildNodeCountUpdated event arrives before the children
are set, we may call updateModifiedParentNode() and try to
create visibleChildren when they are null, breaking the tree.
This CL moves the place where 'populated' is set, so that
updateModifiedParentNode() does not update tree children
before they are available.
Bug: 829884
Change-Id: Id68e71fb7a58336d781207b298a53354af3e5cfc
Reviewed-on: https://chromium-review.googlesource.com/1049113
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#557132}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 2e5ad0a88b7d04fe1aac8b2fd0c26b2d3475e4c2
This patch starts displaying color swatches in suggest box
next to css variables that compute to color value.
For this to be possible, the ColorSwatch and BezierSwatch were
moved under the ui/ module. The CSSShadowSwatch stayed in the
inline_editor/ for now because it has a dependency on
ShadowModel.
R=einbinder, dgozman
Change-Id: Ic29a13073dc8236d5ef9a2fe35adf6bcd927290b
Reviewed-on: https://chromium-review.googlesource.com/1026882
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#553468}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: b85cc4539f06a76af94addf2d193adaa4edc9b9d
Joel Einbinder